{"thread":{"id":"55445","subject":"signed-off-by not overwritten with GIT_AUTHOR_NAME...?","startedAt":"2021-04-07T13:48:49Z","lastAt":"2021-04-07T14:00:39Z","messageCount":3,"participants":["Matthias Beyer","Taylor Blau"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"421120","messageId":"20210407134201.kxijiev5sn346bsy@hoshi","threadId":"55445","inReplyTo":null,"subject":"signed-off-by not overwritten with GIT_AUTHOR_NAME...?","fromName":"Matthias Beyer","fromEmail":"mail@beyermatthias.de","sentAt":"2021-04-07T13:42:01Z","receivedAt":"2021-04-07T13:48:49Z","isPatch":false,"sender":{"key":"mail@beyermatthias.de","avatar":null},"body":"Hi,\n\nI just found that overwriting the GIT_AUTHOR_EMAIL and GIT_AUTHOR_NAME env\nvariables does alter the author when committing, but does not overwrite the\n--signoff entry. Is this intentional?\n\nTo reproduce:\n\n    cd /tmp\n    mkdir foo\n    cd foo\n    git init\n    touch foo\n    git add foo\n    GIT_AUTHOR_EMAIL=nobody@nomail.de GIT_AUTHOR_NAME=\"Someone Else\" git commit -s -m test\n    git show\n\n\nI'm tested this for 2.29.3 and 2.29.2.\n\nThe manpage (2.29.3) does not say anything related to that under the `--signoff`\nentry, nor under the `COMMIT INFORMATION` section!\n\nIf this is a bug, I'd love to contribute a patch, if someone can take my hand\nand guide me to the right places!\n\nPlease keep me in CC, I'm not subscribed.\n\n-- \nMatthias\n"},{"id":"421121","messageId":"YG25jNZH9ATfwlMu@nand.local","threadId":"55445","inReplyTo":"20210407134201.kxijiev5sn346bsy@hoshi","subject":"Re: signed-off-by not overwritten with GIT_AUTHOR_NAME...?","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-04-07T13:54:20Z","receivedAt":"2021-04-07T13:54:28Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, Apr 07, 2021 at 03:42:01PM +0200, Matthias Beyer wrote:\n> Hi,\n>\n> I just found that overwriting the GIT_AUTHOR_EMAIL and GIT_AUTHOR_NAME env\n> variables does alter the author when committing, but does not overwrite the\n> --signoff entry. Is this intentional?\n\nIt is intentional. The identity used for signoff is the committer's, not\nthe author's. The documentation for `--signoff` in git-commit(1) says\n(emphasis mine):\n\n  [...] it typically certifies that *committer* has the rights to submit\n  this work\n\nAnd indeed 'sequencer.c:append_signoff()' calls 'fmt_name()' with\nWANT_COMMITTER_IDENT, not WANT_AUTHOR_IDENT.\n\n> To reproduce:\n>\n>     cd /tmp\n>     mkdir foo\n>     cd foo\n>     git init\n>     touch foo\n>     git add foo\n>     GIT_AUTHOR_EMAIL=nobody@nomail.de GIT_AUTHOR_NAME=\"Someone Else\" git commit -s -m test\n>     git show\n>\n\nAll of the above is to say that if you s/AUTHOR/COMMITTER in your\nexample above, it will do what you expect.\n\nThanks,\nTaylor\n"},{"id":"421123","messageId":"20210407140017.5m523lua2l3cluk3@hoshi","threadId":"55445","inReplyTo":"YG25jNZH9ATfwlMu@nand.local","subject":"Re: signed-off-by not overwritten with GIT_AUTHOR_NAME...?","fromName":"Matthias Beyer","fromEmail":"mail@beyermatthias.de","sentAt":"2021-04-07T14:00:17Z","receivedAt":"2021-04-07T14:00:39Z","isPatch":false,"sender":{"key":"mail@beyermatthias.de","avatar":null},"body":"On 07-04-2021 09:54:20, Taylor Blau wrote:\n> [...] if you s/AUTHOR/COMMITTER in your example above, it will do what you\n> expect.\n\nAh, awsome! Thanks for the explanation!\n\nMatthias\n"}]}