{"thread":{"id":"55428","subject":"[PATCH] gitk: fix selection color not persistent","startedAt":"2021-04-02T19:22:59Z","lastAt":"2021-04-04T02:13:11Z","messageCount":3,"participants":["gh acct via GitGitGadget","Bagas Sanjaya","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"420889","messageId":"pull.926.git.1617391375445.gitgitgadget@gmail.com","threadId":"55428","inReplyTo":null,"subject":"[PATCH] gitk: fix selection color not persistent","fromName":"gh acct via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-04-02T19:22:54Z","receivedAt":"2021-04-02T19:22:59Z","isPatch":true,"sender":{"key":"name:gh acct","avatar":null},"body":"From: ghacct <tony@viulogix.com>\n\nDear git community,\nIs it possible please for the gitk selection color setting to be persistent?  Since 2015 this has been working for me.\nThank you for considering!\n\nSigned-off-by: tgomez <tgomez@usa.wtbts.net>\nSigned-off-by: ghacct <tony@viulogix.com>\n---\n    gitk: fix selection color not persistent\n    \n    Dear git community, Is it possible please for the gitk selection color\n    setting to be persistent? Since 2015 this has been working for me. Thank\n    you for considering!\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-926%2Fghacct%2Fpatch-1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-926/ghacct/patch-1-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/926\n\n gitk-git/gitk | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 23d9dd1fe0d0..d255654b02fd 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -2412,6 +2412,7 @@ proc makewindow {} {\n     text $ctext -background $bgcolor -foreground $fgcolor \\\n         -state disabled -undo 0 -font textfont \\\n         -yscrollcommand scrolltext -wrap none \\\n+        -selectbackground $selectbgcolor -selectforeground $fgcolor \\\n         -xscrollcommand \".bleft.bottom.sbhorizontal set\"\n     if {$have_tk85} {\n         $ctext conf -tabstyle wordprocessor\n\nbase-commit: a65ce7f831aa5fcc596c6d23fcde543d98b39bd7\n-- \ngitgitgadget\n"},{"id":"420927","messageId":"1c869676-d818-c789-5df4-b6d6075ebafb@gmail.com","threadId":"55428","inReplyTo":"pull.926.git.1617391375445.gitgitgadget@gmail.com","subject":"Re: [PATCH] gitk: fix selection color not persistent","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-04-03T09:59:14Z","receivedAt":"2021-04-03T09:59:21Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 03/04/21 02.22, gh acct via GitGitGadget wrote:\n> From: ghacct <tony@viulogix.com>\nIs it anonymous contribution?\n\n> Dear git community,\n> Is it possible please for the gitk selection color setting to be persistent?  Since 2015 this has been working for me.\n> Thank you for considering!\nThe patch/commit message seems like question asking for something,\nbut you should instead describe why you made this patch, as our\nconvention here.\n  \n> Signed-off-by: tgomez <tgomez@usa.wtbts.net>\n> Signed-off-by: ghacct <tony@viulogix.com>\nI asked to you: Is tgomez co-authored this patch or just helping?\n\n> ---\n>      gitk: fix selection color not persistent\n>      \n>      Dear git community, Is it possible please for the gitk selection color\n>      setting to be persistent? Since 2015 this has been working for me. Thank\n>      you for considering!\n> \n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-926%2Fghacct%2Fpatch-1-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-926/ghacct/patch-1-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/926\n> \n>   gitk-git/gitk | 1 +\n>   1 file changed, 1 insertion(+)\n> \n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index 23d9dd1fe0d0..d255654b02fd 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n> @@ -2412,6 +2412,7 @@ proc makewindow {} {\n>       text $ctext -background $bgcolor -foreground $fgcolor \\\n>           -state disabled -undo 0 -font textfont \\\n>           -yscrollcommand scrolltext -wrap none \\\n> +        -selectbackground $selectbgcolor -selectforeground $fgcolor \\\n>           -xscrollcommand \".bleft.bottom.sbhorizontal set\"\n>       if {$have_tk85} {\n>           $ctext conf -tabstyle wordprocessor\n> \n> base-commit: a65ce7f831aa5fcc596c6d23fcde543d98b39bd7\n> \n[CC] Junio, what do you think about this patch?\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"420947","messageId":"xmqqim52ztji.fsf@gitster.g","threadId":"55428","inReplyTo":"pull.926.git.1617391375445.gitgitgadget@gmail.com","subject":"Re: [PATCH] gitk: fix selection color not persistent","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-04-04T02:13:05Z","receivedAt":"2021-04-04T02:13:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"gh acct via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: ghacct <tony@viulogix.com>\n>\n> Dear git community,\n> Is it possible please for the gitk selection color setting to be persistent?  Since 2015 this has been working for me.\n> Thank you for considering!\n>\n> Signed-off-by: tgomez <tgomez@usa.wtbts.net>\n> Signed-off-by: ghacct <tony@viulogix.com>\n\ncf. Documentation/SubmittingPatches\n[[describe-changes]]\n[[summary-section]]\n[[meaningful-message]]\n[[imperative-mood]]\n[[sign-off]]\n[[real-name]]\n\nAlso 'gitk' patches should be based on Paul's tree, not mine.\ncf.  \"Subsystems with dedicated maintainers\" section in\nDocumentation/SubmittingPatches\n\nSo the diff should look more like \n\n\tdiff --git a/gitk b/gitk\n\tindex ...\n\t--- a/gitk\n\t+++ b/gitk\n\t@@ ...\n\nAs to the contents of the patch itself, I am not the best person to\ncomment on.  I no longer use gitk myself unless I am testing gitk,\nand I no longer speak Tcl/Tk.\n\nHaving said that, I see no existing instance of -selectforeground so\nin the absense of somebody who is better versed in Tk, I'd be wary\nof this change.  I, however, see that\n\n    text some-widget \\\n    -background $bgcolor -foreground $fgcolor -selectbackground $selectbgcolor\n\nis a recurring theme for other text widgets like $cflist and\n$top.list, so if the change were only to add the missing\n\"-selectbackground $selectbgcolor\" there, I would imagine it would\nbe a safe improvement (or adding the \"-selectforeground $fgcolor\" to\nother text widgets that currently lack might turn out to be a sensible\nchange, too, but as I said, I do not speak Tcl/Tk).\n\n\n>  gitk-git/gitk | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index 23d9dd1fe0d0..d255654b02fd 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n> @@ -2412,6 +2412,7 @@ proc makewindow {} {\n>      text $ctext -background $bgcolor -foreground $fgcolor \\\n>          -state disabled -undo 0 -font textfont \\\n>          -yscrollcommand scrolltext -wrap none \\\n> +        -selectbackground $selectbgcolor -selectforeground $fgcolor \\\n>          -xscrollcommand \".bleft.bottom.sbhorizontal set\"\n>      if {$have_tk85} {\n>          $ctext conf -tabstyle wordprocessor\n>\n> base-commit: a65ce7f831aa5fcc596c6d23fcde543d98b39bd7\n"}]}