{"thread":{"id":"55407","subject":"Upstreaming Reviewed-by to git.git","startedAt":"2021-03-29T10:57:38Z","lastAt":"2021-03-30T07:22:49Z","messageCount":5,"participants":["Bagas Sanjaya","Christian Couder","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"420446","messageId":"0e32b0af-cd05-39a9-51a9-4d983e7085cc@gmail.com","threadId":"55407","inReplyTo":null,"subject":"Upstreaming Reviewed-by to git.git","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-03-29T10:56:33Z","receivedAt":"2021-03-29T10:57:38Z","isPatch":false,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Hi,\n\nI had reviewing patches here, but how can my reviews be credited with\nReviewed-by tags to the applicable patches on git.git (Git SCM)\nrepo (upstream)?\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"420455","messageId":"CAP8UFD1TmckvQLVQ7eWMKakMKOF76J+Z+E25vUCGkWveXMWv1g@mail.gmail.com","threadId":"55407","inReplyTo":"0e32b0af-cd05-39a9-51a9-4d983e7085cc@gmail.com","subject":"Re: Upstreaming Reviewed-by to git.git","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2021-03-29T12:15:17Z","receivedAt":"2021-03-29T12:16:15Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi,\n\nOn Mon, Mar 29, 2021 at 1:03 PM Bagas Sanjaya wrote:\n\n> I had reviewing patches here, but how can my reviews be credited with\n> Reviewed-by tags to the applicable patches on git.git (Git SCM)\n> repo (upstream)?\n\nWhen you have reviewed a patch or a patch series, you can tell the\nreviewer you are ok with the patch or patch series, and that you are\nok with them adding your \"Reviewed-by: yourname \" to it.\n\nIf you are applying to the GSoC or other such program, you can also\nput links to the discussions you participated in in your proposal.\n"},{"id":"420511","messageId":"xmqqr1jxisee.fsf@gitster.g","threadId":"55407","inReplyTo":"CAP8UFD1TmckvQLVQ7eWMKakMKOF76J+Z+E25vUCGkWveXMWv1g@mail.gmail.com","subject":"Re: Upstreaming Reviewed-by to git.git","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-03-29T21:03:53Z","receivedAt":"2021-03-29T21:04:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder writes:\n\n> On Mon, Mar 29, 2021 at 1:03 PM Bagas Sanjaya wrote:\n>\n>> I had reviewing patches here, but how can my reviews be credited with\n>> Reviewed-by tags to the applicable patches on git.git (Git SCM)\n>> repo (upstream)?\n>\n> When you have reviewed a patch or a patch series, you can tell the\n> reviewer you are ok with the patch or patch series, and that you are\n> ok with them adding your \"Reviewed-by: yourname \" to it.\n\nI think you meant \"you can tell the reviewEE\", not reviewer.\n\nIn general, anybody can review a patch, but a review by somebody who\nis not all that familiar with the codebase does not carry a lot of\nweight. Reviews from those who have already invested a lot in the\ncode that is being fixed or extended would obviously be very\nhelpful, as they are expected to know how the current code is\nsupposed to work well, and reviews from those who have worked on\nother parts of the system that depend on the code that is being\nfixed or extended would also be usefl, as they know what the callers\nof the code being changed expect out of it.\n\nSo my suggestion to Bagas is not to worry too much about\n\"Reviewed-by\" with your name, until you have your own code in the\ncodebase (and while doing so, you should worry about adding\nreviewed-by by others).\n\nIn any case, reading others' patch, together with the original\nversion before the patch changed, is a great opportunity to learn\nthe codebase and how the project work in general. It is highly\nrecommended.\n\nThanks.\n"},{"id":"420551","messageId":"xmqqczvhfp44.fsf@gitster.g","threadId":"55407","inReplyTo":"xmqqr1jxisee.fsf@gitster.g","subject":"Re: Upstreaming Reviewed-by to git.git","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-03-30T00:43:07Z","receivedAt":"2021-03-30T00:44:15Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> In any case, reading others' patch, together with the original\n> version before the patch changed, is a great opportunity to learn\n> the codebase and how the project work in general. It is highly\n> recommended.\n\nAddendum. The above makes it sound as if I am encouraging new\npeople to only read to learn silently, but that is not what I meant.\n\nReading and then expressing what you read in the patch in your own\nwords is a good way for you to learn the system. And it is also a\ngood way for the patch author to ensure what was written in the\npatch is understandable. For somebody who is totally new to the\ncodebase, any patch that is more complex than the most trivial might\nnot be hard to understand and that is not a patch author's fault,\nbut once contributors have learned the codebase enough, even before\nthey have their own changes to our codebase, a new patch should be\nwritten in such a way to understandable by them without getting\nmisunderstood. So a mere \"this looks good to me\" by new people may\nnot add much value to the discussion, but thinking aloud in more\ndetail, expressing why they think the patch is good, e.g. \"I think\nthis change tries to do X by doing Y. If I were doing so, I might\ndo so by Z, but I think Y would be a better approach than that\"\nwould help others to see that what is written in the patch was truly\nunderstandable (if what the new person said was to the point) or\nmisleading (otherwise).\n\nThanks.\n"},{"id":"420563","messageId":"CAP8UFD220trs=ERcg2rTU1MCrF+2aw-Nnbyy1mqjkGqxeMfZxw@mail.gmail.com","threadId":"55407","inReplyTo":"xmqqr1jxisee.fsf@gitster.g","subject":"Re: Upstreaming Reviewed-by to git.git","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2021-03-30T07:21:56Z","receivedAt":"2021-03-30T07:22:49Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Mon, Mar 29, 2021 at 11:03 PM Junio C Hamano wrote:\n>\n> Christian Couder writes:\n>\n> > On Mon, Mar 29, 2021 at 1:03 PM Bagas Sanjaya wrote:\n> >\n> >> I had reviewing patches here, but how can my reviews be credited with\n> >> Reviewed-by tags to the applicable patches on git.git (Git SCM)\n> >> repo (upstream)?\n> >\n> > When you have reviewed a patch or a patch series, you can tell the\n> > reviewer you are ok with the patch or patch series, and that you are\n> > ok with them adding your \"Reviewed-by: yourname \" to it.\n>\n> I think you meant \"you can tell the reviewEE\", not reviewer.\n\nYeah, sorry and thanks for all your explanations.\n"}]}