{"thread":{"id":"55313","subject":"[PATCH] vcs-svn: remove header files as well","startedAt":"2021-03-14T14:38:52Z","lastAt":"2021-03-15T15:33:19Z","messageCount":3,"participants":["René Scharfe.","Johannes Schindelin","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"419078","messageId":"b937922d-8b56-c333-3f76-6e17a28210e3@web.de","threadId":"55313","inReplyTo":null,"subject":"[PATCH] vcs-svn: remove header files as well","fromName":"René Scharfe.","fromEmail":"l.s.r@web.de","sentAt":"2021-03-14T14:37:39Z","receivedAt":"2021-03-14T14:38:52Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"fc47391e24 (drop vcs-svn experiment, 2020-08-13) removed most vcs-svn\nfiles.  Drop the remaining header files as well, as they are no longer\nused.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\n vcs-svn/fast_export.h    | 34 ----------------------------------\n vcs-svn/line_buffer.h    | 30 ------------------------------\n vcs-svn/sliding_window.h | 18 ------------------\n vcs-svn/svndiff.h        | 10 ----------\n vcs-svn/svndump.h        | 10 ----------\n 5 files changed, 102 deletions(-)\n delete mode 100644 vcs-svn/fast_export.h\n delete mode 100644 vcs-svn/line_buffer.h\n delete mode 100644 vcs-svn/sliding_window.h\n delete mode 100644 vcs-svn/svndiff.h\n delete mode 100644 vcs-svn/svndump.h\n\ndiff --git a/vcs-svn/fast_export.h b/vcs-svn/fast_export.h\ndeleted file mode 100644\nindex 9dcf9337c1..0000000000\n--- a/vcs-svn/fast_export.h\n+++ /dev/null\n@@ -1,34 +0,0 @@\n-#ifndef FAST_EXPORT_H\n-#define FAST_EXPORT_H\n-\n-struct strbuf;\n-struct line_buffer;\n-\n-void fast_export_init(int fd);\n-void fast_export_deinit(void);\n-\n-void fast_export_delete(const char *path);\n-void fast_export_modify(const char *path, uint32_t mode, const char *dataref);\n-void fast_export_note(const char *committish, const char *dataref);\n-void fast_export_begin_note(uint32_t revision, const char *author,\n-\t\tconst char *log, timestamp_t timestamp, const char *note_ref);\n-void fast_export_begin_commit(uint32_t revision, const char *author,\n-\t\t\tconst struct strbuf *log, const char *uuid,const char *url,\n-\t\t\ttimestamp_t timestamp, const char *local_ref);\n-void fast_export_end_commit(uint32_t revision);\n-void fast_export_data(uint32_t mode, off_t len, struct line_buffer *input);\n-void fast_export_buf_to_data(const struct strbuf *data);\n-void fast_export_blob_delta(uint32_t mode,\n-\t\t\tuint32_t old_mode, const char *old_data,\n-\t\t\toff_t len, struct line_buffer *input);\n-\n-/* If there is no such file at that rev, returns -1, errno == ENOENT. */\n-int fast_export_ls_rev(uint32_t rev, const char *path,\n-\t\t\tuint32_t *mode_out, struct strbuf *dataref_out);\n-int fast_export_ls(const char *path,\n-\t\t\tuint32_t *mode_out, struct strbuf *dataref_out);\n-\n-void fast_export_copy(uint32_t revision, const char *src, const char *dst);\n-const char *fast_export_read_path(const char *path, uint32_t *mode_out);\n-\n-#endif\ndiff --git a/vcs-svn/line_buffer.h b/vcs-svn/line_buffer.h\ndeleted file mode 100644\nindex e192aedea2..0000000000\n--- a/vcs-svn/line_buffer.h\n+++ /dev/null\n@@ -1,30 +0,0 @@\n-#ifndef LINE_BUFFER_H\n-#define LINE_BUFFER_H\n-\n-#include \"strbuf.h\"\n-\n-#define LINE_BUFFER_LEN 10000\n-\n-struct line_buffer {\n-\tchar line_buffer[LINE_BUFFER_LEN];\n-\tFILE *infile;\n-};\n-#define LINE_BUFFER_INIT { \"\", NULL }\n-\n-int buffer_init(struct line_buffer *buf, const char *filename);\n-int buffer_fdinit(struct line_buffer *buf, int fd);\n-int buffer_deinit(struct line_buffer *buf);\n-\n-int buffer_tmpfile_init(struct line_buffer *buf);\n-FILE *buffer_tmpfile_rewind(struct line_buffer *buf);\t/* prepare to write. */\n-long buffer_tmpfile_prepare_to_read(struct line_buffer *buf);\n-\n-int buffer_ferror(struct line_buffer *buf);\n-char *buffer_read_line(struct line_buffer *buf);\n-int buffer_read_char(struct line_buffer *buf);\n-size_t buffer_read_binary(struct line_buffer *buf, struct strbuf *sb, size_t len);\n-/* Returns number of bytes read (not necessarily written). */\n-off_t buffer_copy_bytes(struct line_buffer *buf, off_t len);\n-off_t buffer_skip_bytes(struct line_buffer *buf, off_t len);\n-\n-#endif\ndiff --git a/vcs-svn/sliding_window.h b/vcs-svn/sliding_window.h\ndeleted file mode 100644\nindex a7fc0999cb..0000000000\n--- a/vcs-svn/sliding_window.h\n+++ /dev/null\n@@ -1,18 +0,0 @@\n-#ifndef SLIDING_WINDOW_H\n-#define SLIDING_WINDOW_H\n-\n-#include \"strbuf.h\"\n-\n-struct sliding_view {\n-\tstruct line_buffer *file;\n-\toff_t off;\n-\tsize_t width;\n-\toff_t max_off;\t/* -1 means unlimited */\n-\tstruct strbuf buf;\n-};\n-\n-#define SLIDING_VIEW_INIT(input, len)\t{ (input), 0, 0, (len), STRBUF_INIT }\n-\n-int move_window(struct sliding_view *view, off_t off, size_t width);\n-\n-#endif\ndiff --git a/vcs-svn/svndiff.h b/vcs-svn/svndiff.h\ndeleted file mode 100644\nindex 625d950bb8..0000000000\n--- a/vcs-svn/svndiff.h\n+++ /dev/null\n@@ -1,10 +0,0 @@\n-#ifndef SVNDIFF_H\n-#define SVNDIFF_H\n-\n-struct line_buffer;\n-struct sliding_view;\n-\n-int svndiff0_apply(struct line_buffer *delta, off_t delta_len,\n-\t\t   struct sliding_view *preimage, FILE *postimage);\n-\n-#endif\ndiff --git a/vcs-svn/svndump.h b/vcs-svn/svndump.h\ndeleted file mode 100644\nindex 26faed5968..0000000000\n--- a/vcs-svn/svndump.h\n+++ /dev/null\n@@ -1,10 +0,0 @@\n-#ifndef SVNDUMP_H\n-#define SVNDUMP_H\n-\n-int svndump_init(const char *filename);\n-int svndump_init_fd(int in_fd, int back_fd);\n-void svndump_read(const char *url, const char *local_ref, const char *notes_ref);\n-void svndump_deinit(void);\n-void svndump_reset(void);\n-\n-#endif\n--\n2.30.2\n\n"},{"id":"419146","messageId":"nycvar.QRO.7.76.6.2103150421520.50@tvgsbejvaqbjf.bet","threadId":"55313","inReplyTo":"b937922d-8b56-c333-3f76-6e17a28210e3@web.de","subject":"Re: [PATCH] vcs-svn: remove header files as well","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-03-15T03:23:16Z","receivedAt":"2021-03-15T12:23:42Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi René,\n\nOn Sun, 14 Mar 2021, René Scharfe. wrote:\n\n> fc47391e24 (drop vcs-svn experiment, 2020-08-13) removed most vcs-svn\n> files.  Drop the remaining header files as well, as they are no longer\n> used.\n\nWhile it is sad to say good-bye to the last chance of replacing the Perl\nscript `git-svn` with anything that works with less problems on Windows, I\nagree it is the right thing to do.\n\nThanks,\nDscho\n\n>\n> Signed-off-by: René Scharfe <l.s.r@web.de>\n> ---\n>  vcs-svn/fast_export.h    | 34 ----------------------------------\n>  vcs-svn/line_buffer.h    | 30 ------------------------------\n>  vcs-svn/sliding_window.h | 18 ------------------\n>  vcs-svn/svndiff.h        | 10 ----------\n>  vcs-svn/svndump.h        | 10 ----------\n>  5 files changed, 102 deletions(-)\n>  delete mode 100644 vcs-svn/fast_export.h\n>  delete mode 100644 vcs-svn/line_buffer.h\n>  delete mode 100644 vcs-svn/sliding_window.h\n>  delete mode 100644 vcs-svn/svndiff.h\n>  delete mode 100644 vcs-svn/svndump.h\n>\n> diff --git a/vcs-svn/fast_export.h b/vcs-svn/fast_export.h\n> deleted file mode 100644\n> index 9dcf9337c1..0000000000\n> --- a/vcs-svn/fast_export.h\n> +++ /dev/null\n> @@ -1,34 +0,0 @@\n> -#ifndef FAST_EXPORT_H\n> -#define FAST_EXPORT_H\n> -\n> -struct strbuf;\n> -struct line_buffer;\n> -\n> -void fast_export_init(int fd);\n> -void fast_export_deinit(void);\n> -\n> -void fast_export_delete(const char *path);\n> -void fast_export_modify(const char *path, uint32_t mode, const char *dataref);\n> -void fast_export_note(const char *committish, const char *dataref);\n> -void fast_export_begin_note(uint32_t revision, const char *author,\n> -\t\tconst char *log, timestamp_t timestamp, const char *note_ref);\n> -void fast_export_begin_commit(uint32_t revision, const char *author,\n> -\t\t\tconst struct strbuf *log, const char *uuid,const char *url,\n> -\t\t\ttimestamp_t timestamp, const char *local_ref);\n> -void fast_export_end_commit(uint32_t revision);\n> -void fast_export_data(uint32_t mode, off_t len, struct line_buffer *input);\n> -void fast_export_buf_to_data(const struct strbuf *data);\n> -void fast_export_blob_delta(uint32_t mode,\n> -\t\t\tuint32_t old_mode, const char *old_data,\n> -\t\t\toff_t len, struct line_buffer *input);\n> -\n> -/* If there is no such file at that rev, returns -1, errno == ENOENT. */\n> -int fast_export_ls_rev(uint32_t rev, const char *path,\n> -\t\t\tuint32_t *mode_out, struct strbuf *dataref_out);\n> -int fast_export_ls(const char *path,\n> -\t\t\tuint32_t *mode_out, struct strbuf *dataref_out);\n> -\n> -void fast_export_copy(uint32_t revision, const char *src, const char *dst);\n> -const char *fast_export_read_path(const char *path, uint32_t *mode_out);\n> -\n> -#endif\n> diff --git a/vcs-svn/line_buffer.h b/vcs-svn/line_buffer.h\n> deleted file mode 100644\n> index e192aedea2..0000000000\n> --- a/vcs-svn/line_buffer.h\n> +++ /dev/null\n> @@ -1,30 +0,0 @@\n> -#ifndef LINE_BUFFER_H\n> -#define LINE_BUFFER_H\n> -\n> -#include \"strbuf.h\"\n> -\n> -#define LINE_BUFFER_LEN 10000\n> -\n> -struct line_buffer {\n> -\tchar line_buffer[LINE_BUFFER_LEN];\n> -\tFILE *infile;\n> -};\n> -#define LINE_BUFFER_INIT { \"\", NULL }\n> -\n> -int buffer_init(struct line_buffer *buf, const char *filename);\n> -int buffer_fdinit(struct line_buffer *buf, int fd);\n> -int buffer_deinit(struct line_buffer *buf);\n> -\n> -int buffer_tmpfile_init(struct line_buffer *buf);\n> -FILE *buffer_tmpfile_rewind(struct line_buffer *buf);\t/* prepare to write. */\n> -long buffer_tmpfile_prepare_to_read(struct line_buffer *buf);\n> -\n> -int buffer_ferror(struct line_buffer *buf);\n> -char *buffer_read_line(struct line_buffer *buf);\n> -int buffer_read_char(struct line_buffer *buf);\n> -size_t buffer_read_binary(struct line_buffer *buf, struct strbuf *sb, size_t len);\n> -/* Returns number of bytes read (not necessarily written). */\n> -off_t buffer_copy_bytes(struct line_buffer *buf, off_t len);\n> -off_t buffer_skip_bytes(struct line_buffer *buf, off_t len);\n> -\n> -#endif\n> diff --git a/vcs-svn/sliding_window.h b/vcs-svn/sliding_window.h\n> deleted file mode 100644\n> index a7fc0999cb..0000000000\n> --- a/vcs-svn/sliding_window.h\n> +++ /dev/null\n> @@ -1,18 +0,0 @@\n> -#ifndef SLIDING_WINDOW_H\n> -#define SLIDING_WINDOW_H\n> -\n> -#include \"strbuf.h\"\n> -\n> -struct sliding_view {\n> -\tstruct line_buffer *file;\n> -\toff_t off;\n> -\tsize_t width;\n> -\toff_t max_off;\t/* -1 means unlimited */\n> -\tstruct strbuf buf;\n> -};\n> -\n> -#define SLIDING_VIEW_INIT(input, len)\t{ (input), 0, 0, (len), STRBUF_INIT }\n> -\n> -int move_window(struct sliding_view *view, off_t off, size_t width);\n> -\n> -#endif\n> diff --git a/vcs-svn/svndiff.h b/vcs-svn/svndiff.h\n> deleted file mode 100644\n> index 625d950bb8..0000000000\n> --- a/vcs-svn/svndiff.h\n> +++ /dev/null\n> @@ -1,10 +0,0 @@\n> -#ifndef SVNDIFF_H\n> -#define SVNDIFF_H\n> -\n> -struct line_buffer;\n> -struct sliding_view;\n> -\n> -int svndiff0_apply(struct line_buffer *delta, off_t delta_len,\n> -\t\t   struct sliding_view *preimage, FILE *postimage);\n> -\n> -#endif\n> diff --git a/vcs-svn/svndump.h b/vcs-svn/svndump.h\n> deleted file mode 100644\n> index 26faed5968..0000000000\n> --- a/vcs-svn/svndump.h\n> +++ /dev/null\n> @@ -1,10 +0,0 @@\n> -#ifndef SVNDUMP_H\n> -#define SVNDUMP_H\n> -\n> -int svndump_init(const char *filename);\n> -int svndump_init_fd(int in_fd, int back_fd);\n> -void svndump_read(const char *url, const char *local_ref, const char *notes_ref);\n> -void svndump_deinit(void);\n> -void svndump_reset(void);\n> -\n> -#endif\n> --\n> 2.30.2\n>\n>\n"},{"id":"419166","messageId":"YE9+CvIs7PxX4Y8i@coredump.intra.peff.net","threadId":"55313","inReplyTo":"b937922d-8b56-c333-3f76-6e17a28210e3@web.de","subject":"Re: [PATCH] vcs-svn: remove header files as well","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-03-15T15:32:26Z","receivedAt":"2021-03-15T15:33:19Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Mar 14, 2021 at 03:37:39PM +0100, René Scharfe. wrote:\n\n> fc47391e24 (drop vcs-svn experiment, 2020-08-13) removed most vcs-svn\n> files.  Drop the remaining header files as well, as they are no longer\n> used.\n\nOops, I don't know how I managed to miss these in my initial commit. It\ndefinitely was not intentional. :)\n\nThey were present in the initial patch in 2018:\n\n  https://lore.kernel.org/git/20180817190310.GA5360@sigill.intra.peff.net/\n\nbut when I later posted it as part of a series in 2020:\n\n  https://lore.kernel.org/git/20200813150017.GE891370@coredump.intra.peff.net/\n\nthey were gone. I guess I must have made some mistake in rebasing it\nforward over time. I'm not sure how, though.\n\nAnyway, this is clearly the right thing to do. Thanks for noticing.\n\n-Peff\n"}]}