{"thread":{"id":"55257","subject":"[PATCH] Documentation/RelNotes: improve release note for rename detection work","startedAt":"2021-03-04T22:51:37Z","lastAt":"2021-03-05T00:37:01Z","messageCount":3,"participants":["Elijah Newren via GitGitGadget","Junio C Hamano","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"418269","messageId":"pull.974.git.git.1614898292503.gitgitgadget@gmail.com","threadId":"55257","inReplyTo":null,"subject":"[PATCH] Documentation/RelNotes: improve release note for rename detection work","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-03-04T22:51:32Z","receivedAt":"2021-03-04T22:51:37Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren <newren@gmail.com>\n\nThere were some early changes in the 2.31 cycle to optimize some setup\nin diffcore-rename.c[1], some later changes to measure performance[2],\nand finally some significant changes to improve rename detection\nperformance.  The final one was merged with the note\n\n   Performance optimization work on the rename detection continues.\n\nThat works for the commit log, but feels misleading as a release note\nsince all the changes were within one cycle.  Simplify this to just\n\n   Performance improvements for rename detection.\n\nThe former wording could be seen as hinting that more performance\nimprovements will come in 2.32, which is true, but we can just cover\nthose in the 2.32 release notes when the time comes.\n\n[1] a5ac31b5b1 (Merge branch 'en/diffcore-rename', 2021-01-25)\n[2] d3a035b055 (Merge branch 'en/merge-ort-perf', 2021-02-11)\n[3] 12bd17521c (Merge branch 'en/diffcore-rename', 2021-03-01)\n\nSigned-off-by: Elijah Newren <newren@gmail.com>\n---\n    Documentation/RelNotes: improve release note for rename detection work\n    \n    Just a tiny release note tweak\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-974%2Fnewren%2Frelease-notes-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-974/newren/release-notes-v1\nPull-Request: https://github.com/git/git/pull/974\n\n Documentation/RelNotes/2.31.0.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/RelNotes/2.31.0.txt b/Documentation/RelNotes/2.31.0.txt\nindex 04bd5b70a950..56d4643de909 100644\n--- a/Documentation/RelNotes/2.31.0.txt\n+++ b/Documentation/RelNotes/2.31.0.txt\n@@ -199,7 +199,7 @@ Performance, Internal Implementation, Development Support etc.\n \n  * Preliminary changes to fsmonitor integration.\n \n- * Performance optimization work on the rename detection continues.\n+ * Performance improvements for rename detection.\n \n  * The common code to deal with \"chunked file format\" that is shared\n    by the multi-pack-index and commit-graph files have been factored\n\nbase-commit: f01623b2c9d14207e497b21ebc6b3ec4afaf4b46\n-- \ngitgitgadget\n"},{"id":"418275","messageId":"xmqqpn0ebicj.fsf@gitster.c.googlers.com","threadId":"55257","inReplyTo":"pull.974.git.git.1614898292503.gitgitgadget@gmail.com","subject":"Re: [PATCH] Documentation/RelNotes: improve release note for rename detection work","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-03-04T23:38:04Z","receivedAt":"2021-03-04T23:38:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Elijah Newren via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> The former wording could be seen as hinting that more performance\n> improvements will come in 2.32, which is true, but ...\n\nIt is somewhat dissappointing to hear that, as the above \"hinting\"\nwas exactly what I wanted to achieve by leaving \"continues\" in\nthere.\n\nWill queue, though.\n"},{"id":"418280","messageId":"CABPp-BFL7-Na7btLxcdvaAtM1AGG6xXxwXt-YxGO-rh9e0NeKA@mail.gmail.com","threadId":"55257","inReplyTo":"xmqqpn0ebicj.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] Documentation/RelNotes: improve release note for rename detection work","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2021-03-05T00:36:48Z","receivedAt":"2021-03-05T00:37:01Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Thu, Mar 4, 2021 at 3:38 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> \"Elijah Newren via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n>\n> > The former wording could be seen as hinting that more performance\n> > improvements will come in 2.32, which is true, but ...\n>\n> It is somewhat dissappointing to hear that, as the above \"hinting\"\n> was exactly what I wanted to achieve by leaving \"continues\" in\n> there.\n\nAh.  I actually threw that last paragraph into the commit message\nalmost as an afterthought.  Perhaps \"commences\" or \"has begun\" instead\nof \"continues\" would have worked?  When I saw \"continues\" it just\nlooked to me like an accidental copy of the commit message and one\nthat could be misleading, so I thought I'd flag it.\n\n> Will queue, though.\n"}]}