{"thread":{"id":"55254","subject":"[GIT PULL v2] git-gui pull request","startedAt":"2021-03-04T18:46:43Z","lastAt":"2021-03-04T21:06:17Z","messageCount":3,"participants":["Pratyush Yadav","Eric Sunshine","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"418243","messageId":"20210304184455.sah45hzavctfnhwa@yadavpratyush.com","threadId":"55254","inReplyTo":null,"subject":"[GIT PULL v2] git-gui pull request","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2021-03-04T18:44:55Z","receivedAt":"2021-03-04T18:46:43Z","isPatch":false,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"Hi Junio,\n\nIn light of the recent breakages on macOS, this PR contains a revert of \nthe offending commit. I will add it back in the next version with \nproblems on macOS fixed.\n\nThis highlights the need for me to figure out a way to test on macOS. It \nis not a good strategy to put breaking bugs in a release and hope to fix \nit in the next one. And macOS has been a regular offender. Dunno if it \nis possible without owning the Mac hardware though...\n\n---\nThe following changes since commit \nb1056f60b63f1bc8226d01881bc829e171fc78bf:\n\n  Merge branch 'py/commit-comments' (2021-02-22 20:19:53 +0530)\n\nare available in the Git repository at:\n\n  https://github.com/prati0100/git-gui.git \n\nfor you to fetch changes up to df4f9e28f64ea97032ec70d9c8894dc87a1b7f9e:\n\n  Merge branch 'py/revert-commit-comments' (2021-03-04 13:59:45 +0530)\n\n----------------------------------------------------------------\nPratyush Yadav (2):\n      Revert \"git-gui: remove lines starting with the comment character\"\n      Merge branch 'py/revert-commit-comments'\n\n git-gui.sh     |  5 -----\n lib/commit.tcl | 18 ++----------------\n 2 files changed, 2 insertions(+), 21 deletions(-)\n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"418244","messageId":"CAPig+cR8WA-KpuBsOjqbR2yGMwiszwe_ZEeQzpV-DutCh0aaww@mail.gmail.com","threadId":"55254","inReplyTo":"20210304184455.sah45hzavctfnhwa@yadavpratyush.com","subject":"Re: [GIT PULL v2] git-gui pull request","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-03-04T18:54:05Z","receivedAt":"2021-03-04T18:55:47Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Mar 4, 2021 at 1:45 PM Pratyush Yadav <me@yadavpratyush.com> wrote:\n> In light of the recent breakages on macOS, this PR contains a revert of\n> the offending commit. I will add it back in the next version with\n> problems on macOS fixed.\n>\n> This highlights the need for me to figure out a way to test on macOS. It\n> is not a good strategy to put breaking bugs in a release and hope to fix\n> it in the next one. And macOS has been a regular offender. Dunno if it\n> is possible without owning the Mac hardware though...\n\nA couple suggestions:\n\nSend pull requests to Junio early and often. His tree gets tested more\nwidely than the stand-alone git-gui, so breakage is more likely to get\ndetected earlier rather than later in his tree, thus giving us a more\ncomfortable margin for dealing with problems.\n\nThe majority of the problems noticed on macOS have not been specific\nto macOS itself. Rather, they are specific to the old version of Tcl\nwhich ships with macOS. Therefore, an easy way for you to detect these\nproblems early is to install an old version of Tcl on your development\nmachine and ensure that you test against that version before sending a\npull request. I think that this approach alone would catch all of the\noutright breakage problems we've seen recently on macOS. (It won't\ncatch aesthetic issues, but those tend to be minor compared with the\noutright breakage.)\n\nThanks.\n"},{"id":"418260","messageId":"xmqq1rcueilq.fsf@gitster.c.googlers.com","threadId":"55254","inReplyTo":"20210304184455.sah45hzavctfnhwa@yadavpratyush.com","subject":"Re: [GIT PULL v2] git-gui pull request","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-03-04T21:04:17Z","receivedAt":"2021-03-04T21:06:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pratyush Yadav <me@yadavpratyush.com> writes:\n\n> The following changes since commit \n> b1056f60b63f1bc8226d01881bc829e171fc78bf:\n>\n>   Merge branch 'py/commit-comments' (2021-02-22 20:19:53 +0530)\n>\n> are available in the Git repository at:\n>\n>   https://github.com/prati0100/git-gui.git \n>\n> for you to fetch changes up to df4f9e28f64ea97032ec70d9c8894dc87a1b7f9e:\n>\n>   Merge branch 'py/revert-commit-comments' (2021-03-04 13:59:45 +0530)\n\nThanks.\n"}]}