{"thread":{"id":"55240","subject":"[PATCH] Add support for C# record types","startedAt":"2021-03-02T15:28:12Z","lastAt":"2021-06-15T21:04:51Z","messageCount":2,"participants":["Julian Verdurmen via GitGitGadget","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"418093","messageId":"pull.971.git.git.1614646689506.gitgitgadget@gmail.com","threadId":"55240","inReplyTo":null,"subject":"[PATCH] Add support for C# record types","fromName":"Julian Verdurmen via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-03-02T00:58:09Z","receivedAt":"2021-03-02T15:28:12Z","isPatch":true,"sender":{"key":"name:Julian Verdurmen","avatar":null},"body":"From: Julian Verdurmen <julian.verdurmen@outlook.com>\n\nRecords are added in C# 9\n\nCode example :\n\n    public record Person(string FirstName, string LastName);\n\nFor more information, see:\n* https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-9\n\nSigned-off-by: Julian Verdurmen <julian.verdurmen@outlook.com>\n---\n    userdiff.c: Added support for record types in C#\n    \n    Support for C# 9 records. See\n    https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/exploration/records\n    \n    I will try to use gitgitgadget [https://gitgitgadget.github.io/]\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-971%2F304NotModified%2Fcsharp-record-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-971/304NotModified/csharp-record-v1\nPull-Request: https://github.com/git/git/pull/971\n\n userdiff.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/userdiff.c b/userdiff.c\nindex 3f81a2261c5e..2803683c3117 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -212,7 +212,7 @@ PATTERNS(\"csharp\",\n \t /* Properties */\n \t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[@._[:alnum:]]+)[ \\t]*$\\n\"\n \t /* Type definitions */\n-\t \"^[ \\t]*(((static|public|internal|private|protected|new|unsafe|sealed|abstract|partial)[ \\t]+)*(class|enum|interface|struct)[ \\t]+.*)$\\n\"\n+\t \"^[ \\t]*(((static|public|internal|private|protected|new|unsafe|sealed|abstract|partial)[ \\t]+)*(class|enum|interface|struct|record)[ \\t]+.*)$\\n\"\n \t /* Namespace */\n \t \"^[ \\t]*(namespace[ \\t]+.*)$\",\n \t /* -- */\n\nbase-commit: 328c10930387d301560f7cbcd3351cc485a13381\n-- \ngitgitgadget\n"},{"id":"427529","messageId":"nycvar.QRO.7.76.6.2106152130590.57@tvgsbejvaqbjf.bet","threadId":"55240","inReplyTo":"pull.971.git.git.1614646689506.gitgitgadget@gmail.com","subject":"Re: [PATCH] Add support for C# record types","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-06-15T21:04:42Z","receivedAt":"2021-06-15T21:04:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Julian,\n\nOn Tue, 2 Mar 2021, Julian Verdurmen via GitGitGadget wrote:\n\n> From: Julian Verdurmen <julian.verdurmen@outlook.com>\n>\n> Records are added in C# 9\n>\n> Code example :\n>\n>     public record Person(string FirstName, string LastName);\n>\n> For more information, see:\n> * https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-9\n>\n> Signed-off-by: Julian Verdurmen <julian.verdurmen@outlook.com>\n\nI am not precisely a C# _expert_, but from what I understand this patch\nand commit message look good to me.\n\nReviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nThanks,\nDscho\n\n> ---\n>     userdiff.c: Added support for record types in C#\n>\n>     Support for C# 9 records. See\n>     https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/exploration/records\n>\n>     I will try to use gitgitgadget [https://gitgitgadget.github.io/]\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-971%2F304NotModified%2Fcsharp-record-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-971/304NotModified/csharp-record-v1\n> Pull-Request: https://github.com/git/git/pull/971\n>\n>  userdiff.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/userdiff.c b/userdiff.c\n> index 3f81a2261c5e..2803683c3117 100644\n> --- a/userdiff.c\n> +++ b/userdiff.c\n> @@ -212,7 +212,7 @@ PATTERNS(\"csharp\",\n>  \t /* Properties */\n>  \t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[@._[:alnum:]]+)[ \\t]*$\\n\"\n>  \t /* Type definitions */\n> -\t \"^[ \\t]*(((static|public|internal|private|protected|new|unsafe|sealed|abstract|partial)[ \\t]+)*(class|enum|interface|struct)[ \\t]+.*)$\\n\"\n> +\t \"^[ \\t]*(((static|public|internal|private|protected|new|unsafe|sealed|abstract|partial)[ \\t]+)*(class|enum|interface|struct|record)[ \\t]+.*)$\\n\"\n>  \t /* Namespace */\n>  \t \"^[ \\t]*(namespace[ \\t]+.*)$\",\n>  \t /* -- */\n>\n> base-commit: 328c10930387d301560f7cbcd3351cc485a13381\n> --\n> gitgitgadget\n>\n>\n"}]}