{"thread":{"id":"55238","subject":"[PATCH] docs: clarified that --lost-found implies --no-reflogs","startedAt":"2021-03-01T15:03:08Z","lastAt":"2021-03-01T19:06:34Z","messageCount":2,"participants":["Marco Luzzara via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"418038","messageId":"pull.970.git.git.1614610921331.gitgitgadget@gmail.com","threadId":"55238","inReplyTo":null,"subject":"[PATCH] docs: clarified that --lost-found implies --no-reflogs","fromName":"Marco Luzzara via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-03-01T15:02:00Z","receivedAt":"2021-03-01T15:03:08Z","isPatch":true,"sender":{"key":"name:Marco Luzzara","avatar":null},"body":"From: Marco Luzzara <marco.luzzara@hotmail.it>\n\ngit fsck --lost-found does not look for references in the reflog. If not specified, it could create misunderstandings like this one: https://stackoverflow.com/questions/66401232/git-fsck-combining-lost-found-and-unreachable\n\nSigned-off-by: Marco Luzzara <marco.luzzara@hotmail.it>\n---\n    docs: clarified that --lost-found implies --no-reflogs\n    \n    git fsck --lost-found does not look for references in the reflog. If not\n    specified, it could create misunderstandings like this one: git fsck\n    combining --lost-found and --unreachable\n    [https://stackoverflow.com/questions/66401232/git-fsck-combining-lost-found-and-unreachable]\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-970%2Fmarco-luzzara%2Fmaster-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-970/marco-luzzara/master-v1\nPull-Request: https://github.com/git/git/pull/970\n\n Documentation/git-fsck.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-fsck.txt b/Documentation/git-fsck.txt\nindex bd596619c0d3..9f1db29042f0 100644\n--- a/Documentation/git-fsck.txt\n+++ b/Documentation/git-fsck.txt\n@@ -89,7 +89,7 @@ care about this output and want to speed it up further.\n \tWrite dangling objects into .git/lost-found/commit/ or\n \t.git/lost-found/other/, depending on type.  If the object is\n \ta blob, the contents are written into the file, rather than\n-\tits object name.\n+\tits object name. This option implies `--no-reflogs`.\n \n --name-objects::\n \tWhen displaying names of reachable objects, in addition to the\n\nbase-commit: 225365fb5195e804274ab569ac3cc4919451dc7f\n-- \ngitgitgadget\n"},{"id":"418057","messageId":"xmqq4khur931.fsf@gitster.c.googlers.com","threadId":"55238","inReplyTo":"pull.970.git.git.1614610921331.gitgitgadget@gmail.com","subject":"Re: [PATCH] docs: clarified that --lost-found implies --no-reflogs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-03-01T19:02:26Z","receivedAt":"2021-03-01T19:06:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Marco Luzzara via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Marco Luzzara <marco.luzzara@hotmail.it>\n>\n> git fsck --lost-found does not look for references in the reflog. If not specified, it could create misunderstandings like this one: https://stackoverflow.com/questions/66401232/git-fsck-combining-lost-found-and-unreachable\n\nThanks for attempting to improve our documentation.\n\n - Please avoid an overly long line like the above.  Wrap your line\n   at around 60-70 columns.\n\n - Please do not force readers to visit external site to understand\n   why your change is useful.  You should be able to summarize the\n   puzzlement described there in a few sentences, something like:\n\n\tThe documentation does not say \"git fsck --lost-found\" uses\n\t\"--no-reflogs\" to make it easier to find objects that are\n\tnot reachable from the tip of refs, which leads people to\n\twonder why commits that are reachable only from reflogs are\n\tshown as dangling (see https://stackoverflow.com/questions/66401232\n\tfor an example).\n\n   perhaps.\n\n> @@ -89,7 +89,7 @@ care about this output and want to speed it up further.\n>  \tWrite dangling objects into .git/lost-found/commit/ or\n>  \t.git/lost-found/other/, depending on type.  If the object is\n>  \ta blob, the contents are written into the file, rather than\n> -\tits object name.\n> +\tits object name. This option implies `--no-reflogs`.\n\nIt also would be a good idea to explain why it implies that.\n\nTHanks.\n"}]}