{"thread":{"id":"55110","subject":"[rfh] where is coccinelle these days on Ubuntu?","startedAt":"2021-02-05T01:35:31Z","lastAt":"2021-02-10T00:34:49Z","messageCount":5,"participants":["Junio C Hamano","Taylor Blau"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"416230","messageId":"xmqqeehv2t71.fsf@gitster.c.googlers.com","threadId":"55110","inReplyTo":null,"subject":"[rfh] where is coccinelle these days on Ubuntu?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-02-05T01:34:42Z","receivedAt":"2021-02-05T01:35:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This is probably something that is very obvious for GitHub folks or\na debian person, but does anybody know what made it suddenly wrong\nthat we have been doing to obtain coccinelle?\n\nhttps://github.com/git/git/runs/1835560289?check_suite_focus=true#step:3:108\n\n"},{"id":"416231","messageId":"YBylBKMG4G4dbiOW@nand.local","threadId":"55110","inReplyTo":"xmqqeehv2t71.fsf@gitster.c.googlers.com","subject":"Re: [rfh] where is coccinelle these days on Ubuntu?","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-02-05T01:53:08Z","receivedAt":"2021-02-05T01:54:25Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Feb 04, 2021 at 05:34:42PM -0800, Junio C Hamano wrote:\n> This is probably something that is very obvious for GitHub folks or\n> a debian person, but does anybody know what made it suddenly wrong\n> that we have been doing to obtain coccinelle?\n>\n> https://github.com/git/git/runs/1835560289?check_suite_focus=true#step:3:108\n\nNot obvious to me, but I did happen to notice it last night when waiting\non some workflows to finish on ttaylorr/git.\n\nFrom a quick search, it looks like coccinelle was moved to the\n\"universe\" repository, at least in the Azure mirrors (which is what\nGitHub Actions uses):\n\n http://azure.archive.ubuntu.com/ubuntu/pool/universe/c/coccinelle/\n\nI just pushed the patch below the scissors line to my fork, and I'll\nwatch the static analysis build to see if it works again:\n\n https://github.com/ttaylorr/git/actions/runs/539049631\n\n--- >8 ---\n\nSubject: [PATCH] ci/install-dependencies.sh: install coccinelle from universe\n\nThe apt package \"coccinelle\" moved to the universe repository in the\npackage mirrors that are used by GitHub Actions. This causes\ncoccinelle to be reported as missing, since it is no longer available in\nthe main repository.\n\nSince universe isn't sourced by default, add it as an apt repository\nbefore updating and installing coccinelle.\n\nSigned-off-by: Taylor Blau \n---\n ci/install-dependencies.sh | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex 0b1184e04a..0350538d52 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -61,6 +61,7 @@ osx-clang|osx-gcc)\n \tesac\n \t;;\n StaticAnalysis)\n+\tsudo add-apt-repository universe\n \tsudo apt-get -q update\n \tsudo apt-get -q -y install coccinelle libcurl4-openssl-dev libssl-dev \\\n \t\tlibexpat-dev gettext make\n--\n2.30.0.667.g81c0cbc6fd\n\n"},{"id":"416338","messageId":"xmqqr1lt9gm3.fsf@gitster.c.googlers.com","threadId":"55110","inReplyTo":"YBylBKMG4G4dbiOW@nand.local","subject":"Re: [rfh] where is coccinelle these days on Ubuntu?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-02-06T18:49:08Z","receivedAt":"2021-02-06T18:50:10Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> From a quick search, it looks like coccinelle was moved to the\n> \"universe\" repository, at least in the Azure mirrors (which is what\n> GitHub Actions uses):\n>\n> http://azure.archive.ubuntu.com/ubuntu/pool/universe/c/coccinelle/\n\nUnfortunately the pool/ system does not tell us which suite a\npackage is available in (that's the whole point of it, as it lets\nthem share the packages across suites without moving things around).\n\nLooking for the package availability\n\n https://packages.ubuntu.com/search?keywords=coccinelle\n\nseems to tell me about these:\n\n xenial (16.04LTS) (devel): semantic patching tool for C [universe]\n 1.0.4.deb-2: amd64 arm64 armhf i386 powerpc ppc64el s390x\n\n bionic (18.04LTS) (devel): semantic patching tool for C [universe]\n 1.0.4.deb-3build4: amd64 arm64 armhf i386 ppc64el s390x\n\n groovy (20.10) (devel): semantic patching tool for C [universe]\n 1.0.8.deb-4: amd64 arm64 armhf ppc64el s390x\n\n hirsute (devel): semantic patching tool for C [universe]\n 1.0.8.deb-5build1: amd64 arm64 armhf ppc64el s390x\n\nbut it does not seem to produce hits in any of the [focal],\n[focal-updates], and [focal-backports] suites, which the actions\nthing seem to be using X-<.\n\nHmph...\n"},{"id":"416442","messageId":"YCGrmsg8J7XT32TM@nand.local","threadId":"55110","inReplyTo":"xmqqr1lt9gm3.fsf@gitster.c.googlers.com","subject":"Re: [rfh] where is coccinelle these days on Ubuntu?","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-02-08T21:22:34Z","receivedAt":"2021-02-08T21:24:00Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sat, Feb 06, 2021 at 10:49:08AM -0800, Junio C Hamano wrote:\n> Taylor Blau writes:\n>\n> > From a quick search, it looks like coccinelle was moved to the\n> > \"universe\" repository, at least in the Azure mirrors (which is what\n> > GitHub Actions uses):\n> >\n> > http://azure.archive.ubuntu.com/ubuntu/pool/universe/c/coccinelle/\n>\n> Unfortunately the pool/ system does not tell us which suite a\n> package is available in (that's the whole point of it, as it lets\n> them share the packages across suites without moving things around).\n\nOK. I'm learning about this as I go, so this is helpful to know it's not\ngood practice to pin a specific suite.\n\n> Looking for the package availability\n>\n> https://packages.ubuntu.com/search?keywords=coccinelle\n>\n> seems to tell me about these:\n\nIt seems that there isn't a coccinelle package available for focal yet.\nThat's odd, since (1) focal is a LTS release, and (2) there *is* a\ncoccinelle package on groovy, which is newer than focal. Here's a piece\nof mail from the coccinelle list that says there's no release yet.\n\n https://systeme.lip6.fr/pipermail/cocci/2020-June/007768.html\n\nOur static-analysis build runs on 'ubuntu-latest', which I understand is\nin the process of being upgraded from bionic to focal (I was pointed to\nhttps://github.com/actions/virtual-environments/issues/1816 internally\nas a spot to learn more about this.)\n\nDouble checking the latest successful static-analysis build, indeed it\nwas on 18.04:\n\n https://github.com/git/git/runs/1811069070?check_suite_focus=true\n\n> Hmph...\n\nSo, I guess we could continue to run on 18.04 until there is a focal\ncoccinelle. Below would be the way to do that...\n\nThanks,\nTaylor\n\n--- >8 ---\n\nSubject: [PATCH] .github/workflows/main.yml: run static-analysis on bionic\n\nGitHub Actions is transitioning workflow steps that run on\n'ubuntu-latest' from 18.04 to 20.04 [1].\n\nThis works fine in all steps except the static-analysis one, since\nCoccinelle isn't available on Ubuntu focal (it is only available in the\nuniverse suite).\n\nUntil Coccinelle can be installed from 20.04's main suite, pin the\nstatic-analysis build to run on 18.04, where it can be installed by\ndefault.\n\n[1]: https://github.com/actions/virtual-environments/issues/1816\n\nReported-by: Junio C Hamano \nSigned-off-by: Taylor Blau \n---\n .github/workflows/main.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex f6885e88ee..a3fbbe6398 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -340,7 +340,7 @@ jobs:\n if: needs.ci-config.outputs.enabled == 'yes'\n env:\n jobname: StaticAnalysis\n- runs-on: ubuntu-latest\n+ runs-on: ubuntu-18.04\n steps:\n - uses: actions/checkout@v1\n - run: ci/install-dependencies.sh\n--\n2.30.0.667.g81c0cbc6fd\n\n"},{"id":"416596","messageId":"xmqqlfbwye4m.fsf@gitster.c.googlers.com","threadId":"55110","inReplyTo":"YCGrmsg8J7XT32TM@nand.local","subject":"Re: [rfh] where is coccinelle these days on Ubuntu?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-02-10T00:12:41Z","receivedAt":"2021-02-10T00:34:49Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> So, I guess we could continue to run on 18.04 until there is a focal\n> coccinelle. Below would be the way to do that...\n>\n> Thanks,\n> Taylor\n\nThanks. Let's merge this down to 'next', 'master' and then to\n'maint'.\n"}]}