{"thread":{"id":"54967","subject":"Git 2.30.0 and failed self tests","startedAt":"2021-01-09T00:08:12Z","lastAt":"2021-01-11T07:37:56Z","messageCount":5,"participants":["Jeffrey Walton","Stefan Moch"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"413899","messageId":"CAH8yC8km6mHsrCD6sW+Z2ERpyO_X8Xp6fJbYKV+JF2gaqYakgQ@mail.gmail.com","threadId":"54967","inReplyTo":null,"subject":"Git 2.30.0 and failed self tests","fromName":"Jeffrey Walton","fromEmail":"noloader@gmail.com","sentAt":"2021-01-09T00:07:04Z","receivedAt":"2021-01-09T00:08:12Z","isPatch":false,"sender":{"key":"noloader@gmail.com","avatar":null},"body":"Hi Everyone,\n\nI'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64\nfully patched. They seem to be centered around email.\n\n    *** t9001-send-email.sh ***\n    ok 1 - prepare reference tree\n    ok 2 - Setup helper tool\n    ok 3 - Extract patches\n    not ok 4 - No confirm with --suppress-cc\n    #\n    #        test_no_confirm --suppress-cc=sob &&\n    #        check_no_confirm\n    #\n    ...\n\n    not ok 174 - test forbidSendmailVariables behavior override\n    #\n    #        test_config sendmail.program sendmail &&\n    #        test_config sendemail.forbidSendmailVariables false &&\n    #        git send-email \\\n    #            --from=\"Example <nobody@example.com>\" \\\n    #            --to=nobody@example.com \\\n    #            --smtp-server=\"$(pwd)/fake.sendmail\" \\\n    #            HEAD^\n    #\n    # failed 132 among 174 test(s)\n\nJeff\n"},{"id":"413976","messageId":"4d81f0f1-66eb-2aac-4eab-dc5508d161b1@mail.de","threadId":"54967","inReplyTo":"CAH8yC8km6mHsrCD6sW+Z2ERpyO_X8Xp6fJbYKV+JF2gaqYakgQ@mail.gmail.com","subject":"Re: Git 2.30.0 and failed self tests","fromName":"Stefan Moch","fromEmail":"stefanmoch@mail.de","sentAt":"2021-01-10T17:09:02Z","receivedAt":"2021-01-10T17:20:24Z","isPatch":false,"sender":{"key":"stefanmoch@mail.de","avatar":null},"body":"Hi Jeff,\n\nJeffrey Walton wrote:\n> I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64\n> fully patched. They seem to be centered around email.\n\nI cannot confirm this on the same git version and platform:\n\n    # passed all 174 test(s)\n    1..174\n\nChristian's suggestion from your other thread about running the test\nwith the options -i -v -x should also help here to give more\ndetailed error messages:\n\nhttps://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/\n\n>     *** t9001-send-email.sh ***\n>     ok 1 - prepare reference tree\n>     ok 2 - Setup helper tool\n>     ok 3 - Extract patches\n>     not ok 4 - No confirm with --suppress-cc\n\n\nSince the tests 1-3 do not call git send-email, but test 4 and most\nof the following do, I suspect the system is missing some dependency\npackages needed for git send-email, probably mail-related Perl modules.\n\nInstalling Fedora's git-email package is probably enough to fix this:\n\n    dnf install git-email\n\n\n\nStefan\n"},{"id":"413977","messageId":"CAH8yC8kdMhCU2WzvCU==dmm8n3+ci2+0Pg_DBF2Np-X+ZKTfgQ@mail.gmail.com","threadId":"54967","inReplyTo":"4d81f0f1-66eb-2aac-4eab-dc5508d161b1@mail.de","subject":"Re: Git 2.30.0 and failed self tests","fromName":"Jeffrey Walton","fromEmail":"noloader@gmail.com","sentAt":"2021-01-10T17:24:08Z","receivedAt":"2021-01-10T17:25:01Z","isPatch":false,"sender":{"key":"noloader@gmail.com","avatar":null},"body":"On Sun, Jan 10, 2021 at 12:09 PM Stefan Moch <stefanmoch@mail.de> wrote:\n>\n> Hi Jeff,\n>\n> Jeffrey Walton wrote:\n> > I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64\n> > fully patched. They seem to be centered around email.\n>\n> I cannot confirm this on the same git version and platform:\n>\n>     # passed all 174 test(s)\n>     1..174\n>\n> Christian's suggestion from your other thread about running the test\n> with the options -i -v -x should also help here to give more\n> detailed error messages:\n>\n> https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/\n>\n> >     *** t9001-send-email.sh ***\n> >     ok 1 - prepare reference tree\n> >     ok 2 - Setup helper tool\n> >     ok 3 - Extract patches\n> >     not ok 4 - No confirm with --suppress-cc\n>\n>\n> Since the tests 1-3 do not call git send-email, but test 4 and most\n> of the following do, I suspect the system is missing some dependency\n> packages needed for git send-email, probably mail-related Perl modules.\n>\n> Installing Fedora's git-email package is probably enough to fix this:\n>\n>     dnf install git-email\n\nYeah, I think I yanked exim out of this machine a long time ago (or\nwhatever smtp mailer gets installed). It faces the internet and I did\nnot want the additional attack surface.\n\nLet me run that test manually.\n\nJeff\n"},{"id":"413982","messageId":"CAH8yC8mVxNrd-j3=7OWz-vnKvvjHmp8izSow9XK0G71XqcP1tw@mail.gmail.com","threadId":"54967","inReplyTo":"4d81f0f1-66eb-2aac-4eab-dc5508d161b1@mail.de","subject":"Re: Git 2.30.0 and failed self tests","fromName":"Jeffrey Walton","fromEmail":"noloader@gmail.com","sentAt":"2021-01-10T19:05:43Z","receivedAt":"2021-01-10T19:07:12Z","isPatch":false,"sender":{"key":"noloader@gmail.com","avatar":null},"body":"On Sun, Jan 10, 2021 at 12:09 PM Stefan Moch <stefanmoch@mail.de> wrote:\n>\n> Jeffrey Walton wrote:\n> > I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64\n> > fully patched. They seem to be centered around email.\n>\n> I cannot confirm this on the same git version and platform:\n>\n>     # passed all 174 test(s)\n>     1..174\n>\n> Christian's suggestion from your other thread about running the test\n> with the options -i -v -x should also help here to give more\n> detailed error messages:\n>\n> https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/\n>\n> >     *** t9001-send-email.sh ***\n> >     ok 1 - prepare reference tree\n> >     ok 2 - Setup helper tool\n> >     ok 3 - Extract patches\n> >     not ok 4 - No confirm with --suppress-cc\n>\n> Since the tests 1-3 do not call git send-email, but test 4 and most\n> of the following do, I suspect the system is missing some dependency\n> packages needed for git send-email, probably mail-related Perl modules.\n>\n> Installing Fedora's git-email package is probably enough to fix this:\n>\n>     dnf install git-email\n\nIt looks like a Perl problem.\n\nI've got a Perl recipe for OpenSSL. The OpenSSL devs don't realize the\ntrouble they create with that dependency. Old systems need a newer\nPerl for OpenSSL. The F33 machine is a test machine, so Perl gets\ntested on it, too.\n\nt$ ./t9001-send-email.sh -i -v -x\nInitialized empty Git repository in\n/home/jwalton/Build-Scripts/git-2.30.0/t/trash\ndirectory.t9001-send-email/.git/\nexpecting success of 9001.1 'prepare reference tree':\n    echo \"1A quick brown fox jumps over the\" >file &&\n    echo \"lazy dog\" >>file &&\n    git add file &&\n    GIT_AUTHOR_NAME=\"A\" git commit -a -m \"Initial.\"\n\n++ echo '1A quick brown fox jumps over the'\n++ echo 'lazy dog'\n++ git add file\n++ GIT_AUTHOR_NAME=A\n++ git commit -a -m Initial.\n[master (root-commit) fbff2ba] Initial.\n Author: A <author@example.com>\n 1 file changed, 2 insertions(+)\n create mode 100644 file\nok 1 - prepare reference tree\n\nexpecting success of 9001.2 'Setup helper tool':\n    write_script fake.sendmail <<-\\EOF &&\n    shift\n    output=1\n    while test -f commandline$output\n    do\n        output=$(($output+1))\n    done\n    for a\n    do\n        echo \"!$a!\"\n    done >commandline$output\n    cat >\"msgtxt$output\"\n    EOF\n    git add fake.sendmail &&\n    GIT_AUTHOR_NAME=\"A\" git commit -a -m \"Second.\"\n\n++ write_script fake.sendmail\n++ echo '#!/bin/sh'\n++ cat\n++ chmod +x fake.sendmail\n++ git add fake.sendmail\n++ GIT_AUTHOR_NAME=A\n++ git commit -a -m Second.\n[master 60cacbf] Second.\n Author: A <author@example.com>\n 1 file changed, 12 insertions(+)\n create mode 100755 fake.sendmail\nok 2 - Setup helper tool\n\nexpecting success of 9001.3 'Extract patches':\n    patches=$(git format-patch -s --cc=\"One <one@example.com>\"\n--cc=two@example.com -n HEAD^1) &&\n    threaded_patches=$(git format-patch -o threaded -s\n--in-reply-to=\"format\" HEAD^1)\n\n+++ git format-patch -s '--cc=One <one@example.com>'\n--cc=two@example.com -n 'HEAD^1'\n++ patches=0001-Second.patch\n+++ git format-patch -o threaded -s --in-reply-to=format 'HEAD^1'\n++ threaded_patches=threaded/0001-Second.patch\nok 3 - Extract patches\n\nexpecting success of 9001.4 'No confirm with --suppress-cc':\n    test_no_confirm --suppress-cc=sob &&\n    check_no_confirm\n\n++ test_no_confirm --suppress-cc=sob\n++ rm -f no_confirm_okay\n++ echo n\n+++ pwd\n++ GIT_SEND_EMAIL_NOTTY=1\n++ git send-email '--from=Example <from@example.com>'\n--to=nobody@example.com\n'--smtp-server=/home/jwalton/Build-Scripts/git-2.30.0/t/trash\ndirectory.t9001-send-email/fake.sendmail' --suppress-cc=sob\n0001-Second.patch\nCan't locate Term/ReadLine.pm in @INC (you may need to install the\nTerm::ReadLine module) (@INC contains:\n/home/jwalton/Build-Scripts/git-2.30.0/perl/build/lib\n/home/jwalton/Build-Scripts/git-2.30.0/t/../perl/build/lib\n/usr/local/lib64/perl5/5.32 /usr/local/share/perl5/5.32\n/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl\n/usr/lib64/perl5 /usr/share/perl5) at\n/home/jwalton/Build-Scripts/git-2.30.0/git-send-email line 25.\nBEGIN failed--compilation aborted at\n/home/jwalton/Build-Scripts/git-2.30.0/git-send-email line 25.\nerror: last command exited with $?=2\nnot ok 4 - No confirm with --suppress-cc\n#\n#        test_no_confirm --suppress-cc=sob &&\n#        check_no_confirm\n\nJeff\n"},{"id":"414010","messageId":"CAH8yC8kEcUrVr9iortiWWVRwfos0DAb+E3z2k8bQgmcSSOmGLg@mail.gmail.com","threadId":"54967","inReplyTo":"4d81f0f1-66eb-2aac-4eab-dc5508d161b1@mail.de","subject":"Re: Git 2.30.0 and failed self tests","fromName":"Jeffrey Walton","fromEmail":"noloader@gmail.com","sentAt":"2021-01-11T07:37:02Z","receivedAt":"2021-01-11T07:37:56Z","isPatch":false,"sender":{"key":"noloader@gmail.com","avatar":null},"body":"On Sun, Jan 10, 2021 at 12:09 PM Stefan Moch <stefanmoch@mail.de> wrote:\n>\n> Jeffrey Walton wrote:\n> > I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64\n> > fully patched. They seem to be centered around email.\n>\n> I cannot confirm this on the same git version and platform:\n>\n>     # passed all 174 test(s)\n>     1..174\n>\n> Christian's suggestion from your other thread about running the test\n> with the options -i -v -x should also help here to give more\n> detailed error messages:\n>\n> https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/\n>\n> >     *** t9001-send-email.sh ***\n> >     ok 1 - prepare reference tree\n> >     ok 2 - Setup helper tool\n> >     ok 3 - Extract patches\n> >     not ok 4 - No confirm with --suppress-cc\n>\n> Since the tests 1-3 do not call git send-email, but test 4 and most\n> of the following do, I suspect the system is missing some dependency\n> packages needed for git send-email, probably mail-related Perl modules.\n>\n> Installing Fedora's git-email package is probably enough to fix this:\n>\n>     dnf install git-email\n\nI deleted my copy of Perl. I am only using the system's version:\n\n    $ command -v perl\n    /bin/perl\n\n    $ perl --version\n    This is perl 5, version 32, subversion 0 (v5.32.0) built for\nx86_64-linux-thread-multi\n    (with 44 registered patches, see perl -V for more detail)\n\nI'm still seeing the failure. Weird...\n\nJeff\n"}]}