{"thread":{"id":"54888","subject":"[PATCH] SubmittingPatches: tighten wording on \"sign-off\" procedure","startedAt":"2020-12-28T10:40:57Z","lastAt":"2021-01-07T23:38:54Z","messageCount":5,"participants":["Junio C Hamano","Felipe Contreras","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"413051","messageId":"xmqqh7o6jjt1.fsf@gitster.c.googlers.com","threadId":"54888","inReplyTo":null,"subject":"[PATCH] SubmittingPatches: tighten wording on \"sign-off\" procedure","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-28T10:39:54Z","receivedAt":"2020-12-28T10:40:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The text says \"if you can certify DCO then you add a Singed-off-by\ntrailer\". But it does not say anything about people who cannot\ncertify. A natural reading may be that if you cannot certify, you\ndo not add the trailer, but it shouldn't hurt to be overly explicit.\n\nSigned-off-by: Junio C Hamano \n---\n\n Documentation/SubmittingPatches | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches\nindex d12094bac5..b091730771 100644\n--- c/Documentation/SubmittingPatches\n+++ w/Documentation/SubmittingPatches\n@@ -307,35 +307,35 @@ wrote the patch or have the right to pass it on under the same license\n as ours, by \"signing off\" your patch. Without sign-off, we cannot\n accept your patches.\n \n-If you can certify the below D-C-O:\n+If (and only if) you can certify the below D-C-O:\n \n [[dco]]\n .Developer's Certificate of Origin 1.1\n ____\n By making a contribution to this project, I certify that:\n\n a. The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\n b. The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\n c. The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\n d. I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n ____\n\n you add a \"Signed-off-by\" trailer to your commit, that looks like\n this:\n"},{"id":"413072","messageId":"5fe9e731de0e5_209d20845@natae.notmuch","threadId":"54888","inReplyTo":"xmqqh7o6jjt1.fsf@gitster.c.googlers.com","subject":"RE: [PATCH] SubmittingPatches: tighten wording on \"sign-off\" procedure","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-28T14:09:53Z","receivedAt":"2020-12-28T15:06:27Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Junio C Hamano wrote:\n> The text says \"if you can certify DCO then you add a Singed-off-by\n> trailer\". But it does not say anything about people who cannot\n> certify. A natural reading may be that if you cannot certify, you\n> do not add the trailer, but it shouldn't hurt to be overly explicit.\n\nIt doesn't matter if a person *can* certify, what matters is if the\nperson *does* certify.\n\nIn a weeding ceremony when asked \"do you take this woman to be your\nwife?\", the answer that is looked for is not \"I can\".\n\nDo you or don't you? Is the question.\n\n> diff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches\n> index d12094bac5..b091730771 100644\n> --- c/Documentation/SubmittingPatches\n> +++ w/Documentation/SubmittingPatches\n> @@ -307,35 +307,35 @@ wrote the patch or have the right to pass it on under the same license\n> as ours, by \"signing off\" your patch. Without sign-off, we cannot\n> accept your patches.\n> \n> -If you can certify the below D-C-O:\n> +If (and only if) you can certify the below D-C-O:\n\nIf you certify the bellow D-C-O:\n\n> [[dco]]\n> .Developer's Certificate of Origin 1.1\n> ____\n\n-- \nFelipe Contreras\n"},{"id":"413074","messageId":"e54cbb7d-eb80-519a-bedd-f4ab65e6ec24@gmail.com","threadId":"54888","inReplyTo":"xmqqh7o6jjt1.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] SubmittingPatches: tighten wording on \"sign-off\" procedure","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-12-28T15:19:58Z","receivedAt":"2020-12-28T15:20:48Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 12/28/2020 5:39 AM, Junio C Hamano wrote:\n> The text says \"if you can certify DCO then you add a Singed-off-by\n> trailer\". But it does not say anything about people who cannot\n> certify. A natural reading may be that if you cannot certify, you\n> do not add the trailer, but it shouldn't hurt to be overly explicit.\n\nThis is a good change.\n\nThanks,\n-Stolee\n"},{"id":"413089","messageId":"xmqq35zpg2li.fsf@gitster.c.googlers.com","threadId":"54888","inReplyTo":"5fe9e731de0e5_209d20845@natae.notmuch","subject":"Re: [PATCH] SubmittingPatches: tighten wording on \"sign-off\" procedure","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-28T19:19:53Z","receivedAt":"2020-12-28T19:20:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n>> -If you can certify the below D-C-O:\n>> +If (and only if) you can certify the below D-C-O:\n>\n> If you certify the bellow D-C-O:\n\nYes, dropping \"can\" would be a good clarification, I would think, too.\n\n>\n>> [[dco]]\n>> .Developer's Certificate of Origin 1.1\n>> ____\n"},{"id":"413772","messageId":"xmqqim88jp26.fsf@gitster.c.googlers.com","threadId":"54888","inReplyTo":"xmqqh7o6jjt1.fsf@gitster.c.googlers.com","subject":"[PATCH v2] SubmittingPatches: tighten wording on \"sign-off\" procedure","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-01-07T23:38:09Z","receivedAt":"2021-01-07T23:38:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The text says \"if you can certify DCO then you add a Signed-off-by\ntrailer\". But it does not say anything about people who cannot or\ndo not want to certify. A natural reading may be that if you do not\ncertify, you must not add the trailer, but it shouldn't hurt to be\noverly explicit.\n\nSigned-off-by: Junio C Hamano \n---\n Documentation/SubmittingPatches | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex d12094bac5..0452db2e67 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -307,7 +307,7 @@ wrote the patch or have the right to pass it on under the same license\n as ours, by \"signing off\" your patch. Without sign-off, we cannot\n accept your patches.\n \n-If you can certify the below D-C-O:\n+If (and only if) you certify the below D-C-O:\n \n [[dco]]\n .Developer's Certificate of Origin 1.1\n-- \n2.30.0-274-g31e3a2ed96\n\n"}]}