{"thread":{"id":"54868","subject":"[PATCH] git.txt: fix typos in 'linkgit' macro invocation","startedAt":"2020-12-22T15:33:21Z","lastAt":"2020-12-22T20:06:37Z","messageCount":3,"participants":["Philippe Blain via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"412849","messageId":"pull.934.git.git.1608651140403.gitgitgadget@gmail.com","threadId":"54868","inReplyTo":null,"subject":"[PATCH] git.txt: fix typos in 'linkgit' macro invocation","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-12-22T15:32:20Z","receivedAt":"2020-12-22T15:33:21Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain <levraiphilippeblain@gmail.com>\n\nThe 'linkgit' Asciidoc macro is misspelled as 'linkit' in the\ndescription of 'GIT_SEQUENCE_EDITOR' since the addition of that variable\nto git(1) in 902a126eca (doc: mention GIT_SEQUENCE_EDITOR and\n'sequence.editor' more, 2020-08-31).\n\nFix that.\n\nSigned-off-by: Philippe Blain <levraiphilippeblain@gmail.com>\n---\n    git.txt: fix typos in 'linkgit' macro invocation\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-934%2Fphil-blain%2Ffix-linkgit-git1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-934/phil-blain/fix-linkgit-git1-v1\nPull-Request: https://github.com/git/git/pull/934\n\n Documentation/git.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git.txt b/Documentation/git.txt\nindex c463b937a86..aaa3668a7e9 100644\n--- a/Documentation/git.txt\n+++ b/Documentation/git.txt\n@@ -609,8 +609,8 @@ other\n `GIT_SEQUENCE_EDITOR`::\n \tThis environment variable overrides the configured Git editor\n \twhen editing the todo list of an interactive rebase. See also\n-\tlinkit::git-rebase[1] and the `sequence.editor` option in\n-\tlinkit::git-config[1].\n+\tlinkgit::git-rebase[1] and the `sequence.editor` option in\n+\tlinkgit::git-config[1].\n \n `GIT_SSH`::\n `GIT_SSH_COMMAND`::\n\nbase-commit: 6d3ef5b467eccd2769f1aa1c555d317d3c8dc707\n-- \ngitgitgadget\n"},{"id":"412850","messageId":"pull.934.v2.git.git.1608651882510.gitgitgadget@gmail.com","threadId":"54868","inReplyTo":"pull.934.git.git.1608651140403.gitgitgadget@gmail.com","subject":"[PATCH v2] git.txt: fix typos in 'linkgit' macro invocation","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-12-22T15:44:42Z","receivedAt":"2020-12-22T15:45:41Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain <levraiphilippeblain@gmail.com>\n\nThe 'linkgit' Asciidoc macro is misspelled as 'linkit' in the\ndescription of 'GIT_SEQUENCE_EDITOR' since the addition of that variable\nto git(1) in 902a126eca (doc: mention GIT_SEQUENCE_EDITOR and\n'sequence.editor' more, 2020-08-31). Also, it uses two colons instead of\none.\n\nFix that.\n\nSigned-off-by: Philippe Blain <levraiphilippeblain@gmail.com>\n---\n    git.txt: fix typos in 'linkgit' macro invocation\n    \n    Changes since v1:\n    \n     * also fixed the fact that I had used two colons instead of one.\n    \n    Sorry for not checking the doc build before sending v1.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-934%2Fphil-blain%2Ffix-linkgit-git1-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-934/phil-blain/fix-linkgit-git1-v2\nPull-Request: https://github.com/git/git/pull/934\n\nRange-diff vs v1:\n\n 1:  978e328fb94 ! 1:  494173a5865 git.txt: fix typos in 'linkgit' macro invocation\n     @@ Commit message\n          The 'linkgit' Asciidoc macro is misspelled as 'linkit' in the\n          description of 'GIT_SEQUENCE_EDITOR' since the addition of that variable\n          to git(1) in 902a126eca (doc: mention GIT_SEQUENCE_EDITOR and\n     -    'sequence.editor' more, 2020-08-31).\n     +    'sequence.editor' more, 2020-08-31). Also, it uses two colons instead of\n     +    one.\n      \n          Fix that.\n      \n     @@ Documentation/git.txt: other\n       \twhen editing the todo list of an interactive rebase. See also\n      -\tlinkit::git-rebase[1] and the `sequence.editor` option in\n      -\tlinkit::git-config[1].\n     -+\tlinkgit::git-rebase[1] and the `sequence.editor` option in\n     -+\tlinkgit::git-config[1].\n     ++\tlinkgit:git-rebase[1] and the `sequence.editor` option in\n     ++\tlinkgit:git-config[1].\n       \n       `GIT_SSH`::\n       `GIT_SSH_COMMAND`::\n\n\n Documentation/git.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git.txt b/Documentation/git.txt\nindex c463b937a86..a6d4ad0818b 100644\n--- a/Documentation/git.txt\n+++ b/Documentation/git.txt\n@@ -609,8 +609,8 @@ other\n `GIT_SEQUENCE_EDITOR`::\n \tThis environment variable overrides the configured Git editor\n \twhen editing the todo list of an interactive rebase. See also\n-\tlinkit::git-rebase[1] and the `sequence.editor` option in\n-\tlinkit::git-config[1].\n+\tlinkgit:git-rebase[1] and the `sequence.editor` option in\n+\tlinkgit:git-config[1].\n \n `GIT_SSH`::\n `GIT_SSH_COMMAND`::\n\nbase-commit: 6d3ef5b467eccd2769f1aa1c555d317d3c8dc707\n-- \ngitgitgadget\n"},{"id":"412855","messageId":"xmqqsg7xhaht.fsf@gitster.c.googlers.com","threadId":"54868","inReplyTo":"pull.934.v2.git.git.1608651882510.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] git.txt: fix typos in 'linkgit' macro invocation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-22T20:05:50Z","receivedAt":"2020-12-22T20:06:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Philippe Blain via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Philippe Blain <levraiphilippeblain@gmail.com>\n>\n> The 'linkgit' Asciidoc macro is misspelled as 'linkit' in the\n> description of 'GIT_SEQUENCE_EDITOR' since the addition of that variable\n> to git(1) in 902a126eca (doc: mention GIT_SEQUENCE_EDITOR and\n> 'sequence.editor' more, 2020-08-31). Also, it uses two colons instead of\n> one.\n>\n> Fix that.\n>\n> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>\n> ---\n\nIt seems that 2.29 shipped with these typos without anybody\nnoticing.\n\nHow did you find them, by the way?  Anything we can do to prevent\nsimilar mistakes with automation?\n\nWill queue.  Thanks.\n\n> diff --git a/Documentation/git.txt b/Documentation/git.txt\n> index c463b937a86..a6d4ad0818b 100644\n> --- a/Documentation/git.txt\n> +++ b/Documentation/git.txt\n> @@ -609,8 +609,8 @@ other\n>  `GIT_SEQUENCE_EDITOR`::\n>  \tThis environment variable overrides the configured Git editor\n>  \twhen editing the todo list of an interactive rebase. See also\n> -\tlinkit::git-rebase[1] and the `sequence.editor` option in\n> -\tlinkit::git-config[1].\n> +\tlinkgit:git-rebase[1] and the `sequence.editor` option in\n> +\tlinkgit:git-config[1].\n>  \n>  `GIT_SSH`::\n>  `GIT_SSH_COMMAND`::\n>\n> base-commit: 6d3ef5b467eccd2769f1aa1c555d317d3c8dc707\n"}]}