{"thread":{"id":"54740","subject":"bug report/feature request: git describe: what is 'clean'","startedAt":"2020-12-01T10:47:31Z","lastAt":"2020-12-01T20:04:45Z","messageCount":2,"participants":["Ernst Reissner","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"411054","messageId":"ed404c7e-d098-348d-d8fe-dae8aa5a5fda@arcor.de","threadId":"54740","inReplyTo":null,"subject":"bug report/feature request: git describe: what is 'clean'","fromName":"Ernst Reissner","fromEmail":"rei3ner@arcor.de","sentAt":"2020-12-01T10:46:35Z","receivedAt":"2020-12-01T10:47:31Z","isPatch":false,"sender":{"key":"rei3ner@arcor.de","avatar":null},"body":"Hello All,\n\nfind below a bug report/feature request.\n\nRegards,\n\nErnst\n\n\nThank you for filling out a Git bug report!\nPlease answer the following questions to help us understand your issue.\n\nWhat did you do before the bug happened? (Steps to reproduce your issue)\ni have a workspace with untracked files, else clean.\nthen i did `git describe`.\nWhat did you expect to happen? (Expected behavior)\nI expected to see a label 'dirty'\nWhat happened instead? (Actual behavior)\nno label `dirty`\nWhat's different between what you expected and what actually happened?\nobvious\nAnything else you want to add:\nI know that this is not precisely a bug,\nInstead it is a feature request.\nPractically, `git describe` is used to determine a version.\nFor me the sense of 'dirty' is to indicate that this deliverable is not \nreproducible from the repo.\nThus it may not be delivered to a customer.\nSo in this sense, untracked files make a workspace dirty also.\n\nWithout the need of backward compatibility, i would say, dirty is all,\nwhich is tracked and modified staged or not,\nor which is untracked but not ignored.\n\nTo keep backward compatibility,\nmaybe it is a good idea to add a second suffix, maybe 'untracked' to \ndisplay in addition.\nThat way it is clear: only if no suffix is present, software from repo \ncan be delivered\nand one is sure that this is reproducible.\n\nPlease review the rest of the bug report below.\nYou can delete any lines you don't wish to share.\n\n\n[System Info]\ngit version:\ngit version 2.29.2\ncpu: x86_64\nno commit associated with this build\nsizeof-long: 8\nsizeof-size_t: 8\nshell-path: /bin/sh\nuname: Linux 5.9.1-2-default #1 SMP Mon Oct 26 07:02:23 UTC 2020 \n(435e92d) x86_64\ncompiler info: gnuc: 10.2\nlibc info: glibc: 2.32\n$SHELL (typically, interactive shell): /bin/bash\n\n\n\n"},{"id":"411092","messageId":"xmqqh7p5pa3m.fsf@gitster.c.googlers.com","threadId":"54740","inReplyTo":"ed404c7e-d098-348d-d8fe-dae8aa5a5fda@arcor.de","subject":"Re: bug report/feature request: git describe: what is 'clean'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-01T20:03:41Z","receivedAt":"2020-12-01T20:04:45Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ernst Reissner <rei3ner@arcor.de> writes:\n\n> To keep backward compatibility,\n> maybe it is a good idea to add a second suffix, maybe 'untracked' to\n> display in addition.\n\nIt won't work for folks who have used output from \"describe --dirty\"\nas the base of their version number, as their procedure do not know\nthey need to strip \"-untracked\" at the end.  \n\nA new option, \"describe --dirty --untracked\", is possible, though.\n"}]}