{"thread":{"id":"5474","subject":"[PATCH 2/4] gitweb: Change the name of diff to parent link in \"commit\" view to \"diff\"","startedAt":"2006-09-04T16:10:09Z","lastAt":"2006-09-05T08:59:04Z","messageCount":14,"participants":["Jakub Narebski","Linus Torvalds","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"26306","messageId":"200609041810.09838.jnareb@gmail.com","threadId":"5474","inReplyTo":null,"subject":"[PATCH 0/4] gitweb: Some improvements","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T16:10:09Z","receivedAt":"2006-09-04T16:10:09Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"This is small series of patches, applicable both to 'master' and 'next',\nwhich adds simple improvements, or in the case of last patch\nfix bug/typo.\n\nFirst two patches were sent earlier, I don't know if they were dropped\nor forgotten. \n\n---\nDiffstat:\n Makefile               |    2 ++\n gitweb/git-favicon.png |  Bin\n gitweb/gitweb.perl     |   44 +++++++++++++++++++++++++++++++-------------\n 3 files changed, 33 insertions(+), 13 deletions(-)\n\nShortlog:\n gitweb: Add GIT favicon, assuming image/png type.\n gitweb: Change the name of diff to parent link in \"commit\" view to \"diff\"\n gitweb: Divide page path into directories -- path's \"breadcrumbs\"\n gitweb: Correct typo: '==' instead of 'eq' in git_difftree_body\n\n-- \nJakub Narebski\nShadeHawk on #git\nPoland\n"},{"id":"26309","messageId":"200609041813.49103.jnareb@gmail.com","threadId":"5474","inReplyTo":"200609041810.09838.jnareb@gmail.com","subject":"PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T16:13:48Z","receivedAt":"2006-09-04T16:13:48Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThis is my first post with binary patch. I'd rather not send file\ngit-favicon.png as an attachement due to filtering.\n\nYou can see (and download) the favicon istelf at\n  http://git.or.cz/gitwiki/GitRelatedLogos\n(the first favicon).\n\n Makefile               |    2 ++\n gitweb/git-favicon.png |  Bin\n gitweb/gitweb.perl     |    5 +++++\n 3 files changed, 7 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 199fbe8..f3b762d 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -137,6 +137,7 @@ GITWEB_LIST =\n GITWEB_HOMETEXT = indextext.html\n GITWEB_CSS = gitweb.css\n GITWEB_LOGO = git-logo.png\n+GITWEB_FAVICON = git-favicon.png\n \n export prefix bindir gitexecdir template_dir GIT_PYTHON_DIR\n \n@@ -674,6 +675,7 @@ gitweb/gitweb.cgi: gitweb/gitweb.perl\n \t    -e 's|++GITWEB_HOMETEXT++|$(GITWEB_HOMETEXT)|g' \\\n \t    -e 's|++GITWEB_CSS++|$(GITWEB_CSS)|g' \\\n \t    -e 's|++GITWEB_LOGO++|$(GITWEB_LOGO)|g' \\\n+\t    -e 's|++GITWEB_FAVICON++|$(GITWEB_FAVICON)|g' \\\n \t    $< >$@+\n \tchmod +x $@+\n \tmv $@+ $@\ndiff --git a/gitweb/git-favicon.png b/gitweb/git-favicon.png\nnew file mode 100644\nindex 0000000..de637c0\nBinary files /dev/null and b/gitweb/git-favicon.png differ\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 7961945..bebaa0f 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -48,6 +48,8 @@ # URI of default stylesheet\n our $stylesheet = \"++GITWEB_CSS++\";\n # URI of GIT logo\n our $logo = \"++GITWEB_LOGO++\";\n+# URI of GIT favicon, assumed to be image/png type\n+our $favicon = \"++GITWEB_FAVICON++\";\n \n # source of projects list\n our $projects_list = \"++GITWEB_LIST++\";\n@@ -1192,6 +1194,9 @@ EOF\n \t\t       'href=\"%s\" type=\"application/rss+xml\"/>'.\"\\n\",\n \t\t       esc_param($project), href(action=>\"rss\"));\n \t}\n+\tif (defined $favicon) {\n+\t\tprint qq(<link rel=\"shortcut icon\" href=\"$favicon\" type=\"image/png\"/>\\n);\n+\t}\n \n \tprint \"</head>\\n\" .\n \t      \"<body>\\n\" .\n-- \n1.4.1.1\n"},{"id":"26305","messageId":"200609041815.29203.jnareb@gmail.com","threadId":"5474","inReplyTo":"200609041810.09838.jnareb@gmail.com","subject":"[PATCH 2/4] gitweb: Change the name of diff to parent link in \"commit\" view to \"diff\"","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T16:15:28Z","receivedAt":"2006-09-04T16:15:28Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Change the name of diff to parent (current commit to one of parents)\nlink in \"commit\" view (git_commit subroutine) from \"commitdiff\" to\n\"diff\".  Let's leave \"commitdiff\" for equivalent of git-show, or\ngit-diff-tree with one revision, i.e. diff for a given commit to its\nparent (parents).\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThe commit message is barely smaller than the diff itself, but it\nis expected as commit message tell the why behind the change.\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex bebaa0f..3b5c0e2 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2758,7 +2758,7 @@ sub git_commit {\n \t\t      \"<td class=\\\"link\\\">\" .\n \t\t      $cgi->a({-href => href(action=>\"commit\", hash=>$par)}, \"commit\") .\n \t\t      \" | \" .\n-\t\t      $cgi->a({-href => href(action=>\"commitdiff\", hash=>$hash, hash_parent=>$par)}, \"commitdiff\") .\n+\t\t      $cgi->a({-href => href(action=>\"commitdiff\", hash=>$hash, hash_parent=>$par)}, \"diff\") .\n \t\t      \"</td>\" .\n \t\t      \"</tr>\\n\";\n \t}\n-- \n1.4.1.1\n"},{"id":"26308","messageId":"200609041817.59054.jnareb@gmail.com","threadId":"5474","inReplyTo":"200609041810.09838.jnareb@gmail.com","subject":"[PATCH 3/4] gitweb: Divide page path into directories -- path's \"breadcrumbs\"","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T16:17:58Z","receivedAt":"2006-09-04T16:17:58Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Divide page path into directories, so that each part of path links to\nthe \"tree\" view of the $hash_base (or HEAD, if $hash_base is not set)\nversion of the directory.\n\nIf the entity is blob, final part (basename) links to $hash_base or\nHEAD revision of the \"raw\" blob (\"blob_plain\" view).  If the entity is\ntree, link to the \"tree\" view.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.perl |   29 +++++++++++++++++++++--------\n 1 files changed, 21 insertions(+), 8 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 3b5c0e2..4240a30 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1375,19 +1375,32 @@ sub git_print_page_path {\n \n \tif (!defined $name) {\n \t\tprint \"<div class=\\\"page_path\\\">/</div>\\n\";\n-\t} elsif (defined $type && $type eq 'blob') {\n+\t} else {\n+\t\tmy @dirname = split '/', $name;\n+\t\tmy $basename = pop @dirname;\n+\t\tmy $fullname = '';\n+\n \t\tprint \"<div class=\\\"page_path\\\">\";\n-\t\tif (defined $hb) {\n+\t\tforeach my $dir (@dirname) {\n+\t\t\t$fullname .= $dir . '/';\n+\t\t\tprint $cgi->a({-href => href(action=>\"tree\", file_name=>$fullname,\n+\t\t\t                             hash_base=>$hb),\n+\t\t\t              -title => $fullname}, esc_html($dir));\n+\t\t\tprint \"/\";\n+\t\t}\n+\t\tif (defined $type && $type eq 'blob') {\n \t\t\tprint $cgi->a({-href => href(action=>\"blob_plain\", file_name=>$file_name,\n-\t\t\t                             hash_base=>$hb)},\n-\t\t\t              esc_html($name));\n+\t\t\t                             hash_base=>$hb),\n+\t\t\t              -title => $name}, esc_html($basename));\n+\t\t} elsif (defined $type && $type eq 'tree') {\n+\t\t\tprint $cgi->a({-href => href(action=>\"tree\", file_name=>$file_name,\n+\t\t\t                             hash_base=>$hb),\n+\t\t\t              -title => $name}, esc_html($basename));\n+\t\t\tprint \"/\";\n \t\t} else {\n-\t\t\tprint $cgi->a({-href => href(action=>\"blob_plain\", file_name=>$file_name)},\n-\t\t\t              esc_html($name));\n+\t\t\tprint esc_html($basename);\n \t\t}\n \t\tprint \"<br/></div>\\n\";\n-\t} else {\n-\t\tprint \"<div class=\\\"page_path\\\">\" . esc_html($name) . \"<br/></div>\\n\";\n \t}\n }\n \n-- \n1.4.1.1\n"},{"id":"26307","messageId":"200609041819.58737.jnareb@gmail.com","threadId":"5474","inReplyTo":"200609041810.09838.jnareb@gmail.com","subject":"[PATCH 4/4] gitweb: Correct typo: '==' instead of 'eq' in git_difftree_body","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T16:19:58Z","receivedAt":"2006-09-04T16:19:58Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThis caused that the \"commitdiff\" version, with \"patch\" link to anchor\ninstead of \"diff\" link to \"blobdiff\" view was used even in \"commit\" view.\n\n gitweb/gitweb.perl |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 4240a30..e7d7bd7 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1519,7 +1519,7 @@ sub git_difftree_body {\n \t\t\t      $cgi->a({-href => href(action=>\"blob\", hash=>$diff{'to_id'},\n \t\t\t                             hash_base=>$hash, file_name=>$diff{'file'})},\n \t\t\t              \"blob\");\n-\t\t\tif ($action == \"commitdiff\") {\n+\t\t\tif ($action eq 'commitdiff') {\n \t\t\t\t# link to patch\n \t\t\t\t$patchno++;\n \t\t\t\tprint \" | \" .\n@@ -1540,7 +1540,7 @@ sub git_difftree_body {\n \t\t\t                             hash_base=>$parent, file_name=>$diff{'file'})},\n \t\t\t              \"blob\") .\n \t\t\t      \" | \";\n-\t\t\tif ($action == \"commitdiff\") {\n+\t\t\tif ($action eq 'commitdiff') {\n \t\t\t\t# link to patch\n \t\t\t\t$patchno++;\n \t\t\t\tprint \" | \" .\n@@ -1586,7 +1586,7 @@ sub git_difftree_body {\n \t\t\t                             hash_base=>$hash, file_name=>$diff{'file'})},\n \t\t\t              \"blob\");\n \t\t\tif ($diff{'to_id'} ne $diff{'from_id'}) { # modified\n-\t\t\t\tif ($action == \"commitdiff\") {\n+\t\t\t\tif ($action eq 'commitdiff') {\n \t\t\t\t\t# link to patch\n \t\t\t\t\t$patchno++;\n \t\t\t\t\tprint \" | \" .\n@@ -1628,7 +1628,7 @@ sub git_difftree_body {\n \t\t\t                             hash=>$diff{'to_id'}, file_name=>$diff{'to_file'})},\n \t\t\t              \"blob\");\n \t\t\tif ($diff{'to_id'} ne $diff{'from_id'}) {\n-\t\t\t\tif ($action == \"commitdiff\") {\n+\t\t\t\tif ($action eq 'commitdiff') {\n \t\t\t\t\t# link to patch\n \t\t\t\t\t$patchno++;\n \t\t\t\t\tprint \" | \" .\n-- \n1.4.1.1\n"},{"id":"26311","messageId":"Pine.LNX.4.64.0609041010540.27779@g5.osdl.org","threadId":"5474","inReplyTo":"200609041813.49103.jnareb@gmail.com","subject":"Re: PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2006-09-04T17:15:09Z","receivedAt":"2006-09-04T17:15:09Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Mon, 4 Sep 2006, Jakub Narebski wrote:\n>\n> This is my first post with binary patch. I'd rather not send file\n> git-favicon.png as an attachement due to filtering.\n\nYou forgot the \"--binary\" flag, so it didn't actually create a binary \npatch, it just did the \"Binary files .. differ\" thing:\n\n> diff --git a/gitweb/git-favicon.png b/gitweb/git-favicon.png\n> new file mode 100644\n> index 0000000..de637c0\n> Binary files /dev/null and b/gitweb/git-favicon.png differ\n\nSee diff.c: builtin_diff() for the logic:\n\n\t...\n                if (o->binary)\n                        emit_binary_diff(&mf1, &mf2);\n                else\n                        printf(\"Binary files %s and %s differ\\n\",\n                               lbl[0], lbl[1]);\n\t...\n\nie the default is to act like a regular \"diff\", and we do the extended git \nbinary diffs only if you ask for them explicitly.\n\n(Of course, since we do the _other_ extended git diff headers regardless, \nmaybe that doesn't make much sense. On the other hand, the normal extended \ngit diff headers are compatible with normal patches, so there is a real \ndifference, and so arguably the \"--binary\" flag makes tons of sense).\n\n\t\tLinus\n"},{"id":"26312","messageId":"200609042032.13742.jnareb@gmail.com","threadId":"5474","inReplyTo":"200609041813.49103.jnareb@gmail.com","subject":"[PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T18:32:13Z","receivedAt":"2006-09-04T18:32:13Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nCorrected version, with the actual binary diff\n(that was the version sent earlier, by the way).\n\n Makefile               |    2 ++\n gitweb/git-favicon.png |  Bin\n gitweb/gitweb.perl     |    5 +++++\n 3 files changed, 7 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -137,6 +137,7 @@ GITWEB_LIST =\n GITWEB_HOMETEXT = indextext.html\n GITWEB_CSS = gitweb.css\n GITWEB_LOGO = git-logo.png\n+GITWEB_FAVICON = git-favicon.png\n \n export prefix bindir gitexecdir template_dir GIT_PYTHON_DIR\n \n@@ -674,6 +675,7 @@ gitweb/gitweb.cgi: gitweb/gitweb.perl\n \t    -e 's|++GITWEB_HOMETEXT++|$(GITWEB_HOMETEXT)|g' \\\n \t    -e 's|++GITWEB_CSS++|$(GITWEB_CSS)|g' \\\n \t    -e 's|++GITWEB_LOGO++|$(GITWEB_LOGO)|g' \\\n+\t    -e 's|++GITWEB_FAVICON++|$(GITWEB_FAVICON)|g' \\\n \t    $< >$@+\n \tchmod +x $@+\n \tmv $@+ $@\ndiff --git a/gitweb/git-favicon.png b/gitweb/git-favicon.png\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..de637c0608090162a6ce6b51d5f9bfe512cf8bcf\nGIT binary patch\nliteral 164\nzc-rd>@N?(olHy`uVBq!ia0vp^0wB!93?!50ihlx9JOMr-t_OgO28RD&a4c8tKak5=\nz;1OBOz`!jG!i)^F=12eq?L1u^Ln;_q4{j86a1dcV@b%g0mmUiOK9(+Io+#BK-XURJ\nz*52lzAh4o%_q+oa1XgVS7Wa3@eurhH>!fs<8s*Qab3eLq`JX({BnD4cKbLh*2~7aN\nC3N}^%\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 7961945630e44e94649f3ccd9f96a962c94af0d9..bebaa0fb1e93995da8ea19af8b70a453b9572488 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -48,6 +48,8 @@ # URI of default stylesheet\n our $stylesheet = \"++GITWEB_CSS++\";\n # URI of GIT logo\n our $logo = \"++GITWEB_LOGO++\";\n+# URI of GIT favicon, assumed to be image/png type\n+our $favicon = \"++GITWEB_FAVICON++\";\n \n # source of projects list\n our $projects_list = \"++GITWEB_LIST++\";\n@@ -1192,6 +1194,9 @@ EOF\n \t\t       'href=\"%s\" type=\"application/rss+xml\"/>'.\"\\n\",\n \t\t       esc_param($project), href(action=>\"rss\"));\n \t}\n+\tif (defined $favicon) {\n+\t\tprint qq(<link rel=\"shortcut icon\" href=\"$favicon\" type=\"image/png\"/>\\n);\n+\t}\n \n \tprint \"</head>\\n\" .\n \t      \"<body>\\n\" .\n-- \n1.4.1.1\n"},{"id":"26314","messageId":"edhrij$l9j$1@sea.gmane.org","threadId":"5474","inReplyTo":"200609042032.13742.jnareb@gmail.com","subject":"Re: [PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T18:34:06Z","receivedAt":"2006-09-04T18:34:06Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jakub Narebski wrote:\n\n> index 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644\n\nHmmm... I do wonder why --binary implies --full-index option.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"26325","messageId":"7virk3l07a.fsf@assigned-by-dhcp.cox.net","threadId":"5474","inReplyTo":"edhrij$l9j$1@sea.gmane.org","subject":"Re: [PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-04T22:46:17Z","receivedAt":"2006-09-04T22:46:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> Jakub Narebski wrote:\n>\n>> index 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644\n>\n> Hmmm... I do wonder why --binary implies --full-index option.\n\nPatch safety.  Yours happened to be a creation patch so it might\nnot matter in this particular case, but we would want to be\nreasonably sure there is no ambiguity in the preimage when you\nare doing a modification patch.\n"},{"id":"26332","messageId":"edib58$61k$1@sea.gmane.org","threadId":"5474","inReplyTo":"7virk3l07a.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T23:00:04Z","receivedAt":"2006-09-04T23:00:04Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Jakub Narebski <jnareb@gmail.com> writes:\n> \n>> Jakub Narebski wrote:\n>>\n>>> index 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644\n>>\n>> Hmmm... I do wonder why --binary implies --full-index option.\n> \n> Patch safety.  Yours happened to be a creation patch so it might\n> not matter in this particular case, but we would want to be\n> reasonably sure there is no ambiguity in the preimage when you\n> are doing a modification patch.\n \nCouldn't we do this (show full sha1) only for the binary part of patch?\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"26334","messageId":"7vejurkyro.fsf@assigned-by-dhcp.cox.net","threadId":"5474","inReplyTo":"edib58$61k$1@sea.gmane.org","subject":"Re: [PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-04T23:17:15Z","receivedAt":"2006-09-04T23:17:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> Junio C Hamano wrote:\n>\n>> Jakub Narebski <jnareb@gmail.com> writes:\n>> \n>>> Jakub Narebski wrote:\n>>>\n>>>> index 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644\n>>>\n>>> Hmmm... I do wonder why --binary implies --full-index option.\n>> \n>> Patch safety.  Yours happened to be a creation patch so it might\n>> not matter in this particular case, but we would want to be\n>> reasonably sure there is no ambiguity in the preimage when you\n>> are doing a modification patch.\n>  \n> Couldn't we do this (show full sha1) only for the binary part of patch?\n\nPersonally I would say why bother, but patches welcome if\ncleanly done.\n"},{"id":"26335","messageId":"7v8xkzkyie.fsf@assigned-by-dhcp.cox.net","threadId":"5474","inReplyTo":"200609041810.09838.jnareb@gmail.com","subject":"Re: [PATCH 0/4] gitweb: Some improvements","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-04T23:22:49Z","receivedAt":"2006-09-04T23:22:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> This is small series of patches, applicable both to 'master' and 'next',\n> which adds simple improvements, or in the case of last patch\n> fix bug/typo.\n>\n> First two patches were sent earlier, I don't know if they were dropped\n> or forgotten. \n\nI think you were just expecting too quick turnaround ;-).\n\nIf I recall correctly it used to be that we could not use png\nfor favicon but it seems that things have improved.\n\nIt is a while since I tried gitweb on my machine the last time\nbut was it always this slow I wonder...  We probably would need\na good benchmark and automated test before going too much\nfurther.\n"},{"id":"26341","messageId":"ediea9$d3d$2@sea.gmane.org","threadId":"5474","inReplyTo":"7v8xkzkyie.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 0/4] gitweb: Some improvements","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-04T23:53:57Z","receivedAt":"2006-09-04T23:53:57Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Jakub Narebski <jnareb@gmail.com> writes:\n> \n>> This is small series of patches, applicable both to 'master' and 'next',\n>> which adds simple improvements, or in the case of last patch\n>> fix bug/typo.\n>>\n>> First two patches were sent earlier, I don't know if they were dropped\n>> or forgotten. \n> \n> I think you were just expecting too quick turnaround ;-).\n> \n> If I recall correctly it used to be that we could not use png\n> for favicon but it seems that things have improved.\n> \n> It is a while since I tried gitweb on my machine the last time\n> but was it always this slow I wonder...  We probably would need\n> a good benchmark and automated test before going too much\n> further.\n\nThe problem is that before commit 5d043a3d856bd40d8b34b8836a561e438d23573b\n  gitweb: fill in gitweb configuration by Makefile\nby Martin Waitz one had to modify gitweb script to change the configuration\nfrom default.\n\nBut benchmarking is good. Simple time to run script from command line, with\nenvironment variables GATEWAY_INTERFACE=\"CGI/1.1\", HTTP_ACCEPT=\"*/*\",\nREQUEST_METHOD=\"GET\" and of course QUERY_STRING set, and perhaps using\nApacheBench.\n\n\n>From my experience with gitweb, the longest it take to show summary and tags\nviews (for a large number of tags, which grows linearly with history), and\nto show history (and of course blame).\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"26353","messageId":"edje8a$sdo$1@sea.gmane.org","threadId":"5474","inReplyTo":"ediea9$d3d$2@sea.gmane.org","subject":"Re: gitweb testing and benchmarking (was: [PATCH 0/4] gitweb: Some improvements)","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-05T08:59:04Z","receivedAt":"2006-09-05T08:59:04Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jakub Narebski wrote:\n\n> Junio C Hamano wrote:\n>\n>> It is a while since I tried gitweb on my machine the last time\n>> but was it always this slow I wonder...  We probably would need\n>> a good benchmark and automated test before going too much\n>> further.\n> \n> The problem is that before commit 5d043a3d856bd40d8b34b8836a561e438d23573b\n>   gitweb: fill in gitweb configuration by Makefile\n> by Martin Waitz one had to modify gitweb script to change\n> the configuration from default.\n> \n> But benchmarking is good. Simple time to run script from command line,\n> with environment variables GATEWAY_INTERFACE=\"CGI/1.1\", HTTP_ACCEPT=\"*/*\",\n> REQUEST_METHOD=\"GET\" and of course QUERY_STRING set, and perhaps using\n> ApacheBench.\n\nI think that for testing gitweb we will be better with creating some twisted\ntest repository (c.f. t/t4114-apply-typechange.sh), but for benchmarking it\nwould be better to use some larger repository, for example git repository\ncut-off from above at some version (including tags!). Is there a way to do\nthat?\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}