{"thread":{"id":"54737","subject":"What's cooking in git.git (Nov 2020, #06; Mon, 30)","startedAt":"2020-12-01T05:16:29Z","lastAt":"2020-12-02T22:15:24Z","messageCount":13,"participants":["Junio C Hamano","Ævar Arnfjörð Bjarmason","Jeff King","Felipe Contreras","Derrick Stolee"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"411038","messageId":"xmqqtut6qf7q.fsf@gitster.c.googlers.com","threadId":"54737","inReplyTo":null,"subject":"What's cooking in git.git (Nov 2020, #06; Mon, 30)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-01T05:15:37Z","receivedAt":"2020-12-01T05:16:29Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking.  Commits prefixed with '-' are\nonly in 'seen' (formerly 'pu'---proposed updates) while commits prefixed\nwith '+' are in 'next'.  The ones marked with '.' do not appear in any of\nthe integration branches, but I am still holding onto them.\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into.  Some repositories have\nonly a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://github.com/git/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/gitster/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are published in these repositories for\nconvenience (replace \"htmldocs\" with \"manpages\" for the manual\npages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\nRelease tarballs are available at:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[Graduated to 'master']\n\n* ab/gc-keep-base-option (2020-11-21) 2 commits\n  (merged to 'next' on 2020-11-25 at ac76ddcfe7)\n + gc: rename keep_base_pack variable for --keep-largest-pack\n + gc docs: change --keep-base-pack to --keep-largest-pack\n\n Fix an option name in \"gc\" documentation.\n\n\n* hn/sleep-millisec-decl (2020-11-24) 1 commit\n  (merged to 'next' on 2020-11-25 at d11de8b987)\n + move sleep_millisec to git-compat-util.h\n\n Move a definition of compatibility wrapper from cache.h to\n git-compat-util.h\n\n\n* jc/do-not-just-explain-but-update-your-patch (2020-11-24) 1 commit\n  (merged to 'next' on 2020-11-25 at 1f5235d4e1)\n + MyFirstContribition: answering questions is not the end of the story\n\n Expectation for the original contributor after responding to a\n review comment to use the explanation in a patch update has been\n described.\n\n\n* js/pull-rebase-use-advise (2020-11-19) 1 commit\n  (merged to 'next' on 2020-11-25 at 05db775119)\n + pull: colorize the hint about setting `pull.rebase`\n\n UI improvement.\n\n\n* js/t1309-master-to-topic (2020-11-19) 1 commit\n  (merged to 'next' on 2020-11-25 at 044da285ef)\n + t1309: use a neutral branch name in the `onbranch` test cases\n\n Test preparation.\n\n\n* js/t2106-cleanup (2020-11-18) 3 commits\n  (merged to 'next' on 2020-11-23 at b1bcd5d8b2)\n + t2106: ensure that the checkout fails for the expected reason\n + t2106: make test independent of the current main branch name\n + t2106: adjust style to the current conventions\n\n A test script got cleaned up and then made not to depend on the\n value of init.defaultBranch.\n\n\n* js/t3040-cleanup (2020-11-18) 1 commit\n  (merged to 'next' on 2020-11-23 at 88951eae2f)\n + t3040: remove stale note\n\n Cleanup.\n\n\n* js/t3404-master-to-primary (2020-11-24) 1 commit\n  (merged to 'next' on 2020-11-25 at c2959cc831)\n + t3404: do not depend on any specific default branch name\n\n A test script got cleaned up and then made not to depend on the\n value of init.defaultBranch.\n\n\n* js/t4015-wo-master (2020-11-19) 1 commit\n  (merged to 'next' on 2020-11-23 at b85c36ffb4)\n + t4015: let the test pass with any default branch name\n\n A test script got cleaned up not to depend on the value of\n init.defaultBranch.\n\n\n* km/stash-error-message-fix (2020-11-24) 1 commit\n  (merged to 'next' on 2020-11-25 at 9ef82d6aa7)\n + stash: add missing space to an error message\n\n Error message fix.\n\n\n* mt/worktree-error-message-fix (2020-11-21) 1 commit\n  (merged to 'next' on 2020-11-25 at bc887168ff)\n + worktree: fix order of arguments in error message\n\n Fix formulation of an error message with two placeholders in \"git\n worktree add\" subcommand.\n\n\n* na/notes-displayref-is-not-boolean (2020-11-23) 2 commits\n  (merged to 'next' on 2020-11-25 at b0dda46b56)\n + t3301: test proper exit response to no-value notes.displayRef.\n + notes.c: fix a segfault in notes_display_config()\n\n Config parser fix for \"git notes\".\n\n\n* sa/credential-store-timeout (2020-11-25) 1 commit\n  (merged to 'next' on 2020-11-25 at 7a9a4b68fd)\n + crendential-store: use timeout when locking file\n\n Multiple \"credential-store\" backends can race to lock the same\n file, causing everybody else but one to fail---reattempt locking\n with some timeout to reduce the rate of the failure.\n\n--------------------------------------------------\n[New Topics]\n\n* nk/perf-fsmonitor-cleanup (2020-11-30) 1 commit\n - perf/fsmonitor: use test_must_be_empty helper\n\n Test clean-up.\n\n Will merge to 'next'.\n\n\n* rs/fetch-pack-invalid-lockfile (2020-11-30) 1 commit\n - fetch-pack: disregard invalid pack lockfiles\n\n \"fetch-pack\" could pass NULL pointer to unlink(2) when it sees an\n invalid filename; the error checking has been tightened to make\n this impossible.\n\n Will merge to 'next'.\n\n\n* rs/maintenance-run-outside-repo (2020-11-30) 1 commit\n - maintenance: fix SEGFAULT when no repository\n\n \"git maintenance run/start/stop\" needed to be run in a repository\n to hold the lockfile they use, but didn't make sure they are\n actually in a repository, which has been corrected.\n\n Will merge to 'next'.\n\n--------------------------------------------------\n[Stalled]\n\n* mt/grep-sparse-checkout (2020-09-10) 9 commits\n - config: add setting to ignore sparsity patterns in some cmds\n - grep: honor sparse checkout patterns\n - config: correctly read worktree configs in submodules\n - config: make do_git_config_sequence receive a 'struct repository'\n - t/helper/test-config: unify exit labels\n - t/helper/test-config: diagnose missing arguments\n - t/helper/test-config: be consistent with exit codes\n - t1308-config-set: avoid false positives when using test-config\n - doc: grep: unify info on configuration variables\n (this branch is used by mt/rm-sparse-checkout.)\n\n \"git grep\" has been tweaked to be limited to the sparse checkout\n paths.\n\n\n* mt/rm-sparse-checkout (2020-11-16) 1 commit\n - rm: honor sparse checkout patterns\n (this branch uses mt/grep-sparse-checkout.)\n\n \"git rm\" follows suit to \"git grep\" to ignore paths outside the\n sparsity pattern when the sparse checkout feature is in use.\n\n Need to wait for how these fit in larger picture.\n cf. <CABPp-BGMX3wb7LiS1HkJpGveoW3J1oR0vVHbKTF5+qYLRF+59g@mail.gmail.com>\n\n\n* jk/symlinked-dotgitx-files (2020-10-23) 9 commits\n  (merged to 'next' on 2020-10-26 at c1dd37b024)\n + docs: document symlink restrictions for .git* files\n + fsck: complain when .gitattributes or .gitignore is a symlink\n + verify_path(): disallow symlinks in .gitattributes and .gitignore\n + t0060: test obscured .gitattributes and .gitignore matching\n + t7450: test .gitmodules symlink matching against obscured names\n + t7450: test verify_path() handling of gitmodules\n + t7415: rename to expand scope\n + fsck_tree(): wrap some long lines\n + fsck_tree(): fix shadowed variable\n\n Originally merged to 'next' on 2020-10-23\n\n \"git fsck\" and the corresponding check done during the transport\n learned to ensure that in-tree files like `.gitignore` and\n `.gitattributes` are not symbolic links.\n\n It seems that there are real projects with .gitignore recorded as\n symlinks, which may need to loosen the fsck setting.  Do we need to\n introduce a class that is separate from symlinked .gitmodules that\n probably is with potential consequences that is more/less grave?\n\n\n* es/config-hooks (2020-10-16) 8 commits\n - hook: replace find_hook() with hook_exists()\n - hook: add 'run' subcommand\n - parse-options: parse into strvec\n - hook: implement hookcmd.<name>.skip\n - hook: include hookdir hook in list\n - hook: add list command\n - hook: scaffolding for git-hook subcommand\n - doc: propose hooks managed by the config\n\n The \"hooks defined in config\" topic.\n\n\n* hn/reftable (2020-10-01) 13 commits\n . reftable: \"test-tool dump-reftable\" command.\n . reftable: rest of library\n . reftable: file level tests\n . reftable: read reftable files\n . reftable: write reftable files\n . reftable: a generic binary tree implementation\n . reftable: reading/writing blocks\n . reftable: (de)serialization for the polymorphic record type.\n . reftable: utility functions\n . reftable: add a barebones unittest framework\n . vcxproj: adjust for the reftable changes\n . reftable: define the public API\n . reftable: add LICENSE\n\n The reftable backend for the refs API.\n\n Expecting a reroll.\n Seems not to build for Windows folks.\n cf. <nycvar.QRO.7.76.6.2010021555290.50@tvgsbejvaqbjf.bet>\n cf. <nycvar.QRO.7.76.6.2010021557570.50@tvgsbejvaqbjf.bet>\n\n\n* sm/curl-retry (2020-10-13) 3 commits\n - http: automatically retry some requests\n - replace CURLOPT_FILE With CURLOPT_WRITEDATA\n - remote-curl: add testing for intelligent retry for HTTP\n\n The http transport has been taught to retry a failed request that\n may reasonably be retried.\n\n Expecting a reroll.\n cf. <20201015000410.GB328643@google.com>\n cf. <CAM4o00eefXK2CJ_FxwwVPpBKL01JsJANf+SdjCtw_0NVV82L+Q@mail.gmail.com>\n\n\n* sv/t7001-modernize (2020-09-25) 11 commits\n - t7001: move cleanup code from outside the tests into them\n - t7001: use `test` rather than `[`\n - t7001: use here-docs instead of echo\n - t7001: put each command on a separate line\n - t7001: use ': >' rather than 'touch'\n - t7001: change (cd <path> && git foo) to (git -C <path> foo)\n - t7001: remove whitespace after redirect operators\n - t7001: change the style for cd according to subshell\n - t7001: remove unnecessary blank lines\n - t7001: use TAB instead of spaces\n - t7001: convert tests from the old style to the current style\n\n Test script modernization.\n\n Expecting a reroll.\n cf. <20200925170256.11490-1-shubhunic@gmail.com>\n\n\n* ew/decline-core-abbrev (2020-09-01) 1 commit\n - core.abbrev <off|false|no> disables abbreviations\n\n Allow the configuration to specify no abbreviation regardless of\n the hash algorithm.\n\n Expecting a reroll.  The intent is very good.\n\n\n* bc/rev-parse-path-format (2020-10-09) 2 commits\n - rev-parse: add option for absolute or relative path formatting\n - abspath: add a function to resolve paths with missing components\n\n \"git rev-parse\" can be explicitly told to give output as absolute\n or relative path.\n\n\n* ar/fetch-transfer-ipversion (2020-09-16) 1 commit\n - config: option transfer.ipversion to set transport protocol version for network fetches\n\n Adds transfer.ipversion configuration variable.\n\n Needs more work.\n\n\n* vv/send-email-with-less-secure-apps-access (2020-08-29) 1 commit\n - Documentation/git-send-email.txt: Mention less secure app access might need to enable.\n\n Doc update.\n\n Expecting a reroll.\n cf. <xmqqwo1hi9nv.fsf@gitster.c.googlers.com>\n cf. <xmqqft85i72s.fsf@gitster.c.googlers.com>\n\n\n* jc/war-on-dashed-git (2020-08-27) 1 commit\n - git: catch an attempt to run \"git-foo\"\n\n The first step to remove on-disk binaries for built-in subcommands\n by soliciting objections.\n\n On hold for now.\n\n\n* dr/push-remoteref-fix (2020-04-23) 1 commit\n - remote.c: fix handling of %(push:remoteref)\n\n The \"%(push:remoteref)\" placeholder in the \"--format=\" argument of\n \"git format-patch\" (and friends) only showed what got explicitly\n configured, not what ref at the receiving end would be updated when\n \"git push\" was used, as it ignored the default behaviour (e.g. update\n the same ref as the source).\n\n Discard for now.\n cf. <xmqqv9gu7c61.fsf@gitster.c.googlers.com>\n cf. <20200911214358.acl3hy2e763begoo@feanor>\n\n\n* mk/use-size-t-in-zlib (2018-10-15) 1 commit\n - zlib.c: use size_t for size\n\n The wrapper to call into zlib followed our long tradition to use\n \"unsigned long\" for sizes of regions in memory, which have been\n updated to use \"size_t\".\n\n--------------------------------------------------\n[Needs Review]\n\n* ss/submodule-add-in-c (2020-10-07) 3 commits\n . t7400: add test to check 'submodule add' for tracked paths\n . submodule: port submodule subcommand 'add' from shell to C\n . dir: change the scope of function 'directory_exists_in_index()'\n\n \"git submodule add\" being rewritten in C.\n\n Needs review.\n\n\n* mt/parallel-checkout-part-1 (2020-11-04) 19 commits\n - ci: run test round with parallel-checkout enabled\n - parallel-checkout: add tests related to .gitattributes\n - parallel-checkout: add tests related to clone collisions\n - parallel-checkout: add tests for basic operations\n - checkout-index: add parallel checkout support\n - builtin/checkout.c: complete parallel checkout support\n - make_transient_cache_entry(): optionally alloc from mem_pool\n - parallel-checkout: support progress displaying\n - parallel-checkout: make it truly parallel\n - unpack-trees: add basic support for parallel checkout\n - entry: add checkout_entry_ca() which takes preloaded conv_attrs\n - entry: move conv_attrs lookup up to checkout_entry()\n - entry: extract cache_entry update from write_entry()\n - entry: make fstat_output() and read_blob_entry() public\n - entry: extract a header file for entry.c functions\n - convert: add conv_attrs classification\n - convert: add get_stream_filter_ca() variant\n - convert: add [async_]convert_to_working_tree_ca() variants\n - convert: make convert_attrs() and convert structs public\n\n Parallel checkout.\n\n Needs review.\n\n\n* fc/bash-completion-post-2.29 (2020-11-10) 26 commits\n - completion: bash: shuffle __gitcomp functions\n - completion: bash: cleanup __gitcomp* invocations\n - completion: bash: add __gitcomp_opts\n - completion: bash: improve __gitcomp description\n - completion: bash: rename _get_comp_words_by_ref()\n - completion: bash: trivial cleanup\n - completion: bash: cleanup _get_comp_words_by_ref()\n - completion: bash: refactor _get_comp_words_by_ref()\n - completion: bash: simplify _get_comp_words_by_ref()\n - test: completion: switch __gitcomp_nl prefix test\n - completion: bash: simplify config_variable_name\n - completion: bash: improve __gitcomp suffix code\n - completion: bash: change suffix check in __gitcomp\n - completion: bash: simplify __gitcomp\n - completion: bash: refactor __gitcomp\n - completion: bash: simplify equal suffix check\n - completion: bash: factor out check in __gitcomp\n - completion: bash: get rid of any non-append code\n - completion: bash: get rid of _append() functions\n - completion: bash: remove non-append functionality\n - test: completion: add run_func() helper\n - test: completion: fix currently typed words\n - completion: bash: do not modify COMP_WORDBREAKS\n - completion: bash: fix for suboptions with value\n - completion: bash: add correct suffix in variables\n - completion: bash: fix prefix detection in branch.*\n\n Needs review.\n\n\n* so/log-diff-merge (2020-11-09) 27 commits\n - doc/git-show: include --diff-merges description\n - doc/rev-list-options: document --first-parent implies --diff-merges=first-parent\n - doc/diff-generate-patch: mention new --diff-merges option\n - doc/git-log: describe new --diff-merges options\n - t4013: add test for --diff-merges=first-parent\n - diff-merges: implement new values for --diff-merges\n - diff-merges: make -m/-c/--cc explicitly mutually exclusive\n - diff-merges: refactor opt settings into separate functions\n - diff-merges: get rid of now empty diff_merges_init_revs()\n - diff-merges: group diff-merge flags next to each other inside 'rev_info'\n - diff-merges: split 'ignore_merges' field\n - diff-merges: fix -m to properly override -c/--cc\n - t4013: add tests for -m failing to override -c/--cc\n - t4013: support test_expect_failure through ':failure' magic\n - diff-merges: revise revs->diff flag handling\n - diff-merges: introduce revs->first_parent_merges flag\n - diff-merges: new function diff_merges_set_dense_combined_if_unset()\n - diff-merges: new function diff_merges_suppress()\n - diff-merges: re-arrange functions to match the order they are called in\n - diff-merges: rename diff_merges_default_to_enable() to match semantics\n - diff-merges: move checks for first_parent_only out of the module\n - diff-merges: rename all functions to have common prefix\n - revision: move diff merges functions to its own diff-merges.c\n - revision: provide implementation for diff merges tweaks\n - revision: factor out initialization of diff-merge related settings\n - revision: factor out setup of diff-merge related settings\n - revision: factor out parsing of diff-merge related options\n\n \"git log\" learned a new \"--diff-merges=<how>\" option.\n\n Needs review.\n\n\n* en/merge-ort-impl (2020-11-11) 21 commits\n - merge-ort: free data structures in merge_finalize()\n - merge-ort: add implementation of record_unmerged_index_entries()\n - tree: enable cmp_cache_name_compare() to be used elsewhere\n - merge-ort: add implementation of checkout()\n - merge-ort: basic outline for merge_switch_to_result()\n - merge-ort: step 3 of tree writing -- handling subdirectories as we go\n - merge-ort: step 2 of tree writing -- function to create tree object\n - merge-ort: step 1 of tree writing -- record basenames, modes, and oids\n - merge-ort: have process_entries operate in a defined order\n - merge-ort: add a preliminary simple process_entries() implementation\n - merge-ort: avoid recursing into identical trees\n - merge-ort: record stage and auxiliary info for every path\n - merge-ort: compute a few more useful fields for collect_merge_info\n - merge-ort: avoid repeating fill_tree_descriptor() on the same tree\n - merge-ort: implement a very basic collect_merge_info()\n - merge-ort: add an err() function similar to one from merge-recursive\n - merge-ort: use histogram diff\n - merge-ort: port merge_start() from merge-recursive\n - merge-ort: add some high-level algorithm structure\n - merge-ort: setup basic internal data structures\n - Merge branch 'en/strmap' into en/merge-ort-impl\n\n Needs review.\n A reroll exists.\n cf. <pull.923.git.git.1606635803.gitgitgadget@gmail.com>\n\n--------------------------------------------------\n[Cooking]\n\n* en/stash-apply-sparse-checkout (2020-11-21) 3 commits\n - stash: fix stash application in sparse-checkouts\n - stash: remove unnecessary process forking\n - t7012: add a testcase demonstrating stash apply bugs in sparse checkouts\n\n\n* jk/stop-pack-objects-when-push-is-killed (2020-11-21) 1 commit\n  (merged to 'next' on 2020-11-25 at f73fb999cd)\n + send-pack: kill pack-objects helper on signal or exit\n\n Receiving \"git push\" that is killed may leave zombie pack-objects\n process behind, which has been corrected.\n\n Will merge to 'master'.\n\n\n* ma/grep-init-default (2020-11-30) 4 commits\n - MyFirstObjectWalk: drop `init_walken_defaults()`\n - grep: copy struct in one fell swoop\n - grep: use designated initializers for `grep_defaults`\n - grep: don't set up a \"default\" repo for grep\n\n Code clean-up.\n\n Will merge to 'next'.\n\n\n* fc/atmark-in-refspec (2020-11-30) 3 commits\n - refspec: make @ a synonym of HEAD\n - tests: push: trivial cleanup\n - tests: push: improve cleanup of HEAD tests\n\n \"@\" sometimes worked (e.g. \"git push origin @:there\") as a part of\n a refspec element, but \"git push orign @\" did not work, which has\n been corrected.\n\n\n* js/init-defaultbranch-advice (2020-11-24) 4 commits\n - init: provide useful advice about init.defaultBranch\n - get_default_branch_name(): prepare for showing some advice\n - branch -m: allow renaming a yet-unborn branch\n - init: document `init.defaultBranch` better\n\n Our users are going to be trained to prepare for future change of\n init.defaultBranch configuration variable.\n\n\n* jt/trace-error-on-warning (2020-11-24) 1 commit\n  (merged to 'next' on 2020-11-30 at 1ab8a970f8)\n + usage: add trace2 entry upon warning()\n\n Like die() and error(), a call to warning() will also trigger a\n trace2 event.\n\n Will merge to 'master'.\n\n\n* ps/config-env-pairs (2020-11-24) 2 commits\n - config: allow specifying config entries via envvar pairs\n - config: extract function to parse config pairs\n\n Introduce a way to feed configuration variable-value pairs via\n environment variables.\n\n Getting there.\n cf. <X74CigYS7AUtMo9Q@tanuki>\n\n\n* tb/idx-midx-race-fix (2020-11-25) 2 commits\n  (merged to 'next' on 2020-11-30 at 493ded178e)\n + midx.c: protect against disappearing packs\n + packfile.c: protect against disappearing indexes\n\n Processes that access packdata while the .idx file gets removed\n (e.g. while repacking) did not fail or fall back gracefully as they\n could.\n\n Will merge to 'master'.\n\n\n* rs/stop-pack-objects-when-fetch-is-killed (2020-11-25) 1 commit\n - upload-pack: kill pack-objects helper on signal or exit\n\n \"git upload-pack\" that is killed may leave zombie pack-objects\n process behind, which has been corrected.\n\n Needs to be replaced with signed-off and/or improved version.\n\n\n* tb/pack-bitmap (2020-11-21) 24 commits\n - pack-bitmap-write: better reuse bitmaps\n - pack-bitmap-write: relax unique rewalk condition\n - pack-bitmap-write: use existing bitmaps\n - pack-bitmap: factor out 'add_commit_to_bitmap()'\n - pack-bitmap: factor out 'bitmap_for_commit()'\n - pack-bitmap-write: ignore BITMAP_FLAG_REUSE\n - pack-bitmap-write: build fewer intermediate bitmaps\n - pack-bitmap.c: check reads more aggressively when loading\n - pack-bitmap-write: rename children to reverse_edges\n - t5310: add branch-based checks\n - commit: implement commit_list_contains()\n - bitmap: add bitmap_diff_nonzero()\n - pack-bitmap-write: fill bitmap with commit history\n - pack-bitmap-write: pass ownership of intermediate bitmaps\n - pack-bitmap-write: reimplement bitmap writing\n - ewah: add bitmap_dup() function\n - ewah: implement bitmap_or()\n - ewah: make bitmap growth less aggressive\n - ewah: factor out bitmap growth\n - rev-list: die when --test-bitmap detects a mismatch\n - t5310: drop size of truncated ewah bitmap\n - pack-bitmap: bounds-check size of cache extension\n - pack-bitmap: fix header size check\n - ewah/ewah_bitmap.c: grow buffer past 1\n\n Various improvement to the codepath that writes out pack bitmaps.\n\n Needs a bit of reshuffling?\n cf. <X7xzWClGr3bM3wcg@coredump.intra.peff.net>\n\n\n* ab/retire-parse-remote (2020-11-24) 4 commits\n  (merged to 'next' on 2020-11-25 at 644484d7df)\n + submodule: fix fetch_in_submodule logic\n  (merged to 'next' on 2020-11-18 at 80d4d8290c)\n + parse-remote: remove this now-unused library\n + submodule: remove sh function in favor of helper\n + submodule: use \"fetch\" logic instead of custom remote discovery\n\n \"git-parse-remote\" shell script library outlived its usefulness.\n\n Will merge to 'master'.\n\n\n* pb/pull-rebase-recurse-submodules (2020-11-16) 4 commits\n  (merged to 'next' on 2020-11-25 at 9837b50d7f)\n + pull: check for local submodule modifications with the right range\n + t5572: describe '--rebase' tests a little more\n + t5572: add notes on a peculiar test\n + pull --rebase: compute rebase arguments in separate function\n\n \"git pull --rebase --recurse-submodules\" checked for local changes\n in a wrong range and failed to run correctly when it should.\n\n Will merge to 'master'.\n\n\n* tb/repack-simplify (2020-11-17) 3 commits\n  (merged to 'next' on 2020-11-25 at 79a98f2403)\n + builtin/repack.c: don't move existing packs out of the way\n + builtin/repack.c: keep track of what pack-objects wrote\n + repack: make \"exts\" array available outside cmd_repack()\n\n Simplify the logic to deal with a repack operation that ended up\n creating the same packfile.\n\n Will merge to 'master'.\n\n\n* dd/help-autocorrect-never (2020-11-25) 1 commit\n - help.c: help.autocorrect=never means \"do not compute suggestions\"\n\n \"git $cmd $args\", when $cmd is not a recognised subcommand, by\n default tries to see if $cmd is a typo of an existing subcommand\n and optionally executes the corrected command if there is only one\n possibility, depending on the setting of help.autocorrect; the\n users can now disable the whole thing, including the cycles spent\n to find a likely typo, by setting the configuration variable to\n 'never'.\n\n Getting there.\n cf. <xmqqft4xdubq.fsf_-_@gitster.c.googlers.com>\n\n\n* js/default-branch-name-tests-final-stretch (2020-11-19) 29 commits\n - tests: drop prereq `PREPARE_FOR_MAIN_BRANCH` where no longer needed\n - t99*: adjust the references to the default branch name \"main\"\n - tests(git-p4): transition to the default branch name `main`\n - t9[5-7]*: adjust the references to the default branch name \"main\"\n - t9[0-4]*: adjust the references to the default branch name \"main\"\n - t8*: adjust the references to the default branch name \"main\"\n - t7[5-9]*: adjust the references to the default branch name \"main\"\n - t7[0-4]*: adjust the references to the default branch name \"main\"\n - t6[4-9]*: adjust the references to the default branch name \"main\"\n - t64*: preemptively adjust alignment to prepare for `master` -> `main`\n - t6[0-3]*: adjust the references to the default branch name \"main\"\n - t5[6-9]*: adjust the references to the default branch name \"main\"\n - t55[4-9]*: adjust the references to the default branch name \"main\"\n - t55[23]*: adjust the references to the default branch name \"main\"\n - t551*: adjust the references to the default branch name \"main\"\n - t550*: adjust the references to the default branch name \"main\"\n - t5503: prepare aligned comment for replacing `master` with `main`\n - t5[0-4]*: adjust the references to the default branch name \"main\"\n - t5323: prepare centered comment for `master` -> `main`\n - t4*: adjust the references to the default branch name \"main\"\n - t3[5-9]*: adjust the references to the default branch name \"main\"\n - t34*: adjust the references to the default branch name \"main\"\n - t3416: preemptively adjust alignment in a comment\n - t3[0-3]*: adjust the references to the default branch name \"main\"\n - t2*: adjust the references to the default branch name \"main\"\n - t[01]*: adjust the references to the default branch name \"main\"\n - t0060: preemptively adjust alignment\n - tests: mark tests relying on the current default for `init.defaultBranch`\n - Merge 'jk/diff-release-filespec-fix' into js/default-branch-name-tests-final-stretch\n\n Prepare tests not to be affected by the name of the default branch\n \"git init\" creates.\n\n\n* ds/config-literal-value (2020-11-25) 8 commits\n - config doc: value-pattern is not necessarily a regexp\n - config: implement --fixed-value with --get*\n - config: plumb --fixed-value into config API\n - config: add --fixed-value option, un-implemented\n - t1300: add test for --replace-all with value-pattern\n - t1300: test \"set all\" mode with value-pattern\n - config: replace 'value_regex' with 'value_pattern'\n - config: convert multi_replace to flags\n (this branch is used by ds/maintenance-part-3.)\n\n Various subcommands of \"git config\" that takes value_regex\n learn the \"--literal-value\" option to take the value_regex option\n as a literal string.\n\n Expecting a (hopefully final) reroll.\n\n\n* ds/maintenance-part-3 (2020-11-25) 2 commits\n - maintenance: use 'git config --fixed-value'\n - Merge branch 'ds/config-literal-value' into ds/maintenance-part-3\n (this branch uses ds/config-literal-value.)\n\n \"git maintenance\" command had trouble working in a directory whose\n pathname contained an ERE metacharacter like '+'.\n\n Blocked by ds/config-literal-value.\n\n\n* ag/merge-strategies-in-c (2020-11-24) 13 commits\n - sequencer: use the \"octopus\" merge strategy without forking\n - sequencer: use the \"resolve\" strategy without forking\n - merge: use the \"octopus\" strategy without forking\n - merge: use the \"resolve\" strategy without forking\n - merge-octopus: rewrite in C\n - merge-recursive: move better_branch_name() to merge.c\n - merge-resolve: rewrite in C\n - merge-index: don't fork if the requested program is `git-merge-one-file'\n - merge-index: libify merge_one_path() and merge_all()\n - merge-one-file: rewrite in C\n - update-index: move add_cacheinfo() to read-cache.c\n - t6060: modify multiple files to expose a possible issue with merge-index\n - t6407: modernise tests\n\n The resolve and octopus merge strategy backends have been rewritten\n in C.\n\n Needs review.\n\n\n* ps/update-ref-multi-transaction (2020-11-16) 4 commits\n  (merged to 'next' on 2020-11-30 at c1c3e23374)\n + update-ref: disallow \"start\" for ongoing transactions\n + p1400: use `git-update-ref --stdin` to test multiple transactions\n + update-ref: allow creation of multiple transactions\n + t1400: avoid touching refs on filesystem\n\n \"git update-ref --stdin\" learns to take multiple transactions in a\n single session.\n\n Will merge to 'master'.\n\n\n* js/add-i-color-fix (2020-11-16) 11 commits\n  (merged to 'next' on 2020-11-30 at 5cb8202cd4)\n + add -i: verify in the tests that colors can be overridden\n + add -p: prefer color.diff.context over color.diff.plain\n + add -i (Perl version): color header to match the C version\n + add -i (built-in): use the same indentation as the Perl version\n + add -p (built-in): do not color the progress indicator separately\n + add -i (built-in): use correct names to load color.diff.* config\n + add -i (built-in): prevent the `reset` \"color\" from being configured\n + add -i: use `reset_color` consistently\n + add -p (built-in): imitate `xdl_format_hunk_hdr()` generating hunk headers\n + add -i (built-in): send error messages to stderr\n + add -i (built-in): do show an error message for incorrect inputs\n\n \"git add -i\" failed to honor custom colors configured to show\n patches, which has been corrected.\n\n Will merge to 'master'.\n cf. <20201117015149.GC19433@coredump.intra.peff.net>\n\n\n* js/trace2-session-id (2020-11-11) 11 commits\n - receive-pack: log received client session ID\n - send-pack: advertise session ID in capabilities\n - upload-pack, serve: log received client session ID\n - fetch-pack: advertise session ID in capabilities\n - transport: log received server session ID\n - serve: advertise session ID in v2 capabilities\n - receive-pack: advertise session ID in v0 capabilities\n - upload-pack: advertise session ID in v0 capabilities\n - trace2: add a public function for getting the SID\n - docs: new transfer.advertiseSID option\n - docs: new capability to advertise session IDs\n\n The transport layer was taught to optionally exchange the session\n ID assigned by the trace2 subsystem during fetch/push transactions.\n\n Will merge to 'next'.\n\n\n* ds/maintenance-part-4 (2020-11-24) 4 commits\n - maintenance: use Windows scheduled tasks\n - maintenance: use launchctl on macOS\n - maintenance: include 'cron' details in docs\n - maintenance: extract platform-specific scheduling\n\n Follow-up on the \"maintenance part-3\" which introduced scheduled\n maintenance tasks to support platforms whose native scheduling\n methods are not 'cron'.\n\n\n* sj/untracked-files-in-submodule-directory-is-not-dirty (2020-10-26) 1 commit\n - diff: do not show submodule with untracked files as \"-dirty\"\n\n \"git diff\" showed a submodule working tree with untracked cruft as\n \"Submodule commit <objectname>-dirty\", but a natural expectation is\n that the \"-dirty\" indicator would align with \"git describe --dirty\",\n which does not consider having untracked files in the working tree\n as source of dirtiness.  The inconsistency has been fixed.\n\n Needs doc update and also adjusting \"git status\".\n\n\n* ak/corrected-commit-date (2020-10-08) 10 commits\n - doc: add corrected commit date info\n - commit-reach: use corrected commit dates in paint_down_to_common()\n - commit-graph: use generation v2 only if entire chain does\n - commit-graph: implement generation data chunk\n - commit-graph: implement corrected commit date\n - commit-graph: add a slab to store topological levels\n - commit-graph: return 64-bit generation number\n - commit-graph: consolidate fill_commit_graph_info\n - revision: parse parent in indegree_walk_step()\n - commit-graph: fix regression when computing Bloom filters\n\n The commit-graph learned to use corrected commit dates instead of\n the generation number to help topological revision traversal.\n\n Getting there.\n cf. <85y2jiqq3c.fsf@gmail.com>\n cf. <685afed6-f01f-5d22-80d4-00fdc11caf0a@gmail.com>\n cf. <20201103053629.GA13228@Abhishek-Arch>\n"},{"id":"411040","messageId":"20201201094623.4290-1-avarab@gmail.com","threadId":"54737","inReplyTo":"xmqqtut6qf7q.fsf@gitster.c.googlers.com","subject":"[PATCH] cook: add github.com/git-vcs/git as a URL","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2020-12-01T09:46:23Z","receivedAt":"2020-12-01T09:47:47Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"I maintain this mirror, but hopefully we can make it semi-official. It\nhas the same refs as the GitHub one except for the GitHub \"pull\" refs:\n\n    $ diff -u \\\n        <(git ls-remote https://gitlab.com/git-vcs/git.git/) \\\n        <(git ls-remote https://github.com/git/git/|grep -v refs/pull)\n    $\n\nAlthough I had to delete the stale \"pu\" manually just now.\n\nAs an aside there are also https://gitlab.com/gitlab-org/git and\nhttps://gitlab.com/git-vcs/git which mostly mirror but also carry some\nGitLab Employee topic branches.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n MaintNotes | 1 +\n cook       | 5 +++--\n 2 files changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/MaintNotes b/MaintNotes\nindex 0dc03080de..bb3064e9ac 100644\n--- a/MaintNotes\n+++ b/MaintNotes\n@@ -136,6 +136,7 @@ My public git.git repositories are (mirrored) at:\n   https://kernel.googlesource.com/pub/scm/git/git\n   git://repo.or.cz/alt-git.git/\n   https://github.com/git/git/\n+  https://gitlab.com/git-vcs/git/\n \n This one shows not just the main integration branches, but also\n individual topics broken out:\ndiff --git a/cook b/cook\nindex 03ac0cfbe4..2258390114 100755\n--- a/cook\n+++ b/cook\n@@ -295,8 +295,8 @@ the integration branches, but I am still holding onto them.\n \n \n Copies of the source code to Git live in many repositories, and the\n-following is a list of the ones I push into.  Some repositories have\n-only a subset of branches.\n+following is a list of the ones I push into or their mirrors.  Some\n+repositories have only a subset of branches.\n \n With maint, master, next, seen, todo:\n \n@@ -304,6 +304,7 @@ With maint, master, next, seen, todo:\n \tgit://repo.or.cz/alt-git.git/\n \thttps://kernel.googlesource.com/pub/scm/git/git/\n \thttps://github.com/git/git/\n+\thttps://gitlab.com/git-vcs/git/\n \n With all the integration branches and topics broken out:\n \n-- \n2.29.2.222.g5d2a92d10f8\n\n"},{"id":"411049","messageId":"20201201095815.12850-1-avarab@gmail.com","threadId":"54737","inReplyTo":"20201201094623.4290-1-avarab@gmail.com","subject":"[PATCH] MaintNotes: use https:// instead of git:// when possible","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2020-12-01T09:58:15Z","receivedAt":"2020-12-01T09:59:30Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change advertised git:// links to https://. These all work as\narguments to \"git clone\", but in addition they also have friendly web\ninterfaces.\n\nThis leaves just git://ozlabs.org/~paulus/gitk as the only git://\nURL. As far as I can tell there's no web interface for it. There is\ne.g. https://git.ozlabs.org/?p=ppp.git which is a frontend for\ngit://git.ozlabs.org/~paulus/ppp.git, but even though cloning the repo\nat git://git.ozlabs.org/~paulus/gitk.git works (not the \"git\"\nsubdomain) there's no corresponding web UI at\nhttps://git.ozlabs.org/?p=gitk.git\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\nNot on top of the last patch I sent (in In-Reply-To), but it\nauto-merges.\n\n MaintNotes | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/MaintNotes b/MaintNotes\nindex 0dc03080de..b52b164e2d 100644\n--- a/MaintNotes\n+++ b/MaintNotes\n@@ -132,15 +132,15 @@ leaking out before we're ready to make public announcements.\n \n My public git.git repositories are (mirrored) at:\n \n-  git://git.kernel.org/pub/scm/git/git.git/\n+  https://git.kernel.org/pub/scm/git/git.git/\n   https://kernel.googlesource.com/pub/scm/git/git\n-  git://repo.or.cz/alt-git.git/\n+  https://repo.or.cz/alt-git.git/\n   https://github.com/git/git/\n \n This one shows not just the main integration branches, but also\n individual topics broken out:\n \n-  git://github.com/gitster/git/\n+  https://github.com/gitster/git/\n \n A few web interfaces are found at:\n \n@@ -151,8 +151,8 @@ A few web interfaces are found at:\n Preformatted documentation from the tip of the \"master\" branch can be\n found in:\n \n-  git://git.kernel.org/pub/scm/git/git-{htmldocs,manpages}.git/\n-  git://repo.or.cz/git-{htmldocs,manpages}.git/\n+  https://git.kernel.org/pub/scm/git/git-{htmldocs,manpages}.git/\n+  https://repo.or.cz/git-{htmldocs,manpages}.git/\n   https://github.com/gitster/git-{htmldocs,manpages}.git/\n \n The manual pages formatted in HTML for the tip of 'master' can be\n-- \n2.29.2.222.g5d2a92d10f8\n\n"},{"id":"411061","messageId":"X8Ytbbvp7SjrN2g5@coredump.intra.peff.net","threadId":"54737","inReplyTo":"20201201094623.4290-1-avarab@gmail.com","subject":"Re: [PATCH] cook: add github.com/git-vcs/git as a URL","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-01T11:47:57Z","receivedAt":"2020-12-01T11:48:40Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 01, 2020 at 10:46:23AM +0100, Ævar Arnfjörð Bjarmason wrote:\n\n> Subject: Re: [PATCH] cook: add github.com/git-vcs/git as a URL\n>\n> I maintain this mirror, but hopefully we can make it semi-official.\n\nI scratched my head for a moment at why you would main another mirror on\ngithub.com. But I think it is just a typo in the subject. You are\nmaintaining a mirror on gitlab.com, which seems perfectly reasonable.\n\n> It\n> has the same refs as the GitHub one except for the GitHub \"pull\" refs:\n> \n>     $ diff -u \\\n>         <(git ls-remote https://gitlab.com/git-vcs/git.git/) \\\n>         <(git ls-remote https://github.com/git/git/|grep -v refs/pull)\n>     $\n\nI.e., here it is gitlab.com/git-vcs/git, although...\n\n> As an aside there are also https://gitlab.com/gitlab-org/git and\n> https://gitlab.com/git-vcs/git which mostly mirror but also carry some\n> GitLab Employee topic branches.\n\nThe mention of git-vcs/git here again confused me. Is it an \"also\", or\nis it the thing we are talking about?\n\n> diff --git a/MaintNotes b/MaintNotes\n> index 0dc03080de..bb3064e9ac 100644\n> --- a/MaintNotes\n> +++ b/MaintNotes\n> @@ -136,6 +136,7 @@ My public git.git repositories are (mirrored) at:\n>    https://kernel.googlesource.com/pub/scm/git/git\n>    git://repo.or.cz/alt-git.git/\n>    https://github.com/git/git/\n> +  https://gitlab.com/git-vcs/git/\n\nThis part make sense to me at least. :)\n\nWould you want to get the maintainer to also push to it as part of the\nregular push-out, so there is never any mirror lag?\n\n-Peff\n"},{"id":"411062","messageId":"X8Yu5CephK3uvMeV@coredump.intra.peff.net","threadId":"54737","inReplyTo":"20201201095815.12850-1-avarab@gmail.com","subject":"Re: [PATCH] MaintNotes: use https:// instead of git:// when possible","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-01T11:54:12Z","receivedAt":"2020-12-01T11:54:54Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 01, 2020 at 10:58:15AM +0100, Ævar Arnfjörð Bjarmason wrote:\n\n> Change advertised git:// links to https://. These all work as\n> arguments to \"git clone\", but in addition they also have friendly web\n> interfaces.\n\nThis is a good idea, I think. Not only for that reason, but because\nhttps:// is more secure. You can verify tags from the maintainer's\nsignature, of course, but if you are just fetching some refs, you are\nrelying on the remote server not to lie to you. With https://, you at\nleast have some assurance that it is the remote server you intended to\ntalk to, and not a man-in-the-middle over the totally unauthenticated\ngit:// protocol.\n\n> This leaves just git://ozlabs.org/~paulus/gitk as the only git://\n> URL. As far as I can tell there's no web interface for it. There is\n> e.g. https://git.ozlabs.org/?p=ppp.git which is a frontend for\n> git://git.ozlabs.org/~paulus/ppp.git, but even though cloning the repo\n> at git://git.ozlabs.org/~paulus/gitk.git works (not the \"git\" subdomain)\n\ns/not/note/ in this last line?\n\n-Peff\n"},{"id":"411080","messageId":"xmqq7dq1qrqv.fsf@gitster.c.googlers.com","threadId":"54737","inReplyTo":"20201201094623.4290-1-avarab@gmail.com","subject":"Re: [PATCH] cook: add github.com/git-vcs/git as a URL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-01T18:57:12Z","receivedAt":"2020-12-01T18:58:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:\n\nAs Peff noticed, the typo in the title is at exactly the right place\nas if designed to confuse all readers.  I had to read the body twice\nbefore I realized s/hub/lab/ is needed.\n\n> I maintain this mirror, but hopefully we can make it semi-official. It\n\nAs Peff hinted, all the current list entries are repositories I push\ninto directly, and obviously I do not want to increase the number of\nsuch direct non-mirrors (I managed to drop sourceforge some time ago\nand I was happy).  But the list is described with a weasel-out\nphrase \"My public ... repositories are (mirrored) at:\", hinting that\nsome of the entries can be mere mirrors.  To most end-users, as long\nas the contents are genuine and lag is minimum, it makes no\ndifference if it is a mirror or a directly pushed non-mirror, I\nwould think.\n\nSo it is OK to add one, as long as it benefits the community.\n\nI would consider adding this repository to the list only if it is\nhosted on GitLab's infrastructure with commitment from GitLab to\nback it officially, as opposed to a mirror being maintained by a\nrandom GitLab user running a cronjob.  What I expect is that the\nformer would get transfer quota boost if/when the mirror gets\npopular enough while the latter would probably not, and I would like\nto make sure we advertise to our users a service that they can rely\non.\n\n> has the same refs as the GitHub one except for the GitHub \"pull\" refs:\n>\n>     $ diff -u \\\n>         <(git ls-remote https://gitlab.com/git-vcs/git.git/) \\\n>         <(git ls-remote https://github.com/git/git/|grep -v refs/pull)\n>     $\n>\n> Although I had to delete the stale \"pu\" manually just now.\n>\n> As an aside there are also https://gitlab.com/gitlab-org/git and\n> https://gitlab.com/git-vcs/git which mostly mirror but also carry some\n> GitLab Employee topic branches.\n\nThese I suspect falls into \"are we advertising a service of a\ncompany, or are we offering service to the community?\" bin.\n\n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n>  MaintNotes | 1 +\n>  cook       | 5 +++--\n>  2 files changed, 4 insertions(+), 2 deletions(-)\n>\n> diff --git a/MaintNotes b/MaintNotes\n> index 0dc03080de..bb3064e9ac 100644\n> --- a/MaintNotes\n> +++ b/MaintNotes\n> @@ -136,6 +136,7 @@ My public git.git repositories are (mirrored) at:\n>    https://kernel.googlesource.com/pub/scm/git/git\n>    git://repo.or.cz/alt-git.git/\n>    https://github.com/git/git/\n> +  https://gitlab.com/git-vcs/git/\n>  \n>  This one shows not just the main integration branches, but also\n>  individual topics broken out:\n> diff --git a/cook b/cook\n> index 03ac0cfbe4..2258390114 100755\n> --- a/cook\n> +++ b/cook\n> @@ -295,8 +295,8 @@ the integration branches, but I am still holding onto them.\n>  \n>  \n>  Copies of the source code to Git live in many repositories, and the\n> -following is a list of the ones I push into.  Some repositories have\n> -only a subset of branches.\n> +following is a list of the ones I push into or their mirrors.  Some\n> +repositories have only a subset of branches.\n\nThis harmonises the description with the phrase used in MaintNotes,\nand because \"What's cooking\" is issued much more often than the \"A\nnote from the maintainer\", it matters more to have the new entry\nhere (having said that, the text here is only used when starting\n\"What's cooking\" from scratch, and because we have already issued\nmany many issues of \"What's cooking\" report so far, it makes no\ndifference to edit the text above and list below with this patch).\n\n>  With maint, master, next, seen, todo:\n>  \n> @@ -304,6 +304,7 @@ With maint, master, next, seen, todo:\n>  \tgit://repo.or.cz/alt-git.git/\n>  \thttps://kernel.googlesource.com/pub/scm/git/git/\n>  \thttps://github.com/git/git/\n> +\thttps://gitlab.com/git-vcs/git/\n>  \n>  With all the integration branches and topics broken out:\n"},{"id":"411081","messageId":"xmqq360pqra2.fsf@gitster.c.googlers.com","threadId":"54737","inReplyTo":"X8Yu5CephK3uvMeV@coredump.intra.peff.net","subject":"Re: [PATCH] MaintNotes: use https:// instead of git:// when possible","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-01T19:07:17Z","receivedAt":"2020-12-01T19:08:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Tue, Dec 01, 2020 at 10:58:15AM +0100, Ævar Arnfjörð Bjarmason wrote:\n>\n>> Change advertised git:// links to https://. These all work as\n>> arguments to \"git clone\", but in addition they also have friendly web\n>> interfaces.\n>\n> This is a good idea, I think. Not only for that reason, but because\n> https:// is more secure. You can verify tags from the maintainer's\n> signature, of course, but if you are just fetching some refs, you are\n> relying on the remote server not to lie to you. With https://, you at\n> least have some assurance that it is the remote server you intended to\n> talk to, and not a man-in-the-middle over the totally unauthenticated\n> git:// protocol.\n>\n>> This leaves just git://ozlabs.org/~paulus/gitk as the only git://\n>> URL. As far as I can tell there's no web interface for it. There is\n>> e.g. https://git.ozlabs.org/?p=ppp.git which is a frontend for\n>> git://git.ozlabs.org/~paulus/ppp.git, but even though cloning the repo\n>> at git://git.ozlabs.org/~paulus/gitk.git works (not the \"git\" subdomain)\n>\n> s/not/note/ in this last line?\n\nWith or without the tweak, I couldn't figure out what the paragraph\nwanted to say.  On the other hand, I didn't quite get why \"friendly\nweb interfaces\" matters until trying to read the paragraph again to\nrealize that it was talking about repository browser like gitweb and\ncgit.\n\nI'd probably rephrase the entire proposed commit log message to\nsomething like:\n\n\tMost git:// URLs listed for the copies of the Git repository\n\thave working corresponding https:// URLs that can be given\n\tto a browser to browse the repository interactively.  List\n\thttps:// URL instead of git:// URL for such repositories.\n\tThe former is also more secure, even though it may be more\n\texpensive.\n\nwithout mentioning ozlabs at all.\n\nThanks.\n"},{"id":"411082","messageId":"xmqqy2ihpck7.fsf@gitster.c.googlers.com","threadId":"54737","inReplyTo":"X8Ytbbvp7SjrN2g5@coredump.intra.peff.net","subject":"Re: [PATCH] cook: add github.com/git-vcs/git as a URL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-01T19:10:32Z","receivedAt":"2020-12-01T19:11:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Tue, Dec 01, 2020 at 10:46:23AM +0100, Ævar Arnfjörð Bjarmason wrote:\n>\n>> Subject: Re: [PATCH] cook: add github.com/git-vcs/git as a URL\n>>\n>> I maintain this mirror, but hopefully we can make it semi-official.\n>\n> I scratched my head for a moment at why you would main another mirror on\n> github.com. But I think it is just a typo in the subject. You are\n> maintaining a mirror on gitlab.com, which seems perfectly reasonable.\n>\n>> It\n>> has the same refs as the GitHub one except for the GitHub \"pull\" refs:\n>> \n>>     $ diff -u \\\n>>         <(git ls-remote https://gitlab.com/git-vcs/git.git/) \\\n>>         <(git ls-remote https://github.com/git/git/|grep -v refs/pull)\n>>     $\n>\n> I.e., here it is gitlab.com/git-vcs/git, although...\n>\n>> As an aside there are also https://gitlab.com/gitlab-org/git and\n>> https://gitlab.com/git-vcs/git which mostly mirror but also carry some\n>> GitLab Employee topic branches.\n>\n> The mention of git-vcs/git here again confused me. Is it an \"also\", or\n> is it the thing we are talking about?\n\nAh, thanks for good eyes.  \n\nIf https://gitlab.com/git-vcs/git is mirror-plus-something-else,\nthen that is a bad fit for the purpose of the list there.\n\n>> diff --git a/MaintNotes b/MaintNotes\n>> index 0dc03080de..bb3064e9ac 100644\n>> --- a/MaintNotes\n>> +++ b/MaintNotes\n>> @@ -136,6 +136,7 @@ My public git.git repositories are (mirrored) at:\n>>    https://kernel.googlesource.com/pub/scm/git/git\n>>    git://repo.or.cz/alt-git.git/\n>>    https://github.com/git/git/\n>> +  https://gitlab.com/git-vcs/git/\n>\n> This part make sense to me at least. :)\n>\n> Would you want to get the maintainer to also push to it as part of the\n> regular push-out, so there is never any mirror lag?\n\nThe maintainer does not want to push to more repositories than he\ncurrently does.  I think the one at googlesource.com is a mere\nmirror out of k.org and not something I push directly into.\n"},{"id":"411128","messageId":"X8bxUsHN8JcyEKHh@coredump.intra.peff.net","threadId":"54737","inReplyTo":"xmqq360pqra2.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] MaintNotes: use https:// instead of git:// when possible","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-02T01:43:46Z","receivedAt":"2020-12-02T01:44:29Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 01, 2020 at 11:07:17AM -0800, Junio C Hamano wrote:\n\n> > s/not/note/ in this last line?\n> \n> With or without the tweak, I couldn't figure out what the paragraph\n> wanted to say.  On the other hand, I didn't quite get why \"friendly\n> web interfaces\" matters until trying to read the paragraph again to\n> realize that it was talking about repository browser like gitweb and\n> cgit.\n> \n> I'd probably rephrase the entire proposed commit log message to\n> something like:\n> \n> \tMost git:// URLs listed for the copies of the Git repository\n> \thave working corresponding https:// URLs that can be given\n> \tto a browser to browse the repository interactively.  List\n> \thttps:// URL instead of git:// URL for such repositories.\n> \tThe former is also more secure, even though it may be more\n> \texpensive.\n> \n> without mentioning ozlabs at all.\n\nYeah, I agree that is the important part.\n\n-Peff\n"},{"id":"411129","messageId":"X8bxfGP0b6v3rM9/@coredump.intra.peff.net","threadId":"54737","inReplyTo":"xmqqy2ihpck7.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] cook: add github.com/git-vcs/git as a URL","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-02T01:44:28Z","receivedAt":"2020-12-02T01:45:11Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 01, 2020 at 11:10:32AM -0800, Junio C Hamano wrote:\n\n> > Would you want to get the maintainer to also push to it as part of the\n> > regular push-out, so there is never any mirror lag?\n> \n> The maintainer does not want to push to more repositories than he\n> currently does.  I think the one at googlesource.com is a mere\n> mirror out of k.org and not something I push directly into.\n\nThat's fair. I definitely don't want to create more work for you. My\nonly concern would be if the mirror is lagged, etc; but you covered all\nof that and more in your other response, so I can shut up now. :)\n\n-Peff\n"},{"id":"411139","messageId":"CAMP44s3c3UiSBUXGfmMi7tTLik6JQv+fDsii0HYOJAx3r2ZXWA@mail.gmail.com","threadId":"54737","inReplyTo":"xmqqtut6qf7q.fsf@gitster.c.googlers.com","subject":"Re: What's cooking in git.git (Nov 2020, #06; Mon, 30)","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-02T04:33:18Z","receivedAt":"2020-12-02T04:34:18Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Mon, Nov 30, 2020 at 11:19 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> Here are the topics that have been cooking.  Commits prefixed with '-' are\n> only in 'seen' (formerly 'pu'---proposed updates) while commits prefixed\n> with '+' are in 'next'.  The ones marked with '.' do not appear in any of\n> the integration branches, but I am still holding onto them.\n\nWhat happened to the git pull ff-only topic?\n\nThere's about three proposals flying around with no feedback [1][2][3].\n\nIn the meantime the annoying warning is still there.\n\n[1] https://lore.kernel.org/git/20201125032938.786393-1-felipe.contreras@gmail.com/\n[2] https://lore.kernel.org/git/20201125020931.248427-2-alexhenrie24@gmail.com/\n[3] https://lore.kernel.org/git/20201123224621.2573159-2-felipe.contreras@gmail.com/\n\n-- \nFelipe Contreras\n"},{"id":"411164","messageId":"ee7a17a2-25a0-d8c9-f686-4ce3a22616e0@gmail.com","threadId":"54737","inReplyTo":"xmqqtut6qf7q.fsf@gitster.c.googlers.com","subject":"ds/config-literal-value (was Re: What's cooking in git.git (Nov 2020, #06; Mon, 30))","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-12-02T13:22:58Z","receivedAt":"2020-12-02T13:23:41Z","isPatch":false,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 12/1/2020 12:15 AM, Junio C Hamano wrote:\n> * ds/config-literal-value (2020-11-25) 8 commits\n>  - config doc: value-pattern is not necessarily a regexp\n>  - config: implement --fixed-value with --get*\n>  - config: plumb --fixed-value into config API\n>  - config: add --fixed-value option, un-implemented\n>  - t1300: add test for --replace-all with value-pattern\n>  - t1300: test \"set all\" mode with value-pattern\n>  - config: replace 'value_regex' with 'value_pattern'\n>  - config: convert multi_replace to flags\n>  (this branch is used by ds/maintenance-part-3.)\n> \n>  Various subcommands of \"git config\" that takes value_regex\n>  learn the \"--literal-value\" option to take the value_regex option\n>  as a literal string.\n> \n>  Expecting a (hopefully final) reroll.\n\nHi Junio,\n\nDid this expectation of a reroll get updated since v3? My understanding\nis that any remaining feedback is related to the angle brackets, which\nare consistent with the surrounding documentation (and should be tackled\nin a separate series). Do you mean that you want me to update the lines\nI'm touching to use angle brackets?\n\nOr, do you mean that I should re-roll to include the patch you sent [1]\nfor between patches 7 and 8?\n\n[1] https://lore.kernel.org/git/xmqq7dq9ca94.fsf@gitster.c.googlers.com/\n\nThanks,\n-Stolee\n"},{"id":"411178","messageId":"xmqq5z5jn9dv.fsf@gitster.c.googlers.com","threadId":"54737","inReplyTo":"ee7a17a2-25a0-d8c9-f686-4ce3a22616e0@gmail.com","subject":"Re: ds/config-literal-value (was Re: What's cooking in git.git (Nov 2020, #06; Mon, 30))","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-02T22:14:20Z","receivedAt":"2020-12-02T22:15:24Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Derrick Stolee <stolee@gmail.com> writes:\n\n> On 12/1/2020 12:15 AM, Junio C Hamano wrote:\n>> * ds/config-literal-value (2020-11-25) 8 commits\n>>  - config doc: value-pattern is not necessarily a regexp\n>>  - config: implement --fixed-value with --get*\n>>  - config: plumb --fixed-value into config API\n>>  - config: add --fixed-value option, un-implemented\n>>  - t1300: add test for --replace-all with value-pattern\n>>  - t1300: test \"set all\" mode with value-pattern\n>>  - config: replace 'value_regex' with 'value_pattern'\n>>  - config: convert multi_replace to flags\n>>  (this branch is used by ds/maintenance-part-3.)\n>> \n>>  Various subcommands of \"git config\" that takes value_regex\n>>  learn the \"--literal-value\" option to take the value_regex option\n>>  as a literal string.\n>> \n>>  Expecting a (hopefully final) reroll.\n>\n> Hi Junio,\n>\n> Did this expectation of a reroll get updated since v3?\n\nThe comment is stale, patches are up-to-date.  Sorry for the mixup.\n\n"}]}