{"thread":{"id":"54735","subject":"[PATCH 4/4] tests: lib-functions: trivial style cleanups","startedAt":"2020-12-01T00:48:02Z","lastAt":"2020-12-02T22:33:15Z","messageCount":18,"participants":["Felipe Contreras","Jeff King","Junio C Hamano","René Scharfe","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"411023","messageId":"20201201004649.57548-5-felipe.contreras@gmail.com","threadId":"54735","inReplyTo":"20201201004649.57548-1-felipe.contreras@gmail.com","subject":"[PATCH 4/4] tests: lib-functions: trivial style cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-01T00:46:49Z","receivedAt":"2020-12-01T00:48:02Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Signed-off-by: Felipe Contreras \n---\n t/test-lib-functions.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh\nindex 7ba3011b90..a791f2f1d6 100644\n--- a/t/test-lib-functions.sh\n+++ b/t/test-lib-functions.sh\n@@ -955,7 +955,7 @@ test_expect_code () {\n # - cmp's output is not nearly as easy to read as diff -u\n # - not all diff versions understand \"-u\"\n \n-test_cmp() {\n+test_cmp () {\n \teval \"$GIT_TEST_CMP\" '\"$@\"'\n }\n \n@@ -968,7 +968,7 @@ test_cmp() {\n #\n # test_cmp_config foo core.bar\n #\n-test_cmp_config() {\n+test_cmp_config () {\n \tlocal GD &&\n \tif test \"$1\" = \"-C\"\n \tthen\n@@ -984,7 +984,7 @@ test_cmp_config() {\n \n # test_cmp_bin - helper to compare binary files\n \n-test_cmp_bin() {\n+test_cmp_bin () {\n \tcmp \"$@\"\n }\n \n@@ -1418,7 +1418,7 @@ nongit () {\n # whitespace and put in a single packet. Note that data containing NULs must be\n # given on stdin, and that empty input becomes an empty packet, not a flush\n # packet (for that you can just print 0000 yourself).\n-packetize() {\n+packetize () {\n \tif test $# -gt 0\n \tthen\n \t\tpacket=\"$*\"\n-- \n2.29.2\n\n"},{"id":"411024","messageId":"20201201004649.57548-2-felipe.contreras@gmail.com","threadId":"54735","inReplyTo":"20201201004649.57548-1-felipe.contreras@gmail.com","subject":"[PATCH 1/4] refspec: trivial cleanup","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-01T00:46:46Z","receivedAt":"2020-12-01T00:48:02Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"We can remove one level of indentation and make the code clearer. So why\nnot do so?\n\nNo functional changes.\n\nSigned-off-by: Felipe Contreras \n---\n refspec.c | 19 ++++++++++---------\n 1 file changed, 10 insertions(+), 9 deletions(-)\n\ndiff --git a/refspec.c b/refspec.c\nindex c49347c2d7..d4823dbff9 100644\n--- a/refspec.c\n+++ b/refspec.c\n@@ -272,15 +272,16 @@ void refspec_ref_prefixes(const struct refspec *rs,\n \t\telse if (item->src && !item->exact_sha1)\n \t\t\tprefix = item->src;\n \n-\t\tif (prefix) {\n-\t\t\tif (item->pattern) {\n-\t\t\t\tconst char *glob = strchr(prefix, '*');\n-\t\t\t\tstrvec_pushf(ref_prefixes, \"%.*s\",\n-\t\t\t\t\t (int)(glob - prefix),\n-\t\t\t\t\t prefix);\n-\t\t\t} else {\n-\t\t\t\texpand_ref_prefix(ref_prefixes, prefix);\n-\t\t\t}\n+\t\tif (!prefix)\n+\t\t\tcontinue;\n+\n+\t\tif (item->pattern) {\n+\t\t\tconst char *glob = strchr(prefix, '*');\n+\t\t\tstrvec_pushf(ref_prefixes, \"%.*s\",\n+\t\t\t\t (int)(glob - prefix),\n+\t\t\t\t prefix);\n+\t\t} else {\n+\t\t\texpand_ref_prefix(ref_prefixes, prefix);\n \t\t}\n \t}\n }\n-- \n2.29.2\n\n"},{"id":"411027","messageId":"20201201004649.57548-4-felipe.contreras@gmail.com","threadId":"54735","inReplyTo":"20201201004649.57548-1-felipe.contreras@gmail.com","subject":"[PATCH 3/4] test: completion: fix typos","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-01T00:46:48Z","receivedAt":"2020-12-01T00:48:02Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Signed-off-by: Felipe Contreras \n---\n t/t9902-completion.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex 5c01c75d40..81a728c743 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -906,7 +906,7 @@ test_expect_success '__git_refs - after --opt= - full refs' '\n \ttest_cmp expected \"$actual\"\n '\n \n-test_expect_success '__git refs - exluding refs' '\n+test_expect_success '__git refs - excluding refs' '\n \tcat >expected <<-EOF &&\n \t^HEAD\n \t^master\n@@ -922,7 +922,7 @@ test_expect_success '__git refs - exluding refs' '\n \ttest_cmp expected \"$actual\"\n '\n \n-test_expect_success '__git refs - exluding full refs' '\n+test_expect_success '__git refs - excluding full refs' '\n \tcat >expected <<-EOF &&\n \t^refs/heads/master\n \t^refs/heads/matching-branch\n-- \n2.29.2\n\n"},{"id":"411025","messageId":"20201201004649.57548-1-felipe.contreras@gmail.com","threadId":"54735","inReplyTo":null,"subject":"[PATCH 0/4] Random cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-01T00:46:45Z","receivedAt":"2020-12-01T00:48:03Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Just some low-hanging fruit I found.\n\n\nFelipe Contreras (4):\n refspec: trivial cleanup\n .gitignore: remove dangling file\n test: completion: fix typos\n tests: lib-functions: trivial style cleanups\n\n .gitignore | 1 -\n refspec.c | 19 ++++++++++---------\n t/t9902-completion.sh | 4 ++--\n t/test-lib-functions.sh | 8 ++++----\n 4 files changed, 16 insertions(+), 16 deletions(-)\n\n-- \n2.29.2\n\n"},{"id":"411026","messageId":"20201201004649.57548-3-felipe.contreras@gmail.com","threadId":"54735","inReplyTo":"20201201004649.57548-1-felipe.contreras@gmail.com","subject":"[PATCH 2/4] .gitignore: remove dangling file","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-01T00:46:47Z","receivedAt":"2020-12-01T00:48:03Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"The library was removed 7 years ago on commit ae34ac126f. But not from\nthe .gitignore file.\n\nSigned-off-by: Felipe Contreras \n---\n .gitignore | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex f85d02c854..7c5096aee5 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -135,7 +135,6 @@\n /git-remote-ftps\n /git-remote-fd\n /git-remote-ext\n-/git-remote-testpy\n /git-repack\n /git-replace\n /git-request-pull\n-- \n2.29.2\n\n"},{"id":"411059","messageId":"X8YsXjN7MQrLnytw@coredump.intra.peff.net","threadId":"54735","inReplyTo":"20201201004649.57548-2-felipe.contreras@gmail.com","subject":"Re: [PATCH 1/4] refspec: trivial cleanup","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-01T11:43:26Z","receivedAt":"2020-12-01T11:44:09Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Nov 30, 2020 at 06:46:46PM -0600, Felipe Contreras wrote:\n\n> We can remove one level of indentation and make the code clearer. So why\n> not do so?\n\nI know your question was rhetorical, but a good reason not to do so in\ngeneral is that the existing pattern reveals some intent. E.g., it\nsometimes is the case that with the _current_ code we can return early\nfrom a function or loop, but that is not inherent to what the code is\ndoing, and the early return or continue makes it harder to understand\nthat.\n\nI don't think that is the case here, though. The continue actually\nexpresses the intent more clearly than the existing code.\n\nSo the patch looks good to me (as do the others in the series).\n\n-Peff\n"},{"id":"411077","messageId":"xmqqh7p5qt0p.fsf@gitster.c.googlers.com","threadId":"54735","inReplyTo":"X8YsXjN7MQrLnytw@coredump.intra.peff.net","subject":"Re: [PATCH 1/4] refspec: trivial cleanup","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-01T18:29:42Z","receivedAt":"2020-12-01T18:31:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Mon, Nov 30, 2020 at 06:46:46PM -0600, Felipe Contreras wrote:\n>\n>> We can remove one level of indentation and make the code clearer. So why\n>> not do so?\n>\n> I know your question was rhetorical, but a good reason not to do so in\n> general is that the existing pattern reveals some intent. E.g., it\n> sometimes is the case that with the _current_ code we can return early\n> from a function or loop, but that is not inherent to what the code is\n> doing, and the early return or continue makes it harder to understand\n> that.\n>\n> I don't think that is the case here, though. The continue actually\n> expresses the intent more clearly than the existing code.\n>\n> So the patch looks good to me (as do the others in the series).\n\nYup, the patch text (eh, the source with the patch applied) looks\ngood. I'd agree with your hintand would take rhetorical question\nout of the log message while queuing.\n\nThanks.\n"},{"id":"411078","messageId":"xmqqczztqszv.fsf@gitster.c.googlers.com","threadId":"54735","inReplyTo":"20201201004649.57548-3-felipe.contreras@gmail.com","subject":"Re: [PATCH 2/4] .gitignore: remove dangling file","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-01T18:30:12Z","receivedAt":"2020-12-01T18:31:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> The library was removed 7 years ago on commit ae34ac126f. But not from\n> the .gitignore file.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n\nGood eyes. Any automation used here, or just mark I eyeballs?\n\n> .gitignore | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/.gitignore b/.gitignore\n> index f85d02c854..7c5096aee5 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -135,7 +135,6 @@\n> /git-remote-ftps\n> /git-remote-fd\n> /git-remote-ext\n> -/git-remote-testpy\n> /git-repack\n> /git-replace\n> /git-request-pull\n"},{"id":"411120","messageId":"CAMP44s3usd5EW4sA6_qapnDBVRAWg4nk5ZSxAPPQN1UygD=ctA@mail.gmail.com","threadId":"54735","inReplyTo":"X8YsXjN7MQrLnytw@coredump.intra.peff.net","subject":"Re: [PATCH 1/4] refspec: trivial cleanup","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-01T23:25:53Z","receivedAt":"2020-12-01T23:26:47Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Tue, Dec 1, 2020 at 5:43 AM Jeff King wrote:\n>\n> On Mon, Nov 30, 2020 at 06:46:46PM -0600, Felipe Contreras wrote:\n>\n> > We can remove one level of indentation and make the code clearer. So why\n> > not do so?\n>\n> I know your question was rhetorical, but a good reason not to do so in\n> general is that the existing pattern reveals some intent. E.g., it\n> sometimes is the case that with the _current_ code we can return early\n> from a function or loop, but that is not inherent to what the code is\n> doing, and the early return or continue makes it harder to understand\n> that.\n\nYes, but even in those cases it arguably helps readability.\n\nAnyway, I prefer to argue on the tangible rather than hypotheticals\nbecause the hypotheticals are infinite.\n\nIn this particular case there's no particular reason to just continue\nif there's no prefix.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"411121","messageId":"CAMP44s1sdTYxWthfHCxPdoDdmapE05gG5Rr1W3BjTfWv2pCTvg@mail.gmail.com","threadId":"54735","inReplyTo":"xmqqczztqszv.fsf@gitster.c.googlers.com","subject":"Re: [PATCH 2/4] .gitignore: remove dangling file","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-01T23:32:46Z","receivedAt":"2020-12-01T23:33:40Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Tue, Dec 1, 2020 at 12:30 PM Junio C Hamano wrote:\n>\n> Felipe Contreras writes:\n>\n> > The library was removed 7 years ago on commit ae34ac126f. But not from\n> > the .gitignore file.\n> >\n> > Signed-off-by: Felipe Contreras \n> > ---\n>\n> Good eyes. Any automation used here, or just mark I eyeballs?\n\nNope. Just switching to a very old branch prompted me to look at the\n.gitignore file and I stumbled upon it.\n\n-- \nFelipe Contreras\n"},{"id":"411133","messageId":"X8b1au+GDihNvhIQ@coredump.intra.peff.net","threadId":"54735","inReplyTo":"CAMP44s3usd5EW4sA6_qapnDBVRAWg4nk5ZSxAPPQN1UygD=ctA@mail.gmail.com","subject":"Re: [PATCH 1/4] refspec: trivial cleanup","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-02T02:01:14Z","receivedAt":"2020-12-02T02:02:12Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 01, 2020 at 05:25:53PM -0600, Felipe Contreras wrote:\n\n> > I know your question was rhetorical, but a good reason not to do so in\n> > general is that the existing pattern reveals some intent. E.g., it\n> > sometimes is the case that with the _current_ code we can return early\n> > from a function or loop, but that is not inherent to what the code is\n> > doing, and the early return or continue makes it harder to understand\n> > that.\n> \n> Yes, but even in those cases it arguably helps readability.\n> \n> Anyway, I prefer to argue on the tangible rather than hypotheticals\n> because the hypotheticals are infinite.\n>\n> In this particular case there's no particular reason to just continue\n> if there's no prefix.\n\nRight, which I already agreed with.\n\nI hesitated on responding at all, because you and I have not had a good\nhistory of agreeing on commit messages. But my comment was primarily for\nother readers on the list. I do not want people blindly applying a rule\nlike \"less indentation is good\" without thinking about the code overall\n(I don't know whether you thought about it or not, but it was not\napparent from your commit message).\n\n-Peff\n"},{"id":"411134","messageId":"X8b7UMcsfaD0OFv4@coredump.intra.peff.net","threadId":"54735","inReplyTo":"xmqqczztqszv.fsf@gitster.c.googlers.com","subject":"Re: [PATCH 2/4] .gitignore: remove dangling file","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-02T02:26:24Z","receivedAt":"2020-12-02T02:27:07Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 01, 2020 at 10:30:12AM -0800, Junio C Hamano wrote:\n\n> Felipe Contreras writes:\n> \n> > The library was removed 7 years ago on commit ae34ac126f. But not from\n> > the .gitignore file.\n> >\n> > Signed-off-by: Felipe Contreras \n> > ---\n> \n> Good eyes. Any automation used here, or just mark I eyeballs?\n\nI was curious how hard it would be to find unused ones, and it is not\ntoo bad:\n\n find * -type f |\n git check-ignore --stdin -v |\n perl -e '\n my $ignore_file = shift;\n while (<>) {\n /^\\Q$ignore_file\\E:(\\d+)/ and $seen{$1} = 1;\n }\n open(my $fh, \"<\", $ignore_file);\n while (<$fh>) {\n print \"$. $_\" unless $seen{$.};\n }\n ' .gitignore\n\nIt turns up many hits, depending on what built cruft you have in your\ndirectory (having a crufty state is nice because it shows which patterns\nare used, but it also may mean you have leftover trash from old versions\nthat doesn't get built anymore, and which we wouldn't notice). So I\nthink a human has to apply some brain-power to the result to see which\nones are plausibly created by other people's environments.\n\nYou might want to revisit some of the old dist rules (do we still ever\nbuild git-core-*? \"make dist\" doesn't seem to. Likewise, \"make rpm\" and\n\"make deb\" are no more, so perhaps it's time to drop those ignores.\n\nThe one below didn't take much brain-power, though.\n\n-- >8 --\nSubject: [PATCH] gitignore: drop duplicate entry for git-sh-i18n\n\nThis was accidentally added by e00cf070a4 (git-sh-i18n.sh: add no-op\ngettext() and eval_gettext() wrappers, 2011-05-14), even though an\nearlier commit in the same series had already done so.\n\nSigned-off-by: Jeff King \n---\n .gitignore | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex f85d02c854..d20d4afc1d 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -152,7 +152,6 @@\n /git-sh-i18n\n /git-sh-i18n--envsubst\n /git-sh-setup\n-/git-sh-i18n\n /git-shell\n /git-shortlog\n /git-show\n-- \n2.29.2.894.g2dadb8c6b8\n\n"},{"id":"411135","messageId":"CAMP44s2KHv_XvQi7YiGKLZ3Tz3nvOj3ZMg+uZtZLnLjyW-wgNQ@mail.gmail.com","threadId":"54735","inReplyTo":"X8b1au+GDihNvhIQ@coredump.intra.peff.net","subject":"Re: [PATCH 1/4] refspec: trivial cleanup","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-02T02:27:19Z","receivedAt":"2020-12-02T02:28:14Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Tue, Dec 1, 2020 at 8:01 PM Jeff King wrote:\n> On Tue, Dec 01, 2020 at 05:25:53PM -0600, Felipe Contreras wrote:\n\n> > In this particular case there's no particular reason to just continue\n> > if there's no prefix.\n>\n> Right, which I already agreed with.\n>\n> I hesitated on responding at all, because you and I have not had a good\n> history of agreeing on commit messages.\n\nWe don't have to agree. Having a different opinion is fine. In fact,\nthat's precisely what keeps a project healthy: diversity of opinion.\n\nDo not hesitate. If you feel it must be said, say it. Or at least;\ndon't hesitate on my behalf. I don't take disagreements personally.\n\n> But my comment was primarily for\n> other readers on the list. I do not want people blindly applying a rule\n> like \"less indentation is good\" without thinking about the code overall\n> (I don't know whether you thought about it or not, but it was not\n> apparent from your commit message).\n\nI see. I did think about it, but I couldn't find an instance in which\nsuch similar change could be contestable.\n\n\"Why not do so?\" was my succinct way of saying that: I cannot find any\nof the typical reasons why we might want to keep an indented\ncondition. Sure, there's possibly better ways to state that, but I\ncouldn't think of any in the limited time I devoted to the commit\nmessage.\n\nMaybe: \"There's no reason to keep the main conditional branch\nindented; we can invert the condition and not continue\".\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"411138","messageId":"CAMP44s2kHshVBRaQ=+jMTLvvxo+aQyB_XP8Et=+ZZt8XhpDufQ@mail.gmail.com","threadId":"54735","inReplyTo":"X8b7UMcsfaD0OFv4@coredump.intra.peff.net","subject":"Re: [PATCH 2/4] .gitignore: remove dangling file","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-02T03:30:34Z","receivedAt":"2020-12-02T03:31:44Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Tue, Dec 1, 2020 at 8:26 PM Jeff King wrote:\n\n> I was curious how hard it would be to find unused ones, and it is not\n> too bad:\n>\n> find * -type f |\n> git check-ignore --stdin -v |\n> perl -e '\n> my $ignore_file = shift;\n> while (<>) {\n> /^\\Q$ignore_file\\E:(\\d+)/ and $seen{$1} = 1;\n> }\n> open(my $fh, \"<\", $ignore_file);\n> while (<$fh>) {\n> print \"$. $_\" unless $seen{$.};\n> }\n> ' .gitignore\n\nOr to use a more modern language:\n\nfind * -type f |\n git check-ignore --stdin -v |\n ruby -e '\n $ignore_file = ARGV.first\n $seen = {}\n $stdin.each do |e|\n e =~ /^#{Regexp.quote($ignore_file)}:(\\d+)/ and $seen[$1.to_i - 1] = true\n end\n ARGF.each_with_index do |e, i|\n print \"#{i} #{e}\" unless $seen[i]\n end\n ' .gitignore\n\n-- \nFelipe Contreras\n"},{"id":"411154","messageId":"4e30fa82-fe24-1783-6f9a-13e1dd6f4ca9@web.de","threadId":"54735","inReplyTo":"X8b7UMcsfaD0OFv4@coredump.intra.peff.net","subject":"[PATCH] gitignore: remove entry for git serve","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2020-12-02T11:46:01Z","receivedAt":"2020-12-02T11:48:02Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git\nserve from a builtin command to a test helper. As a result the\ngit-serve binary is no longer built and thus doesn't have to be ignored\nanymore.\n\nSigned-off-by: René Scharfe \n---\n .gitignore | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex f85d02c854..28c079f227 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -148,7 +148,6 @@\n /git-rm\n /git-send-email\n /git-send-pack\n-/git-serve\n /git-sh-i18n\n /git-sh-i18n--envsubst\n /git-sh-setup\n--\n2.29.2\n"},{"id":"411157","messageId":"nycvar.QRO.7.76.6.2012021202490.25979@tvgsbejvaqbjf.bet","threadId":"54735","inReplyTo":"4e30fa82-fe24-1783-6f9a-13e1dd6f4ca9@web.de","subject":"Re: [PATCH] gitignore: remove entry for git serve","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-12-02T11:03:06Z","receivedAt":"2020-12-02T12:40:08Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi René,\n\nOn Wed, 2 Dec 2020, René Scharfe wrote:\n\n> b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git\n> serve from a builtin command to a test helper. As a result the\n> git-serve binary is no longer built and thus doesn't have to be ignored\n> anymore.\n>\n> Signed-off-by: René Scharfe \n\nACK!\nDscho\n\n> ---\n> .gitignore | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/.gitignore b/.gitignore\n> index f85d02c854..28c079f227 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -148,7 +148,6 @@\n> /git-rm\n> /git-send-email\n> /git-send-pack\n> -/git-serve\n> /git-sh-i18n\n> /git-sh-i18n--envsubst\n> /git-sh-setup\n> --\n> 2.29.2\n>\n"},{"id":"411159","messageId":"X8eNGzay6yWSEoJH@coredump.intra.peff.net","threadId":"54735","inReplyTo":"4e30fa82-fe24-1783-6f9a-13e1dd6f4ca9@web.de","subject":"Re: [PATCH] gitignore: remove entry for git serve","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-02T12:48:27Z","receivedAt":"2020-12-02T12:49:25Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Dec 02, 2020 at 12:46:01PM +0100, René Scharfe wrote:\n\n> b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git\n> serve from a builtin command to a test helper. As a result the\n> git-serve binary is no longer built and thus doesn't have to be ignored\n> anymore.\n\nGood catch. This shows a weakness in my detection script: I had a stale\ngit-serve sitting around from building old versions of Git. :)\n\nI repeated the script in a \"clean\" directory that was a fresh clone +\nmake, and diffed the results. git-serve was the only interesting\ndifference I saw. So this is probably the last of the low-hanging fruit.\n\n-Peff\n"},{"id":"411181","messageId":"xmqqsg8nltzx.fsf@gitster.c.googlers.com","threadId":"54735","inReplyTo":"X8eNGzay6yWSEoJH@coredump.intra.peff.net","subject":"Re: [PATCH] gitignore: remove entry for git serve","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-02T22:32:02Z","receivedAt":"2020-12-02T22:33:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Wed, Dec 02, 2020 at 12:46:01PM +0100, René Scharfe wrote:\n>\n>> b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git\n>> serve from a builtin command to a test helper. As a result the\n>> git-serve binary is no longer built and thus doesn't have to be ignored\n>> anymore.\n>\n> Good catch. This shows a weakness in my detection script: I had a stale\n> git-serve sitting around from building old versions of Git. :)\n>\n> I repeated the script in a \"clean\" directory that was a fresh clone +\n> make, and diffed the results. git-serve was the only interesting\n> difference I saw. So this is probably the last of the low-hanging fruit.\n\nThanks, all. \n\nJust for simplicity, these two are also queued on the same \"random\ncleanup\" topic branch started with Felipe's four trivial clean-up\npatches.\n"}]}