{"thread":{"id":"54720","subject":"New sharness/test vim syntax","startedAt":"2020-11-26T10:24:56Z","lastAt":"2020-12-09T00:31:46Z","messageCount":4,"participants":["Felipe Contreras","Jeff King","Emily Shaffer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"410876","messageId":"CAMP44s1D-Zp3KDS+Hi74a=Lkc7Nc_0qiEzQEF0Pmj=bD8i+=JQ@mail.gmail.com","threadId":"54720","inReplyTo":null,"subject":"New sharness/test vim syntax","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-11-26T10:24:42Z","receivedAt":"2020-11-26T10:24:56Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Hello,\n\nIt gets a bit tedious to see all the tests in the same color, so I\nwrote my own vim syntax file so that at least the body of\ntest_expect_success is highlighted properly.\n\nI've updated it to make it handle more cases, and the result doesn't\nlook bad at all:\n\nhttps://i.imgur.com/qDgvjtu.png\n\nYou can find it on my dotfiles:\n\nhttps://github.com/felipec/dotfiles/blob/master/.vim/syntax/sharness.vim\n\nWhat I do is place it on ~/.vim/syntax/sharness.vim, and then add the\nfollowing to my ~/.vimrc:\n\n  au! BufRead,BufNewFile */git/t/*.sh set ft=sharness\n\nI hope you find this useful.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"411726","messageId":"X8++TTnv95IAIkZL@coredump.intra.peff.net","threadId":"54720","inReplyTo":"CAMP44s1D-Zp3KDS+Hi74a=Lkc7Nc_0qiEzQEF0Pmj=bD8i+=JQ@mail.gmail.com","subject":"Re: New sharness/test vim syntax","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-12-08T17:56:29Z","receivedAt":"2020-12-08T17:57:28Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Nov 26, 2020 at 04:24:42AM -0600, Felipe Contreras wrote:\n\n> It gets a bit tedious to see all the tests in the same color, so I\n> wrote my own vim syntax file so that at least the body of\n> test_expect_success is highlighted properly.\n\nThanks for sharing this. Over the years I've gotten used to the horrible\nall-red view when editing our test scripts, but I'm looking forward to\nleaving that behind. :)\n\n-Peff\n"},{"id":"411752","messageId":"20201208215411.GB3783238@google.com","threadId":"54720","inReplyTo":"X8++TTnv95IAIkZL@coredump.intra.peff.net","subject":"Re: New sharness/test vim syntax","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2020-12-08T21:54:11Z","receivedAt":"2020-12-08T21:54:58Z","isPatch":false,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Tue, Dec 08, 2020 at 12:56:29PM -0500, Jeff King wrote:\n> \n> On Thu, Nov 26, 2020 at 04:24:42AM -0600, Felipe Contreras wrote:\n> \n> > It gets a bit tedious to see all the tests in the same color, so I\n> > wrote my own vim syntax file so that at least the body of\n> > test_expect_success is highlighted properly.\n> \n> Thanks for sharing this. Over the years I've gotten used to the horrible\n> all-red view when editing our test scripts, but I'm looking forward to\n> leaving that behind. :)\n\nThanks for bumping this mail, Peff - I saw it come in, said \"oh heck\nyeah, I'll install that later\" ... and then forgot :)\n\nBut I've installed it now. This is awesome. Thanks for sharing it\nFelipe!\n\n - Emily\n"},{"id":"411799","messageId":"CAMP44s3qUNdGHV2sCovj1Ls7MGesB8_uuX39h4zhCZ_aG-jCsQ@mail.gmail.com","threadId":"54720","inReplyTo":"20201208215411.GB3783238@google.com","subject":"Re: New sharness/test vim syntax","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-12-09T00:30:46Z","receivedAt":"2020-12-09T00:31:46Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Tue, Dec 8, 2020 at 3:54 PM Emily Shaffer <emilyshaffer@google.com> wrote:\n>\n> On Tue, Dec 08, 2020 at 12:56:29PM -0500, Jeff King wrote:\n> >\n> > On Thu, Nov 26, 2020 at 04:24:42AM -0600, Felipe Contreras wrote:\n> >\n> > > It gets a bit tedious to see all the tests in the same color, so I\n> > > wrote my own vim syntax file so that at least the body of\n> > > test_expect_success is highlighted properly.\n> >\n> > Thanks for sharing this. Over the years I've gotten used to the horrible\n> > all-red view when editing our test scripts, but I'm looking forward to\n> > leaving that behind. :)\n>\n> Thanks for bumping this mail, Peff - I saw it come in, said \"oh heck\n> yeah, I'll install that later\" ... and then forgot :)\n>\n> But I've installed it now. This is awesome. Thanks for sharing it\n> Felipe!\n\nYou're welcome!\n\nI also sent a patch to add a project-wide .vimrc file, to minimize the\nburden on each individual developer.\n\nA little bit of quality of life never hurts.\n\nCheers.\n\n-- \nFelipe Contreras\n"}]}