{"thread":{"id":"54619","subject":"[PATCH 0/2] config.mak.uname: remove unused flags","startedAt":"2020-11-11T09:54:36Z","lastAt":"2020-11-11T16:09:30Z","messageCount":4,"participants":["Ævar Arnfjörð Bjarmason","Randall S. Becker"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"409594","messageId":"20201111095420.1446-1-avarab@gmail.com","threadId":"54619","inReplyTo":null,"subject":"[PATCH 0/2] config.mak.uname: remove unused flags","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2020-11-11T09:54:18Z","receivedAt":"2020-11-11T09:54:36Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"A trivial cleanup series to remove flags we're not using anymore.\n\nI don't think there's any more unsed flags, I looked with:\n\n for flag in $(grep -o -P '[A-Z0-9_]+(?= = )' config.mak.uname|sort|uniq); do echo $(grep -c $flag Makefile) $flag; done|sort -n\n\nÆvar Arnfjörð Bjarmason (2):\n config.mak.uname: remove unused the NO_R_TO_GCC_LINKER flag\n config.mak.uname: remove unused NEEDS_SSL_WITH_CURL flag\n\n config.mak.uname | 8 --------\n 1 file changed, 8 deletions(-)\n\n-- \n2.29.2.222.g5d2a92d10f8\n\n"},{"id":"409595","messageId":"20201111095420.1446-2-avarab@gmail.com","threadId":"54619","inReplyTo":"20201111095420.1446-1-avarab@gmail.com","subject":"[PATCH 1/2] config.mak.uname: remove unused the NO_R_TO_GCC_LINKER flag","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2020-11-11T09:54:19Z","receivedAt":"2020-11-11T09:54:40Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The NO_R_TO_GCC_LINKER flag was still being on some platforms. It\nhasn't been used since my 0f50c8e32c8 (\"Makefile: remove the\nNO_R_TO_GCC_LINKER flag\", 2019-05-17).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n config.mak.uname | 3 ---\n 1 file changed, 3 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex c7eba69e54e..8d7b96f8b9b 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -636,7 +636,6 @@ ifneq (,$(wildcard ../THIS_IS_MSYSGIT))\n \tprefix =\n \tINSTALL = /bin/install\n \tEXTLIBS += /mingw/lib/libz.a\n-\tNO_R_TO_GCC_LINKER = YesPlease\n \tINTERNAL_QSORT = YesPlease\n \tHAVE_LIBCHARSET_H = YesPlease\n \tNO_GETTEXT = YesPlease\n@@ -669,7 +668,6 @@ else\n \t\t\t-fstack-protector-strong\n \t\tEXTLIBS += -lntdll\n \t\tINSTALL = /bin/install\n-\t\tNO_R_TO_GCC_LINKER = YesPlease\n \t\tINTERNAL_QSORT = YesPlease\n \t\tHAVE_LIBCHARSET_H = YesPlease\n \t\tNO_GETTEXT =\n@@ -695,7 +693,6 @@ ifeq ($(uname_S),QNX)\n \tNO_MKDTEMP = YesPlease\n \tNO_NSEC = YesPlease\n \tNO_PTHREADS = YesPlease\n-\tNO_R_TO_GCC_LINKER = YesPlease\n \tNO_STRCASESTR = YesPlease\n \tNO_STRLCPY = YesPlease\n endif\n-- \n2.29.2.222.g5d2a92d10f8\n\n"},{"id":"409596","messageId":"20201111095420.1446-3-avarab@gmail.com","threadId":"54619","inReplyTo":"20201111095420.1446-1-avarab@gmail.com","subject":"[PATCH 2/2] config.mak.uname: remove unused NEEDS_SSL_WITH_CURL flag","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2020-11-11T09:54:20Z","receivedAt":"2020-11-11T09:54:41Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The NEEDS_SSL_WITH_CURL flag was still being set in one case, but\nhasn't existed since 23c4bbe28e6 (\"build: link with curl-defined\nlinker flags\", 2018-11-03). Remove it, and a comment which referred to\nit. See 6c109904bc8 (\"Port to HP NonStop\", 2012-09-19) for the initial\naddition of the comment.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n config.mak.uname | 5 -----\n 1 file changed, 5 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 8d7b96f8b9b..5b30a9154ac 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -541,11 +541,6 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \t# removing the directory at OS releases J06.21 and L17.02.\n \t# Default to the older rm until those two releases are deprecated.\n \tRM = /bin/rm -f\n-\t# As detected by './configure'.\n-\t# Missdetected, hence commented out, see below.\n-\t#NO_CURL = YesPlease\n-\t# Added manually, see above.\n-\tNEEDS_SSL_WITH_CURL = YesPlease\n \tNEEDS_CRYPTO_WITH_SSL = YesPlease\n \tHAVE_DEV_TTY = YesPlease\n \tHAVE_LIBCHARSET_H = YesPlease\n-- \n2.29.2.222.g5d2a92d10f8\n\n"},{"id":"409636","messageId":"012701d6b845$03bde880$0b39b980$@nexbridge.com","threadId":"54619","inReplyTo":"20201111095420.1446-3-avarab@gmail.com","subject":"RE: [PATCH 2/2] config.mak.uname: remove unused NEEDS_SSL_WITH_CURL flag","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2020-11-11T16:09:14Z","receivedAt":"2020-11-11T16:09:30Z","isPatch":true,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On November 11, 2020 4:54 AM, Ævar Arnfjörð Bjarmason wrote:\n> The NEEDS_SSL_WITH_CURL flag was still being set in one case, but hasn't\n> existed since 23c4bbe28e6 (\"build: link with curl-defined linker flags\", 2018-\n> 11-03). Remove it, and a comment which referred to it. See 6c109904bc8\n> (\"Port to HP NonStop\", 2012-09-19) for the initial addition of the comment.\n> \n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n> config.mak.uname | 5 -----\n> 1 file changed, 5 deletions(-)\n> \n> diff --git a/config.mak.uname b/config.mak.uname index\n> 8d7b96f8b9b..5b30a9154ac 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -541,11 +541,6 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> \t# removing the directory at OS releases J06.21 and L17.02.\n> \t# Default to the older rm until those two releases are deprecated.\n> \tRM = /bin/rm -f\n> -\t# As detected by './configure'.\n> -\t# Missdetected, hence commented out, see below.\n> -\t#NO_CURL = YesPlease\n> -\t# Added manually, see above.\n> -\tNEEDS_SSL_WITH_CURL = YesPlease\n> \tNEEDS_CRYPTO_WITH_SSL = YesPlease\n> \tHAVE_DEV_TTY = YesPlease\n> \tHAVE_LIBCHARSET_H = YesPlease\n> --\n> 2.29.2.222.g5d2a92d10f8\n\nThis should be fine. We will test when rolled in, but I can't see an issue here. Sadly, I can't remove the junk above those deletions yet.\n\nThanks,\nRandall\n\n-- Brief whoami:\n NonStop developer since approximately 211288444200000000\n UNIX developer since approximately 421664400\n-- In my real life, I talk too much.\n\n\n\n"}]}