{"thread":{"id":"54459","subject":"[OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","startedAt":"2020-10-19T04:26:19Z","lastAt":"2020-10-20T19:33:40Z","messageCount":8,"participants":["Joey S","Phillip Wood","Taylor Blau","Emily Shaffer","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"407870","messageId":"ERmIkC3rLZ3BAyv2Nq_GK0CjWvEQw6ejl8V-HVvwCsyIv0guQV67nO8KMLi7eA9qO5mo_ZJ8XB360uP_LtP-LY1xsaRBXHsc0F1uSID-KPE=@protonmail.com","threadId":"54459","inReplyTo":null,"subject":"[OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Joey S","fromEmail":"jgsal@protonmail.com","sentAt":"2020-10-19T04:26:07Z","receivedAt":"2020-10-19T04:26:19Z","isPatch":true,"sender":{"key":"jgsal@protonmail.com","avatar":null},"body":"Hi everyone,\n\nThis is my first contribution to Git's public repo and, after using Git for several years, I'm very looking forward to becoming an active member of the community.\n\nIn this patch for test t7006-pager, I have:\n\n - ensured the guidelines[1] were followed\n - used the helper function 'test_path_is_file()' to replace all found instances of 'test -e'\n\nPlease find the output of 'git format-patch' below.\n\nThank you all, looking forward to your feedback and observations,\n\nJoey\n\n[1] lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/\n\n\nModernized the test by replacing 'test -e' instances with\ntest_path_is_file helper functions.\n\nSigned-off-by: JoeyS \n---\n t/t7006-pager.sh | 84 ++++++++++++++++++++++++------------------------\n 1 file changed, 42 insertions(+), 42 deletions(-)\n\ndiff --git a/t/t7006-pager.sh b/t/t7006-pager.sh\nindex 00e09a375c..1d0f75e34e 100755\n--- a/t/t7006-pager.sh\n+++ b/t/t7006-pager.sh\n@@ -19,7 +19,7 @@ test_expect_success 'setup' '\n test_expect_success TTY 'some commands use a pager' '\n \trm -f paginated.out &&\n \ttest_terminal git log &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_failure TTY 'pager runs from subdir' '\n@@ -65,49 +65,49 @@ test_expect_success !MINGW,TTY 'LESS and LV envvars set by git-sh-setup' '\n test_expect_success TTY 'some commands do not use a pager' '\n \trm -f paginated.out &&\n \ttest_terminal git rev-list HEAD &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success 'no pager when stdout is a pipe' '\n \trm -f paginated.out &&\n \tgit log | cat &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success 'no pager when stdout is a regular file' '\n \trm -f paginated.out &&\n \tgit log >file &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git --paginate rev-list uses a pager' '\n \trm -f paginated.out &&\n \ttest_terminal git --paginate rev-list HEAD &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_success 'no pager even with --paginate when stdout is a pipe' '\n \trm -f file paginated.out &&\n \tgit --paginate log | cat &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'no pager with --no-pager' '\n \trm -f paginated.out &&\n \ttest_terminal git --no-pager log &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'configuration can disable pager' '\n \trm -f paginated.out &&\n \ttest_unconfig pager.grep &&\n \ttest_terminal git grep initial &&\n-\ttest -e paginated.out &&\n+\ttest_path_is_file paginated.out &&\n\n \trm -f paginated.out &&\n \ttest_config pager.grep false &&\n \ttest_terminal git grep initial &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'configuration can enable pager (from subdir)' '\n@@ -122,107 +122,107 @@ test_expect_success TTY 'configuration can enable pager (from subdir)' '\n \t\ttest_terminal git bundle unbundle ../test.bundle\n \t) &&\n \t{\n-\t\ttest -e paginated.out ||\n-\t\ttest -e subdir/paginated.out\n+\t\ttest_path_is_file paginated.out ||\n+\t\ttest_path_is_file subdir/paginated.out\n \t}\n '\n\n test_expect_success TTY 'git tag -l defaults to paging' '\n \trm -f paginated.out &&\n \ttest_terminal git tag -l &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag -l respects pager.tag' '\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.tag=false tag -l &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag -l respects --no-pager' '\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.tag --no-pager tag -l &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag with no args defaults to paging' '\n \t# no args implies -l so this should page like -l\n \trm -f paginated.out &&\n \ttest_terminal git tag &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag with no args respects pager.tag' '\n \t# no args implies -l so this should page like -l\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.tag=false tag &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag --contains defaults to paging' '\n \t# --contains implies -l so this should page like -l\n \trm -f paginated.out &&\n \ttest_terminal git tag --contains &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag --contains respects pager.tag' '\n \t# --contains implies -l so this should page like -l\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.tag=false tag --contains &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag -a defaults to not paging' '\n \ttest_when_finished \"git tag -d newtag\" &&\n \trm -f paginated.out &&\n \ttest_terminal git tag -am message newtag &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag -a ignores pager.tag' '\n \ttest_when_finished \"git tag -d newtag\" &&\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.tag tag -am message newtag &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag -a respects --paginate' '\n \ttest_when_finished \"git tag -d newtag\" &&\n \trm -f paginated.out &&\n \ttest_terminal git --paginate tag -am message newtag &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag as alias ignores pager.tag with -a' '\n \ttest_when_finished \"git tag -d newtag\" &&\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.tag -c alias.t=tag t -am message newtag &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git tag as alias respects pager.tag with -l' '\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.tag=false -c alias.t=tag t -l &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git branch defaults to paging' '\n \trm -f paginated.out &&\n \ttest_terminal git branch &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git branch respects pager.branch' '\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.branch=false branch &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git branch respects --no-pager' '\n \trm -f paginated.out &&\n \ttest_terminal git --no-pager branch &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git branch --edit-description ignores pager.branch' '\n@@ -232,8 +232,8 @@ test_expect_success TTY 'git branch --edit-description ignores pager.branch' '\n \t\ttouch editor.used\n \tEOF\n \tEDITOR=./editor test_terminal git -c pager.branch branch --edit-description &&\n-\t! test -e paginated.out &&\n-\ttest -e editor.used\n+\t! test_path_is_file paginated.out &&\n+\ttest_path_is_file editor.used\n '\n\n test_expect_success TTY 'git branch --set-upstream-to ignores pager.branch' '\n@@ -242,13 +242,13 @@ test_expect_success TTY 'git branch --set-upstream-to ignores pager.branch' '\n \ttest_when_finished \"git branch -D other\" &&\n \ttest_terminal git -c pager.branch branch --set-upstream-to=other &&\n \ttest_when_finished \"git branch --unset-upstream\" &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git config ignores pager.config when setting' '\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.config config foo.bar bar &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git config --edit ignores pager.config' '\n@@ -257,33 +257,33 @@ test_expect_success TTY 'git config --edit ignores pager.config' '\n \t\ttouch editor.used\n \tEOF\n \tEDITOR=./editor test_terminal git -c pager.config config --edit &&\n-\t! test -e paginated.out &&\n-\ttest -e editor.used\n+\t! test_path_is_file paginated.out &&\n+\ttest_path_is_file editor.used\n '\n\n test_expect_success TTY 'git config --get ignores pager.config' '\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.config config --get foo.bar &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git config --get-urlmatch defaults to paging' '\n \trm -f paginated.out &&\n \ttest_terminal git -c http.\"https://foo.com/\".bar=foo \\\n \t\t\t config --get-urlmatch http https://foo.com &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git config --get-all respects pager.config' '\n \trm -f paginated.out &&\n \ttest_terminal git -c pager.config=false config --get-all foo.bar &&\n-\t! test -e paginated.out\n+\t! test_path_is_file paginated.out\n '\n\n test_expect_success TTY 'git config --list defaults to paging' '\n \trm -f paginated.out &&\n \ttest_terminal git config --list &&\n-\ttest -e paginated.out\n+\ttest_path_is_file paginated.out\n '\n\n\n@@ -392,7 +392,7 @@ test_default_pager() {\n \t\t\texport PATH &&\n \t\t\t$full_command\n \t\t) &&\n-\t\ttest -e default_pager_used\n+\t\ttest_path_is_file default_pager_used\n \t\"\n }\n\n@@ -406,7 +406,7 @@ test_PAGER_overrides() {\n \t\tPAGER='wc >PAGER_used' &&\n \t\texport PAGER &&\n \t\t$full_command &&\n-\t\ttest -e PAGER_used\n+\t\ttest_path_is_file PAGER_used\n \t\"\n }\n\n@@ -432,7 +432,7 @@ test_core_pager() {\n \t\texport PAGER &&\n \t\ttest_config core.pager 'wc >core.pager_used' &&\n \t\t$full_command &&\n-\t\t${if_local_config}test -e core.pager_used\n+\t\t${if_local_config}test_path_is_file core.pager_used\n \t\"\n }\n\n@@ -464,7 +464,7 @@ test_pager_subdir_helper() {\n \t\t\tcd sub &&\n \t\t\t$full_command\n \t\t) &&\n-\t\t${if_local_config}test -e core.pager_used\n+\t\t${if_local_config}test_path_is_file core.pager_used\n \t\"\n }\n\n@@ -477,7 +477,7 @@ test_GIT_PAGER_overrides() {\n \t\tGIT_PAGER='wc >GIT_PAGER_used' &&\n \t\texport GIT_PAGER &&\n \t\t$full_command &&\n-\t\ttest -e GIT_PAGER_used\n+\t\ttest_path_is_file GIT_PAGER_used\n \t\"\n }\n\n@@ -489,7 +489,7 @@ test_doesnt_paginate() {\n \t\tGIT_PAGER='wc >GIT_PAGER_used' &&\n \t\texport GIT_PAGER &&\n \t\t$full_command &&\n-\t\t! test -e GIT_PAGER_used\n+\t\t! test_path_is_file GIT_PAGER_used\n \t\"\n }\n\n--\n2.29.0.rc2\n"},{"id":"407874","messageId":"ff9619cd-8a31-9ce4-f0e9-c7291a4141d2@talktalk.net","threadId":"54459","inReplyTo":"ERmIkC3rLZ3BAyv2Nq_GK0CjWvEQw6ejl8V-HVvwCsyIv0guQV67nO8KMLi7eA9qO5mo_ZJ8XB360uP_LtP-LY1xsaRBXHsc0F1uSID-KPE=@protonmail.com","subject":"Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Phillip Wood","fromEmail":"phillip.wood@talktalk.net","sentAt":"2020-10-19T11:28:33Z","receivedAt":"2020-10-19T11:36:51Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Joey\n\nOn 19/10/2020 05:26, Joey S wrote:\n> Hi everyone,\n> \n> This is my first contribution to Git's public repo and, after using Git for several years, I'm very looking forward to becoming an active member of the community.\n\nWelcome to the list\n\n> In this patch for test t7006-pager, I have:\n> \n> - ensured the guidelines[1] were followed\n> - used the helper function 'test_path_is_file()' to replace all found instances of 'test -e'\n> \n> Please find the output of 'git format-patch' below.\n> \n> Thank you all, looking forward to your feedback and observations,\n> \n> Joey\n> \n> [1] lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/\n> \n\nAll this text above is useful context for reviewers but appears as part \nof the commit message which is not what you want. If you add notes after \nthe `---` line below then they will not end up in the commit message.\n\n> Modernized the test by replacing 'test -e' instances with\n> test_path_is_file helper functions.\n\ns/Modernized/Modernize/\n\nI've got some comments about the conversions of `! test -e` below\n\n\n> Signed-off-by: JoeyS \n> ---\n> t/t7006-pager.sh | 84 ++++++++++++++++++++++++------------------------\n> 1 file changed, 42 insertions(+), 42 deletions(-)\n> \n> diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh\n> index 00e09a375c..1d0f75e34e 100755\n> --- a/t/t7006-pager.sh\n> +++ b/t/t7006-pager.sh\n> @@ -19,7 +19,7 @@ test_expect_success 'setup' '\n> test_expect_success TTY 'some commands use a pager' '\n> \trm -f paginated.out &&\n> \ttest_terminal git log &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n\nThis and all the other conversions of `test -e` look fine\n\n> test_expect_failure TTY 'pager runs from subdir' '\n> @@ -65,49 +65,49 @@ test_expect_success !MINGW,TTY 'LESS and LV envvars set by git-sh-setup' '\n> test_expect_success TTY 'some commands do not use a pager' '\n> \trm -f paginated.out &&\n> \ttest_terminal git rev-list HEAD &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n\nIt would be better to replace `! test -e` this with \n`test_path_is_missing` as the modified test will pass if paginated.out \nexists but is not a file. `test_path_is_missing` will print an \nappropriate diagnostic message as well.\n\nBest Wishes\n\nPhillip\n\n> '\n> \n> test_expect_success 'no pager when stdout is a pipe' '\n> \trm -f paginated.out &&\n> \tgit log | cat &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success 'no pager when stdout is a regular file' '\n> \trm -f paginated.out &&\n> \tgit log >file &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git --paginate rev-list uses a pager' '\n> \trm -f paginated.out &&\n> \ttest_terminal git --paginate rev-list HEAD &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> test_expect_success 'no pager even with --paginate when stdout is a pipe' '\n> \trm -f file paginated.out &&\n> \tgit --paginate log | cat &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'no pager with --no-pager' '\n> \trm -f paginated.out &&\n> \ttest_terminal git --no-pager log &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'configuration can disable pager' '\n> \trm -f paginated.out &&\n> \ttest_unconfig pager.grep &&\n> \ttest_terminal git grep initial &&\n> -\ttest -e paginated.out &&\n> +\ttest_path_is_file paginated.out &&\n> \n> \trm -f paginated.out &&\n> \ttest_config pager.grep false &&\n> \ttest_terminal git grep initial &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'configuration can enable pager (from subdir)' '\n> @@ -122,107 +122,107 @@ test_expect_success TTY 'configuration can enable pager (from subdir)' '\n> \t\ttest_terminal git bundle unbundle ../test.bundle\n> \t) &&\n> \t{\n> -\t\ttest -e paginated.out ||\n> -\t\ttest -e subdir/paginated.out\n> +\t\ttest_path_is_file paginated.out ||\n> +\t\ttest_path_is_file subdir/paginated.out\n> \t}\n> '\n> \n> test_expect_success TTY 'git tag -l defaults to paging' '\n> \trm -f paginated.out &&\n> \ttest_terminal git tag -l &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag -l respects pager.tag' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.tag=false tag -l &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag -l respects --no-pager' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.tag --no-pager tag -l &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag with no args defaults to paging' '\n> \t# no args implies -l so this should page like -l\n> \trm -f paginated.out &&\n> \ttest_terminal git tag &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag with no args respects pager.tag' '\n> \t# no args implies -l so this should page like -l\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.tag=false tag &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag --contains defaults to paging' '\n> \t# --contains implies -l so this should page like -l\n> \trm -f paginated.out &&\n> \ttest_terminal git tag --contains &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag --contains respects pager.tag' '\n> \t# --contains implies -l so this should page like -l\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.tag=false tag --contains &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag -a defaults to not paging' '\n> \ttest_when_finished \"git tag -d newtag\" &&\n> \trm -f paginated.out &&\n> \ttest_terminal git tag -am message newtag &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag -a ignores pager.tag' '\n> \ttest_when_finished \"git tag -d newtag\" &&\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.tag tag -am message newtag &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag -a respects --paginate' '\n> \ttest_when_finished \"git tag -d newtag\" &&\n> \trm -f paginated.out &&\n> \ttest_terminal git --paginate tag -am message newtag &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag as alias ignores pager.tag with -a' '\n> \ttest_when_finished \"git tag -d newtag\" &&\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.tag -c alias.t=tag t -am message newtag &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git tag as alias respects pager.tag with -l' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.tag=false -c alias.t=tag t -l &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git branch defaults to paging' '\n> \trm -f paginated.out &&\n> \ttest_terminal git branch &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git branch respects pager.branch' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.branch=false branch &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git branch respects --no-pager' '\n> \trm -f paginated.out &&\n> \ttest_terminal git --no-pager branch &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git branch --edit-description ignores pager.branch' '\n> @@ -232,8 +232,8 @@ test_expect_success TTY 'git branch --edit-description ignores pager.branch' '\n> \t\ttouch editor.used\n> \tEOF\n> \tEDITOR=./editor test_terminal git -c pager.branch branch --edit-description &&\n> -\t! test -e paginated.out &&\n> -\ttest -e editor.used\n> +\t! test_path_is_file paginated.out &&\n> +\ttest_path_is_file editor.used\n> '\n> \n> test_expect_success TTY 'git branch --set-upstream-to ignores pager.branch' '\n> @@ -242,13 +242,13 @@ test_expect_success TTY 'git branch --set-upstream-to ignores pager.branch' '\n> \ttest_when_finished \"git branch -D other\" &&\n> \ttest_terminal git -c pager.branch branch --set-upstream-to=other &&\n> \ttest_when_finished \"git branch --unset-upstream\" &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git config ignores pager.config when setting' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.config config foo.bar bar &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git config --edit ignores pager.config' '\n> @@ -257,33 +257,33 @@ test_expect_success TTY 'git config --edit ignores pager.config' '\n> \t\ttouch editor.used\n> \tEOF\n> \tEDITOR=./editor test_terminal git -c pager.config config --edit &&\n> -\t! test -e paginated.out &&\n> -\ttest -e editor.used\n> +\t! test_path_is_file paginated.out &&\n> +\ttest_path_is_file editor.used\n> '\n> \n> test_expect_success TTY 'git config --get ignores pager.config' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.config config --get foo.bar &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git config --get-urlmatch defaults to paging' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c http.\"https://foo.com/\".bar=foo \\\n> \t\t\t config --get-urlmatch http https://foo.com &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git config --get-all respects pager.config' '\n> \trm -f paginated.out &&\n> \ttest_terminal git -c pager.config=false config --get-all foo.bar &&\n> -\t! test -e paginated.out\n> +\t! test_path_is_file paginated.out\n> '\n> \n> test_expect_success TTY 'git config --list defaults to paging' '\n> \trm -f paginated.out &&\n> \ttest_terminal git config --list &&\n> -\ttest -e paginated.out\n> +\ttest_path_is_file paginated.out\n> '\n> \n> \n> @@ -392,7 +392,7 @@ test_default_pager() {\n> \t\t\texport PATH &&\n> \t\t\t$full_command\n> \t\t) &&\n> -\t\ttest -e default_pager_used\n> +\t\ttest_path_is_file default_pager_used\n> \t\"\n> }\n> \n> @@ -406,7 +406,7 @@ test_PAGER_overrides() {\n> \t\tPAGER='wc >PAGER_used' &&\n> \t\texport PAGER &&\n> \t\t$full_command &&\n> -\t\ttest -e PAGER_used\n> +\t\ttest_path_is_file PAGER_used\n> \t\"\n> }\n> \n> @@ -432,7 +432,7 @@ test_core_pager() {\n> \t\texport PAGER &&\n> \t\ttest_config core.pager 'wc >core.pager_used' &&\n> \t\t$full_command &&\n> -\t\t${if_local_config}test -e core.pager_used\n> +\t\t${if_local_config}test_path_is_file core.pager_used\n> \t\"\n> }\n> \n> @@ -464,7 +464,7 @@ test_pager_subdir_helper() {\n> \t\t\tcd sub &&\n> \t\t\t$full_command\n> \t\t) &&\n> -\t\t${if_local_config}test -e core.pager_used\n> +\t\t${if_local_config}test_path_is_file core.pager_used\n> \t\"\n> }\n> \n> @@ -477,7 +477,7 @@ test_GIT_PAGER_overrides() {\n> \t\tGIT_PAGER='wc >GIT_PAGER_used' &&\n> \t\texport GIT_PAGER &&\n> \t\t$full_command &&\n> -\t\ttest -e GIT_PAGER_used\n> +\t\ttest_path_is_file GIT_PAGER_used\n> \t\"\n> }\n> \n> @@ -489,7 +489,7 @@ test_doesnt_paginate() {\n> \t\tGIT_PAGER='wc >GIT_PAGER_used' &&\n> \t\texport GIT_PAGER &&\n> \t\t$full_command &&\n> -\t\t! test -e GIT_PAGER_used\n> +\t\t! test_path_is_file GIT_PAGER_used\n> \t\"\n> }\n> \n> --\n> 2.29.0.rc2\n> \n\n"},{"id":"407910","messageId":"20201019202807.GA47395@nand.local","threadId":"54459","inReplyTo":"ff9619cd-8a31-9ce4-f0e9-c7291a4141d2@talktalk.net","subject":"Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-10-19T20:28:07Z","receivedAt":"2020-10-19T20:28:12Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Oct 19, 2020 at 12:28:33PM +0100, Phillip Wood wrote:\n> Hi Joey\n>\n> On 19/10/2020 05:26, Joey S wrote:\n> > Hi everyone,\n> >\n> > This is my first contribution to Git's public repo and, after using Git for several years, I'm very looking forward to becoming an active member of the community.\n>\n> Welcome to the list\n\nIndeed :-).\n\n> > In this patch for test t7006-pager, I have:\n> >\n> > - ensured the guidelines[1] were followed\n> > - used the helper function 'test_path_is_file()' to replace all found instances of 'test -e'\n> >\n> > Please find the output of 'git format-patch' below.\n> >\n> > Thank you all, looking forward to your feedback and observations,\n> >\n> > Joey\n> >\n> > [1] lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/\n> >\n>\n> All this text above is useful context for reviewers but appears as part of\n> the commit message which is not what you want. If you add notes after the\n> `---` line below then they will not end up in the commit message.\n\n...Alternatively, this would fit just fine in a cover letter. Usually\ncover letters are not necessary for single patches (where the patch\nmessage itself conveys the full message, or a little bit of additional\ncontext below the triple-dash line is all that's necessary to clarify\nthe intent). But, if you want to introduce yourself, a 0/1 cover letter\nis fine, too.\n\n> > test_expect_failure TTY 'pager runs from subdir' '\n> > @@ -65,49 +65,49 @@ test_expect_success !MINGW,TTY 'LESS and LV envvars set by git-sh-setup' '\n> > test_expect_success TTY 'some commands do not use a pager' '\n> > \trm -f paginated.out &&\n> > \ttest_terminal git rev-list HEAD &&\n> > -\t! test -e paginated.out\n> > +\t! test_path_is_file paginated.out\n>\n> It would be better to replace `! test -e` this with `test_path_is_missing`\n> as the modified test will pass if paginated.out exists but is not a file.\n> `test_path_is_missing` will print an appropriate diagnostic message as well.\n\nYup, great catch.\n\nThanks,\nTaylor\n"},{"id":"407937","messageId":"20201020001103.GB2774782@google.com","threadId":"54459","inReplyTo":"ERmIkC3rLZ3BAyv2Nq_GK0CjWvEQw6ejl8V-HVvwCsyIv0guQV67nO8KMLi7eA9qO5mo_ZJ8XB360uP_LtP-LY1xsaRBXHsc0F1uSID-KPE=@protonmail.com","subject":"Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2020-10-20T00:11:03Z","receivedAt":"2020-10-20T00:11:12Z","isPatch":true,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:\n> \n> Hi everyone,\nHi Joey and welcome.\n\n> \n> Signed-off-by: JoeyS \n\nOne thing missed by other commenters: the Developer's Certificate of\nOrigin line - which is what this indicates - should have your \"full\nname\". So in my case, I sign my patches 'Emily Shaffer\n'. If I'm wrong that's fine, but JoeyS sounds\nlike a name and initial rather than a full name.\n\nThe rest of the patch looks okay to me, though.\n\n - Emily\n"},{"id":"407946","messageId":"xmqqpn5dd5dv.fsf@gitster.c.googlers.com","threadId":"54459","inReplyTo":"20201020001103.GB2774782@google.com","subject":"Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-10-20T01:59:24Z","receivedAt":"2020-10-20T01:59:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Emily Shaffer writes:\n\n> On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:\n>> \n>> Hi everyone,\n> Hi Joey and welcome.\n>\n>> \n>> Signed-off-by: JoeyS \n>\n> One thing missed by other commenters: the Developer's Certificate of\n> Origin line - which is what this indicates - should have your \"full\n> name\".\n\n... and it must match the authorship.\n\n> So in my case, I sign my patches 'Emily Shaffer\n> '. If I'm wrong that's fine, but JoeyS sounds\n> like a name and initial rather than a full name.\n\nThanks for pointing it out.\n\nIf somebody from the \"mentoring\" group is taking a tally, it might\nnot be a bad idea to identify which style and procedure rules are\noften failed to be followed by new contributors so that we can\nfigure out ways to make them stand out in our documentation set\n(e.g. Documentation/SubmittingPatches but maybe a separate cheat\nsheet might be worth having).\n\nThanks.\n\n\n"},{"id":"407964","messageId":"O2ACwMmJ8_oj_OrMPF4bGf-9nctJiXbFxJ6yzlWWCob0Zr25aSCOfcCc8pGNukbReQQJi_6igxiEyQT1hWp3ccbY1pJr62Y4eNk097tInP8=@protonmail.com","threadId":"54459","inReplyTo":"xmqqpn5dd5dv.fsf@gitster.c.googlers.com","subject":"Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Joey S","fromEmail":"jgsal@protonmail.com","sentAt":"2020-10-20T07:24:40Z","receivedAt":"2020-10-20T07:24:53Z","isPatch":true,"sender":{"key":"jgsal@protonmail.com","avatar":null},"body":"Hi everyone,\n\nThank you very much for the input and feedback, it's much appreciated.\n\n> All this text above is useful context for reviewers but appears as part\n> of the commit message which is not what you want. If you add notes after\n> the `---` line below then they will not end up in the commit message.\n>\nUnderstood, thank you.\n\n> > Modernized the test by replacing 'test -e' instances with\n> > test_path_is_file helper functions.\n>\n> s/Modernized/Modernize/\nWill do in the amended commit next.\n\n> > - ! test_path_is_file paginated.out\n>\n> It would be better to replace`! test -e` this with\n> `test_path_is_missing` as the modified test will pass if paginated.out\n> exists but is not a file. `test_path_is_missing` will print an\n> appropriate diagnostic message as well.\n\nThank you for the explanation : )\n\nAfter replacing `! test -e` with `! test_path_is_missing paginated.out` however, the changed test cases are failing;\n```\n$ cd t/ && prove t7006-pager.sht7006-pager.sh .. Dubious, test returned 1 (wstat 256, 0x100)\nFailed 3/101 subtests\n\nTest Summary Report\n-------------------\nt7006-pager.sh (Wstat: 256 Tests: 101 Failed: 3)\n Failed tests: 7-9\n Non-zero exit status: 1\nFiles=1, Tests=101, 5 wallclock secs ( 0.03 usr 0.00 sys + 3.49 cusr 0.65 csys = 4.17 CPU)\nResult: FAIL\n```\nIs this the behavior I should be expecting?\n\n\n> ...Alternatively, this would fit just fine in a cover letter. Usually\n> cover letters are not necessary for single patches (where the patch\n> message itself conveys the full message, or a little bit of additional\n> context below the triple-dash line is all that's necessary to clarify\n> the intent). But, if you want to introduce yourself, a 0/1 cover letter\n> is fine, too.\n\nWill keep this in mind, thank you Taylor.\n\n> > One thing missed by other commenters: the Developer's Certificate of\n> > Origin line - which is what this indicates - should have your \"full\n> > name\".\n>\n> ... and it must match the authorship.\n\nChanged, thank you both for catching that.\n\nThank you all,\nJoey\n\n‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐\nOn Monday, October 19, 2020 7:59 PM, Junio C Hamano wrote:\n\n> Emily Shaffer emilyshaffer@google.com writes:\n>\n> > On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:\n> >\n> > > Hi everyone,\n> > > Hi Joey and welcome.\n> >\n> > > Signed-off-by: JoeyS jgsal@yahoo.com\n> >\n> > One thing missed by other commenters: the Developer's Certificate of\n> > Origin line - which is what this indicates - should have your \"full\n> > name\".\n>\n> ... and it must match the authorship.\n>\n> > So in my case, I sign my patches 'Emily Shaffer\n> > emilyshaffer@google.com'. If I'm wrong that's fine, but JoeyS sounds\n> > like a name and initial rather than a full name.\n>\n> Thanks for pointing it out.\n>\n> If somebody from the \"mentoring\" group is taking a tally, it might\n> not be a bad idea to identify which style and procedure rules are\n> often failed to be followed by new contributors so that we can\n> figure out ways to make them stand out in our documentation set\n> (e.g. Documentation/SubmittingPatches but maybe a separate cheat\n> sheet might be worth having).\n>\n> Thanks.\n\n\n"},{"id":"407979","messageId":"0c61c3cc-b6b6-84dc-7e3f-99a41f676e7f@gmail.com","threadId":"54459","inReplyTo":"O2ACwMmJ8_oj_OrMPF4bGf-9nctJiXbFxJ6yzlWWCob0Zr25aSCOfcCc8pGNukbReQQJi_6igxiEyQT1hWp3ccbY1pJr62Y4eNk097tInP8=@protonmail.com","subject":"Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2020-10-20T12:19:04Z","receivedAt":"2020-10-20T12:19:09Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Joey\n\nOn 20/10/2020 08:24, Joey S wrote:\n> Hi everyone,\n> \n> Thank you very much for the input and feedback, it's much appreciated.\n> \n>> All this text above is useful context for reviewers but appears as part\n>> of the commit message which is not what you want. If you add notes after\n>> the `---` line below then they will not end up in the commit message.\n>>\n> Understood, thank you.\n> \n>>> Modernized the test by replacing 'test -e' instances with\n>>> test_path_is_file helper functions.\n>>\n>> s/Modernized/Modernize/\n> Will do in the amended commit next.\n> \n>>> - ! test_path_is_file paginated.out\n>>\n>> It would be better to replace`! test -e` this with\n>> `test_path_is_missing` as the modified test will pass if paginated.out\n>> exists but is not a file. `test_path_is_missing` will print an\n>> appropriate diagnostic message as well.\n> \n> Thank you for the explanation : )\n> \n> After replacing `! test -e` with `! test_path_is_missing paginated.out` however, the changed test cases are failing;\n> ```\n> $ cd t/ && prove t7006-pager.sht7006-pager.sh .. Dubious, test returned 1 (wstat 256, 0x100)\n> Failed 3/101 subtests\n> \n> Test Summary Report\n> -------------------\n> t7006-pager.sh (Wstat: 256 Tests: 101 Failed: 3)\n> Failed tests: 7-9\n> Non-zero exit status: 1\n> Files=1, Tests=101, 5 wallclock secs ( 0.03 usr 0.00 sys + 3.49 cusr 0.65 csys = 4.17 CPU)\n> Result: FAIL\n> ```\n> Is this the behavior I should be expecting?\n\nNo it's not! As one aspect of this process is to help candidates improve \ntheir understanding I'll give you a hint rather than the whole answer. \n`test -e ` checks whether exists and exits 0 if it does and \nthe shell treats an exit code of 0 as success. `!` inverts the \nsuccess/failure of the command that follows it. Using that and looking \nat the definition of test_file_is_missing in t/test-lib-functions.sh see \nif you can fix the conversion so that the tests pass. If you get stuck \ndo let me know and I'll try and help some more.\n\nBest Wishes\n\nPhillip\n\n>> ...Alternatively, this would fit just fine in a cover letter. Usually\n>> cover letters are not necessary for single patches (where the patch\n>> message itself conveys the full message, or a little bit of additional\n>> context below the triple-dash line is all that's necessary to clarify\n>> the intent). But, if you want to introduce yourself, a 0/1 cover letter\n>> is fine, too.\n> \n> Will keep this in mind, thank you Taylor.\n> \n>>> One thing missed by other commenters: the Developer's Certificate of\n>>> Origin line - which is what this indicates - should have your \"full\n>>> name\".\n>>\n>> ... and it must match the authorship.\n> \n> Changed, thank you both for catching that.\n> \n> Thank you all,\n> Joey\n> \n> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐\n> On Monday, October 19, 2020 7:59 PM, Junio C Hamano wrote:\n> \n>> Emily Shaffer emilyshaffer@google.com writes:\n>>\n>>> On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:\n>>>\n>>>> Hi everyone,\n>>>> Hi Joey and welcome.\n>>>\n>>>> Signed-off-by: JoeyS jgsal@yahoo.com\n>>>\n>>> One thing missed by other commenters: the Developer's Certificate of\n>>> Origin line - which is what this indicates - should have your \"full\n>>> name\".\n>>\n>> ... and it must match the authorship.\n>>\n>>> So in my case, I sign my patches 'Emily Shaffer\n>>> emilyshaffer@google.com'. If I'm wrong that's fine, but JoeyS sounds\n>>> like a name and initial rather than a full name.\n>>\n>> Thanks for pointing it out.\n>>\n>> If somebody from the \"mentoring\" group is taking a tally, it might\n>> not be a bad idea to identify which style and procedure rules are\n>> often failed to be followed by new contributors so that we can\n>> figure out ways to make them stand out in our documentation set\n>> (e.g. Documentation/SubmittingPatches but maybe a separate cheat\n>> sheet might be worth having).\n>>\n>> Thanks.\n> \n> \n\n"},{"id":"408002","messageId":"8sVPe0y2NOpCfqcDBmjBK5jJgJdS7FH7InhekygiMy41mgadB9Rim7QaeoT5E_MYdxw52RHKLLdTGQ-2UIkVKMSJlun_AjvR3lUUcNNNHDI=@protonmail.com","threadId":"54459","inReplyTo":"0c61c3cc-b6b6-84dc-7e3f-99a41f676e7f@gmail.com","subject":"Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script","fromName":"Joey S","fromEmail":"jgsal@protonmail.com","sentAt":"2020-10-20T19:33:29Z","receivedAt":"2020-10-20T19:33:40Z","isPatch":true,"sender":{"key":"jgsal@protonmail.com","avatar":null},"body":"Hi Phillip,\n\n> `test -e ` checks whether exists and exits 0 if it does and\n> the shell treats an exit code of 0 as success. `!` inverts the\n> success/failure of the command that follows it. Using that and looking\n> at the definition of test_file_is_missing in t/test-lib-functions.sh see\n> if you can fix the conversion so that the tests pass.\n\nThank you, that makes sense, now the test cases with `! test -e` replaced with `test_path_is_missing paginated.out` all pass.\n\nSending PATCH v2 next.\n\nThank you for your help,\n\nJoey\n\n\n\n‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐\nOn Tuesday, October 20, 2020 6:19 AM, Phillip Wood wrote:\n\n> Hi Joey\n>\n> On 20/10/2020 08:24, Joey S wrote:\n>\n> > Hi everyone,\n> > Thank you very much for the input and feedback, it's much appreciated.\n> >\n> > > All this text above is useful context for reviewers but appears as part\n> > > of the commit message which is not what you want. If you add notes after\n> > > the `---` line below then they will not end up in the commit message.\n> >\n> > Understood, thank you.\n> >\n> > > > Modernized the test by replacing 'test -e' instances with\n> > > > test_path_is_file helper functions.\n> > >\n> > > s/Modernized/Modernize/\n> > > Will do in the amended commit next.\n> >\n> > > > - ! test_path_is_file paginated.out\n> > >\n> > > It would be better to replace`! test -e` this with\n> > > `test_path_is_missing` as the modified test will pass if paginated.out\n> > > exists but is not a file. `test_path_is_missing` will print an\n> > > appropriate diagnostic message as well.\n> >\n> > Thank you for the explanation : )\n> > After replacing `! test -e` with `! test_path_is_missing paginated.out` however, the changed test cases are failing;\n> >\n> > $ cd t/ && prove t7006-pager.sht7006-pager.sh .. Dubious, test returned 1 (wstat 256, 0x100)\n> > Failed 3/101 subtests\n> >\n> > Test Summary Report\n> > -------------------\n> > t7006-pager.sh (Wstat: 256 Tests: 101 Failed: 3)\n> > Failed tests: 7-9\n> > Non-zero exit status: 1\n> > Files=1, Tests=101, 5 wallclock secs ( 0.03 usr 0.00 sys + 3.49 cusr 0.65 csys = 4.17 CPU)\n> > Result: FAIL\n> >\n> >\n> > Is this the behavior I should be expecting?\n>\n> No it's not! As one aspect of this process is to help candidates improve\n> their understanding I'll give you a hint rather than the whole answer.\n> `test -e ` checks whether exists and exits 0 if it does and\n> the shell treats an exit code of 0 as success. `!` inverts the\n> success/failure of the command that follows it. Using that and looking\n> at the definition of test_file_is_missing in t/test-lib-functions.sh see\n> if you can fix the conversion so that the tests pass. If you get stuck\n> do let me know and I'll try and help some more.\n>\n> Best Wishes\n>\n> Phillip\n>\n> > > ...Alternatively, this would fit just fine in a cover letter. Usually\n> > > cover letters are not necessary for single patches (where the patch\n> > > message itself conveys the full message, or a little bit of additional\n> > > context below the triple-dash line is all that's necessary to clarify\n> > > the intent). But, if you want to introduce yourself, a 0/1 cover letter\n> > > is fine, too.\n> >\n> > Will keep this in mind, thank you Taylor.\n> >\n> > > > One thing missed by other commenters: the Developer's Certificate of\n> > > > Origin line - which is what this indicates - should have your \"full\n> > > > name\".\n> > >\n> > > ... and it must match the authorship.\n> >\n> > Changed, thank you both for catching that.\n> > Thank you all,\n> > Joey\n> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐\n> > On Monday, October 19, 2020 7:59 PM, Junio C Hamano gitster@pobox.com wrote:\n> >\n> > > Emily Shaffer emilyshaffer@google.com writes:\n> > >\n> > > > On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:\n> > > >\n> > > > > Hi everyone,\n> > > > > Hi Joey and welcome.\n> > > >\n> > > > > Signed-off-by: JoeyS jgsal@yahoo.com\n> > > >\n> > > > One thing missed by other commenters: the Developer's Certificate of\n> > > > Origin line - which is what this indicates - should have your \"full\n> > > > name\".\n> > >\n> > > ... and it must match the authorship.\n> > >\n> > > > So in my case, I sign my patches 'Emily Shaffer\n> > > > emilyshaffer@google.com'. If I'm wrong that's fine, but JoeyS sounds\n> > > > like a name and initial rather than a full name.\n> > >\n> > > Thanks for pointing it out.\n> > > If somebody from the \"mentoring\" group is taking a tally, it might\n> > > not be a bad idea to identify which style and procedure rules are\n> > > often failed to be followed by new contributors so that we can\n> > > figure out ways to make them stand out in our documentation set\n> > > (e.g. Documentation/SubmittingPatches but maybe a separate cheat\n> > > sheet might be worth having).\n> > > Thanks.\n\n\n"}]}