{"thread":{"id":"54447","subject":"[PATCH 1/1] Microproject - Use debug-friendly test_path_is_* functions.","startedAt":"2020-10-17T06:02:16Z","lastAt":"2020-10-17T07:19:19Z","messageCount":4,"participants":["Caleb Tillman","Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"407784","messageId":"20201017024353.189792-2-caleb.tillman@gmail.com","threadId":"54447","inReplyTo":"20201017024353.189792-1-caleb.tillman@gmail.com","subject":"[PATCH 1/1] Microproject - Use debug-friendly test_path_is_* functions.","fromName":"Caleb Tillman","fromEmail":"caleb.tillman@gmail.com","sentAt":"2020-10-17T02:43:53Z","receivedAt":"2020-10-17T06:02:16Z","isPatch":true,"sender":{"key":"caleb.tillman@gmail.com","avatar":null},"body":"t0000-basic.sh - Replace an instance of test -f with test_path_is_file.\n\nSigned-off-by: Caleb Tillman \n---\n t/t0000-basic.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t0000-basic.sh b/t/t0000-basic.sh\nindex 923281af93..eb99892a87 100755\n--- a/t/t0000-basic.sh\n+++ b/t/t0000-basic.sh\n@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '\n test_expect_success 'git read-tree followed by write-tree should be idempotent' '\n \trm -f .git/index &&\n \tgit read-tree $tree &&\n-\ttest -f .git/index &&\n+\ttest_path_is_file .git/index &&\n \tnewtree=$(git write-tree) &&\n \ttest \"$newtree\" = \"$tree\"\n '\n-- \n2.25.1\n\n"},{"id":"407785","messageId":"20201017024353.189792-1-caleb.tillman@gmail.com","threadId":"54447","inReplyTo":null,"subject":"[Outreachy] [PATCH 0/1]","fromName":"Caleb Tillman","fromEmail":"caleb.tillman@gmail.com","sentAt":"2020-10-17T02:43:52Z","receivedAt":"2020-10-17T06:02:17Z","isPatch":true,"sender":{"key":"caleb.tillman@gmail.com","avatar":null},"body":"*** BLURB HERE ***\n\nCaleb Tillman (1):\n Microproject - Use debug-friendly test_path_is_* functions.\n\n t/t0000-basic.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n-- \n2.25.1\n\nMicroproject for Outreachy. Replace test -f with test_path_is_file in t/t0000-basic.sh.\n"},{"id":"407787","messageId":"CAP8UFD3=pByaH-bFFo8VVSqt_NVPwpHLx0RQyCDwfWV8OL7TRw@mail.gmail.com","threadId":"54447","inReplyTo":"20201017024353.189792-1-caleb.tillman@gmail.com","subject":"Re: [Outreachy] [PATCH 0/1]","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2020-10-17T06:43:59Z","receivedAt":"2020-10-17T06:44:14Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Sat, Oct 17, 2020 at 8:06 AM Caleb Tillman wrote:\n>\n> *** BLURB HERE ***\n\nCover letters like this are about giving context for a series of\npatches. As there is only one patch (1/1) in the series, the context\nin the patch itself should suffice, so there is no real need for a\ncover letter like this if there is only one patch.\n\nWhen there is a real need for a cover letter though, the title of the\ncover letter should explain what the patch series is about and \"***\nBLURB HERE ***\" in the body of the cover letter should be replaced by\ntext that explains the context and the reason for the patch series.\n\nThanks!\n"},{"id":"407788","messageId":"CAP8UFD2RS-sdaA8tJjqGW=L=_DM0QOZT-pg9D1oL8LEk7Cc84w@mail.gmail.com","threadId":"54447","inReplyTo":"20201017024353.189792-2-caleb.tillman@gmail.com","subject":"Re: [PATCH 1/1] Microproject - Use debug-friendly test_path_is_* functions.","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2020-10-17T07:19:05Z","receivedAt":"2020-10-17T07:19:19Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Sat, Oct 17, 2020 at 8:05 AM Caleb Tillman wrote:\n>\n> t0000-basic.sh - Replace an instance of test -f with test_path_is_file.\n\nThis line seems redundant with the subject.\n\nWe suggest that all the messages sent by Outreachy applicants or\ninterns have \"[Outreachy]\" at the beginning of their subject. This way\nwe can identify these emails more easily and prioritize them. Also\nusing \"[...]\" ensures that \"Outreachy\" doesn't appear in the commits\nwhen the patches are applied.\n\nFor Outreachy patches related to a test script, we suggest a subject like:\n\n[Outreachy][PATCH X/Y] tZZZZ: do something\n\nwhere X, Y and ZZZZ are numbers and tZZZZ is the identifier of the test script.\n\nSo in this case the subject should be something like:\n\n[Outreachy][PATCH 1/1] t0000: replace an instance of test -f with\ntest_path_is_file\n\nNote that there is no \"Microproject\" in the subject and that there is\nno uppercase letter used after \"PATCH\".\n\nThe body of the message should explain the reason or the goal of the\npatch. Here the reason is that test_path_is_file provides an\n(hopefully helpful) error message when it fails, so it should make the\nreason for a test failure easier to diagnose.\n\n> Signed-off-by: Caleb Tillman \n> ---\n\nHere, after the line with \"---\" and before the stats below, you can\nadd comments that will not appear in the commit message when the patch\nwill be applied. For example here you can say that the patch is your\nmicroproject.\n\nIf you really want to make it more prominent, another option is to use\n[Outreachy-Microproject] in the subject instead of [Outreachy] but it\nmakes the subject line longer for information that we are anyway not\nlikely to miss.\n\n> t/t0000-basic.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh\n> index 923281af93..eb99892a87 100755\n> --- a/t/t0000-basic.sh\n> +++ b/t/t0000-basic.sh\n> @@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '\n> test_expect_success 'git read-tree followed by write-tree should be idempotent' '\n> rm -f .git/index &&\n> git read-tree $tree &&\n> - test -f .git/index &&\n> + test_path_is_file .git/index &&\n> newtree=$(git write-tree) &&\n> test \"$newtree\" = \"$tree\"\n> '\n\nThis looks good to me.\n\nThanks!\n"}]}