{"thread":{"id":"54420","subject":"BUG: git rebase shows different commit message","startedAt":"2020-10-14T17:18:39Z","lastAt":"2020-10-15T07:37:05Z","messageCount":3,"participants":["Eugen Konkov","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"407529","messageId":"703071109.20201014201106@yandex.ru","threadId":"54420","inReplyTo":null,"subject":"BUG: git rebase shows different commit message","fromName":"Eugen Konkov","fromEmail":"kes-kes@yandex.ru","sentAt":"2020-10-14T17:11:06Z","receivedAt":"2020-10-14T17:18:39Z","isPatch":false,"sender":{"key":"kes-kes@yandex.ru","avatar":null},"body":"Hello Git,\n\nHow to reproduce: do commit message with leading space:\n\n$git log --graph --decorate --pretty=oneline --abbrev-commit\n* 093010ea (local/dev) Change column 'Label' => 'OPFG' and added column 'comment'\n* 86221a47  Updated OpenAPI schema according to SCHEMA 193\n* 6202eb08 Added opfg.html\n\n$git rebase -i --autostash --rebase-merges 86221a47^\nlabel onto\n\nreset onto\npick 86221a47 Updated OpenAPI schema according to SCHEMA 193\npick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'\n\nHere commit message is shown without leading space.\nI  think  that this is wrong. Because if space was shown then I reword\ncommit message\n\nr 86221a47 Updated OpenAPI schema according to SCHEMA 193\npick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'\n\nbut now I just do not see that I shold reword it =(\n\nTODO: Display commit message as is\n\n-- \nBest regards,\nEugen Konkov\n\n"},{"id":"407535","messageId":"CAPc5daVAJxfZVz0HwTFwhq-EfERrESU2Ta6-0fAyXrzf3YJREg@mail.gmail.com","threadId":"54420","inReplyTo":"703071109.20201014201106@yandex.ru","subject":"Re: BUG: git rebase shows different commit message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-10-14T17:55:45Z","receivedAt":"2020-10-14T17:56:03Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"> $git log --graph --decorate --pretty=oneline --abbrev-commit\n> * 093010ea (local/dev) Change column 'Label' => 'OPFG' and added column 'comment'\n> * 86221a47  Updated OpenAPI schema according to SCHEMA 193\n> * 6202eb08 Added opfg.html\n>\n> $git rebase -i --autostash --rebase-merges 86221a47^\n> label onto\n>\n> reset onto\n> pick 86221a47 Updated OpenAPI schema according to SCHEMA 193\n> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'\n>\n> Here commit message is shown without leading space.\n> I  think  that this is wrong. Because if space was shown then I reword\n> commit message\n>\n> r 86221a47 Updated OpenAPI schema according to SCHEMA 193\n> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'\n>\n> but now I just do not see that I shold reword it =(\n\nThese one-line titles are shown to help you identify the commit to futz with,\nnot to help you review them. After all, you see only titles here\nwithout the body\nof the log message [*1*].\n\nBesides, if the \"breakage\" in the title were not just an extra\nwhitespace but some\ncontrol characters that take the terminal into an insane state, we\nshould sanitize\nthe title we'd show here for identification purposes, so \"show the\ntitle as-is\" is not\na good idea to begin with.\n\nSo, NAK.\n\n[Footnote]\n*1* ... and if majority of your commits have a single-liner titles, I cannot\nimagine how these logs can be useful to its consumers (i.e. those who\nuse \"git show\" after identifying an old commit that broke things using\n\"git bisect\" or \"git blame\").\n\nA leading whitespace in such a \"git log\" output would be the least of your\nproblems in such a history, I would have to say.\n"},{"id":"407584","messageId":"858416875.20201015103656@yandex.ru","threadId":"54420","inReplyTo":"CAPc5daVAJxfZVz0HwTFwhq-EfERrESU2Ta6-0fAyXrzf3YJREg@mail.gmail.com","subject":"Re: BUG: git rebase shows different commit message","fromName":"Eugen Konkov","fromEmail":"kes-kes@yandex.ru","sentAt":"2020-10-15T07:36:56Z","receivedAt":"2020-10-15T07:37:05Z","isPatch":false,"sender":{"key":"kes-kes@yandex.ru","avatar":null},"body":"Hello Junio,\n\n>>>These one-line titles are shown to help you identify the commit to futz with,\n>>>not to help you review them.\n\nIt  would  be  better, if these one-line titles also help me to review them.\n\n>>> but some control characters that take the terminal into an insane state, we\n>>> should sanitize the title we'd show here for identification purposes,\nI expect they are sanitized in **same way** as it done for `git log ...`\n\n>>> so \"show the title as-is\" is not\nSo  it  would  be better if it was shown same as `git log ...` display them\n\nand sorry, \"as is\" was bad word. I mean if in different places is used\nsame  formatting,  so  **result should be same**.\nI do not expect that commit messages are differ\n\nThank you.\n\nWednesday, October 14, 2020, 8:55:45 PM, you wrote:\n\n>> $git log --graph --decorate --pretty=oneline --abbrev-commit\n>> * 093010ea (local/dev) Change column 'Label' => 'OPFG' and added column 'comment'\n>> * 86221a47  Updated OpenAPI schema according to SCHEMA 193\n>> * 6202eb08 Added opfg.html\n>>\n>> $git rebase -i --autostash --rebase-merges 86221a47^\n>> label onto\n>>\n>> reset onto\n>> pick 86221a47 Updated OpenAPI schema according to SCHEMA 193\n>> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'\n>>\n>> Here commit message is shown without leading space.\n>> I  think  that this is wrong. Because if space was shown then I reword\n>> commit message\n>>\n>> r 86221a47 Updated OpenAPI schema according to SCHEMA 193\n>> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'\n>>\n>> but now I just do not see that I shold reword it =(\n\n> These one-line titles are shown to help you identify the commit to futz with,\n> not to help you review them. After all, you see only titles here\n> without the body\n> of the log message [*1*].\n\n> Besides, if the \"breakage\" in the title were not just an extra\n> whitespace but some\n> control characters that take the terminal into an insane state, we\n> should sanitize\n> the title we'd show here for identification purposes, so \"show the\n> title as-is\" is not\n> a good idea to begin with.\n\n> So, NAK.\n\n> [Footnote]\n> *1* ... and if majority of your commits have a single-liner titles, I cannot\n> imagine how these logs can be useful to its consumers (i.e. those who\n> use \"git show\" after identifying an old commit that broke things using\n> \"git bisect\" or \"git blame\").\n\n> A leading whitespace in such a \"git log\" output would be the least of your\n> problems in such a history, I would have to say.\n\n\n\n-- \nBest regards,\nEugen Konkov\n\n"}]}