{"thread":{"id":"54401","subject":"Re: Patchwork now does the right thing with GGG submissions","startedAt":"2020-10-12T19:38:55Z","lastAt":"2020-10-12T21:31:12Z","messageCount":4,"participants":["Jonathan Nieder","Junio C Hamano","Konstantin Ryabitsev"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"407373","messageId":"20201012193850.GE3740546@google.com","threadId":"54401","inReplyTo":"20201012180034.tu4rmeoadhy5j4w7@chatter.i7.local","subject":"Re: Patchwork now does the right thing with GGG submissions","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2020-10-12T19:38:50Z","receivedAt":"2020-10-12T19:38:55Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Konstantin Ryabitsev wrote:\n\n> Just FYI, I made the necessary tweaks to patchwork to make it properly\n> assign \"From\" for gitgitgadget submissions:\n>\n> https://patchwork.kernel.org/patch/11832689/\n\n\\o/ Thanks much for this.\n\nFor the curious, any links to the change behind the scenes that made\nthat happens? Does it use Sender[1] or a different field? Does the\nchange live in [2] or [3]?\n\nSincerely,\nJonathan\n\n[1] https://lore.kernel.org/git/xmqqiml4bsra.fsf@gitster-ct.c.googlers.com/\n[2] https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/\n[3] https://github.com/getpatchwork/patchwork\n"},{"id":"407387","messageId":"xmqq362jnpuw.fsf@gitster.c.googlers.com","threadId":"54401","inReplyTo":"20201012193850.GE3740546@google.com","subject":"Re: Patchwork now does the right thing with GGG submissions","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-10-12T20:36:39Z","receivedAt":"2020-10-12T20:36:45Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> Konstantin Ryabitsev wrote:\n>\n>> Just FYI, I made the necessary tweaks to patchwork to make it properly\n>> assign \"From\" for gitgitgadget submissions:\n>>\n>> https://patchwork.kernel.org/patch/11832689/\n>\n> \\o/ Thanks much for this.\n>\n> For the curious, any links to the change behind the scenes that made\n> that happens? Does it use Sender[1] or a different field? Does the\n> change live in [2] or [3]?\n>\n> Sincerely,\n> Jonathan\n\nIt is curious that I sometimes see you respond to Konstantin on this\nlist, but the message you are responding to is not found. What is\ngoing on?\n\nA question to Konstantin is what is so special about GGG? Did you\nmake patchwork to pay attention to the in-body \"From:\" and other\nin-body header lines (in which case it benefits not just GGG but\neverybody). If you added a support to ignore everything before the\nscissors that would deserve an extra gold star ;-)\n\nFor example, how does\n\nhttps://lore.kernel.org/git/xmqqy2kwiimi.fsf@gitster.c.googlers.com/\n\nappear in patchwork?\n\n> [1] https://lore.kernel.org/git/xmqqiml4bsra.fsf@gitster-ct.c.googlers.com/\n> [2] https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/\n> [3] https://github.com/getpatchwork/patchwork\n"},{"id":"407394","messageId":"20201012212736.vb7qq3hcdkdnqvnq@chatter.i7.local","threadId":"54401","inReplyTo":"xmqq362jnpuw.fsf@gitster.c.googlers.com","subject":"Re: Patchwork now does the right thing with GGG submissions","fromName":"Konstantin Ryabitsev","fromEmail":"konstantin@linuxfoundation.org","sentAt":"2020-10-12T21:27:36Z","receivedAt":"2020-10-12T21:27:41Z","isPatch":false,"sender":{"key":"konstantin@linuxfoundation.org","avatar":"https://gravatar.com/avatar/7cb8827c6de56e1bd2dea16508c6708aa43feed3bf3813bcdacecdf96ceadd79?d=mp&s=160"},"body":"On Mon, Oct 12, 2020 at 01:36:39PM -0700, Junio C Hamano wrote:\n> >> Just FYI, I made the necessary tweaks to patchwork to make it \n> >> properly\n> >> assign \"From\" for gitgitgadget submissions:\n> >>\n> >> https://patchwork.kernel.org/patch/11832689/\n> >\n> > \\o/ Thanks much for this.\n> >\n> > For the curious, any links to the change behind the scenes that made\n> > that happens? Does it use Sender[1] or a different field? Does the\n> > change live in [2] or [3]?\n> >\n> > Sincerely,\n> > Jonathan\n> \n> It is curious that I sometimes see you respond to Konstantin on this\n> list, but the message you are responding to is not found. What is\n> going on?\n\nI initially didn't send it to git@vger, only to Jonathan. :) I don't \nmind, though -- I just wasn't sure if this was something others on the \ngit list would care about.\n\n> A question to Konstantin is what is so special about GGG? Did you\n> make patchwork to pay attention to the in-body \"From:\" and other\n> in-body header lines (in which case it benefits not just GGG but\n> everybody). If you added a support to ignore everything before the\n> scissors that would deserve an extra gold star ;-)\n\nNo, this is specifically for GGG mail, as it's a very specific \nwell-understood case. The solution I have in place is to just pay \nattention to the in-body Form, but once we upgrade to patchwork 2.2.2 \ntomorrow, we will also start paying attention to the X-Original-From \nheader.\n\nI'm not 100% sure if it's always correct to pay attention to the in-body \nFrom -- at least for the purposes of patchwork. Patchwork pays attention \nto \"who submitted the series,\" not \"who authored the commit,\" so making \nin-body From always be the \"From\" in patchwork would be wrong.\n\nFor the cases of GGG, we can ignore this difference, as we definitely \ndon't want to pay attention to \"who sent the patch\" (it's always \ngitgitgadget@gmail.com). However, GGG can make the situation more \ncorrect if it starts adding an X-Original-From that would be the Github \nname and email of the person submitting the pull request. E.g.:\n\nFrom: D. Eveloper via GitGitGadget <- DMARC From\nX-Original-From: D. Eveloper <- Patchwork From\nSubject: [PATCH 1/10] ...\n\nFrom: A. Nother-Person <- Git From\n\n> For example, how does\n> \n> https://lore.kernel.org/git/xmqqy2kwiimi.fsf@gitster.c.googlers.com/\n> \n> appear in patchwork?\n\nIt's a reply to another patch, so patchwork only processes it as a \ncomment. Generally, patchwork doesn't see worrying about this thing as \nits job -- it just wants to let maintainers track incoming patches and \nseries and download them in a format that is easy to apply using \"git \nam\". For that matter, that's how b4 approaches this as well.\n\n-K\n"},{"id":"407395","messageId":"20201012213107.ad3j2wetrfs62pvp@chatter.i7.local","threadId":"54401","inReplyTo":"20201012193850.GE3740546@google.com","subject":"Re: Patchwork now does the right thing with GGG submissions","fromName":"Konstantin Ryabitsev","fromEmail":"konstantin@linuxfoundation.org","sentAt":"2020-10-12T21:31:07Z","receivedAt":"2020-10-12T21:31:12Z","isPatch":false,"sender":{"key":"konstantin@linuxfoundation.org","avatar":"https://gravatar.com/avatar/7cb8827c6de56e1bd2dea16508c6708aa43feed3bf3813bcdacecdf96ceadd79?d=mp&s=160"},"body":"On Mon, Oct 12, 2020 at 12:38:50PM -0700, Jonathan Nieder wrote:\n> > Just FYI, I made the necessary tweaks to patchwork to make it \n> > properly\n> > assign \"From\" for gitgitgadget submissions:\n> >\n> > https://patchwork.kernel.org/patch/11832689/\n> \n> \\o/ Thanks much for this.\n> \n> For the curious, any links to the change behind the scenes that made\n> that happens? Does it use Sender[1] or a different field? Does the\n> change live in [2] or [3]?\n\nSee my other email explaining how it's implemented. As to where it lives \n-- it's implemented as a procmail rule:\n\n:0\n* ^From: .*\n{\n :0 bw\n INBODYFROM=| formail -xfrom:\n\n :0 hfw\n * INBODYFROM ?? .\n | formail -I \"From:$INBODYFROM\"\n}\n\nCurrently, we fully blow away the From:, but after the 2.2.2 upgrade \nwe'll be setting it as X-Original-From if we don't find one already \npresent.\n\nIt's my goal to start publishing these procmail rules as part of a git \nrepo in the future, so you'll be able to see all rules that are applied \nto incoming mail before we pass it along for patchwork processing.\n\nBest regards,\n-K\n"}]}