{"thread":{"id":"54361","subject":"[PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild","startedAt":"2020-10-07T08:17:57Z","lastAt":"2020-10-07T12:50:01Z","messageCount":2,"participants":["Johannes Schindelin via GitGitGadget","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"407039","messageId":"pull.744.git.1602058669919.gitgitgadget@gmail.com","threadId":"54361","inReplyTo":null,"subject":"[PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-10-07T08:17:49Z","receivedAt":"2020-10-07T08:17:57Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nIt is the custom to follow minor updates of GitHub Actions\nautomatically, by using the suffix `@v1`. Actions' maintainers will then\nupdate that `v1` ref to point to the newest.\n\nHowever, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure\nGitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0`\nsuffix.\n\nIn this instance, that is a problem: should `setup-msbuild` release a\nnew version that intends to fix a critical bug, we won't know it, and we\nwon't use it.\n\nSuch a scenario is not theoretical. It is happening right now:\nhttps://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands\n\nLet's simplify our setup, allowing us to benefit from automatically\nusing the newest v1.x.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    GitHub workflow: automatically follow minor updates of setup-msbuild\n    \n    This patch was based on dd/ci-swap-azure-pipelines-with-github-actions,\n    but due to changes outside of Git, that GitHub workflow does not even\n    begin to work anymore. Therefore, the patch is now actually based on \n    master.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-744%2Fdscho%2Fsimplify-setup-msbuild-upgrades-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-744/dscho/simplify-setup-msbuild-upgrades-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/744\n\n .github/workflows/main.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex fcfd138ff1..14ff94dcbe 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -154,7 +154,7 @@ jobs:\n         Expand-Archive compat.zip -DestinationPath . -Force\n         Remove-Item compat.zip\n     - name: add msbuild to PATH\n-      uses: microsoft/setup-msbuild@v1.0.0\n+      uses: microsoft/setup-msbuild@v1\n     - name: copy dlls to root\n       shell: powershell\n       run: |\n\nbase-commit: d98273ba77e1ab9ec755576bc86c716a97bf59d7\n-- \ngitgitgadget\n"},{"id":"407049","messageId":"20201007124957.GA123549@coredump.intra.peff.net","threadId":"54361","inReplyTo":"pull.744.git.1602058669919.gitgitgadget@gmail.com","subject":"Re: [PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2020-10-07T12:49:57Z","receivedAt":"2020-10-07T12:50:01Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Oct 07, 2020 at 08:17:49AM +0000, Johannes Schindelin via GitGitGadget wrote:\n\n> It is the custom to follow minor updates of GitHub Actions\n> automatically, by using the suffix `@v1`. Actions' maintainers will then\n> update that `v1` ref to point to the newest.\n> \n> However, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure\n> GitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0`\n> suffix.\n> \n> In this instance, that is a problem: should `setup-msbuild` release a\n> new version that intends to fix a critical bug, we won't know it, and we\n> won't use it.\n> \n> Such a scenario is not theoretical. It is happening right now:\n> https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands\n> \n> Let's simplify our setup, allowing us to benefit from automatically\n> using the newest v1.x.\n\nThanks, that explanation makes perfect sense and the patch looks\nobviously correct.\n\n-Peff\n"}]}