{"thread":{"id":"54318","subject":"git commit-tree does not honor commit.gpgSign config","startedAt":"2020-09-28T16:21:55Z","lastAt":"2020-09-28T23:14:27Z","messageCount":4,"participants":["Evan Grim","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"406542","messageId":"CABX4Un0NQV1wkx-AKTFs12agLiBLEe+Y_FDHgQwgxUT=wnFDmA@mail.gmail.com","threadId":"54318","inReplyTo":null,"subject":"git commit-tree does not honor commit.gpgSign config","fromName":"Evan Grim","fromEmail":"evangrim@gmail.com","sentAt":"2020-09-28T16:21:42Z","receivedAt":"2020-09-28T16:21:55Z","isPatch":false,"sender":{"key":"evangrim@gmail.com","avatar":null},"body":"Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`\nconfiguration option?\n\nI'm considering working up a patch to fix this, but want a quick check\nfrom more knowledgeable sources first on what the desired behavior is.\n"},{"id":"406553","messageId":"xmqqd025n3ik.fsf@gitster.c.googlers.com","threadId":"54318","inReplyTo":"CABX4Un0NQV1wkx-AKTFs12agLiBLEe+Y_FDHgQwgxUT=wnFDmA@mail.gmail.com","subject":"Re: git commit-tree does not honor commit.gpgSign config","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-09-28T18:46:11Z","receivedAt":"2020-09-28T18:46:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Evan Grim <evangrim@gmail.com> writes:\n\n> Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`\n> configuration option?\n\nIt would be a bug if it did, as a low level plumbing tool to build\nscripts around, it would not want its behaviour to be affected by\nend-user configuration (rather, scripts that are written using these\nplumbing command do want to handle end-user customization their own\nways).\n"},{"id":"406562","messageId":"CABX4Un3euDWeGr_2DegS3xyoD8VJ23rb9+bj3hBkWS6KZH9FhA@mail.gmail.com","threadId":"54318","inReplyTo":"xmqqd025n3ik.fsf@gitster.c.googlers.com","subject":"Re: git commit-tree does not honor commit.gpgSign config","fromName":"Evan Grim","fromEmail":"evangrim@gmail.com","sentAt":"2020-09-28T19:42:43Z","receivedAt":"2020-09-28T19:42:57Z","isPatch":false,"sender":{"key":"evangrim@gmail.com","avatar":null},"body":"Thank you for that context.  I came across this when I used\n`git-subtree` and was surprised the commits it created weren't signed.\nWould it be appropriate to look into patching `git-subtree` to honor\nthe configuration option?\n\nOn Mon, Sep 28, 2020 at 12:46 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> Evan Grim <evangrim@gmail.com> writes:\n>\n> > Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`\n> > configuration option?\n>\n> It would be a bug if it did, as a low level plumbing tool to build\n> scripts around, it would not want its behaviour to be affected by\n> end-user configuration (rather, scripts that are written using these\n> plumbing command do want to handle end-user customization their own\n> ways).\n"},{"id":"406586","messageId":"xmqqlfgtjzoz.fsf@gitster.c.googlers.com","threadId":"54318","inReplyTo":"CABX4Un3euDWeGr_2DegS3xyoD8VJ23rb9+bj3hBkWS6KZH9FhA@mail.gmail.com","subject":"Re: git commit-tree does not honor commit.gpgSign config","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-09-28T22:37:00Z","receivedAt":"2020-09-28T23:14:27Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Evan Grim <evangrim@gmail.com> writes:\n\n> On Mon, Sep 28, 2020 at 12:46 PM Junio C Hamano <gitster@pobox.com> wrote:\n>>\n>> Evan Grim <evangrim@gmail.com> writes:\n>>\n>> > Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`\n>> > configuration option?\n>>\n>> It would be a bug if it did, as a low level plumbing tool to build\n>> scripts around, it would not want its behaviour to be affected by\n>> end-user configuration (rather, scripts that are written using these\n>> plumbing command do want to handle end-user customization their own\n>> ways).\n>\n> Thank you for that context.  I came across this when I used\n> `git-subtree` and was surprised the commits it created weren't signed.\n> Would it be appropriate to look into patching `git-subtree` to honor\n> the configuration option?\n\nYes, the script that invokes \"commit-tree\" is at the right layer to\nnotice commit.gpgsign and possibly $name_of_the_script.gpgsign\nconfiguration variable(s) and add the -S option, I would think.\n\nI do not know if there are people who are still using, or who is\nmaintaining, the \"subtree\" script, though.\n\nThanks.\n\n\n"}]}