{"thread":{"id":"54312","subject":"[PATCH] config/fmt-merge-msg.txt: drop space in quote","startedAt":"2020-09-27T14:01:13Z","lastAt":"2020-09-27T18:15:39Z","messageCount":2,"participants":["Martin Ågren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"406496","messageId":"20200927140045.9668-1-martin.agren@gmail.com","threadId":"54312","inReplyTo":null,"subject":"[PATCH] config/fmt-merge-msg.txt: drop space in quote","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2020-09-27T14:00:45Z","receivedAt":"2020-09-27T14:01:13Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"We document how `merge.suppressDest` can be used to omit \" into <branch\nname>\" from the title of the merge message. It is true that we omit the\nspace character before \"into\", but that lone double quote character\nrisks ending up on the wrong side of a line break, looking a bit out of\nplace. This currently happens with, e.g., 80-character terminals.\n\nDrop that leading quoted space. The result should be just as clear about\nhow this option affects the formatted message.\n\nSigned-off-by: Martin Ågren <martin.agren@gmail.com>\n---\n On jc/fmt-merge-msg-suppress-destination.\n\n Documentation/config/fmt-merge-msg.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config/fmt-merge-msg.txt b/Documentation/config/fmt-merge-msg.txt\nindex a8e8f74d0a..3fbf40e24f 100644\n--- a/Documentation/config/fmt-merge-msg.txt\n+++ b/Documentation/config/fmt-merge-msg.txt\n@@ -13,7 +13,7 @@ merge.suppressDest::\n \tBy adding a glob that matches the names of integration\n \tbranches to this multi-valued configuration variable, the\n \tdefault merge message computed for merges into these\n-\tintegration branches will omit \" into <branch name>\" from\n+\tintegration branches will omit \"into <branch name>\" from\n \tits title.\n +\n An element with an empty value can be used to clear the list\n-- \n2.28.0.277.g9b3c35fffd\n\n"},{"id":"406506","messageId":"xmqqk0wfgk6x.fsf@gitster.c.googlers.com","threadId":"54312","inReplyTo":"20200927140045.9668-1-martin.agren@gmail.com","subject":"Re: [PATCH] config/fmt-merge-msg.txt: drop space in quote","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-09-27T18:15:34Z","receivedAt":"2020-09-27T18:15:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Ågren <martin.agren@gmail.com> writes:\n\n> We document how `merge.suppressDest` can be used to omit \" into <branch\n> name>\" from the title of the merge message. It is true that we omit the\n> space character before \"into\", but that lone double quote character\n> risks ending up on the wrong side of a line break, looking a bit out of\n> place. This currently happens with, e.g., 80-character terminals.\n\nThe above correctly describes why the current text is written the\nway it is.  The rationale for the change described above looks quite\nsensible.\n\nThanks.\n\n\n>\n> Drop that leading quoted space. The result should be just as clear about\n> how this option affects the formatted message.\n>\n> Signed-off-by: Martin Ågren <martin.agren@gmail.com>\n> ---\n>  On jc/fmt-merge-msg-suppress-destination.\n>\n>  Documentation/config/fmt-merge-msg.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/config/fmt-merge-msg.txt b/Documentation/config/fmt-merge-msg.txt\n> index a8e8f74d0a..3fbf40e24f 100644\n> --- a/Documentation/config/fmt-merge-msg.txt\n> +++ b/Documentation/config/fmt-merge-msg.txt\n> @@ -13,7 +13,7 @@ merge.suppressDest::\n>  \tBy adding a glob that matches the names of integration\n>  \tbranches to this multi-valued configuration variable, the\n>  \tdefault merge message computed for merges into these\n> -\tintegration branches will omit \" into <branch name>\" from\n> +\tintegration branches will omit \"into <branch name>\" from\n>  \tits title.\n>  +\n>  An element with an empty value can be used to clear the list\n"}]}