{"thread":{"id":"54251","subject":"[PATCH] remote: in case of error don't show success message.","startedAt":"2020-09-17T15:29:58Z","lastAt":"2020-09-17T18:39:42Z","messageCount":2,"participants":["Christian Schlack via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"405760","messageId":"pull.848.git.git.1600356459092.gitgitgadget@gmail.com","threadId":"54251","inReplyTo":null,"subject":"[PATCH] remote: in case of error don't show success message.","fromName":"Christian Schlack via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-09-17T15:27:38Z","receivedAt":"2020-09-17T15:29:58Z","isPatch":true,"sender":{"key":"name:Christian Schlack","avatar":null},"body":"From: Christian Schlack <christian@backhub.co>\n\nSuppress the message 'origin/HEAD set to master' in case of an error.\n\n  $ git remote set-head origin -a\n  error: Not a valid ref: refs/remotes/origin/master\n  origin/HEAD set to master\n\nSigned-off-by: Christian Schlack <christian@backhub.co>\n---\n    remote: in case of error don't show success message.\n    \n    Expected behaviour\n    \n    $ git remote set-head origin -a\n    error: Not a valid ref: refs/remotes/origin/master\n    \n    Actual behaviour\n    \n    $ git remote set-head origin -a\n    error: Not a valid ref: refs/remotes/origin/master\n    origin/HEAD set to master\n    \n    I believe ... set to master should not be shown in case of an error.\n    That's why I added an else to the if-condition.\n    \n    Signed-off-by: Christian Schlack christian@backhub.co\n    [christian@backhub.co]\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-848%2Fcschlack%2Fremote-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-848/cschlack/remote-v1\nPull-Request: https://github.com/git/git/pull/848\n\n builtin/remote.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/remote.c b/builtin/remote.c\nindex 542f56e387..64b4b551eb 100644\n--- a/builtin/remote.c\n+++ b/builtin/remote.c\n@@ -1356,7 +1356,7 @@ static int set_head(int argc, const char **argv)\n \t\t\tresult |= error(_(\"Not a valid ref: %s\"), buf2.buf);\n \t\telse if (create_symref(buf.buf, buf2.buf, \"remote set-head\"))\n \t\t\tresult |= error(_(\"Could not setup %s\"), buf.buf);\n-\t\tif (opt_a)\n+\t\telse if (opt_a)\n \t\t\tprintf(\"%s/HEAD set to %s\\n\", argv[0], head_name);\n \t\tfree(head_name);\n \t}\n\nbase-commit: 54e85e7af1ac9e9a92888060d6811ae767fea1bc\n-- \ngitgitgadget\n"},{"id":"405792","messageId":"xmqqpn6kqmco.fsf@gitster.c.googlers.com","threadId":"54251","inReplyTo":"pull.848.git.git.1600356459092.gitgitgadget@gmail.com","subject":"Re: [PATCH] remote: in case of error don't show success message.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-09-17T18:39:19Z","receivedAt":"2020-09-17T18:39:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Christian Schlack via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> diff --git a/builtin/remote.c b/builtin/remote.c\n> index 542f56e387..64b4b551eb 100644\n> --- a/builtin/remote.c\n> +++ b/builtin/remote.c\n> @@ -1356,7 +1356,7 @@ static int set_head(int argc, const char **argv)\n>  \t\t\tresult |= error(_(\"Not a valid ref: %s\"), buf2.buf);\n>  \t\telse if (create_symref(buf.buf, buf2.buf, \"remote set-head\"))\n>  \t\t\tresult |= error(_(\"Could not setup %s\"), buf.buf);\n> -\t\tif (opt_a)\n> +\t\telse if (opt_a)\n>  \t\t\tprintf(\"%s/HEAD set to %s\\n\", argv[0], head_name);\n>  \t\tfree(head_name);\n>  \t}\n>\n\nQuite straight-forward and looks obviously good.\n\nThanks, will queue.\n"}]}