{"thread":{"id":"54241","subject":"[PATCH] commit-graph-format.txt: fix no-parent value","startedAt":"2020-09-15T04:04:04Z","lastAt":"2020-09-15T23:21:33Z","messageCount":4,"participants":["Conor Davis via GitGitGadget","Taylor Blau","Derrick Stolee","Conor Davis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"405547","messageId":"pull.733.git.1600142634326.gitgitgadget@gmail.com","threadId":"54241","inReplyTo":null,"subject":"[PATCH] commit-graph-format.txt: fix no-parent value","fromName":"Conor Davis via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-09-15T04:03:53Z","receivedAt":"2020-09-15T04:04:04Z","isPatch":true,"sender":{"key":"git@conor.fastmail.fm","avatar":null},"body":"From: Conor Davis <git@conor.fastmail.fm>\n\nThe correct value from commit-graph.c:\n\n    #define GRAPH_PARENT_NONE 0x70000000\n\nSigned-off-by: Conor Davis <git@conor.fastmail.fm>\n---\n    commit-graph-format.txt: fix no-parent value\n    \n    The correct value from commit-graph.c:\n    \n    #define GRAPH_PARENT_NONE 0x70000000\n    \n    Signed-off-by: Conor Davis git@conor.fastmail.fm [git@conor.fastmail.fm]\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-733%2Favoidscorn%2Fgraph-parent-none-doc-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-733/avoidscorn/graph-parent-none-doc-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/733\n\n Documentation/technical/commit-graph-format.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/technical/commit-graph-format.txt b/Documentation/technical/commit-graph-format.txt\nindex 1beef17182..002a480c9c 100644\n--- a/Documentation/technical/commit-graph-format.txt\n+++ b/Documentation/technical/commit-graph-format.txt\n@@ -77,7 +77,7 @@ CHUNK DATA:\n   Commit Data (ID: {'C', 'D', 'A', 'T' }) (N * (H + 16) bytes)\n     * The first H bytes are for the OID of the root tree.\n     * The next 8 bytes are for the positions of the first two parents\n-      of the ith commit. Stores value 0x7000000 if no parent in that\n+      of the ith commit. Stores value 0x70000000 if no parent in that\n       position. If there are more than two parents, the second value\n       has its most-significant bit on and the other bits store an array\n       position into the Extra Edge List chunk.\n\nbase-commit: 47ae905ffb98cc4d4fd90083da6bc8dab55d9ecc\n-- \ngitgitgadget\n"},{"id":"405548","messageId":"20200915042607.GA19144@nand.local","threadId":"54241","inReplyTo":"pull.733.git.1600142634326.gitgitgadget@gmail.com","subject":"Re: [PATCH] commit-graph-format.txt: fix no-parent value","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-09-15T04:26:07Z","receivedAt":"2020-09-15T04:26:14Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Conor,\n\nOn Tue, Sep 15, 2020 at 04:03:53AM +0000, Conor Davis via GitGitGadget wrote:\n> -      of the ith commit. Stores value 0x7000000 if no parent in that\n> +      of the ith commit. Stores value 0x70000000 if no parent in that\n\nThnaks for fixing this up. This dates back to a9aa3c0927 (commit-graph:\nfix documentation inconsistencies, 2018-06-28) which mentions the\ncorrect value in the commit message, but uses the incorrect value in the\npatch itself.\n\nFor what it's worth, I can hardly blame the author of a9aa3c0927, since\nI had to flip back and forth between the two a couple of times to\nconvince myself which one was which.\n\nAnyway, this is obviously correct. Thank you for your contribution!\n\n  Reviewed-by: Taylor Blau <me@ttaylorr.com>\n\nThanks,\nTaylor\n"},{"id":"405554","messageId":"8ff4e93a-7291-3093-2f79-9e98236c11f7@gmail.com","threadId":"54241","inReplyTo":"20200915042607.GA19144@nand.local","subject":"Re: [PATCH] commit-graph-format.txt: fix no-parent value","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-09-15T12:16:30Z","receivedAt":"2020-09-15T12:17:42Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 9/15/2020 12:26 AM, Taylor Blau wrote:\n> For what it's worth, I can hardly blame the author of a9aa3c0927,\n\nI can!\n\nThanks for noticing the doc bug. May I ask why you were looking\nat the format document so closely? Are you working on a new\nimplementation?\n\nThanks,\n-Stolee\n"},{"id":"405587","messageId":"7107abb6-e957-da69-5f64-ed6eeb16f14f@fastmail.fm","threadId":"54241","inReplyTo":"8ff4e93a-7291-3093-2f79-9e98236c11f7@gmail.com","subject":"Re: [PATCH] commit-graph-format.txt: fix no-parent value","fromName":"Conor Davis","fromEmail":"git@conor.fastmail.fm","sentAt":"2020-09-15T23:12:57Z","receivedAt":"2020-09-15T23:21:33Z","isPatch":true,"sender":{"key":"git@conor.fastmail.fm","avatar":null},"body":"On 9/15/20 7:16 AM, Derrick Stolee wrote:\n> On 9/15/2020 12:26 AM, Taylor Blau wrote:\n>> For what it's worth, I can hardly blame the author of a9aa3c0927,\n> I can!\n>\n> Thanks for noticing the doc bug. May I ask why you were looking\n> at the format document so closely? Are you working on a new\n> implementation?\n\nYes, I'm adding commit-graph support to gitoxide: \nhttps://github.com/Byron/gitoxide/pull/21\n\n-Conor\n\n"}]}