{"thread":{"id":"54214","subject":"[PATCH v3] blame.c: replace instance of !oidcmp for oideq","startedAt":"2020-09-09T13:17:44Z","lastAt":"2020-09-09T18:33:41Z","messageCount":2,"participants":["Edmundo Carmona Antoranz","Derrick Stolee"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"405243","messageId":"20200909131550.826462-1-eantoranz@gmail.com","threadId":"54214","inReplyTo":null,"subject":"[PATCH v3] blame.c: replace instance of !oidcmp for oideq","fromName":"Edmundo Carmona Antoranz","fromEmail":"eantoranz@gmail.com","sentAt":"2020-09-09T13:15:50Z","receivedAt":"2020-09-09T13:17:44Z","isPatch":true,"sender":{"key":"eantoranz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1491018?v=4"},"body":"0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)\nintroduced a call to oidcmp() that should be replaced with oideq()\ndefined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)\n\nSigned-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>\n---\n blame.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/blame.c b/blame.c\nindex da7e28800e..a8abe86ae4 100644\n--- a/blame.c\n+++ b/blame.c\n@@ -1352,8 +1352,8 @@ static struct blame_origin *find_origin(struct repository *r,\n \telse {\n \t\tint compute_diff = 1;\n \t\tif (origin->commit->parents &&\n-\t\t    !oidcmp(&parent->object.oid,\n-\t\t\t    &origin->commit->parents->item->object.oid))\n+\t\t    oideq(&parent->object.oid,\n+\t\t\t  &origin->commit->parents->item->object.oid))\n \t\t\tcompute_diff = maybe_changed_path(r, origin, bd);\n \n \t\tif (compute_diff)\n-- \n2.28.0\n\n"},{"id":"405269","messageId":"1c9dd960-b15e-b942-fc35-c1ae82b7549f@gmail.com","threadId":"54214","inReplyTo":"20200909131550.826462-1-eantoranz@gmail.com","subject":"Re: [PATCH v3] blame.c: replace instance of !oidcmp for oideq","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-09-09T18:33:33Z","receivedAt":"2020-09-09T18:33:41Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 9/9/2020 9:15 AM, Edmundo Carmona Antoranz wrote:\n> 0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)\n> introduced a call to oidcmp() that should be replaced with oideq()\n> defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)\n\nLGTM. Thanks.\n\n-Stolee\n"}]}