{"thread":{"id":"54182","subject":"[PATCH] vcbuild: fix batch file name in README","startedAt":"2020-09-02T20:18:27Z","lastAt":"2020-09-03T10:19:52Z","messageCount":4,"participants":["Orgad Shaneh via GitGitGadget","Jonathan Nieder","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"404938","messageId":"pull.721.git.1599077900986.gitgitgadget@gmail.com","threadId":"54182","inReplyTo":null,"subject":"[PATCH] vcbuild: fix batch file name in README","fromName":"Orgad Shaneh via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-09-02T20:18:20Z","receivedAt":"2020-09-02T20:18:27Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"From: Orgad Shaneh <orgads@gmail.com>\n\nSigned-off-by: Orgad Shaneh <orgads@gmail.com>\n---\n    vcbuild: Fix batch file name in README\n    \n    Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/721\n\n compat/vcbuild/README | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/compat/vcbuild/README b/compat/vcbuild/README\nindex 42292e7c09..51fb083dbb 100644\n--- a/compat/vcbuild/README\n+++ b/compat/vcbuild/README\n@@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.\n    Use ONE of the following forms which should match how you want to\n    compile git.exe.\n \n-   $ ./compat/vcbuild/vcpkg_copy_packages.bat debug\n-   $ ./compat/vcbuild/vcpkg_copy_packages.bat release\n+   $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug\n+   $ ./compat/vcbuild/vcpkg_copy_dlls.bat release\n \n 3. Build git using MSVC from an SDK bash window using one of the\n    following commands:\n\nbase-commit: e19713638985533ce461db072b49112da5bd2042\n-- \ngitgitgadget\n"},{"id":"404949","messageId":"20200903000236.GC4035286@google.com","threadId":"54182","inReplyTo":"pull.721.git.1599077900986.gitgitgadget@gmail.com","subject":"Re: [PATCH] vcbuild: fix batch file name in README","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2020-09-03T00:02:36Z","receivedAt":"2020-09-03T00:02:42Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"(cc-ing Jeff Hostetler, vcbuild expert)\nOrgad Shaneh wrote:\n\n> Signed-off-by: Orgad Shaneh <orgads@gmail.com>\n> ---\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/721\n>\n>  compat/vcbuild/README | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n\nMakes sense.  This discrepancy is already present in the initial\ncontribution dce7d295514 (msvc: support building Git using MS Visual\nC++, 2019-06-25), so it's probably from documentation going out of\ndate between review rounds.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\n> diff --git a/compat/vcbuild/README b/compat/vcbuild/README\n> index 42292e7c09..51fb083dbb 100644\n> --- a/compat/vcbuild/README\n> +++ b/compat/vcbuild/README\n> @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.\n>     Use ONE of the following forms which should match how you want to\n>     compile git.exe.\n>  \n> -   $ ./compat/vcbuild/vcpkg_copy_packages.bat debug\n> -   $ ./compat/vcbuild/vcpkg_copy_packages.bat release\n> +   $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug\n> +   $ ./compat/vcbuild/vcpkg_copy_dlls.bat release\n>  \n>  3. Build git using MSVC from an SDK bash window using one of the\n>     following commands:\n> \n> base-commit: e19713638985533ce461db072b49112da5bd2042\n> -- \n> gitgitgadget\n"},{"id":"404965","messageId":"nycvar.QRO.7.76.6.2009030349000.56@tvgsbejvaqbjf.bet","threadId":"54182","inReplyTo":"pull.721.git.1599077900986.gitgitgadget@gmail.com","subject":"Re: [PATCH] vcbuild: fix batch file name in README","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-09-03T01:50:58Z","receivedAt":"2020-09-03T10:15:28Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Orgad,\n\nOn Wed, 2 Sep 2020, Orgad Shaneh via GitGitGadget wrote:\n\n> From: Orgad Shaneh <orgads@gmail.com>\n>\n> Signed-off-by: Orgad Shaneh <orgads@gmail.com>\n> ---\n>     vcbuild: Fix batch file name in README\n>\n>     Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/721\n>\n>  compat/vcbuild/README | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/compat/vcbuild/README b/compat/vcbuild/README\n> index 42292e7c09..51fb083dbb 100644\n> --- a/compat/vcbuild/README\n> +++ b/compat/vcbuild/README\n> @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.\n>     Use ONE of the following forms which should match how you want to\n>     compile git.exe.\n>\n> -   $ ./compat/vcbuild/vcpkg_copy_packages.bat debug\n> -   $ ./compat/vcbuild/vcpkg_copy_packages.bat release\n> +   $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug\n> +   $ ./compat/vcbuild/vcpkg_copy_dlls.bat release\n\nGood catch! Somewhere in my refactoring spree, I must have overlooked this\nreference.\n\nACK & Thanks,\nDscho\n\n>\n>  3. Build git using MSVC from an SDK bash window using one of the\n>     following commands:\n>\n> base-commit: e19713638985533ce461db072b49112da5bd2042\n> --\n> gitgitgadget\n>\n"},{"id":"404966","messageId":"nycvar.QRO.7.76.6.2009030353500.56@tvgsbejvaqbjf.bet","threadId":"54182","inReplyTo":"20200903000236.GC4035286@google.com","subject":"Re: [PATCH] vcbuild: fix batch file name in README","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-09-03T01:55:20Z","receivedAt":"2020-09-03T10:19:52Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Jonathan,\n\nOn Wed, 2 Sep 2020, Jonathan Nieder wrote:\n\n> (cc-ing Jeff Hostetler, vcbuild expert)\n> Orgad Shaneh wrote:\n>\n> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>\n> > ---\n> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1\n> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1\n> > Pull-Request: https://github.com/gitgitgadget/git/pull/721\n> >\n> >  compat/vcbuild/README | 4 ++--\n> >  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> Makes sense.  This discrepancy is already present in the initial\n> contribution dce7d295514 (msvc: support building Git using MS Visual\n> C++, 2019-06-25), so it's probably from documentation going out of\n> date between review rounds.\n\nNot in _public_ review rounds, as even the first version I sent did not\nhave that `.bat` file anymore:\nhttps://github.com/gitgitgadget/git/tree/pr-149/dscho/msvc-v1/compat/vcbuild\n\nFWIW the old name was a hold-over from the time when we tried to use NuGet\npackages (and I think this is the first time I mentioned this on this here\nmailing list), which we were able to abandon in favor of using `vcpkg`.\n\nCiao,\nDscho\n\n>\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n> > diff --git a/compat/vcbuild/README b/compat/vcbuild/README\n> > index 42292e7c09..51fb083dbb 100644\n> > --- a/compat/vcbuild/README\n> > +++ b/compat/vcbuild/README\n> > @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.\n> >     Use ONE of the following forms which should match how you want to\n> >     compile git.exe.\n> >\n> > -   $ ./compat/vcbuild/vcpkg_copy_packages.bat debug\n> > -   $ ./compat/vcbuild/vcpkg_copy_packages.bat release\n> > +   $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug\n> > +   $ ./compat/vcbuild/vcpkg_copy_dlls.bat release\n> >\n> >  3. Build git using MSVC from an SDK bash window using one of the\n> >     following commands:\n> >\n> > base-commit: e19713638985533ce461db072b49112da5bd2042\n> > --\n> > gitgitgadget\n>\n"}]}