{"thread":{"id":"54161","subject":"[PATCH 0/3] Clean up and improve git-imap-send.txt","startedAt":"2020-08-30T22:01:31Z","lastAt":"2020-08-30T22:01:41Z","messageCount":4,"participants":["Philippe Blain via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"404772","messageId":"pull.715.git.1598824880.gitgitgadget@gmail.com","threadId":"54161","inReplyTo":null,"subject":"[PATCH 0/3] Clean up and improve git-imap-send.txt","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-08-30T22:01:17Z","receivedAt":"2020-08-30T22:01:31Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"This series cleans up the documentation page for 'git imap-send', removes\nthe sslVerify config from the Gmail example, and uses more appropriate\nAsciidoc syntax.\n\nIt is a rework of [1], incorporating Junio's suggestions from [2]. \n\nI split the suggestions in 2 commits to make reviewing the patches easier.\nThe third commit adds a note about localized Gmail folder names, which bit\nme when I was configuring 'git imap-send' myself.\n\n[1] https://lore.kernel.org/git/51758EE8.7030800@gmail.com/[2] \nhttps://lore.kernel.org/git/7vr4hzetki.fsf@alter.siamese.dyndns.org/\n\nPhilippe Blain (3):\n git-imap-send.txt: don't duplicate 'Examples' sections\n git-imap-send.txt: do verify SSL certificate for gmail.com\n git-imap-send.txt: add note about localized Gmail folders\n\n Documentation/git-imap-send.txt | 34 ++++++++++++++++++---------------\n 1 file changed, 19 insertions(+), 15 deletions(-)\n\n\nbase-commit: d9cd4331470f4d9d78677f12dc79063dab832f53\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-715%2Fphil-blain%2Fimap-send-ssl-verify-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-715/phil-blain/imap-send-ssl-verify-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/715\n-- \ngitgitgadget\n"},{"id":"404773","messageId":"2b12440045d926b194b90f16246d4f166f31442a.1598824880.git.gitgitgadget@gmail.com","threadId":"54161","inReplyTo":"pull.715.git.1598824880.gitgitgadget@gmail.com","subject":"[PATCH 3/3] git-imap-send.txt: add note about localized Gmail folders","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-08-30T22:01:20Z","receivedAt":"2020-08-30T22:01:35Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain \n\nThe name of the \"Special-Use Mailboxes\" in Gmail are localized\nusing the user's localization settings. Add a note to that effect\nin `git imap-send`'s documentation, to make it easier for users to\nconfigure their account.\n\nSigned-off-by: Philippe Blain \n---\n Documentation/git-imap-send.txt | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 5e4d4d43b9..63cf498ce9 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -110,6 +110,10 @@ Using Gmail's IMAP interface:\n You might need to instead use: `folder = \"[Google Mail]/Drafts\"` if you get an error\n that the \"Folder doesn't exist\".\n \n+[NOTE]\n+If your Gmail account is set to another language than English, the name of the \"Drafts\"\n+folder will be localized.\n+\n Once the commits are ready to be sent, run the following command:\n \n $ git format-patch --cover-letter -M --stdout origin/master | git imap-send\n-- \ngitgitgadget\n"},{"id":"404774","messageId":"a4bea1c2dc79ef1947af812a3096ddacb0ef9d4e.1598824880.git.gitgitgadget@gmail.com","threadId":"54161","inReplyTo":"pull.715.git.1598824880.gitgitgadget@gmail.com","subject":"[PATCH 2/3] git-imap-send.txt: do verify SSL certificate for gmail.com","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-08-30T22:01:19Z","receivedAt":"2020-08-30T22:01:39Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain \n\nAs a public service, it is unlikely that the Gmail server is configured\nto throw a certificate that does not verify at the user.\n\nRemove the `sslVerify=false` config from the Gmail example.\n\nAlso, comment it in the `example.com` example, and add a note to the\nuser explaining that they might want to uncomment it if they are having\ntrouble connecting. While at it, use an Asciidoc 'Note' section in the\nGmail example also.\n\nBased-on-patch-by: Barbu Paul - Gheorghe \nHelped-by: Junio C Hamano \nSigned-off-by: Philippe Blain \n---\n Documentation/git-imap-send.txt | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 0a00a1236b..5e4d4d43b9 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -85,10 +85,17 @@ Using direct mode with SSL:\n user = bob\n pass = p4ssw0rd\n port = 123\n- sslverify = false\n+ ; sslVerify = false\n .........................\n \n \n+[NOTE]\n+You may want to use `sslVerify=false`\n+while troubleshooting, if you suspect that the reason you are\n+having trouble connecting is because the certificate you use at\n+the private server `example.com` you are trying to set up (or\n+have set up) may not be verified correctly.\n+\n Using Gmail's IMAP interface:\n \n ---------\n@@ -97,9 +104,9 @@ Using Gmail's IMAP interface:\n \thost = imaps://imap.gmail.com\n \tuser = user@gmail.com\n \tport = 993\n-\tsslverify = false\n ---------\n \n+[NOTE]\n You might need to instead use: `folder = \"[Google Mail]/Drafts\"` if you get an error\n that the \"Folder doesn't exist\".\n \n-- \ngitgitgadget\n\n"},{"id":"404775","messageId":"3a9b82839e47d974a1a37e77dd10a19daeed5d94.1598824880.git.gitgitgadget@gmail.com","threadId":"54161","inReplyTo":"pull.715.git.1598824880.gitgitgadget@gmail.com","subject":"[PATCH 1/3] git-imap-send.txt: don't duplicate 'Examples' sections","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-08-30T22:01:18Z","receivedAt":"2020-08-30T22:01:41Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain \n\nRemove the 'Examples' subsection in the 'Configuration' section and move\nthese examples to the 'Examples' section. Also remove the 'Variables'\ntitle since it is now useless.\n\nAlso, use appropriate Asciidoc syntax for configuration values, and\ncapitalize 'Gmail' properly.\n\nSuggested-by: Junio C Hamano \nSigned-off-by: Philippe Blain \n---\n Documentation/git-imap-send.txt | 19 ++++++-------------\n 1 file changed, 6 insertions(+), 13 deletions(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 65b53fcc47..0a00a1236b 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -51,17 +51,13 @@ OPTIONS\n CONFIGURATION\n -------------\n \n-To use the tool, imap.folder and either imap.tunnel or imap.host must be set\n+To use the tool, `imap.folder` and either `imap.tunnel` or `imap.host` must be set\n to appropriate values.\n \n-Variables\n-~~~~~~~~~\n-\n include::config/imap.txt[]\n \n-Examples\n-~~~~~~~~\n-\n+EXAMPLES\n+--------\n Using tunnel mode:\n \n ..........................\n@@ -93,10 +89,7 @@ Using direct mode with SSL:\n .........................\n \n \n-EXAMPLES\n---------\n-To submit patches using GMail's IMAP interface, first, edit your ~/.gitconfig\n-to specify your account settings:\n+Using Gmail's IMAP interface:\n \n ---------\n [imap]\n@@ -107,14 +100,14 @@ to specify your account settings:\n \tsslverify = false\n ---------\n \n-You might need to instead use: folder = \"[Google Mail]/Drafts\" if you get an error\n+You might need to instead use: `folder = \"[Google Mail]/Drafts\"` if you get an error\n that the \"Folder doesn't exist\".\n \n Once the commits are ready to be sent, run the following command:\n \n $ git format-patch --cover-letter -M --stdout origin/master | git imap-send\n \n-Just make sure to disable line wrapping in the email client (GMail's web\n+Just make sure to disable line wrapping in the email client (Gmail's web\n interface will wrap lines no matter what, so you need to use a real\n IMAP client).\n \n-- \ngitgitgadget\n\n"}]}