{"thread":{"id":"54138","subject":"[PATCH] builtin/index-pack.c: fix some sparse warnings","startedAt":"2020-08-27T00:47:45Z","lastAt":"2020-08-27T00:47:45Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"404565","messageId":"f2c8b658-f9d8-43bd-7121-9e0f04adeb4b@ramsayjones.plus.com","threadId":"54138","inReplyTo":null,"subject":"[PATCH] builtin/index-pack.c: fix some sparse warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2020-08-27T00:40:07Z","receivedAt":"2020-08-27T00:47:45Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Jonathan,\n\nIf you need to re-roll your 'jt/threaded-index-pack' branch, could you\nplease squash this into the relevant patch (commit 4a03e3d995 (index-pack:\nmake quantum of work smaller, 24-08-2020)).\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/index-pack.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin/index-pack.c b/builtin/index-pack.c\nindex 3a20017102..8acd078aa0 100644\n--- a/builtin/index-pack.c\n+++ b/builtin/index-pack.c\n@@ -65,7 +65,7 @@ struct base_data {\n  *\n  * Guarded by work_mutex.\n  */\n-LIST_HEAD(work_head);\n+static LIST_HEAD(work_head);\n \n /*\n  * Stack of struct base_data that have children, all of whom have been\n@@ -75,7 +75,7 @@ LIST_HEAD(work_head);\n  *\n  * Guarded by work_mutex.\n  */\n-LIST_HEAD(done_head);\n+static LIST_HEAD(done_head);\n \n /*\n  * All threads share one delta base cache.\n@@ -83,8 +83,8 @@ LIST_HEAD(done_head);\n  * base_cache_used is guarded by work_mutex, and base_cache_limit is read-only\n  * in a thread.\n  */\n-size_t base_cache_used;\n-size_t base_cache_limit;\n+static size_t base_cache_used;\n+static size_t base_cache_limit;\n \n struct thread_local {\n \tpthread_t thread;\n-- \n2.28.0\n"}]}