{"thread":{"id":"54084","subject":"[PATCH v3 1/5] t7401: modernize style","startedAt":"2020-08-21T17:02:41Z","lastAt":"2020-08-21T17:04:51Z","messageCount":6,"participants":["Shourya Shukla"],"isPatch":true,"patchVersion":3,"patchTotal":5},"messages":[{"id":"404153","messageId":"20200821165952.14376-2-shouryashukla.oo@gmail.com","threadId":"54084","inReplyTo":"20200821165952.14376-1-shouryashukla.oo@gmail.com","subject":"[PATCH v3 1/5] t7401: modernize style","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-08-21T16:59:48Z","receivedAt":"2020-08-21T17:02:41Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"The tests in 't7401-submodule-summary.sh' were written a long time ago\nand has a violation with respect to our CodingGuidelines which is,\nincorrect spacing in usages of the redirection operator.\n\nMentored-by: Christian Couder <chriscool@tuxfamily.org>\nMentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>\nHelped-by: Denton Liu <liu.denton@gmail.com>\nHelped-by: Taylor Blau <me@ttaylorr.com>\nSigned-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>\n---\n t/t7401-submodule-summary.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh\nindex 9bc841d085..07d4ba0b26 100755\n--- a/t/t7401-submodule-summary.sh\n+++ b/t/t7401-submodule-summary.sh\n@@ -16,7 +16,7 @@ add_file () {\n \towd=$(pwd)\n \tcd \"$sm\"\n \tfor name; do\n-\t\techo \"$name\" > \"$name\" &&\n+\t\techo \"$name\" >\"$name\" &&\n \t\tgit add \"$name\" &&\n \t\ttest_tick &&\n \t\tgit commit -m \"Add $name\"\n-- \n2.28.0\n\n"},{"id":"404154","messageId":"20200821165952.14376-4-shouryashukla.oo@gmail.com","threadId":"54084","inReplyTo":"20200821165952.14376-1-shouryashukla.oo@gmail.com","subject":"[PATCH v3 3/5] t7401: change syntax of test_i18ncmp calls for clarity","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-08-21T16:59:50Z","receivedAt":"2020-08-21T17:02:53Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Change the test_i18ncmp syntax from 'test_i18ncmp actual expected' to\n'test_i18ncmp expected actual' to align it with the convention followed\nby other tests in the test script.\n\nMentored-by: Christian Couder <chriscool@tuxfamily.org>\nMentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>\nSigned-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>\n---\n t/t7401-submodule-summary.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh\nindex ccbac875fe..3f580455f7 100755\n--- a/t/t7401-submodule-summary.sh\n+++ b/t/t7401-submodule-summary.sh\n@@ -181,7 +181,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --cached' \"\n   < Add foo5\n \n EOF\n-\ttest_i18ncmp actual expected\n+\ttest_i18ncmp expected actual\n \"\n \n test_expect_success 'typechanged submodule(submodule->blob), --files' \"\n@@ -191,7 +191,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --files' \"\n   > Add foo5\n \n EOF\n-\ttest_i18ncmp actual expected\n+\ttest_i18ncmp expected actual\n \"\n \n rm -rf sm1 &&\n@@ -202,7 +202,7 @@ test_expect_success 'typechanged submodule(submodule->blob)' \"\n * sm1 $head4(submodule)->$head5(blob):\n \n EOF\n-\ttest_i18ncmp actual expected\n+\ttest_i18ncmp expected actual\n \"\n \n rm -f sm1 &&\n@@ -215,7 +215,7 @@ test_expect_success 'nonexistent commit' \"\n   Warn: sm1 doesn't contain commit $head4_full\n \n EOF\n-\ttest_i18ncmp actual expected\n+\ttest_i18ncmp expected actual\n \"\n \n commit_file\n@@ -283,7 +283,7 @@ EOF\n \n test_expect_success '--for-status' \"\n \tgit submodule summary --for-status HEAD^ >actual &&\n-\ttest_i18ncmp actual - <<EOF\n+\ttest_i18ncmp - actual <<EOF\n * sm1 $head6...0000000:\n \n * sm2 0000000...$head7 (2):\n-- \n2.28.0\n\n"},{"id":"404155","messageId":"20200821165952.14376-6-shouryashukla.oo@gmail.com","threadId":"54084","inReplyTo":"20200821165952.14376-1-shouryashukla.oo@gmail.com","subject":"[PATCH v3 5/5] t7401: add a NEEDSWORK","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-08-21T16:59:52Z","receivedAt":"2020-08-21T17:03:58Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Add a NEEDSWORK regarding the outdated syntax and working of the test,\nwhich may need to be improved to obtain better and desired results.\n\nWhile at it, change the word 'test' to 'test script' in the test\ndescription to avoid ambiguity.\n\nMentored-by: Christian Couder <chriscool@tuxfamily.org>\nMentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>\nHelped-by: Taylor Blau <me@ttaylorr.com>\nSigned-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>\n---\n t/t7401-submodule-summary.sh | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh\nindex 1491ab6448..cc87d26619 100755\n--- a/t/t7401-submodule-summary.sh\n+++ b/t/t7401-submodule-summary.sh\n@@ -5,8 +5,11 @@\n \n test_description='Summary support for submodules\n \n-This test tries to verify the sanity of summary subcommand of git submodule.\n+This test script tries to verify the sanity of summary subcommand of git submodule.\n '\n+# NEEDSWORK: This test script is old fashioned and may need a big cleanup due to\n+# various reasons, one of them being that there are lots of commands taking place\n+# outside of 'test_expect_success' block, which is no longer in good-style.\n \n . ./test-lib.sh\n \n-- \n2.28.0\n\n"},{"id":"404156","messageId":"20200821165952.14376-5-shouryashukla.oo@gmail.com","threadId":"54084","inReplyTo":"20200821165952.14376-1-shouryashukla.oo@gmail.com","subject":"[PATCH v3 4/5] t7401: change indentation for enhanced readability","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-08-21T16:59:51Z","receivedAt":"2020-08-21T17:04:16Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Change the indentation of expected outputs for enhanced readability of\nthe tests. Also modify the heredoc string limiter in a test which lacks\nit to support the indentation change.\n\nMentored-by: Christian Couder <chriscool@tuxfamily.org>\nMentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>\nHelped-by: Junio C Hamano <gitster@pobox.com>\nHelped-by: Taylor Blau <me@taylorr.com>\nSigned-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>\n---\n t/t7401-submodule-summary.sh | 130 +++++++++++++++++------------------\n 1 file changed, 65 insertions(+), 65 deletions(-)\n\ndiff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh\nindex 3f580455f7..1491ab6448 100755\n--- a/t/t7401-submodule-summary.sh\n+++ b/t/t7401-submodule-summary.sh\n@@ -38,10 +38,10 @@ test_expect_success 'added submodule' \"\n \tgit add sm1 &&\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 0000000...$head1 (2):\n-  > Add foo2\n+\t* sm1 0000000...$head1 (2):\n+\t  > Add foo2\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -52,10 +52,10 @@ test_expect_success 'added submodule (subdirectory)' \"\n \t\tgit submodule summary >../actual\n \t) &&\n \tcat >expected <<-EOF &&\n-* ../sm1 0000000...$head1 (2):\n-  > Add foo2\n+\t* ../sm1 0000000...$head1 (2):\n+\t  > Add foo2\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -73,10 +73,10 @@ test_expect_success 'added submodule (subdirectory with explicit path)' \"\n \t\tgit submodule summary ../sm1 >../actual\n \t) &&\n \tcat >expected <<-EOF &&\n-* ../sm1 0000000...$head1 (2):\n-  > Add foo2\n+\t* ../sm1 0000000...$head1 (2):\n+\t  > Add foo2\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -86,20 +86,20 @@ head2=$(add_file sm1 foo3)\n test_expect_success 'modified submodule(forward)' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head1...$head2 (1):\n-  > Add foo3\n+\t* sm1 $head1...$head2 (1):\n+\t  > Add foo3\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n test_expect_success 'modified submodule(forward), --files' \"\n \tgit submodule summary --files >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head1...$head2 (1):\n-  > Add foo3\n+\t* sm1 $head1...$head2 (1):\n+\t  > Add foo3\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -110,10 +110,10 @@ test_expect_success 'no ignore=all setting has any effect' \"\n \tgit config diff.ignoreSubmodules all &&\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head1...$head2 (1):\n-  > Add foo3\n+\t* sm1 $head1...$head2 (1):\n+\t  > Add foo3\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual &&\n \tgit config --unset diff.ignoreSubmodules &&\n \tgit config --remove-section submodule.sm1 &&\n@@ -131,11 +131,11 @@ head3=$(\n test_expect_success 'modified submodule(backward)' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head2...$head3 (2):\n-  < Add foo3\n-  < Add foo2\n+\t* sm1 $head2...$head3 (2):\n+\t  < Add foo3\n+\t  < Add foo2\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -144,25 +144,25 @@ head4_full=$(GIT_DIR=sm1/.git git rev-parse --verify HEAD)\n test_expect_success 'modified submodule(backward and forward)' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head2...$head4 (4):\n-  > Add foo5\n-  > Add foo4\n-  < Add foo3\n-  < Add foo2\n+\t* sm1 $head2...$head4 (4):\n+\t  > Add foo5\n+\t  > Add foo4\n+\t  < Add foo3\n+\t  < Add foo2\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n test_expect_success '--summary-limit' \"\n \tgit submodule summary -n 3 >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head2...$head4 (4):\n-  > Add foo5\n-  > Add foo4\n-  < Add foo3\n+\t* sm1 $head2...$head4 (4):\n+\t  > Add foo5\n+\t  > Add foo4\n+\t  < Add foo3\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -177,20 +177,20 @@ mv sm1-bak sm1\n test_expect_success 'typechanged submodule(submodule->blob), --cached' \"\n \tgit submodule summary --cached >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head4(submodule)->$head5(blob) (3):\n-  < Add foo5\n+\t* sm1 $head4(submodule)->$head5(blob) (3):\n+\t  < Add foo5\n \n-EOF\n+\tEOF\n \ttest_i18ncmp expected actual\n \"\n \n test_expect_success 'typechanged submodule(submodule->blob), --files' \"\n \tgit submodule summary --files >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head5(blob)->$head4(submodule) (3):\n-  > Add foo5\n+\t* sm1 $head5(blob)->$head4(submodule) (3):\n+\t  > Add foo5\n \n-EOF\n+\tEOF\n \ttest_i18ncmp expected actual\n \"\n \n@@ -199,9 +199,9 @@ git checkout-index sm1\n test_expect_success 'typechanged submodule(submodule->blob)' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head4(submodule)->$head5(blob):\n+\t* sm1 $head4(submodule)->$head5(blob):\n \n-EOF\n+\tEOF\n \ttest_i18ncmp expected actual\n \"\n \n@@ -211,10 +211,10 @@ head6=$(add_file sm1 foo6 foo7)\n test_expect_success 'nonexistent commit' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head4...$head6:\n-  Warn: sm1 doesn't contain commit $head4_full\n+\t* sm1 $head4...$head6:\n+\t  Warn: sm1 doesn't contain commit $head4_full\n \n-EOF\n+\tEOF\n \ttest_i18ncmp expected actual\n \"\n \n@@ -222,10 +222,10 @@ commit_file\n test_expect_success 'typechanged submodule(blob->submodule)' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head5(blob)->$head6(submodule) (2):\n-  > Add foo7\n+\t* sm1 $head5(blob)->$head6(submodule) (2):\n+\t  > Add foo7\n \n-EOF\n+\tEOF\n \ttest_i18ncmp expected actual\n \"\n \n@@ -234,9 +234,9 @@ rm -rf sm1\n test_expect_success 'deleted submodule' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head6...0000000:\n+\t* sm1 $head6...0000000:\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -249,22 +249,22 @@ test_expect_success 'create second submodule' '\n test_expect_success 'multiple submodules' \"\n \tgit submodule summary >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head6...0000000:\n+\t* sm1 $head6...0000000:\n \n-* sm2 0000000...$head7 (2):\n-  > Add foo9\n+\t* sm2 0000000...$head7 (2):\n+\t  > Add foo9\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n test_expect_success 'path filter' \"\n \tgit submodule summary sm2 >actual &&\n \tcat >expected <<-EOF &&\n-* sm2 0000000...$head7 (2):\n-  > Add foo9\n+\t* sm2 0000000...$head7 (2):\n+\t  > Add foo9\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n@@ -272,24 +272,24 @@ commit_file sm2\n test_expect_success 'given commit' \"\n \tgit submodule summary HEAD^ >actual &&\n \tcat >expected <<-EOF &&\n-* sm1 $head6...0000000:\n+\t* sm1 $head6...0000000:\n \n-* sm2 0000000...$head7 (2):\n-  > Add foo9\n+\t* sm2 0000000...$head7 (2):\n+\t  > Add foo9\n \n-EOF\n+\tEOF\n \ttest_cmp expected actual\n \"\n \n test_expect_success '--for-status' \"\n \tgit submodule summary --for-status HEAD^ >actual &&\n-\ttest_i18ncmp - actual <<EOF\n-* sm1 $head6...0000000:\n+\ttest_i18ncmp - actual <<-EOF\n+\t* sm1 $head6...0000000:\n \n-* sm2 0000000...$head7 (2):\n-  > Add foo9\n+\t* sm2 0000000...$head7 (2):\n+\t  > Add foo9\n \n-EOF\n+\tEOF\n \"\n \n test_expect_success 'fail when using --files together with --cached' \"\n-- \n2.28.0\n\n"},{"id":"404157","messageId":"20200821165952.14376-3-shouryashukla.oo@gmail.com","threadId":"54084","inReplyTo":"20200821165952.14376-1-shouryashukla.oo@gmail.com","subject":"[PATCH v3 2/5] t7401: use 'short' instead of 'verify' and cut in rev-parse calls","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-08-21T16:59:49Z","receivedAt":"2020-08-21T17:04:17Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"'git rev-parse' can limit the number of characters in the hash it\noutputs using the '--short' option, thereby, making the 'cut' invocation\nredundant. Since using '--short' implies '--verify' as well, we can\nsafely replace the latter with the former. This change results in the\nhelper functions getting the hash in the same way 'summary' gets the\nhash internally.\n\nSo, avoid the unnecessary invocation to 'cut' in the helper\nfunctions.\n\nMentored-by: Christian Couder <chriscool@tuxfamily.org>\nMentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>\nSigned-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>\n---\n t/t7401-submodule-summary.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh\nindex 07d4ba0b26..ccbac875fe 100755\n--- a/t/t7401-submodule-summary.sh\n+++ b/t/t7401-submodule-summary.sh\n@@ -21,7 +21,7 @@ add_file () {\n \t\ttest_tick &&\n \t\tgit commit -m \"Add $name\"\n \tdone >/dev/null\n-\tgit rev-parse --verify HEAD | cut -c1-7\n+\tgit rev-parse --short HEAD\n \tcd \"$owd\"\n }\n commit_file () {\n@@ -125,7 +125,7 @@ commit_file sm1 &&\n head3=$(\n \tcd sm1 &&\n \tgit reset --hard HEAD~2 >/dev/null &&\n-\tgit rev-parse --verify HEAD | cut -c1-7\n+\tgit rev-parse --short HEAD\n )\n \n test_expect_success 'modified submodule(backward)' \"\n-- \n2.28.0\n\n"},{"id":"404162","messageId":"20200821165952.14376-1-shouryashukla.oo@gmail.com","threadId":"54084","inReplyTo":null,"subject":"[GSoC][PATCH v3 0/5] t7401: modernize, cleanup and more","fromName":"Shourya Shukla","fromEmail":"shouryashukla.oo@gmail.com","sentAt":"2020-08-21T16:59:47Z","receivedAt":"2020-08-21T17:04:51Z","isPatch":true,"sender":{"key":"shouryashukla.oo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/43680618?v=4"},"body":"Greetings,\nThe is the v3 of the previously posted patch series with the same title:\nhttps://lore.kernel.org/git/20200812192737.13971-1-shouryashukla.oo@gmail.com/\n\nAfter suggestions from Junio and Kaartic I made some changes:\n\n-> In 0f7f1d3f9a (t7401: modernize style, 2020-07-23)), Kaartic advised\n   to use a '--short' instead of '--verify', which will remove the call\n   to 'cut' since '--short' is the name as '--verify' and on top of that\n   shortens the hash as per our need. Thus, deliver this change as a\n   separate commit 2c7afd6147 (t7401: use 'short' instead of 'verify'\n   and cut in rev-parse calls, 2020-08-14).\n\n-> In 948c85f637 (t7401: use 'short' instead of 'verify' and cut in\n   rev-parse calls, 2020-08-14), transfer the heredoc limiter change to\n   7c227a2d47 (t7401: change indentation for enhanced readability,\n   2020-08-11) since it is more apt there. This was suggested by Junio.\n\n-> 7c227a2d47 (t7401: change indentation for enhanced readability,\n   2020-08-11), improve the commit message and account for the heredoc\n   change which was transferred to this commit from the previous one.\n\n-> Although not suggested by anyone, but I also improved the NEEDSWORK\n   in 313c04e197 (t7401: add a NEEDSWORK, 2020-07-23) to make it more\n   precise.\n\nFeedback and reviews are appreciated. I am tagging along a range-diff\nbetween the v1 and v2 for ease of review.\n\nRegards,\nShourya Shukla\n\n-----\nrange-diff:\n\n1:  2939804509 ! 1:  0f7f1d3f9a t7401: modernize style\n    @@ Commit message\n         The tests in 't7401-submodule-summary.sh' were written a long time ago\n         and has a violation with respect to our CodingGuidelines which is,\n         incorrect spacing in usages of the redirection operator.\n    -    Using a Git command in the upstream of a pipe might result in us\n    -    losing its exit code. So, convert such usages so that they write to\n    -    a file and read from them.\n     \n         Mentored-by: Christian Couder <chriscool@tuxfamily.org>\n         Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>\n    @@ t/t7401-submodule-summary.sh: add_file () {\n                git add \"$name\" &&\n                test_tick &&\n                git commit -m \"Add $name\"\n    -   done >/dev/null\n    --  git rev-parse --verify HEAD | cut -c1-7\n    -+  git rev-parse --verify HEAD >out &&\n    -+  cut -c1-7 out\n    -   cd \"$owd\"\n    - }\n    - commit_file () {\n    -@@ t/t7401-submodule-summary.sh: commit_file sm1 &&\n    - head3=$(\n    -   cd sm1 &&\n    -   git reset --hard HEAD~2 >/dev/null &&\n    --  git rev-parse --verify HEAD | cut -c1-7\n    -+  git rev-parse --verify HEAD >out &&\n    -+  cut -c1-7 out\n    - )\n    - \n    - test_expect_success 'modified submodule(backward)' \"\n-:  ---------- > 2:  948c85f637 t7401: use 'short' instead of 'verify' and cut in rev-parse calls\n2:  00c6289d5e ! 3:  f5548fe7c6 t7401: change test_i18ncmp syntax for clarity\n    @@ Metadata\n     Author: Shourya Shukla <shouryashukla.oo@gmail.com>\n     \n      ## Commit message ##\n    -    t7401: change test_i18ncmp syntax for clarity\n    +    t7401: change syntax of test_i18ncmp calls for clarity\n     \n         Change the test_i18ncmp syntax from 'test_i18ncmp actual expected' to\n         'test_i18ncmp expected actual' to align it with the convention followed\n    @@ t/t7401-submodule-summary.sh: EOF\n      test_expect_success '--for-status' \"\n        git submodule summary --for-status HEAD^ >actual &&\n     -  test_i18ncmp actual - <<EOF\n    -+  test_i18ncmp - actual <<-EOF\n    ++  test_i18ncmp - actual <<EOF\n      * sm1 $head6...0000000:\n      \n      * sm2 0000000...$head7 (2):\n3:  f0b87ddaf6 ! 4:  7c227a2d47 t7401: change indentation for enhanced readability\n    @@ Commit message\n         t7401: change indentation for enhanced readability\n     \n         Change the indentation of expected outputs for enhanced readability of\n    -    the tests.\n    +    the tests. Also modify the heredoc string limiter in a test which lacks\n    +    it to support the indentation change.\n     \n         Mentored-by: Christian Couder <chriscool@tuxfamily.org>\n         Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>\n    @@ t/t7401-submodule-summary.sh: commit_file sm2\n      \n      test_expect_success '--for-status' \"\n        git submodule summary --for-status HEAD^ >actual &&\n    -   test_i18ncmp - actual <<-EOF\n    +-  test_i18ncmp - actual <<EOF\n     -* sm1 $head6...0000000:\n    ++  test_i18ncmp - actual <<-EOF\n     +  * sm1 $head6...0000000:\n      \n     -* sm2 0000000...$head7 (2):\n4:  a743c28d71 ! 5:  313c04e197 t7401: add a NEEDSWORK\n    @@ t/t7401-submodule-summary.sh\n     -This test tries to verify the sanity of summary subcommand of git submodule.\n     +This test script tries to verify the sanity of summary subcommand of git submodule.\n      '\n    -+# NEEDSWORK: This test script is old fashioned and may need a big cleanup since\n    -+# there are lots of commands taking place outside of 'test_expect_success'\n    -+# block, which is no longer in good-style.\n    ++# NEEDSWORK: This test script is old fashioned and may need a big cleanup due to\n    ++# various reasons, one of them being that there are lots of commands taking place\n    ++# outside of 'test_expect_success' block, which is no longer in good-style.\n      \n      . ./test-lib.sh\n\n-----\n\nShourya Shukla (5):\n  t7401: modernize style\n  t7401: use 'short' instead of 'verify' and cut in rev-parse calls\n  t7401: change syntax of test_i18ncmp calls for clarity\n  t7401: change indentation for enhanced readability\n  t7401: add a NEEDSWORK\n\n t/t7401-submodule-summary.sh | 149 ++++++++++++++++++-----------------\n 1 file changed, 76 insertions(+), 73 deletions(-)\n\n-- \n2.28.0\n\n"}]}