{"thread":{"id":"54043","subject":"[PATCH] Remove \"unsure\" for --message in subtree doc.","startedAt":"2020-08-14T14:54:32Z","lastAt":"2020-08-18T05:21:51Z","messageCount":6,"participants":["Danny Lin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"403668","messageId":"20200814145344.2413-1-danny0838@gmail.com","threadId":"54043","inReplyTo":null,"subject":"[PATCH] Remove \"unsure\" for --message in subtree doc.","fromName":"Danny Lin","fromEmail":"danny0838@gmail.com","sentAt":"2020-08-14T14:53:45Z","receivedAt":"2020-08-14T14:54:32Z","isPatch":true,"sender":{"key":"danny0838@gmail.com","avatar":"https://avatars.githubusercontent.com/u/531417?v=4"},"body":"It is definitely clear that --message is valid for add, merge and pull.\n\nSigned-off-by: Danny Lin <danny0838@gmail.com>\n---\n contrib/subtree/git-subtree.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\nindex 352deda69d..47e2c611fe 100644\n--- a/contrib/subtree/git-subtree.txt\n+++ b/contrib/subtree/git-subtree.txt\n@@ -139,7 +139,7 @@ OPTIONS\n \n -m <message>::\n --message=<message>::\n-\tThis option is only valid for add, merge and pull (unsure).\n+\tThis option is only valid for add, merge and pull.\n \tSpecify <message> as the commit message for the merge commit.\n \n \n-- \n2.28.0.windows.1\n\n"},{"id":"403692","messageId":"xmqqbljdxgkh.fsf@gitster.c.googlers.com","threadId":"54043","inReplyTo":"20200814145344.2413-1-danny0838@gmail.com","subject":"Re: [PATCH] Remove \"unsure\" for --message in subtree doc.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-08-14T17:50:22Z","receivedAt":"2020-08-14T17:50:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Danny Lin <danny0838@gmail.com> writes:\n\n> It is definitely clear that --message is valid for add, merge and pull.\n\nIf it is also definitely clear that it is _only_ valid for those\nthree, then the change is good.  I do not know if that is true\noffhand, though.\n\n>\n> Signed-off-by: Danny Lin <danny0838@gmail.com>\n> ---\n>  contrib/subtree/git-subtree.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\n> index 352deda69d..47e2c611fe 100644\n> --- a/contrib/subtree/git-subtree.txt\n> +++ b/contrib/subtree/git-subtree.txt\n> @@ -139,7 +139,7 @@ OPTIONS\n>  \n>  -m <message>::\n>  --message=<message>::\n> -\tThis option is only valid for add, merge and pull (unsure).\n> +\tThis option is only valid for add, merge and pull.\n>  \tSpecify <message> as the commit message for the merge commit.\n"},{"id":"403751","messageId":"CAMbsUu6WnHori2t1qG=6UVLWDNEw5FSXeTd-K6WKnpZi5h6q+w@mail.gmail.com","threadId":"54043","inReplyTo":"xmqqbljdxgkh.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] Remove \"unsure\" for --message in subtree doc.","fromName":"Danny Lin","fromEmail":"danny0838@gmail.com","sentAt":"2020-08-15T02:31:43Z","receivedAt":"2020-08-15T21:57:15Z","isPatch":true,"sender":{"key":"danny0838@gmail.com","avatar":"https://avatars.githubusercontent.com/u/531417?v=4"},"body":"Sorry, I missed that.\n\nFurther investigation suggests that it works with 'split --rejoin' and\nhas nothing to do with 'push' (actually, push never generates a merged\ncommit at all).  We can rephrase for that.\n\nJunio C Hamano <gitster@pobox.com> writes:\n>\n> Danny Lin <danny0838@gmail.com> writes:\n>\n> > It is definitely clear that --message is valid for add, merge and pull.\n>\n> If it is also definitely clear that it is _only_ valid for those\n> three, then the change is good.  I do not know if that is true\n> offhand, though.\n>\n"},{"id":"403776","messageId":"20200815023247.788-1-danny0838@gmail.com","threadId":"54043","inReplyTo":"CAMbsUu6WnHori2t1qG=6UVLWDNEw5FSXeTd-K6WKnpZi5h6q+w@mail.gmail.com","subject":"[PATCH] Revise supported options for --message in subtree doc.","fromName":"Danny Lin","fromEmail":"danny0838@gmail.com","sentAt":"2020-08-15T02:32:47Z","receivedAt":"2020-08-15T22:07:29Z","isPatch":true,"sender":{"key":"danny0838@gmail.com","avatar":"https://avatars.githubusercontent.com/u/531417?v=4"},"body":"Revise the documentation and remove previous \"unsure\" after making sure\nthat --message supports only 'add', 'merge', 'pull', and 'split --rejoin'.\n\nSigned-off-by: Danny Lin <danny0838@gmail.com>\n---\n contrib/subtree/git-subtree.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\nindex 352deda69d..9ccd431c7f 100644\n--- a/contrib/subtree/git-subtree.txt\n+++ b/contrib/subtree/git-subtree.txt\n@@ -139,7 +139,7 @@ OPTIONS\n \n -m <message>::\n --message=<message>::\n-\tThis option is only valid for add, merge and pull (unsure).\n+\tThis option is only valid for add, merge, pull, and split --rejoin.\n \tSpecify <message> as the commit message for the merge commit.\n \n \n-- \n2.28.0.windows.1\n\n"},{"id":"403830","messageId":"xmqq4kp143u0.fsf@gitster.c.googlers.com","threadId":"54043","inReplyTo":"20200815023247.788-1-danny0838@gmail.com","subject":"Re: [PATCH] Revise supported options for --message in subtree doc.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-08-17T16:47:19Z","receivedAt":"2020-08-17T16:47:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Danny Lin <danny0838@gmail.com> writes:\n\n> Subject: Re: [PATCH] Revise supported options for --message in subtree doc.\n\nDocumentation/SubmittingPatches:[[summary-section]]\n\n> Revise the documentation and remove previous \"unsure\" after making sure\n> that --message supports only 'add', 'merge', 'pull', and 'split --rejoin'.\n>\n> Signed-off-by: Danny Lin <danny0838@gmail.com>\n> ---\n>  contrib/subtree/git-subtree.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\n> index 352deda69d..9ccd431c7f 100644\n> --- a/contrib/subtree/git-subtree.txt\n> +++ b/contrib/subtree/git-subtree.txt\n> @@ -139,7 +139,7 @@ OPTIONS\n>  \n>  -m <message>::\n>  --message=<message>::\n> -\tThis option is only valid for add, merge and pull (unsure).\n> +\tThis option is only valid for add, merge, pull, and split --rejoin.\n>  \tSpecify <message> as the commit message for the merge commit.\n\n"},{"id":"403920","messageId":"20200818052109.1817-1-danny0838@gmail.com","threadId":"54043","inReplyTo":"xmqq4kp143u0.fsf@gitster.c.googlers.com","subject":"[PATCH] contrib/subtree: fix \"unsure\" for --message in the document","fromName":"Danny Lin","fromEmail":"danny0838@gmail.com","sentAt":"2020-08-18T05:21:10Z","receivedAt":"2020-08-18T05:21:51Z","isPatch":true,"sender":{"key":"danny0838@gmail.com","avatar":"https://avatars.githubusercontent.com/u/531417?v=4"},"body":"Revise the documentation and remove previous \"unsure\" after making sure\nthat --message supports only 'add', 'merge', 'pull', and 'split --rejoin'.\n\nSigned-off-by: Danny Lin <danny0838@gmail.com>\n---\n contrib/subtree/git-subtree.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\nindex 352deda69d..9ccd431c7f 100644\n--- a/contrib/subtree/git-subtree.txt\n+++ b/contrib/subtree/git-subtree.txt\n@@ -139,7 +139,7 @@ OPTIONS\n \n -m <message>::\n --message=<message>::\n-\tThis option is only valid for add, merge and pull (unsure).\n+\tThis option is only valid for add, merge, pull, and split --rejoin.\n \tSpecify <message> as the commit message for the merge commit.\n \n \n-- \n2.28.0.windows.1\n\n"}]}