{"thread":{"id":"54026","subject":"[PATCH] rebase: remove unused function reschedule_last_action","startedAt":"2020-08-12T13:45:58Z","lastAt":"2020-08-12T19:25:19Z","messageCount":3,"participants":["René Scharfe","Taylor Blau","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"403451","messageId":"80744078-c0a9-5b55-0578-d6b62af6673b@web.de","threadId":"54026","inReplyTo":null,"subject":"[PATCH] rebase: remove unused function reschedule_last_action","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2020-08-12T13:45:47Z","receivedAt":"2020-08-12T13:45:58Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"The only caller of reschedule_last_action was removed by ef64bb328df\n(rebase: strip unused code in git-rebase--preserve-merges.sh,\n2018-05-28); remove this unused shell function as well.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\n git-rebase--preserve-merges.sh | 10 ----------\n 1 file changed, 10 deletions(-)\n\ndiff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh\nindex dec90e9af67..b9c71d2a71b 100644\n--- a/git-rebase--preserve-merges.sh\n+++ b/git-rebase--preserve-merges.sh\n@@ -193,16 +193,6 @@ mark_action_done () {\n \tfi\n }\n\n-# Put the last action marked done at the beginning of the todo list\n-# again. If there has not been an action marked done yet, leave the list of\n-# items on the todo list unchanged.\n-reschedule_last_action () {\n-\ttail -n 1 \"$done\" | cat - \"$todo\" >\"$todo\".new\n-\tsed -e \\$d <\"$done\" >\"$done\".new\n-\tmv -f \"$todo\".new \"$todo\"\n-\tmv -f \"$done\".new \"$done\"\n-}\n-\n append_todo_help () {\n \tgettext \"\n Commands:\n--\n2.28.0\n"},{"id":"403452","messageId":"20200812134827.GB74542@syl.lan","threadId":"54026","inReplyTo":"80744078-c0a9-5b55-0578-d6b62af6673b@web.de","subject":"Re: [PATCH] rebase: remove unused function reschedule_last_action","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-08-12T13:48:27Z","receivedAt":"2020-08-12T13:48:52Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, Aug 12, 2020 at 03:45:47PM +0200, René Scharfe wrote:\n> The only caller of reschedule_last_action was removed by ef64bb328df\n> (rebase: strip unused code in git-rebase--preserve-merges.sh,\n> 2018-05-28); remove this unused shell function as well.\n\nEasy peasy ;-). Obviously correct, and thanks for cleaning this up.\n\n  Reviewed-by: Taylor Blau <me@ttaylorr.com>\n\n> Signed-off-by: René Scharfe <l.s.r@web.de>\n> ---\n>  git-rebase--preserve-merges.sh | 10 ----------\n>  1 file changed, 10 deletions(-)\n>\n> diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh\n> index dec90e9af67..b9c71d2a71b 100644\n> --- a/git-rebase--preserve-merges.sh\n> +++ b/git-rebase--preserve-merges.sh\n> @@ -193,16 +193,6 @@ mark_action_done () {\n>  \tfi\n>  }\n>\n> -# Put the last action marked done at the beginning of the todo list\n> -# again. If there has not been an action marked done yet, leave the list of\n> -# items on the todo list unchanged.\n> -reschedule_last_action () {\n> -\ttail -n 1 \"$done\" | cat - \"$todo\" >\"$todo\".new\n> -\tsed -e \\$d <\"$done\" >\"$done\".new\n> -\tmv -f \"$todo\".new \"$todo\"\n> -\tmv -f \"$done\".new \"$done\"\n> -}\n> -\n>  append_todo_help () {\n>  \tgettext \"\n>  Commands:\n> --\n> 2.28.0\n\nThanks,\nTaylor\n"},{"id":"403487","messageId":"xmqqv9hn650k.fsf@gitster.c.googlers.com","threadId":"54026","inReplyTo":"20200812134827.GB74542@syl.lan","subject":"Re: [PATCH] rebase: remove unused function reschedule_last_action","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-08-12T19:25:15Z","receivedAt":"2020-08-12T19:25:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau <me@ttaylorr.com> writes:\n\n> On Wed, Aug 12, 2020 at 03:45:47PM +0200, René Scharfe wrote:\n>> The only caller of reschedule_last_action was removed by ef64bb328df\n>> (rebase: strip unused code in git-rebase--preserve-merges.sh,\n>> 2018-05-28); remove this unused shell function as well.\n>\n> Easy peasy ;-). Obviously correct, and thanks for cleaning this up.\n>\n>   Reviewed-by: Taylor Blau <me@ttaylorr.com>\n>\n>> Signed-off-by: René Scharfe <l.s.r@web.de>\n\nI thought preserve-merges backend is on its way out, but I do not\nhave objection to have some part of it retire earlier than the\nremainder of it ;-)\n\nWill queue.  Thanks.\n\n>> ---\n>>  git-rebase--preserve-merges.sh | 10 ----------\n>>  1 file changed, 10 deletions(-)\n>>\n>> diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh\n>> index dec90e9af67..b9c71d2a71b 100644\n>> --- a/git-rebase--preserve-merges.sh\n>> +++ b/git-rebase--preserve-merges.sh\n>> @@ -193,16 +193,6 @@ mark_action_done () {\n>>  \tfi\n>>  }\n>>\n>> -# Put the last action marked done at the beginning of the todo list\n>> -# again. If there has not been an action marked done yet, leave the list of\n>> -# items on the todo list unchanged.\n>> -reschedule_last_action () {\n>> -\ttail -n 1 \"$done\" | cat - \"$todo\" >\"$todo\".new\n>> -\tsed -e \\$d <\"$done\" >\"$done\".new\n>> -\tmv -f \"$todo\".new \"$todo\"\n>> -\tmv -f \"$done\".new \"$done\"\n>> -}\n>> -\n>>  append_todo_help () {\n>>  \tgettext \"\n>>  Commands:\n>> --\n>> 2.28.0\n>\n> Thanks,\n> Taylor\n"}]}