{"thread":{"id":"53974","subject":"Git Test Coverage Report (August 3, 2020)","startedAt":"2020-08-03T15:00:06Z","lastAt":"2020-08-03T15:00:06Z","messageCount":1,"participants":["Derrick Stolee"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"402683","messageId":"f47a1b6b-f17f-c95f-ff0a-bcc4d12bdbb4@gmail.com","threadId":"53974","inReplyTo":null,"subject":"Git Test Coverage Report (August 3, 2020)","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-08-03T14:50:07Z","receivedAt":"2020-08-03T15:00:06Z","isPatch":false,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"Here is today's test coverage report.\n\nPlease ignore all of the strvec_push* lines, as those are routine refactors,\nand the lack of coverage is due to the previous code being uncovered. This is\nnot an issue with Peff's commit.\n\nThanks,\n-Stolee\n\n[1] https://derrickstolee.github.io/git-test-coverage/reports/2020-08-03-commits.txt\n\n---\n\nseen\ta4f4416e52c27b4f211311ee0b851e72179b5df4\njch\t851d073fe0c0632d14b39ab8434af1d710ae908b\nnext\tb10cc79966954619f1f5981f20a3a6476b5dd483\nmaster\t85b4e0a6dc8407de6f69808d9ee6debdf167ced3\nmaster@{1}\tbd42bbe1a46c0fe486fc33e82969275e27e4dc19\n\n\nUncovered code in 'seen' not in 'jch'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\nDamien Robert\t812a5889 remote.c: fix handling of %(push:remoteref)\nremote.c\n812a5889 1638) return NULL;\n812a5889 1645) return branch->refname;\n812a5889 1660) return NULL;\n812a5889 1774) return NULL;\n\nDerrick Stolee\tc74ad39b maintenance: add auto condition for commit-graph task\nbuiltin/gc.c\nc74ad39b 734) oid = &peeled;\nc74ad39b 736) return 0;\nc74ad39b 740) return 0;\nc74ad39b 742) return 0;\nc74ad39b 761) result = 1;\nc74ad39b 762) break;\nc74ad39b 781) return 0;\nc74ad39b 783) return 1;\n\nDerrick Stolee\t2bc0598a maintenance: add commit-graph task\nbuiltin/gc.c\n2bc0598a 828) return 1;\n2bc0598a 836) chain_path = get_commit_graph_chain_filename(r->objects->odb);\n2bc0598a 837) if (unlink(chain_path)) {\n2bc0598a 841) free(chain_path);\n2bc0598a 843) if (!run_write_commit_graph())\n2bc0598a 844) return 0;\n2bc0598a 847) return 1;\n\nDerrick Stolee\t46b9d9a3 maintenance: add prefetch task\nbuiltin/gc.c\n46b9d9a3 882) result = 1;\n46b9d9a3 883) goto cleanup;\n\nDerrick Stolee\tb3a53c21 maintenance: create auto condition for loose-objects\nbuiltin/gc.c\nb3a53c21 951) return 0;\nb3a53c21 953) return 1;\n\nDerrick Stolee\t27d1a32d maintenance: add loose-objects task\nbuiltin/gc.c\n27d1a32d 1005) return 1;\n27d1a32d 1022) result = 1;\n\nDerrick Stolee\t642b98f6 maintenance: add incremental-repack auto condition\nbuiltin/gc.c\n642b98f6 1042) return 0;\n642b98f6 1048) return 0;\n642b98f6 1050) return 1;\n\nDerrick Stolee\tbfe797a6 maintenance: add incremental-repack task\nbuiltin/gc.c\nbfe797a6 1078) static int rewrite_multi_pack_index(void)\nbfe797a6 1080) struct repository *r = the_repository;\nbfe797a6 1081) char *midx_name = get_midx_filename(r->objects->odb->path);\nbfe797a6 1083) unlink(midx_name);\nbfe797a6 1084) free(midx_name);\nbfe797a6 1086) return multi_pack_index_write();\nbfe797a6 1101) return 1;\nbfe797a6 1191) return 0;\nbfe797a6 1195) return 1;\nbfe797a6 1197) return rewrite_multi_pack_index();\nbfe797a6 1199) return 1;\nbfe797a6 1201) return !!rewrite_multi_pack_index();\nbfe797a6 1203) return 1;\nbfe797a6 1205) return !!rewrite_multi_pack_index();\n\nDerrick Stolee\t3814a14c maintenance: auto-size incremental-repack batch\nbuiltin/gc.c\n3814a14c 1160) result_size = TWO_GIGABYTES;\n\nDerrick Stolee\t417ead9f maintenance: initialize task array\nbuiltin/gc.c\n417ead9f 1318) result = 1;\n\nDerrick Stolee\tf22b2460 midx: use start_delayed_progress()\nmidx.c\nf22b2460 972) progress = start_delayed_progress(_(\"Writing chunks to multi-pack-index\"),\n\nEmily Shaffer\tc1debc60 parse-options: parse into argv_array\nparse-options-cb.c\nc1debc60 212) if (unset) {\nc1debc60 214) return 0;\nc1debc60 217) if (!arg)\nc1debc60 218) return -1;\nc1debc60 221) return 0;\n\nEmily Shaffer\tfe6127f2 hook: add list command\nbuiltin/hook.c\nfe6127f2 44) printf(_(\"no commands configured for hook '%s'\\n\"),\nfe6127f2 46) return 0;\n\nhook.c\nfe6127f2 85) return NULL;\n\nEmily Shaffer\tc45caa8c hook: add 'run' subcommand\nbuiltin/hook.c\nc45caa8c 85) usage_msg_opt(_(\"a hookname must be provided to operate on.\"),\n\nhook.c\nc45caa8c 95) emplace_hook(&hook_head, legacy_hook_path);\n\nJunio C Hamano\t328d5528 Merge branch 'es/config-hooks' into seen\nparse-options-cb.c\n328d5528 208) int parse_opt_strvec(const struct option *opt, const char *arg, int unset)\n328d5528 210) struct strvec *v = opt->value;\n328d5528 213) strvec_clear(v);\n328d5528 220) strvec_push(v, arg);\n\nJunio C Hamano\t5b26a7ec SQUASH???\nbuiltin/config.c\n5b26a7ec 258) int v = git_parse_maybe_bool(value_);\n5b26a7ec 259) if (v < 0)\n5b26a7ec 262) strbuf_addstr(buf, v ? \"true\" : \"false\");\n5b26a7ec 425) int v = git_parse_maybe_bool(value);\n5b26a7ec 426) if (v < 0)\n\nLin Sun\t6571d827 Support auto-merge for meld to follow the vim-diff behavior\nbuiltin/config.c\n6571d827 99) new_type = TYPE_BOOL_OR_STR;\n6571d827 260) strbuf_addstr(buf, value_);\n6571d827 427) return xstrdup(value);\n6571d827 429) return xstrdup(v ? \"true\" : \"false\");\n\nMatheus Tavares\te26e8bfc grep: honor sparse checkout patterns\nbuiltin/grep.c\ne26e8bfc 579) if (file_exists(sparse_file)) {\ne26e8bfc 583) free(sparse_file);\ne26e8bfc 584) free(patterns);\ne26e8bfc 585) return NULL;\n\nMatheus Tavares\ta2371e32 t/helper/test-config: facilitate addition of new cli options\nt/helper/test-config.c\na2371e32 103) goto print_usage_error;\na2371e32 160) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\na2371e32 167) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\na2371e32 175) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\na2371e32 205) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\na2371e32 232) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\n\nMatheus Tavares\t92bca22f config: correctly read worktree configs in submodules\nt/helper/test-config.c\n92bca22f 109) goto print_usage_error;\n92bca22f 114) fprintf(stderr, \"Cannot use --submodule with read_early_config\\n\");\n92bca22f 115) return TC_USAGE_ERROR;\n92bca22f 130) fprintf(stderr, \"Invalid argument to --submodule: '%s'\\n\",\n92bca22f 132) free(subrepo);\n92bca22f 133) ret = TC_USAGE_ERROR;\n92bca22f 134) goto out;\n92bca22f 187) fprintf(stderr, \"Cannot use --submodule with configset_get_value\\n\");\n92bca22f 188) ret = TC_USAGE_ERROR;\n92bca22f 189) goto out;\n92bca22f 210) fprintf(stderr, \"Cannot use --submodule with configset_get_value_multi\\n\");\n92bca22f 211) ret = TC_USAGE_ERROR;\n92bca22f 212) goto out;\n92bca22f 239) fprintf(stderr, \"Invalid syntax. Usage: test-tool config\"\n\nMatheus Tavares\tb77651be t/helper/test-config: return exit codes consistently\nt/helper/test-config.c\nb77651be 161) ret = TC_VALUE_NOT_FOUND;\nb77651be 168) ret = TC_VALUE_NOT_FOUND;\nb77651be 176) ret = TC_VALUE_NOT_FOUND;\nb77651be 206) ret = TC_VALUE_NOT_FOUND;\nb77651be 218) ret = TC_CONFIG_FILE_ERROR;\nb77651be 219) goto out;\nb77651be 233) ret = TC_VALUE_NOT_FOUND;\nb77651be 241) ret = TC_USAGE_ERROR;\n\nTaylor Blau\tf7a39a87 upload-pack.c: introduce 'uploadpackfilter.tree.maxDepth'\nupload-pack.c\nf7a39a87 1256) strbuf_release(&buf);\nf7a39a87 1257) return config_error_nonbool(var);\n\nTaylor Blau\t850afedc list_objects_filter_options: introduce 'list_object_filter_config_name'\nlist-objects-filter-options.c\n850afedc 23) break;\n850afedc 36) break;\n\n\n\nUncovered code in 'jch' not in 'next'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\nAaron Lipman\t0188ee9f bisect: introduce first-parent flag\nbuiltin/bisect--helper.c\n0188ee9f 457) first_parent_only = 1;\n\nJeff King\t22f9b7f3 strvec: convert builtin/ callers away from argv_array name\nbuiltin/am.c\n22f9b7f3 1679) strvec_push(&cp.args, am_path(state, \"patch\"));\n\nbuiltin/bisect--helper.c\n22f9b7f3 176) strvec_clear(&argv);\n\nbuiltin/bundle.c\n22f9b7f3 89) strvec_push(&pack_opts, \"--progress\");\n22f9b7f3 91) strvec_push(&pack_opts, \"--all-progress\");\n22f9b7f3 93) strvec_push(&pack_opts, \"--all-progress-implied\");\n\nbuiltin/clone.c\n22f9b7f3 832) strvec_push(&args, \"--progress\");\n\nbuiltin/describe.c\n22f9b7f3 604) strvec_push(&args, \"--always\");\n\nbuiltin/fetch.c\n22f9b7f3 1529) strvec_push(argv, \"-v\");\n\nbuiltin/gc.c\n22f9b7f3 579) strvec_push(&repack, \"-f\");\n22f9b7f3 581) strvec_pushf(&repack, \"--depth=%d\", aggressive_depth);\n22f9b7f3 583) strvec_pushf(&repack, \"--window=%d\", aggressive_window);\n\nbuiltin/pull.c\n22f9b7f3 535) strvec_push(&args, opt_progress);\n22f9b7f3 541) strvec_push(&args, opt_append);\n22f9b7f3 543) strvec_push(&args, opt_upload_pack);\n22f9b7f3 548) strvec_push(&args, opt_prune);\n22f9b7f3 558) strvec_push(&args, \"--recurse-submodules=on-demand\");\n22f9b7f3 564) strvec_push(&args, max_children);\n22f9b7f3 568) strvec_push(&args, opt_keep);\n22f9b7f3 572) strvec_push(&args, opt_unshallow);\n22f9b7f3 574) strvec_push(&args, opt_update_shallow);\n22f9b7f3 576) strvec_push(&args, opt_refmap);\n22f9b7f3 578) strvec_push(&args, opt_ipv4);\n22f9b7f3 580) strvec_push(&args, opt_ipv6);\n22f9b7f3 582) strvec_push(&args, \"--show-forced-updates\");\n22f9b7f3 584) strvec_push(&args, \"--no-show-forced-updates\");\n22f9b7f3 673) strvec_push(&args, opt_progress);\n22f9b7f3 677) strvec_push(&args, opt_diffstat);\n22f9b7f3 683) strvec_push(&args, opt_squash);\n22f9b7f3 685) strvec_push(&args, opt_commit);\n22f9b7f3 687) strvec_push(&args, opt_edit);\n22f9b7f3 689) strvec_pushf(&args, \"--cleanup=%s\", cleanup_arg);\n22f9b7f3 697) strvec_push(&args, opt_gpg_sign);\n22f9b7f3 878) strvec_push(&args, \"--rebase-merges\");\n22f9b7f3 884) strvec_push(&args, opt_diffstat);\n22f9b7f3 888) strvec_push(&args, opt_gpg_sign);\n22f9b7f3 890) strvec_push(&args, \"--no-autostash\");\n\nbuiltin/rebase.c\n22f9b7f3 826) strvec_push(&am.args, opts->gpg_sign_opt);\n22f9b7f3 861) strvec_clear(&am.args);\n22f9b7f3 872) strvec_split(&format_patch.args,\n22f9b7f3 883) strvec_clear(&am.args);\n22f9b7f3 905) strvec_clear(&am.args);\n22f9b7f3 914) strvec_push(&am.args, \"--rerere-autoupdate\");\n22f9b7f3 916) strvec_push(&am.args, \"--no-rerere-autoupdate\");\n22f9b7f3 918) strvec_push(&am.args, opts->gpg_sign_opt);\n\nbuiltin/receive-pack.c\n22f9b7f3 686) strvec_pushf(&proc->env_array,\n22f9b7f3 729) strvec_pushf(&proc.env_array, \"GIT_PUSH_OPTION_COUNT\");\n22f9b7f3 1795) strvec_push(&child.args, \"--show-resolving-progress\");\n\nbuiltin/remote.c\n22f9b7f3 1466) strvec_push(&fetch_argv, \"-v\");\n\nbuiltin/repack.c\n22f9b7f3 158) strvec_pushf(&cmd->args, \"--window=%s\", args->window);\n22f9b7f3 160) strvec_pushf(&cmd->args, \"--window-memory=%s\", args->window_memory);\n22f9b7f3 162) strvec_pushf(&cmd->args, \"--depth=%s\", args->depth);\n22f9b7f3 164) strvec_pushf(&cmd->args, \"--threads=%s\", args->threads);\n22f9b7f3 166) strvec_pushf(&cmd->args, \"--max-pack-size=%s\", args->max_pack_size);\n22f9b7f3 170) strvec_pushf(&cmd->args, \"--no-reuse-object\");\n\nbuiltin/replace.c\n22f9b7f3 234) strvec_push(&cmd.args, type_name(type));\n\nbuiltin/submodule--helper.c\n22f9b7f3 861) strvec_push(&cpr.args, \"--quiet\");\n22f9b7f3 1030) strvec_push(&cpr.args, \"--quiet\");\n22f9b7f3 1723) strvec_push(&child->args, \"--progress\");\n22f9b7f3 1727) strvec_pushl(&child->args, \"--prefix\", suc->prefix, NULL);\n\nbuiltin/worktree.c\n22f9b7f3 626) strvec_push(&cp.args, \"--quiet\");\n\nJeff King\tef8d7ac4 strvec: convert more callers away from argv_array name\ncolumn.c\nef8d7ac4 372) strvec_pushf(argv, \"--width=%d\", opts->width);\nef8d7ac4 374) strvec_pushf(argv, \"--indent=%s\", opts->indent);\n\ncompat/terminal.c\nef8d7ac4 276) strvec_pushl(&cp.args, \"infocmp\", \"-L\", \"-1\", NULL);\n\nconnect.c\nef8d7ac4 1236) strvec_push(args, \"-6\");\n\ndaemon.c\nef8d7ac4 490) static int upload_archive(const struct strvec *env)\nef8d7ac4 493) strvec_push(&cld.args, \"upload-archive\");\nef8d7ac4 803) strvec_clear(&env);\nef8d7ac4 924) strvec_pushf(&cld.env_array, \"REMOTE_ADDR=[%s]\", buf);\nef8d7ac4 925) strvec_pushf(&cld.env_array, \"REMOTE_PORT=%d\",\n\nexec-cmd.c\nef8d7ac4 342) strvec_clear(&nargv);\n\nJeff King\td70a9eb6 strvec: rename struct fields\ndaemon.c\nd70a9eb6 495) strvec_pushv(&cld.env_array, env->v);\n\nrun-command.c\nd70a9eb6 852) execve(argv.v[0], (char *const *) argv.v,\n\nt/helper/test-run-command.c\nd70a9eb6 251) arg_offset = args.nr;\nd70a9eb6 278) cp.argv = args.v;\nd70a9eb6 284) const char *arg = args.v[j + arg_offset];\nd70a9eb6 301) (int)j, args.v[j + arg_offset]);\n\nJeff King\tfe4a0a28 argv-array: add pop function\nstrvec.c\nfe4a0a28 63) return;\n\nJeff King\tb992657e argv-array: add detach function\nstrvec.c\nb992657e 103) return xcalloc(1, sizeof(const char *));\n\nJeff King\tf6d8942b strvec: fix indentation in renamed calls\nbuiltin/rebase.c\nf6d8942b 873)      opts->git_format_patch_opt.buf);\n\ndaemon.c\nf6d8942b 926)      ntohs(sin6_addr->sin6_port));\n\nJeff King\tc972bf4c strvec: convert remaining callers away from argv_array name\nmidx.c\nc972bf4c 1421) strvec_push(&cmd.args, \"--delta-islands\");\n\npager.c\nc972bf4c 71) static void setup_pager_env(struct strvec *env)\nc972bf4c 91) strvec_push(env, argv[i]);\nc972bf4c 100) strvec_push(&pager_process->args, pager);\nc972bf4c 129) strvec_push(&pager_process.env_array, \"GIT_PAGER_IN_USE\");\n\nremote-curl.c\nc972bf4c 1158) strvec_pushl(&args, \"-v\", \"-v\", NULL);\nc972bf4c 1164) strvec_push(&args, \"--update-shallow\");\nc972bf4c 1277) strvec_push(&child.args, \"--dry-run\");\nc972bf4c 1305) strvec_push(&args, \"--dry-run\");\nc972bf4c 1309) strvec_push(&args, \"--signed=if-asked\");\nc972bf4c 1313) strvec_push(&args, \"--quiet\");\n\nsequencer.c\nc972bf4c 3666) strvec_push(&cmd.args, opts->gpg_sign);\n\nsubmodule.c\nc972bf4c 689) strvec_pushf(&cp.args, \"--src-prefix=%s%s/\",\nc972bf4c 691) strvec_pushf(&cp.args, \"--dst-prefix=%s%s/\",\nc972bf4c 1786) strvec_push(&cp.args, \"-uno\");\nc972bf4c 1791) strvec_push(&cp.args, \"--ignored\");\n\nt/helper/test-run-command.c\nc972bf4c 75) strvec_pushl(&cp->args, \"sh\", test, NULL);\nc972bf4c 77) strvec_push(&cp->args, \"--quiet\");\nc972bf4c 79) strvec_push(&cp->args, \"-i\");\nc972bf4c 81) strvec_push(&cp->args, \"-v\");\nc972bf4c 83) strvec_push(&cp->args, \"-V\");\nc972bf4c 85) strvec_push(&cp->args, \"-x\");\nc972bf4c 87) strvec_push(&cp->args, \"--write-junit-xml\");\nc972bf4c 223) struct strvec args = STRVEC_INIT;\nc972bf4c 244) strvec_clear(&args);\nc972bf4c 246) strvec_pushl(&args, \"sh\", \"-c\",\nc972bf4c 249) strvec_pushl(&args, \"test-tool\", \"run-command\",\nc972bf4c 257) strvec_push(&args, argv[j]);\nc972bf4c 271) strvec_push(&args, buf);\nc972bf4c 304) strvec_clear(&args);\nc972bf4c 314) strvec_clear(&args);\nc972bf4c 341) strvec_pushl(&cp.args,\n\ntmp-objdir.c\nc972bf4c 102) strvec_pushf(env, \"%s=%s%c%s\", key, old, PATH_SEP, val);\n\nupload-pack.c\nc972bf4c 301) strvec_pushf(&pack_objects.args, \"--filter=%s\", buf.buf);\n\nJohannes Schindelin\tc5aa6db6 argv_array: offer to split a string by whitespace\nstrvec.c\nc5aa6db6 72) to_split++;\n\nJunio C Hamano\ta8ba57e4 Merge branch 'bc/sha-256-part-3' into jch\nbuiltin/verify-pack.c\na8ba57e4 22) strvec_push(argv, \"--verify-stat-only\");\n\nsetup.c\na8ba57e4 497) return config_error_nonbool(var);\n\nMichael Forney\tea3f7e59 revision: use repository from rev_info when parsing commits\nrevision.c\nea3f7e59 1062) if (repo_parse_commit(revs->repo, p) < 0)\n\nPhillip Wood\tb61f854f rebase -i: support --ignore-date\nsequencer.c\nb61f854f 893) return NULL;\nb61f854f 1477) res = -1;\nb61f854f 1478) goto out;\n\nPhillip Wood\tfce7916a rebase -i: support --committer-date-is-author-date\nsequencer.c\nfce7916a 1395) goto out;\nfce7916a 1399) goto out;\n\nRené Scharfe\t0aa49583 upload-pack: use buffered I/O to talk to rev-list\nupload-pack.c\n0aa49583 642) goto error;\n\nRené Scharfe\te2aa486c midx: use buffered I/O to talk to pack-objects\nmidx.c\ne2aa486c 1453) error_errno(_(\"could not close stdin of pack-objects\"));\ne2aa486c 1454) result = 1;\ne2aa486c 1455) finish_command(&cmd);\ne2aa486c 1456) goto cleanup;\n\n\n\nUncovered code in 'next' not in 'master'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\n\n\nUncovered code in 'master' not in 'master@{1}'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\nbrian m. carlson\tcd85b447 remote-curl: make --force-with-lease work with non-ASCII ref names\nremote-curl.c\ncd85b447 128) return -1;\n\nJeff King\tec91ffca verify_repository_format(): complain about new extensions in v0 repo\nsetup.c\nec91ffca 472) return config_error_nonbool(var);\nec91ffca 508) return -1;\nec91ffca 517) return -1;\n\nJunio C Hamano\t6e6029a8 fmt-merge-msg: allow merge destination to be omitted again\nfmt-merge-msg.c\n6e6029a8 29) return config_error_nonbool(key);\n\nSZEDER Gábor\t17e6275f commit-graph: simplify chunk writes into loop\ncommit-graph.c\n17e6275f 1766) return -1;\n\n\n"}]}