{"thread":{"id":"53973","subject":"[PATCH] docs: improve the example that illustrates git-notes path names","startedAt":"2020-08-03T14:43:40Z","lastAt":"2020-08-03T19:39:19Z","messageCount":9,"participants":["Noam Yorav-Raphael via GitGitGadget","Taylor Blau","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"402682","messageId":"pull.692.git.1596465817121.gitgitgadget@gmail.com","threadId":"53973","inReplyTo":null,"subject":"[PATCH] docs: improve the example that illustrates git-notes path names","fromName":"Noam Yorav-Raphael via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-08-03T14:43:36Z","receivedAt":"2020-08-03T14:43:40Z","isPatch":true,"sender":{"key":"noamraph@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1553464?v=4"},"body":"From: Noam Yorav-Raphael \n\nThe existing git-notes doc says:\n\n> Permitted pathnames have the form ab/cd/ef/…​/abcdef…​: a sequence of\n> directory names of two hexadecimal digits each followed by a filename\n> with the rest of the object ID.\n\nEven though the text says that the filename has the rest of the object ID,\nI felt the need to check this, since the example gives the impression that\nthe filename is the entire object ID (a schema which is quite prevalent).\n\nThe new example makes it clear that the filename has only the rest of the\nobject ID, and not the entire object ID.\n\nSigned-off-by: Noam Yorav-Raphael \n---\n Improve the example that illustrates git-notes path names\n \n The existing git-notes doc says:\n \n > Permitted pathnames have the form ab/cd/ef/…​/abcdef…​: a sequence of\n > directory names of two hexadecimal digits each followed by a filename\n > with the rest of the object ID.\n \n Even though the text says that the filename has the rest of the object\n ID, I felt the need to check this, since the example gives the\n impression that the filename is the entire object ID (a schema which is\n quite prevalent).\n \n The new example makes it clear that the filename has only the rest of\n the object ID, and not the entire object ID.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/692\n\n Documentation/git-notes.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\nindex ced2e8280e..9fc1979531 100644\n--- a/Documentation/git-notes.txt\n+++ b/Documentation/git-notes.txt\n@@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n contains \"files\" whose paths are the object names for the objects\n they describe, with some directory separators included for performance\n reasons footnote:[Permitted pathnames have the form\n-'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n names of two hexadecimal digits each followed by a filename with the\n rest of the object ID.].\n \n\nbase-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3\n-- \ngitgitgadget\n"},{"id":"402688","messageId":"20200803154852.GA48612@syl.lan","threadId":"53973","inReplyTo":"pull.692.git.1596465817121.gitgitgadget@gmail.com","subject":"Re: [PATCH] docs: improve the example that illustrates git-notes path names","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-08-03T15:48:52Z","receivedAt":"2020-08-03T15:48:56Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Aug 03, 2020 at 02:43:36PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:\n> From: Noam Yorav-Raphael \n>\n> The existing git-notes doc says:\n>\n> > Permitted pathnames have the form ab/cd/ef/…​/abcdef…​: a sequence of\n> > directory names of two hexadecimal digits each followed by a filename\n> > with the rest of the object ID.\n\nThis part of the commit message is unnecessary, since it can easily be\nread off from the diff.\n\n>\n> Even though the text says that the filename has the rest of the object ID,\n> I felt the need to check this, since the example gives the impression that\n> the filename is the entire object ID (a schema which is quite prevalent).\n>\n> The new example makes it clear that the filename has only the rest of the\n> object ID, and not the entire object ID.\n\nPlease use the imperative mood here. Instead of the above, consider:\n\n Make it clear that the filename has only the rest of the object ID,\n not the entirety of it.\n\n> Signed-off-by: Noam Yorav-Raphael \n> ---\n> Improve the example that illustrates git-notes path names\n>\n> The existing git-notes doc says:\n>\n> > Permitted pathnames have the form ab/cd/ef/…​/abcdef…​: a sequence of\n> > directory names of two hexadecimal digits each followed by a filename\n> > with the rest of the object ID.\n>\n> Even though the text says that the filename has the rest of the object\n> ID, I felt the need to check this, since the example gives the\n> impression that the filename is the entire object ID (a schema which is\n> quite prevalent).\n>\n> The new example makes it clear that the filename has only the rest of\n> the object ID, and not the entire object ID.\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/692\n>\n> Documentation/git-notes.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\n> index ced2e8280e..9fc1979531 100644\n> --- a/Documentation/git-notes.txt\n> +++ b/Documentation/git-notes.txt\n> @@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n> contains \"files\" whose paths are the object names for the objects\n> they describe, with some directory separators included for performance\n> reasons footnote:[Permitted pathnames have the form\n> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n\nI had to read this twice to figure out why the first 'ab' changed to\n'12'. It appears that this is to avoid having to use 'gh...' in the\nlast directory, since 'g', 'h' and so on aren't hexadecimal digits.\n\nMakes sense.\n\n> names of two hexadecimal digits each followed by a filename with the\n> rest of the object ID.].\n>\n>\n> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3\n> --\n> gitgitgadget\n\nThe patch looks fine, but the commit message needs some tweaking.\nThanks.\n\nThanks,\nTaylor\n"},{"id":"402695","messageId":"pull.692.v2.git.1596471677167.gitgitgadget@gmail.com","threadId":"53973","inReplyTo":"pull.692.git.1596465817121.gitgitgadget@gmail.com","subject":"[PATCH v2] docs: improve the example that illustrates git-notes path names","fromName":"Noam Yorav-Raphael via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-08-03T16:21:16Z","receivedAt":"2020-08-03T16:21:23Z","isPatch":true,"sender":{"key":"noamraph@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1553464?v=4"},"body":"From: Noam Yorav-Raphael \n\nMake it clear that the filename has only the rest of the object ID,\nnot the entirety of it.\n\nSigned-off-by: Noam Yorav-Raphael \n---\n Improve the example that illustrates git-notes path names\n \n docs: improve the example that illustrates git-notes path names\n \n Make it clear that the filename has only the rest of the object ID, not\n the entirety of it.\n \n Changed: improved the commit message, according to comments by Taylor\n Blau.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/692\n\nRange-diff vs v1:\n\n 1: 76a674871a ! 1: 8b3defb657 docs: improve the example that illustrates git-notes path names\n @@ Metadata\n ## Commit message ##\n docs: improve the example that illustrates git-notes path names\n \n - The existing git-notes doc says:\n -\n - > Permitted pathnames have the form ab/cd/ef/…​/abcdef…​: a sequence of\n - > directory names of two hexadecimal digits each followed by a filename\n - > with the rest of the object ID.\n -\n - Even though the text says that the filename has the rest of the object ID,\n - I felt the need to check this, since the example gives the impression that\n - the filename is the entire object ID (a schema which is quite prevalent).\n -\n - The new example makes it clear that the filename has only the rest of the\n - object ID, and not the entire object ID.\n + Make it clear that the filename has only the rest of the object ID,\n + not the entirety of it.\n \n Signed-off-by: Noam Yorav-Raphael \n \n\n\n Documentation/git-notes.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\nindex ced2e8280e..9fc1979531 100644\n--- a/Documentation/git-notes.txt\n+++ b/Documentation/git-notes.txt\n@@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n contains \"files\" whose paths are the object names for the objects\n they describe, with some directory separators included for performance\n reasons footnote:[Permitted pathnames have the form\n-'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n names of two hexadecimal digits each followed by a filename with the\n rest of the object ID.].\n \n\nbase-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3\n-- \ngitgitgadget\n"},{"id":"402696","messageId":"20200803163110.GC50799@syl.lan","threadId":"53973","inReplyTo":"pull.692.v2.git.1596471677167.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] docs: improve the example that illustrates git-notes path names","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-08-03T16:31:10Z","receivedAt":"2020-08-03T16:31:14Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Noam,\n\nOn Mon, Aug 03, 2020 at 04:21:16PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:\n> From: Noam Yorav-Raphael \n>\n> Make it clear that the filename has only the rest of the object ID,\n> not the entirety of it.\n\nThis looks great, thank you. I left one note below, but I don't think\nthat you should feel obligated to address it.\n\n> Signed-off-by: Noam Yorav-Raphael \n> ---\n> Improve the example that illustrates git-notes path names\n>\n> docs: improve the example that illustrates git-notes path names\n>\n> Make it clear that the filename has only the rest of the object ID, not\n> the entirety of it.\n>\n> Changed: improved the commit message, according to comments by Taylor\n> Blau.\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v2\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v2\n> Pull-Request: https://github.com/gitgitgadget/git/pull/692\n>\n> Range-diff vs v1:\n>\n> 1: 76a674871a ! 1: 8b3defb657 docs: improve the example that illustrates git-notes path names\n> @@ Metadata\n> ## Commit message ##\n> docs: improve the example that illustrates git-notes path names\n>\n> - The existing git-notes doc says:\n> -\n> - > Permitted pathnames have the form ab/cd/ef/…​/abcdef…​: a sequence of\n> - > directory names of two hexadecimal digits each followed by a filename\n> - > with the rest of the object ID.\n> -\n> - Even though the text says that the filename has the rest of the object ID,\n> - I felt the need to check this, since the example gives the impression that\n> - the filename is the entire object ID (a schema which is quite prevalent).\n> -\n> - The new example makes it clear that the filename has only the rest of the\n> - object ID, and not the entire object ID.\n> + Make it clear that the filename has only the rest of the object ID,\n> + not the entirety of it.\n>\n> Signed-off-by: Noam Yorav-Raphael \n>\n>\n>\n> Documentation/git-notes.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\n> index ced2e8280e..9fc1979531 100644\n> --- a/Documentation/git-notes.txt\n> +++ b/Documentation/git-notes.txt\n> @@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n> contains \"files\" whose paths are the object names for the objects\n> they describe, with some directory separators included for performance\n> reasons footnote:[Permitted pathnames have the form\n> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n\nSorry for not suggesting this earlier, but I think you could just as\neasily start this with '01' instead of '12'. I don't think that it\nmatters, though, the point that you're trying to illustrate is perfectly\nclear.\n\n> names of two hexadecimal digits each followed by a filename with the\n> rest of the object ID.].\n>\n>\n> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3\n> --\n> gitgitgadget\n\n Reviewed-by: Taylor Blau \n\nThanks,\nTaylor\n"},{"id":"402700","messageId":"xmqq7dufwtio.fsf@gitster.c.googlers.com","threadId":"53973","inReplyTo":"20200803154852.GA48612@syl.lan","subject":"Re: [PATCH] docs: improve the example that illustrates git-notes path names","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-08-03T17:04:15Z","receivedAt":"2020-08-03T17:04:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n>> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\n>> index ced2e8280e..9fc1979531 100644\n>> --- a/Documentation/git-notes.txt\n>> +++ b/Documentation/git-notes.txt\n>> @@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n>> contains \"files\" whose paths are the object names for the objects\n>> they describe, with some directory separators included for performance\n>> reasons footnote:[Permitted pathnames have the form\n>> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n>> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n>\n> I had to read this twice to figure out why the first 'ab' changed to\n> '12'. It appears that this is to avoid having to use 'gh...' in the\n> last directory, since 'g', 'h' and so on aren't hexadecimal digits.\n\nYou can wrap-around to '0' after counting up to 'f', no ;-)?\n\nHaving '/.../' between '56' and '789' to indicate \"there are more\nlevels possible here\" is somewhat misleading with the new example.\nWe could argue that the original objectname does not have to be\n\"123456789abc..\" but then the whole exercise becomes somewhat\npointless as the objectname could have been 'abcdef...abcdef...'.\n\nAnother minor nit: it probably makes it read more natural to start\ncounting from '0' when writing hexadecimal, if we really want to\nuse sequence of ascending hexdigits.\n\nUsing a seemingly random example 85/b4/.../808d9ee6debdf167ced3\nmight be less confusing, because ...\n\n>> names of two hexadecimal digits each followed by a filename with the\n>> rest of the object ID.].\n\n... I think these two lines is pleanty clear than any example, so I\nam OK with either the old or the updated example, but I think a\nseemingly random example as long as the leaf level does not share\nthe leading hexdigits as the pathname would work the best.\n\n"},{"id":"402701","messageId":"20200803171313.GE50799@syl.lan","threadId":"53973","inReplyTo":"xmqq7dufwtio.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] docs: improve the example that illustrates git-notes path names","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-08-03T17:13:13Z","receivedAt":"2020-08-03T17:13:17Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Aug 03, 2020 at 10:04:15AM -0700, Junio C Hamano wrote:\n> Taylor Blau writes:\n>\n> >> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\n> >> index ced2e8280e..9fc1979531 100644\n> >> --- a/Documentation/git-notes.txt\n> >> +++ b/Documentation/git-notes.txt\n> >> @@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n> >> contains \"files\" whose paths are the object names for the objects\n> >> they describe, with some directory separators included for performance\n> >> reasons footnote:[Permitted pathnames have the form\n> >> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n> >> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n> >\n> > I had to read this twice to figure out why the first 'ab' changed to\n> > '12'. It appears that this is to avoid having to use 'gh...' in the\n> > last directory, since 'g', 'h' and so on aren't hexadecimal digits.\n>\n> You can wrap-around to '0' after counting up to 'f', no ;-)?\n\n;-).\n\n> Having '/.../' between '56' and '789' to indicate \"there are more\n> levels possible here\" is somewhat misleading with the new example.\n> We could argue that the original objectname does not have to be\n> \"123456789abc..\" but then the whole exercise becomes somewhat\n> pointless as the objectname could have been 'abcdef...abcdef...'.\n>\n> Another minor nit: it probably makes it read more natural to start\n> counting from '0' when writing hexadecimal, if we really want to\n> use sequence of ascending hexdigits.\n>\n> Using a seemingly random example 85/b4/.../808d9ee6debdf167ced3\n> might be less confusing, because ...\n>\n> >> names of two hexadecimal digits each followed by a filename with the\n> >> rest of the object ID.].\n>\n> ... I think these two lines is pleanty clear than any example, so I\n> am OK with either the old or the updated example, but I think a\n> seemingly random example as long as the leaf level does not share\n> the leading hexdigits as the pathname would work the best.\n\nI agree with your reasoning (it didn't occur to me as a problem before,\nbut seeing it spelled out in front of me I could understand how such an\nexample might be confusing).\n\nThanks,\nTaylor\n"},{"id":"402740","messageId":"pull.692.v3.git.1596481815803.gitgitgadget@gmail.com","threadId":"53973","inReplyTo":"pull.692.v2.git.1596471677167.gitgitgadget@gmail.com","subject":"[PATCH v3] docs: improve the example that illustrates git-notes path names","fromName":"Noam Yorav-Raphael via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-08-03T19:10:15Z","receivedAt":"2020-08-03T19:10:20Z","isPatch":true,"sender":{"key":"noamraph@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1553464?v=4"},"body":"From: Noam Yorav-Raphael \n\nMake it clear that the filename has only the rest of the object ID,\nnot the entirety of it.\n\nSigned-off-by: Noam Yorav-Raphael \n---\n Improve the example that illustrates git-notes path names\n \n docs: improve the example that illustrates git-notes path names\n \n Make it clear that the filename has only the rest of the object ID, not\n the entirety of it.\n \n Changes since v1:\n \n * Improved the commit message, according to comments by Taylor Blau.\n * Changed the parts to random hex, so the '...' won't be confusing,\n according to suggestion by Junio C Hamano.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v3\nPull-Request: https://github.com/gitgitgadget/git/pull/692\n\nRange-diff vs v2:\n\n 1: 8b3defb657 ! 1: e973e321d8 docs: improve the example that illustrates git-notes path names\n @@ Documentation/git-notes.txt: are taken from notes refs. A notes ref is usually\n they describe, with some directory separators included for performance\n reasons footnote:[Permitted pathnames have the form\n -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n -+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n ++'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory\n names of two hexadecimal digits each followed by a filename with the\n rest of the object ID.].\n \n\n\n Documentation/git-notes.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\nindex ced2e8280e..0a4200674c 100644\n--- a/Documentation/git-notes.txt\n+++ b/Documentation/git-notes.txt\n@@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n contains \"files\" whose paths are the object names for the objects\n they describe, with some directory separators included for performance\n reasons footnote:[Permitted pathnames have the form\n-'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n+'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory\n names of two hexadecimal digits each followed by a filename with the\n rest of the object ID.].\n \n\nbase-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3\n-- \ngitgitgadget\n"},{"id":"402741","messageId":"20200803191139.GA68002@syl.lan","threadId":"53973","inReplyTo":"pull.692.v3.git.1596481815803.gitgitgadget@gmail.com","subject":"Re: [PATCH v3] docs: improve the example that illustrates git-notes path names","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-08-03T19:11:39Z","receivedAt":"2020-08-03T19:11:44Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Aug 03, 2020 at 07:10:15PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:\n> From: Noam Yorav-Raphael \n>\n> Make it clear that the filename has only the rest of the object ID,\n> not the entirety of it.\n>\n> Signed-off-by: Noam Yorav-Raphael \n> ---\n> Improve the example that illustrates git-notes path names\n>\n> docs: improve the example that illustrates git-notes path names\n>\n> Make it clear that the filename has only the rest of the object ID, not\n> the entirety of it.\n>\n> Changes since v1:\n>\n> * Improved the commit message, according to comments by Taylor Blau.\n> * Changed the parts to random hex, so the '...' won't be confusing,\n> according to suggestion by Junio C Hamano.\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v3\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v3\n> Pull-Request: https://github.com/gitgitgadget/git/pull/692\n>\n> Range-diff vs v2:\n>\n> 1: 8b3defb657 ! 1: e973e321d8 docs: improve the example that illustrates git-notes path names\n> @@ Documentation/git-notes.txt: are taken from notes refs. A notes ref is usually\n> they describe, with some directory separators included for performance\n> reasons footnote:[Permitted pathnames have the form\n> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n> -+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n> ++'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory\n> names of two hexadecimal digits each followed by a filename with the\n> rest of the object ID.].\n>\n>\n>\n> Documentation/git-notes.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\n> index ced2e8280e..0a4200674c 100644\n> --- a/Documentation/git-notes.txt\n> +++ b/Documentation/git-notes.txt\n> @@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n> contains \"files\" whose paths are the object names for the objects\n> they describe, with some directory separators included for performance\n> reasons footnote:[Permitted pathnames have the form\n> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n> +'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory\n> names of two hexadecimal digits each followed by a filename with the\n> rest of the object ID.].\n>\n>\n> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3\n> --\n> gitgitgadget\n\nLooks good to me, but Junio should chime in, too.\n\n Acked-by: Taylor Blau \n\nThanks,\nTaylor\n"},{"id":"402743","messageId":"xmqqpn87v7rz.fsf@gitster.c.googlers.com","threadId":"53973","inReplyTo":"20200803191139.GA68002@syl.lan","subject":"Re: [PATCH v3] docs: improve the example that illustrates git-notes path names","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-08-03T19:39:12Z","receivedAt":"2020-08-03T19:39:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> On Mon, Aug 03, 2020 at 07:10:15PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:\n>> From: Noam Yorav-Raphael \n>>\n>> Make it clear that the filename has only the rest of the object ID,\n>> not the entirety of it.\n>>\n>> Signed-off-by: Noam Yorav-Raphael \n>> ---\n>> Improve the example that illustrates git-notes path names\n>>\n>> docs: improve the example that illustrates git-notes path names\n>>\n>> Make it clear that the filename has only the rest of the object ID, not\n>> the entirety of it.\n>>\n>> Changes since v1:\n>>\n>> * Improved the commit message, according to comments by Taylor Blau.\n>> * Changed the parts to random hex, so the '...' won't be confusing,\n>> according to suggestion by Junio C Hamano.\n>>\n>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v3\n>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v3\n>> Pull-Request: https://github.com/gitgitgadget/git/pull/692\n>>\n>> Range-diff vs v2:\n>>\n>> 1: 8b3defb657 ! 1: e973e321d8 docs: improve the example that illustrates git-notes path names\n>> @@ Documentation/git-notes.txt: are taken from notes refs. A notes ref is usually\n>> they describe, with some directory separators included for performance\n>> reasons footnote:[Permitted pathnames have the form\n>> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n>> -+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory\n>> ++'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory\n>> names of two hexadecimal digits each followed by a filename with the\n>> rest of the object ID.].\n>>\n>>\n>>\n>> Documentation/git-notes.txt | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt\n>> index ced2e8280e..0a4200674c 100644\n>> --- a/Documentation/git-notes.txt\n>> +++ b/Documentation/git-notes.txt\n>> @@ -223,7 +223,7 @@ are taken from notes refs. A notes ref is usually a branch which\n>> contains \"files\" whose paths are the object names for the objects\n>> they describe, with some directory separators included for performance\n>> reasons footnote:[Permitted pathnames have the form\n>> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory\n>> +'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory\n>> names of two hexadecimal digits each followed by a filename with the\n>> rest of the object ID.].\n>>\n>>\n>> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3\n>> --\n>> gitgitgadget\n>\n> Looks good to me, but Junio should chime in, too.\n>\n> Acked-by: Taylor Blau \n\nYeah, thanks, both.\n"}]}