{"thread":{"id":"53919","subject":"[PATCH] githooks.txt: use correct \"reference-transaction\" hook name","startedAt":"2020-07-24T13:58:01Z","lastAt":"2020-07-24T20:54:35Z","messageCount":3,"participants":["starlord via GitGitGadget","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"401997","messageId":"pull.681.git.1595599077623.gitgitgadget@gmail.com","threadId":"53919","inReplyTo":null,"subject":"[PATCH] githooks.txt: use correct \"reference-transaction\" hook name","fromName":"starlord via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-07-24T13:57:57Z","receivedAt":"2020-07-24T13:58:01Z","isPatch":true,"sender":{"key":"name:starlord","avatar":null},"body":"From: Bojun Chen <bojun.cbj@alibaba-inc.com>\n\nThe \"reference transaction\" hook was introduced in commit 6754159767\n(refs: implement reference transaction hook, 2020-06-19). The name of\nthe hook is declared as \"reference-transaction\" in \"refs.c\" and\ntestcases, but the name declared in \"githooks.txt\" is different.\n\nSigned-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>\n---\n    githooks.txt: use correct \"reference-transaction\" hook name\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/681\n\n Documentation/githooks.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/githooks.txt b/Documentation/githooks.txt\nindex 642471109f..31b601e4bc 100644\n--- a/Documentation/githooks.txt\n+++ b/Documentation/githooks.txt\n@@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to\n `git send-pack` on the other end, so you can simply `echo` messages\n for the user.\n \n-ref-transaction\n-~~~~~~~~~~~~~~~\n+reference-transaction\n+~~~~~~~~~~~~~~~~~~~~~\n \n This hook is invoked by any Git command that performs reference\n updates. It executes whenever a reference transaction is prepared,\n\nbase-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda\n-- \ngitgitgadget\n"},{"id":"401999","messageId":"20200724142156.GB1032@xps.pks.im","threadId":"53919","inReplyTo":"pull.681.git.1595599077623.gitgitgadget@gmail.com","subject":"Re: [PATCH] githooks.txt: use correct \"reference-transaction\" hook name","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2020-07-24T14:21:56Z","receivedAt":"2020-07-24T14:20:13Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"Hi Bojun,\n\nOn Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:\n> From: Bojun Chen <bojun.cbj@alibaba-inc.com>\n> \n> The \"reference transaction\" hook was introduced in commit 6754159767\n> (refs: implement reference transaction hook, 2020-06-19). The name of\n> the hook is declared as \"reference-transaction\" in \"refs.c\" and\n> testcases, but the name declared in \"githooks.txt\" is different.\n> \n> Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>\n\nIndeed, thanks for catching this!\n\nReviewed-by: Patrick Steinhardt <ps@pks.im>\n\nPatrick\n\n> ---\n>     githooks.txt: use correct \"reference-transaction\" hook name\n> \n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/681\n> \n>  Documentation/githooks.txt | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt\n> index 642471109f..31b601e4bc 100644\n> --- a/Documentation/githooks.txt\n> +++ b/Documentation/githooks.txt\n> @@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to\n>  `git send-pack` on the other end, so you can simply `echo` messages\n>  for the user.\n>  \n> -ref-transaction\n> -~~~~~~~~~~~~~~~\n> +reference-transaction\n> +~~~~~~~~~~~~~~~~~~~~~\n>  \n>  This hook is invoked by any Git command that performs reference\n>  updates. It executes whenever a reference transaction is prepared,\n> \n> base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda\n> -- \n> gitgitgadget\n"},{"id":"402026","messageId":"xmqqmu3ok516.fsf@gitster.c.googlers.com","threadId":"53919","inReplyTo":"20200724142156.GB1032@xps.pks.im","subject":"Re: [PATCH] githooks.txt: use correct \"reference-transaction\" hook name","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-07-24T20:54:29Z","receivedAt":"2020-07-24T20:54:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> Hi Bojun,\n>\n> On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:\n>> From: Bojun Chen <bojun.cbj@alibaba-inc.com>\n>> \n>> The \"reference transaction\" hook was introduced in commit 6754159767\n>> (refs: implement reference transaction hook, 2020-06-19). The name of\n>> the hook is declared as \"reference-transaction\" in \"refs.c\" and\n>> testcases, but the name declared in \"githooks.txt\" is different.\n>> \n>> Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>\n>\n> Indeed, thanks for catching this!\n>\n> Reviewed-by: Patrick Steinhardt <ps@pks.im>\n\nThanks.\n"}]}