{"thread":{"id":"53831","subject":"Git Test Coverage Report (v2.28.0-rc0)","startedAt":"2020-07-10T02:12:29Z","lastAt":"2020-07-10T02:56:18Z","messageCount":2,"participants":["Derrick Stolee","brian m. carlson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"401287","messageId":"fcc3f6da-2b6a-239d-c865-64378ba31510@gmail.com","threadId":"53831","inReplyTo":null,"subject":"Git Test Coverage Report (v2.28.0-rc0)","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-07-10T02:12:26Z","receivedAt":"2020-07-10T02:12:29Z","isPatch":false,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"Here is the test coverage report for code in v2.28.0-rc0 that was not in v2.27.0.\n\nThanks,\n-Stolee\n\n---\n\n\nUncovered code in 'v2.28.0-rc0' not in 'v2.27.0'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\nAbhishek Kumar\t4844812b commit-graph: introduce commit_graph_data_slab\ncommit-graph.c\n4844812b 1350) data->generation = GENERATION_NUMBER_MAX;\n\nbrian m. carlson\tac093d07 remote-curl: detect algorithm for dumb HTTP by size\nremote-curl.c\nac093d07 264) return NULL;\nac093d07 282)     transport_anonymize_url(url.buf));\n\nbrian m. carlson\t7f605017 remote-curl: implement object-format extensions\nremote-curl.c\n7f605017 199) algo = hash_algo_by_name(value);\n7f605017 200) if (algo == GIT_HASH_UNKNOWN)\n7f605017 202) options.hash_algo = &hash_algos[algo];\n\nbrian m. carlson\t4b831208 fetch-pack: parse and advertise the object-format capability\nfetch-pack.c\n4b831208 1212)     the_hash_algo->name, hash_name);\n4b831208 1214) } else if (hash_algo_by_ptr(the_hash_algo) != GIT_HASH_SHA1) {\n4b831208 1216)     the_hash_algo->name);\n\nbrian m. carlson\t122037c2 connect: add function to detect supported v1 hash functions\nconnect.c\n122037c2 566) hash = hash_algos[GIT_HASH_SHA1].name;\n122037c2 567) len = strlen(hash);\n122037c2 573) hash = next_server_feature_value(\"object-format\", &len, &offset);\n\nbrian m. carlson\t9de0dd36 serve: advertise object-format capability for protocol v2\nconnect.c\n9de0dd36 477) reader->hash_algo = &hash_algos[GIT_HASH_SHA1];\n\nbrian m. carlson\t1349ffed connect: add function to fetch value of a v2 server capability\nconnect.c\n1349ffed 98) return 0;\n\nbrian m. carlson\t6161ce7b bundle: detect hash algorithm when reading refs\nbundle.c\n6161ce7b 33) return NULL;\n6161ce7b 70) status = -1;\n6161ce7b 71) break;\n\nbrian m. carlson\t14570dc6 wrapper: add function to compare strings with different NUL termination\nwrapper.c\n14570dc6 112) return res;\n\nbrian m. carlson\t88a09a55 builtin/show-index: provide options to determine hash algo\nbuiltin/show-index.c\n88a09a55 29) hash_algo = hash_algo_by_name(hash_name);\n88a09a55 30) if (hash_algo == GIT_HASH_UNKNOWN)\n88a09a55 32) repo_set_hash_algo(the_repository, hash_algo);\n\nbrian m. carlson\t8b85ee4f transport-helper: implement object-format extensions\ntransport-helper.c\n8b85ee4f 1113) exit(128);\n\nbrian m. carlson\tbb095d08 builtin/receive-pack: detect when the server doesn't support our hash\nbuiltin/receive-pack.c\nbb095d08 1644) hash = hash_algos[GIT_HASH_SHA1].name;\nbb095d08 1645) len = strlen(hash);\n\nCarlo Marcelo Arenas Belón\taba8187e t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ)\nt/helper/test-regex.c\naba8187e 53) goto usage;\naba8187e 59) goto usage;\naba8187e 61) if (!strcmp(*argv, \"--silent\")) {\naba8187e 62) silent = 1;\naba8187e 64) argc--;\naba8187e 66) if (!argc)\naba8187e 67) goto usage;\naba8187e 69) pat = *argv++;\naba8187e 70) if (argc == 1)\naba8187e 71) str = NULL;\naba8187e 73) str = *argv++;\naba8187e 74) while (*argv) {\naba8187e 76) for (rf = reg_flags; rf->name; rf++)\naba8187e 77) if (!strcmp(*argv, rf->name)) {\naba8187e 78) flags |= rf->flag;\naba8187e 79) break;\naba8187e 81) if (!rf->name)\naba8187e 83) argv++;\naba8187e 88) ret = regcomp(&r, pat, flags);\naba8187e 89) if (ret) {\naba8187e 90) if (silent)\naba8187e 91) return ret;\naba8187e 96) if (!str)\naba8187e 97) return 0;\naba8187e 99) ret = regexec(&r, str, 1, m, 0);\naba8187e 100) if (ret) {\naba8187e 101) if (silent || ret == REG_NOMATCH)\naba8187e 102) return ret;\n\nChris Torek\t8bfcb3a6 git diff: improve range handling\nbuiltin/diff.c\n8bfcb3a6 329) usage(builtin_diff_usage);\n\nChristian Couder\tf203a88c upload-pack: move keepalive to upload_pack_data\nupload-pack.c\nf203a88c 1193) data->keepalive = git_config_int(var, value);\nf203a88c 1194) if (!data->keepalive)\nf203a88c 1195) data->keepalive = -1;\n\nChristian Couder\te9d882b8 upload-pack: change multi_ack to an enum\nupload-pack.c\ne9d882b8 1029) data->multi_ack = MULTI_ACK;\n\nChristian Couder\tf8edd1ca upload-pack: move use_sideband to upload_pack_data\nupload-pack.c\nf8edd1ca 1039) data->use_sideband = DEFAULT_PACKET_MAX;\n\nDenton Liu\t0181b600 pkt-line: define PACKET_READ_RESPONSE_END\npkt-line.c\n0181b600 106) die_errno(_(\"unable to write stateless separator packet\"));\n\nt/helper/test-pkt-line.c\n0181b600 50) printf(\"0002\\n\");\n0181b600 51) break;\n\nDerrick Stolee\tf32dde8c line-log: integrate with changed-path Bloom filters\nline-log.c\nf32dde8c 1159) return 1;\nf32dde8c 1166) return 0;\n\nElijah Newren\t051df3cf wt-status: show sparse checkout status as well\nwt-status.c\n051df3cf 1491) return;\n\nEric Sunshine\t916133ef worktree: prune linked worktree referencing main worktree path\nbuiltin/worktree.c\n916133ef 166) return -1;\n\nEric Sunshine\tc9b77f2c worktree: factor out repeated string literal\nbuiltin/worktree.c\nc9b77f2c 105) strbuf_addf(reason, _(\"unable to read gitdir file (%s)\"),\n\nJeff King\tb5a2068c upload-pack: actually use some upload_pack_data bitfields\nupload-pack.c\nb5a2068c 1076) data->no_progress = 1;\n\nJeff King\t65b5d9fa fast-export: allow seeding the anonymized mapping\nbuiltin/fast-export.c\n65b5d9fa 177) ret = NULL;\n\nJeff King\t750bb325 fast-export: store anonymized oids as hex strings\nbuiltin/fast-export.c\n750bb325 731)        anonymize_oid(oid_to_hex(&obj->oid)) :\n\nJeff King\ta0f65641 fast-export: stop storing lengths in anonymized hashmaps\nbuiltin/fast-export.c\na0f65641 149) b = container_of(entry_or_key, const struct anonymized_entry, hash);\na0f65641 150) return strcmp(a->orig, b->orig);\n\nJonathan Nieder\tb5651a20 experimental: default to fetch.writeCommitGraph=false\nrepo-settings.c\nb5651a20 60) UPDATE_DEFAULT_BOOL(r->settings.fetch_negotiation_algorithm, FETCH_NEGOTIATION_SKIPPING);\n\nJonathan Nieder\t3697caf4 config: let feature.experimental imply protocol.version=2\nprotocol.c\n3697caf4 35) return protocol_v2;\n\nJonathan Tan\tdd4b732d upload-pack: send part of packfile response as uri\nupload-pack.c\ndd4b732d 1412) string_list_clear(&data->uri_protocols, 0);\n\nJonathan Tan\t8d5d2a34 http-fetch: support fetching packfiles by URL\nhttp-fetch.c\n8d5d2a34 128) commits = walker_targets_stdin(&commit_id, &write_ref);\n\nJonathan Tan\t9da69a65 fetch-pack: support more than one pack lockfile\nbuiltin/fetch-pack.c\n9da69a65 246) pack_lockfiles.items[i].string);\n\nJonathan Tan\tacaaca7d upload-pack: refactor reading of pack-objects out\nupload-pack.c\nacaaca7d 210) return readsz;\nacaaca7d 438) send_client_data(1, output_state.buffer, output_state.used,\n\nJonathan Tan\t8e6adb69 http-fetch: refactor into function\nhttp-fetch.c\n8e6adb69 30) walker_targets_free(commits, commit_id, write_ref);\n8e6adb69 33) fprintf(stderr,\n\nPatrick Steinhardt\t67541597 refs: implement reference transaction hook\nrefs.c\n67541597 2047) return ret;\n67541597 2061) if (errno != EPIPE)\n67541597 2062) ret = -1;\n67541597 2063) break;\n\nRandall S. Becker\tf64b6a1f bugreport.c: replace strbuf_write_fd with write_in_full\nbugreport.c\nf64b6a1f 184) die_errno(_(\"unable to write to %s\"), report_path.buf);\n\n\n"},{"id":"401331","messageId":"20200710025537.GJ9782@camp.crustytoothpaste.net","threadId":"53831","inReplyTo":"fcc3f6da-2b6a-239d-c865-64378ba31510@gmail.com","subject":"Re: Git Test Coverage Report (v2.28.0-rc0)","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2020-07-10T02:55:37Z","receivedAt":"2020-07-10T02:56:18Z","isPatch":false,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2020-07-10 at 02:12:26, Derrick Stolee wrote:\n> brian m. carlson\tac093d07 remote-curl: detect algorithm for dumb HTTP by size\n\nI've noticed that I appear several times on this list.  As is probably\napparent, most of this is covered by the SHA-256 work, and will be\ncovered appropriately by it when run with an appropriate test option.\nThat won't fix things for 2.28, but it should cover 2.29.\n\nThe relevant series has hit my MX, if not the list, and if there are\nstill additional things outstanding that are uncovered, I'll send\nfollow-up patches to cover anything left over.\n-- \nbrian m. carlson: Houston, Texas, US\n"}]}