{"thread":{"id":"53637","subject":"[BUG] Installing git-gui (2.27.0)","startedAt":"2020-06-08T14:02:18Z","lastAt":"2020-06-23T13:21:14Z","messageCount":3,"participants":["Randall S. Becker","Pratyush Yadav"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"399294","messageId":"00dd01d63d9d$65f5dda0$31e198e0$@nexbridge.com","threadId":"53637","inReplyTo":null,"subject":"[BUG] Installing git-gui (2.27.0)","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2020-06-08T14:02:02Z","receivedAt":"2020-06-08T14:02:18Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"Hi,\n\nThis is what I found when trying to install the whole git package on the\nNonStop TNS/E platform:\n\n DEST /usr/local/share/git-gui/lib\n    INSTALL 644 tclIndex\ninstall: cannot stat 'lib/tclIndex': No such file or directory\nMakefile:293: recipe for target 'install' failed\n\nI’m not sure why we are only hitting this now at 2.27.0. We don’t use\ngit-gui anyway on this platform as it has no GUI interface. It looks like\nthe install script runs auto_mkindex that actually does nothing in our case,\nso lib/tclIndex is not built.\n\nThis does block the install from completing successfully. To bypass, I added\nthe following:\n\nindex f10caedaa7..943febaf75 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n          $(foreach p,$(PRELOAD_FILES),source $p\\;) \\\n          auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \\\n        | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \\\n+        echo >>$@ ; \\\n        else \\\n         echo >&2 \"    * $(TCL_PATH) failed; using unoptimized loading\"; \\\n         rm -f $@ ; \\\n\nRegards,\nRandall\n\n-- Brief whoami:\n NonStop developer since approximately 211288444200000000\n UNIX developer since approximately 421664400\n-- In my real life, I talk too much.\n\n\n\n"},{"id":"400361","messageId":"20200623124726.3f3g7gmm7zfwxvhu@yadavpratyush.com","threadId":"53637","inReplyTo":"00dd01d63d9d$65f5dda0$31e198e0$@nexbridge.com","subject":"Re: [BUG] Installing git-gui (2.27.0)","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2020-06-23T12:47:26Z","receivedAt":"2020-06-23T12:47:36Z","isPatch":false,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"Hi Randall,\n\nOn 08/06/20 10:02AM, Randall S. Becker wrote:\n> Hi,\n> \n> This is what I found when trying to install the whole git package on the\n> NonStop TNS/E platform:\n> \n>  DEST /usr/local/share/git-gui/lib\n>     INSTALL 644 tclIndex\n> install: cannot stat 'lib/tclIndex': No such file or directory\n> Makefile:293: recipe for target 'install' failed\n> \n> I’m not sure why we are only hitting this now at 2.27.0. We don’t use\n> git-gui anyway on this platform as it has no GUI interface. It looks like\n> the install script runs auto_mkindex that actually does nothing in our case,\n> so lib/tclIndex is not built.\n> \n> This does block the install from completing successfully. To bypass, I added\n> the following:\n> \n> index f10caedaa7..943febaf75 100644\n> --- a/git-gui/Makefile\n> +++ b/git-gui/Makefile\n> @@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n>           $(foreach p,$(PRELOAD_FILES),source $p\\;) \\\n>           auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \\\n>         | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \\\n> +        echo >>$@ ; \\\n>         else \\\n>          echo >&2 \"    * $(TCL_PATH) failed; using unoptimized loading\"; \\\n>          rm -f $@ ; \\\n> \n\nIIUC, this is a NonStop-specific problem. This fix shouldn't go in the \ngit-gui 'master', right?\n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"400367","messageId":"009701d64961$27667610$76336230$@nexbridge.com","threadId":"53637","inReplyTo":"20200623124726.3f3g7gmm7zfwxvhu@yadavpratyush.com","subject":"RE: [BUG] Installing git-gui (2.27.0)","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2020-06-23T13:21:02Z","receivedAt":"2020-06-23T13:21:14Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On, June 23, 2020 8:47 AM, Pratyush Yadav:\n> On 08/06/20 10:02AM, Randall S. Becker wrote:\n> > Hi,\n> >\n> > This is what I found when trying to install the whole git package on\n> > the NonStop TNS/E platform:\n> >\n> >  DEST /usr/local/share/git-gui/lib\n> >     INSTALL 644 tclIndex\n> > install: cannot stat 'lib/tclIndex': No such file or directory\n> > Makefile:293: recipe for target 'install' failed\n> >\n> > I’m not sure why we are only hitting this now at 2.27.0. We don’t use\n> > git-gui anyway on this platform as it has no GUI interface. It looks\n> > like the install script runs auto_mkindex that actually does nothing\n> > in our case, so lib/tclIndex is not built.\n> >\n> > This does block the install from completing successfully. To bypass, I\n> > added the following:\n> >\n> > index f10caedaa7..943febaf75 100644\n> > --- a/git-gui/Makefile\n> > +++ b/git-gui/Makefile\n> > @@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n> >           $(foreach p,$(PRELOAD_FILES),source $p\\;) \\\n> >           auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \\\n> >         | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \\\n> > +        echo >>$@ ; \\\n> >         else \\\n> >          echo >&2 \"    * $(TCL_PATH) failed; using unoptimized loading\";\n\\\n> >          rm -f $@ ; \\\n> >\n> \n> IIUC, this is a NonStop-specific problem. This fix shouldn't go in the\ngit-gui\n> 'master', right?\n\nThe component is still part of the git build, so unless it can be severed by\nconfiguration, it should go into 'master'. The Makefile should still\ngenerate a tclIndex, which the foreach is not guaranteed to do, apparently.\n\nRandall\n\n\n"}]}