{"thread":{"id":"53623","subject":"[PATCH] doc: fix a typo inside `--bare` section","startedAt":"2020-06-06T12:15:00Z","lastAt":"2020-06-07T18:54:53Z","messageCount":3,"participants":["Angel via GitGitGadget","Junio C Hamano","F8ER"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"399230","messageId":"pull.649.git.1591445695220.gitgitgadget@gmail.com","threadId":"53623","inReplyTo":null,"subject":"[PATCH] doc: fix a typo inside `--bare` section","fromName":"Angel via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-06-06T12:14:55Z","receivedAt":"2020-06-06T12:15:00Z","isPatch":true,"sender":{"key":"name:Angel","avatar":null},"body":"From: Mark Williams <the.f8er@gmail.com>\n\nAdd a word `variable` and a `$` sign before variable's\nname in `--bare` argument section. Without this word someone\nmight be confused.\n\nSigned-off-by: Mark Williams <the.f8er@gmail.com>\n---\n    doc: fix a typo inside --bare section\n    \n    doc: fix a typo inside --bare section\n    \n    Add a word variable and a $ sign before variable's name in --bare \n    argument section. Without this word someone might be confused.\n    \n    Signed-off-by: Mark Williams the.f8er@gmail.com [the.f8er@gmail.com]\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-649%2Fvv7v7%2Fpatch-3-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-649/vv7v7/patch-3-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/649\n\n Documentation/git-init.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-init.txt b/Documentation/git-init.txt\nindex adc6adfd380..7f8b0bd6c4d 100644\n--- a/Documentation/git-init.txt\n+++ b/Documentation/git-init.txt\n@@ -45,8 +45,8 @@ Only print error and warning messages; all other output will be suppressed.\n \n --bare::\n \n-Create a bare repository. If `GIT_DIR` environment is not set, it is set to the\n-current working directory.\n+Create a bare repository. If the `$GIT_DIR` environment variable is not set, it\n+is set to the current working directory.\n \n --object-format=<format>::\n \n\nbase-commit: 20514004ddf1a3528de8933bc32f284e175e1012\n-- \ngitgitgadget\n"},{"id":"399249","messageId":"xmqqh7vmn72l.fsf@gitster.c.googlers.com","threadId":"53623","inReplyTo":"pull.649.git.1591445695220.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: fix a typo inside `--bare` section","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-06-07T17:01:38Z","receivedAt":"2020-06-07T17:01:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Angel via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Mark Williams <the.f8er@gmail.com>\n>\n> Add a word `variable` and a `$` sign before variable's\n> name in `--bare` argument section. Without this word someone\n> might be confused.\n>\n> Signed-off-by: Mark Williams <the.f8er@gmail.com>\n> ---\n>     doc: fix a typo inside --bare section\n>     \n>     doc: fix a typo inside --bare section\n>     \n>     Add a word variable and a $ sign before variable's name in --bare \n>     argument section. Without this word someone might be confused.\n\nA quick and dirty\n\n  $ git grep 'GIT_[A-Z]*[^A-Za-z0-9] .*environment' Documentation/\n\ntells us that adding \"environment variable\" is probably the right\nthing to do, but we should not add the variable dereference '$' in\nfront (and fix some that do spell $GIT_PAGER etc. to lose '$').\n\nIn shell, $V is a notation to always name the value in the variable,\nand it is clearer to refer to the variable itself without the '$'\nsign.  '$V' means \"the value that currently is in the variable V\".\n\n\tV=newvalue\n\tW=\"old value of $V\"\n\nThis is unlike C where using a variable as lvalue on the left hand\nside of assignment does not need different spelling as the variable\nis used as rvalue, e.g.\n\n\tvariable = newvalue;\n\tanother_variable = 2 * variable;\n\n> -Create a bare repository. If `GIT_DIR` environment is not set, it is set to the\n> -current working directory.\n> +Create a bare repository. If the `$GIT_DIR` environment variable is not set, it\n> +is set to the current working directory.\n>  \n>  --object-format=<format>::\n>  \n>\n> base-commit: 20514004ddf1a3528de8933bc32f284e175e1012\n"},{"id":"399254","messageId":"65cb716b-2766-e066-1d0e-21c899223060@gmail.com","threadId":"53623","inReplyTo":"xmqqh7vmn72l.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] doc: fix a typo inside `--bare` section","fromName":"F8ER","fromEmail":"the.f8er@gmail.com","sentAt":"2020-06-07T18:54:46Z","receivedAt":"2020-06-07T18:54:53Z","isPatch":true,"sender":{"key":"the.f8er@gmail.com","avatar":null},"body":"Dear Junio C Hamano,\n\nThanks!\n\nOn 6/7/2020 7:01 PM, Junio C Hamano wrote:\n\n> tells us that adding \"environment variable\" is probably the right\n> thing to do,\nWhat should I do next? I mean, how to achieve this? This is the first \ntime me doing that.\n> but we should not add the variable dereference '$' in\n> front (and fix some that do spell $GIT_PAGER etc. to lose '$').\n\nShould I remove it from commit, if so, how to?\n\n\nBest regards,\n\nMark\n\n"}]}