{"thread":{"id":"53613","subject":"[PATCH] msvc: fix \"REG_STARTEND\" issue","startedAt":"2020-06-04T21:10:00Z","lastAt":"2020-06-04T21:10:00Z","messageCount":1,"participants":["Johannes Schindelin via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"399153","messageId":"pull.648.git.1591304996279.gitgitgadget@gmail.com","threadId":"53613","inReplyTo":null,"subject":"[PATCH] msvc: fix \"REG_STARTEND\" issue","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-06-04T21:09:56Z","receivedAt":"2020-06-04T21:10:00Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nIn 897d68e7af82 (Makefile: use curl-config --cflags, 2020-03-26), we\ntaught the build process to use `curl-config --cflags` to make sure that\nit can find cURL's headers.\n\nIn the MSVC build, this is completely bogus because we're running in a\nGit for Windows SDK whose `curl-config` supports the _GCC_ build.\n\nLet's just ignore each and every `-I<path>` option where `<path>` points\nto GCC/Clang specific headers.\n\nReported by Jeff Hostetler in\nhttps://github.com/microsoft/git/issues/275.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    msvc: fix \"REG_STARTEND\" issue\n    \n    The MSVC build is actually not tested in our CI/PR builds, that's how\n    this regression could creep in.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-648%2Fdscho%2Ffix-msvc-build-git-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-648/dscho/fix-msvc-build-git-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/648\n\n compat/vcbuild/scripts/clink.pl | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl\nindex d9f71b7cbb7..61ad084a7b7 100755\n--- a/compat/vcbuild/scripts/clink.pl\n+++ b/compat/vcbuild/scripts/clink.pl\n@@ -23,7 +23,9 @@\n \t    # before any \"-l*\" flags.\n \t    $is_debug = 1;\n \t}\n-\tif (\"$arg\" =~ /^-[DIMGOZ]/) {\n+\tif (\"$arg\" =~ /^-I\\/mingw(32|64)/) {\n+\t\t# eat\n+\t} elsif (\"$arg\" =~ /^-[DIMGOZ]/) {\n \t\tpush(@cflags, $arg);\n \t} elsif (\"$arg\" eq \"-o\") {\n \t\tmy $file_out = shift @ARGV;\n\nbase-commit: 20514004ddf1a3528de8933bc32f284e175e1012\n-- \ngitgitgadget\n"}]}