{"thread":{"id":"53608","subject":"Re: Questions about Git-Gui Makefile and GNU File Name and Text Functions","startedAt":"2020-06-03T19:45:56Z","lastAt":"2020-06-03T19:45:56Z","messageCount":1,"participants":["Edua Vioz"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"399087","messageId":"CAGiZ90mZp5sKFBwFr5M4Zm2Z0GCWG=hCQuEUqKOLS0toO=x80A@mail.gmail.com","threadId":"53608","inReplyTo":null,"subject":"Re: Questions about Git-Gui Makefile and GNU File Name and Text Functions","fromName":"Edua Vioz","fromEmail":"eltipejoloco@gmail.com","sentAt":"2020-06-03T19:45:40Z","receivedAt":"2020-06-03T19:45:56Z","isPatch":false,"sender":{"key":"eltipejoloco@gmail.com","avatar":null},"body":"On Wed, 2020-06-03 at 14:34 UTC, Paul Smith wrote:\n>I'm not super-familiar with the Git build system so maybe there are\n>mitigations for this there but: GNU make always treats whitespace as a\n>word separator so it will apply the \"dir\" function to each word.  So:\n>\n>>$(dir C:/Program Files/Git/mingw64/libexec/git-core)\n>\n>is equivalent to writing:\n>\n>>$(dir C:/Program) $(dir Files/Git/mingw64/libexec/git-core)\n>\n>and the expected result is:\n>\n>>C:/ Files/Git/mingw64/libexec\n\nYeah, I figured that was the case after skimming over GNU make\nreference sites online and reading as much. Still, I figured I'd ask in case\nGit or Git Bash specifically had been built to account for this in Git for\nWindows, or if anything had changed since the documentation I'd read\nhad been written.\n\n>No.  Make in general, and GNU make in particular, doesn't expect to be\n>given paths with whitespace in them.\n>\n>Again I'm not an expert in the Git build system but my understanding is\n>that the install can be relocatable: in that case I recommend you build\n>it into a location where there is no whitespace in the path, then move\n>it wherever you like after building.\n\nIdeally, yes. However, Git-Gui's Makefile was not written with this in mind.\nIt will append directories to DEST during installation that can (and do)\ninclude drive letters. Again, the file can be modified to fix this on a case\nby case basis, but ideally I wanted to learn if this was all already known\nabout this particular Makefile and if it was expected behavior.\n\nI've actually already modified my copy of Git-Gui's Makefile to account\nfor whitespaces since I first wrote about it to the mailing list, but since I\nsuspect that it was automatically generated by software, I'd rather\nlearn if the tool responsible is open source and could be modified to\naccount for spaces in directory and file names instead of manually\nfixing up every automated Makefile for each repository Windows users\ncome across until the tool is changed or no longer in use.\n\nIf I were to share it, should the patch by submit to a new e-mail thread,\nor would it be fine to send it in as a reply to this one using the --in-reply-to\nargument in git?\n\nThanks in advance for your time.\n"}]}