{"thread":{"id":"53590","subject":"Git Test Coverage Report (June 1, 2020)","startedAt":"2020-06-01T15:46:28Z","lastAt":"2020-06-01T18:50:44Z","messageCount":2,"participants":["Derrick Stolee","Taylor Blau"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"398979","messageId":"a2ec90be-8559-b83d-de76-5e742c452378@gmail.com","threadId":"53590","inReplyTo":null,"subject":"Git Test Coverage Report (June 1, 2020)","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-06-01T15:46:22Z","receivedAt":"2020-06-01T15:46:28Z","isPatch":false,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"Here is today's test coverage report.\n\nThanks,\n-Stolee\n\n[1] https://derrickstolee.github.io/git-test-coverage/reports/2020-06-01-commits.txt\n[2] https://derrickstolee.github.io/git-test-coverage/reports/2020-06-01.txt\n[3] https://derrickstolee.github.io/git-test-coverage/reports/2020-06-01.htm\n\n---\n\npu\td59a0e9b1b80cfd37c826aaa99c3a6a47779444e\njch\t7940aedf218f360084cb616d530c7c00c2653792\nnext\t5238fbb8ea3e0d9159ed431f9042d31285ea2d15\nmaster\t56219baf1eae50134ee05eaa64e26e7f1207042c\nmaster@{1}\tefcab5b7a3d2ce2ae4bf808b335938098b18d960\n\n\nUncovered code in 'pu' not in 'jch'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\nbrian m. carlson\t4b831208 fetch-pack: parse and advertise the object-format capability\nfetch-pack.c\n4b831208 1202)     the_hash_algo->name, hash_name);\n4b831208 1204) } else if (hash_algo_by_ptr(the_hash_algo) != GIT_HASH_SHA1) {\n4b831208 1206)     the_hash_algo->name);\n\nbrian m. carlson\t14570dc6 wrapper: add function to compare strings with different NUL termination\nwrapper.c\n14570dc6 112) return res;\n\nbrian m. carlson\t8b85ee4f transport-helper: implement object-format extensions\ntransport-helper.c\n8b85ee4f 1163) exit(128);\n\nbrian m. carlson\t90463f5d remote-curl: detect algorithm for dumb HTTP by size\nremote-curl.c\n90463f5d 264) return NULL;\n\nbrian m. carlson\t7f605017 remote-curl: implement object-format extensions\nremote-curl.c\n7f605017 199) algo = hash_algo_by_name(value);\n7f605017 200) if (algo == GIT_HASH_UNKNOWN)\n7f605017 202) options.hash_algo = &hash_algos[algo];\n\nbrian m. carlson\t122037c2 connect: add function to detect supported v1 hash functions\nconnect.c\n122037c2 566) hash = hash_algos[GIT_HASH_SHA1].name;\n122037c2 567) len = strlen(hash);\n122037c2 573) hash = next_server_feature_value(\"object-format\", &len, &offset);\n\nbrian m. carlson\t9de0dd36 serve: advertise object-format capability for protocol v2\nconnect.c\n9de0dd36 477) reader->hash_algo = &hash_algos[GIT_HASH_SHA1];\n\nbrian m. carlson\t1349ffed connect: add function to fetch value of a v2 server capability\nconnect.c\n1349ffed 98) return 0;\n\nbrian m. carlson\t22b74805 bundle: detect hash algorithm when reading refs\nbundle.c\n22b74805 33) return NULL;\n22b74805 70) status = -1;\n22b74805 71) break;\n\nbrian m. carlson\t88a09a55 builtin/show-index: provide options to determine hash algo\nbuiltin/show-index.c\n88a09a55 29) hash_algo = hash_algo_by_name(hash_name);\n88a09a55 30) if (hash_algo == GIT_HASH_UNKNOWN)\n88a09a55 32) repo_set_hash_algo(the_repository, hash_algo);\n\nChristian Couder\t20a359ef upload-pack: move allow_sideband_all to upload_pack_data\nupload-pack.c\n20a359ef 1148) data->allow_sideband_all = git_config_bool(var, value);\n20a359ef 1343)      data->allow_sideband_all) &&\n\nChristian Couder\t198bf8ec upload-pack: move keepalive to upload_pack_data\nupload-pack.c\n198bf8ec 1140) data->keepalive = git_config_int(var, value);\n198bf8ec 1141) if (!data->keepalive)\n198bf8ec 1142) data->keepalive = -1;\n\nChristian Couder\te17afe0e upload-pack: change multi_ack to an enum\nupload-pack.c\ne17afe0e 969) data->multi_ack = multi_ack;\n\nChristian Couder\t1789fbb7 upload-pack: move use_sideband to upload_pack_data\nupload-pack.c\n1789fbb7 371) send_client_data(1, data, 1,\n1789fbb7 979) data->use_sideband = DEFAULT_PACKET_MAX;\n\nDamien Robert\t812a5889 remote.c: fix handling of %(push:remoteref)\nremote.c\n812a5889 1638) return NULL;\n812a5889 1645) return branch->refname;\n812a5889 1660) return NULL;\n812a5889 1774) return NULL;\n\nJeff King\t6c47e1f1 upload-pack: actually use some upload_pack_data bitfields\nupload-pack.c\n6c47e1f1 1016) data->no_progress = 1;\n\nJiang Xin\t1e58de8c receive-pack: add new proc-receive hook\nbuiltin/receive-pack.c\n1e58de8c 1046) return code;\n1e58de8c 1054) if (use_sideband)\n1e58de8c 1055) finish_async(&muxer);\n1e58de8c 1056) return code;\n1e58de8c 1542) cmd->report.error_message = \"broken symref\";\n1e58de8c 1727) cmd->report.error_message = \"transaction failed to start\";\n1e58de8c 1866) if (!cmd->report.error_message)\n1e58de8c 1867) cmd->report.error_message = \"unable to migrate objects to permanent storage\";\n\nt/helper/test-proc-receive.c\n1e58de8c 133) usage_msg_opt(\"Too many arguments.\", proc_receive_usage, options);\n\nJiang Xin\t2dd1150a receive-pack: new config receive.procReceiveRefs\nbuiltin/receive-pack.c\n2dd1150a 239) return config_error_nonbool(var);\n2dd1150a 1839) continue;\n\nJiang Xin\t5e4553bd New capability \"report-status-v2\" for git-push\nsend-pack.c\n5e4553bd 182)        if (new_options) {\n5e4553bd 184) new_options = 0;\n5e4553bd 186) ret = -1;\n5e4553bd 187) continue;\n5e4553bd 223) ret = -1;\n5e4553bd 224) break;\n5e4553bd 241)     hint->status != REF_STATUS_OK &&\n5e4553bd 242)     hint->status != REF_STATUS_REMOTE_REJECT) {\n5e4553bd 435) else if (server_supports(\"report-status\"))\n\ntransport-helper.c\n5e4553bd 836) hint = NULL;\n5e4553bd 855) (*ref)->report.message = msg;\n\nMatheus Tavares\t40d6c71c grep: honor sparse checkout patterns\nbuiltin/grep.c\n40d6c71c 579) if (file_exists(sparse_file)) {\n40d6c71c 583) free(sparse_file);\n40d6c71c 584) free(patterns);\n40d6c71c 585) return NULL;\n\nMatheus Tavares\tf87a6d5c config: correctly read worktree configs in submodules\nt/helper/test-config.c\nf87a6d5c 103) goto print_usage_error;\nf87a6d5c 109) goto print_usage_error;\nf87a6d5c 114) fprintf(stderr, \"Cannot use --submodule with read_early_config\\n\");\nf87a6d5c 115) return TC_USAGE_ERROR;\nf87a6d5c 130) fprintf(stderr, \"Invalid argument to --submodule: '%s'\\n\",\nf87a6d5c 132) free(subrepo);\nf87a6d5c 133) ret = TC_USAGE_ERROR;\nf87a6d5c 134) goto out;\nf87a6d5c 160) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\nf87a6d5c 167) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\nf87a6d5c 175) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\nf87a6d5c 187) fprintf(stderr, \"Cannot use --submodule with configset_get_value\\n\");\nf87a6d5c 188) ret = TC_USAGE_ERROR;\nf87a6d5c 189) goto out;\nf87a6d5c 205) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\nf87a6d5c 210) fprintf(stderr, \"Cannot use --submodule with configset_get_value_multi\\n\");\nf87a6d5c 211) ret = TC_USAGE_ERROR;\nf87a6d5c 212) goto out;\nf87a6d5c 232) printf(\"Value not found for \\\"%s\\\"\\n\", argv[1]);\nf87a6d5c 239) fprintf(stderr, \"Invalid syntax. Usage: test-tool config\"\n\nMatheus Tavares\td86a4b75 t/helper/test-config: return exit codes consistently\nt/helper/test-config.c\nd86a4b75 161) ret = TC_VALUE_NOT_FOUND;\nd86a4b75 168) ret = TC_VALUE_NOT_FOUND;\nd86a4b75 176) ret = TC_VALUE_NOT_FOUND;\nd86a4b75 206) ret = TC_VALUE_NOT_FOUND;\nd86a4b75 218) ret = TC_CONFIG_FILE_ERROR;\nd86a4b75 219) goto out;\nd86a4b75 233) ret = TC_VALUE_NOT_FOUND;\nd86a4b75 241) ret = TC_USAGE_ERROR;\n\nMiriam Rubio\t9aadf776 bisect--helper: introduce new `write_in_file()` function\nbuiltin/bisect--helper.c\n9aadf776 91) return error_errno(_(\"cannot open file '%s' in mode '%s'\"), path, mode);\n9aadf776 96) fclose(fp);\n9aadf776 97) return error_errno(_(\"could not write to file '%s'\"), path);\n\nPhillip Wood\t1a443767 rebase -i: support --ignore-date\nsequencer.c\n1a443767 893) return NULL;\n1a443767 1476) res = -1;\n1a443767 1477) goto out;\n\nPhillip Wood\tee9800cd rebase -i: support --committer-date-is-author-date\nsequencer.c\nee9800cd 1396) goto out;\nee9800cd 1400) goto out;\n\nPranit Bauva\t05a69202 bisect--helper: reimplement `bisect_autostart` shell function in C\nbuiltin/bisect--helper.c\n05a69202 823) fprintf(stderr, _(\"You need to start by \\\"git bisect \"\n05a69202 826) if (!isatty(STDIN_FILENO))\n05a69202 827) return 1;\n05a69202 834) yesno = git_prompt(_(\"Do you want me to do it for you \"\n05a69202 836) if (starts_with(yesno, _(\"n\")) || starts_with(yesno, _(\"N\")))\n05a69202 837) return 1;\n05a69202 839) return bisect_start(terms, 0, NULL, 0);\n\nPranit Bauva\t10520dbf bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C\nbuiltin/bisect--helper.c\n10520dbf 874) return BISECT_FAILED;\n10520dbf 890) oid_array_clear(&revs);\n10520dbf 891) return BISECT_FAILED;\n\nPranit Bauva\t587c9fac bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C\nbuiltin/bisect--helper.c\n587c9fac 493) return error_errno(_(\"failed to write to '%s'\"), git_path_bisect_log());\n587c9fac 522) return error_errno(_(\"could not open '%s' for appending\"),\n\nPranit Bauva\tf0bf9482 bisect--helper: finish porting `bisect_start()` to C\nbuiltin/bisect--helper.c\nf0bf9482 735) return BISECT_FAILED;\nf0bf9482 756) res = BISECT_FAILED;\nf0bf9482 768) res = BISECT_FAILED;\nf0bf9482 780) res = BISECT_FAILED;\n\nShawn O. Pearce\t38a81b4e receive-pack: Wrap status reports inside side-band-64k\nbuiltin/receive-pack.c\n38a81b4e 2283) send_sideband(1, 1, buf.buf, buf.len, use_sideband);\n\n\n\nUncovered code in 'jch' not in 'next'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\n\n\nUncovered code in 'next' not in 'master'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\nCarlo Marcelo Arenas Belón\taba8187e t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ)\nt/helper/test-regex.c\naba8187e 53) goto usage;\naba8187e 59) goto usage;\naba8187e 67) goto usage;\naba8187e 90) if (silent)\naba8187e 91) return ret;\naba8187e 101) if (silent || ret == REG_NOMATCH)\naba8187e 102) return ret;\n\nDenton Liu\t0181b600 pkt-line: define PACKET_READ_RESPONSE_END\npkt-line.c\n0181b600 106) die_errno(_(\"unable to write stateless separator packet\"));\n\nt/helper/test-pkt-line.c\n0181b600 50) printf(\"0002\\n\");\n0181b600 51) break;\n\nDerrick Stolee\tf32dde8c line-log: integrate with changed-path Bloom filters\nline-log.c\nf32dde8c 1159) return 1;\nf32dde8c 1166) return 0;\n\nJonathan Nieder\t3697caf4 config: let feature.experimental imply protocol.version=2\nprotocol.c\n3697caf4 35) return protocol_v2;\n\nTaylor Blau\t5b6653e5 builtin/commit-graph.c: dereference tags in builtin\nbuiltin/commit-graph.c\n5b6653e5 244) progress = start_delayed_progress(\n5b6653e5 268) stop_progress(&progress);\n\n\n\nUncovered code in 'master' not in 'master@{1}'\n--------------------------------------------------------\n\nCommits introducing uncovered code:\n\n"},{"id":"398986","messageId":"20200601180542.GA29247@syl.local","threadId":"53590","inReplyTo":"a2ec90be-8559-b83d-de76-5e742c452378@gmail.com","subject":"Re: Git Test Coverage Report (June 1, 2020)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-06-01T18:05:42Z","receivedAt":"2020-06-01T18:50:44Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Jun 01, 2020 at 11:46:22AM -0400, Derrick Stolee wrote:\n> Taylor Blau\t5b6653e5 builtin/commit-graph.c: dereference tags in builtin\n> builtin/commit-graph.c\n> 5b6653e5 244) progress = start_delayed_progress(\n> 5b6653e5 268) stop_progress(&progress);\n\nThanks for pointing out this area. What's going on here is that we\naren't testing '--stdin-commits' with '--[no]-progress', since\ngenerating a progress meter from the builtin in this path is new since\n'tb/commit-graph-no-check-oids'.\n\nI mailed a few patches to the list to address this. They seem to be\ntrickling in slowly, though...\n\nThanks,\nTaylor\n"}]}