{"thread":{"id":"53577","subject":"[PATCH] docs: mention MyFirstContribution in more places","startedAt":"2020-05-28T23:49:57Z","lastAt":"2020-06-08T22:12:51Z","messageCount":7,"participants":["Emily Shaffer","Jonathan Nieder","Philippe Blain","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"398817","messageId":"20200528234939.145396-1-emilyshaffer@google.com","threadId":"53577","inReplyTo":null,"subject":"[PATCH] docs: mention MyFirstContribution in more places","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2020-05-28T23:49:39Z","receivedAt":"2020-05-28T23:49:57Z","isPatch":true,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"While the MyFirstContribution guide exists and has received some use and\npositive reviews, it is still not as discoverable as it could be. Add a\nreference to it from the GitHub pull request template, where many\nbrand-new contributors may look. Also add a reference to it in\nSubmittingPatches, which is the central source of guidance for patch\ncontribution.\n\nSigned-off-by: Emily Shaffer \n---\nPhilippe mentioned out-of-band that they wished for some more pointers\nto MyFirstContribution in the Git documentation\n(https://github.com/git/git-scm.com/issues/1464#issuecomment-631757274).\n\nHere's a first pass. The change for the GH PR template was easy, since\nthere are a couple other \"here's how\" resources listed the same way. But\nthe change for SubmittingPatches I wasn't so sure about. Since that\ndocument dives right into technical details and doesn't feature some\n\"other resources\" section (at least not that I found), I made a quick\nreference at the top, which I was hoping would be unintrusive but also\neasy to find for newbies overwhelmed by the large list of rules. It's\nnot very scalable if we want to add more info, though, so I'm open to\nother suggestions.\n\n - Emily\n\n .github/CONTRIBUTING.md | 3 +++\n Documentation/SubmittingPatches | 5 +++--\n 2 files changed, 6 insertions(+), 2 deletions(-)\n\ndiff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md\nindex e7b4e2f3c2..c8755e38de 100644\n--- a/.github/CONTRIBUTING.md\n+++ b/.github/CONTRIBUTING.md\n@@ -16,4 +16,7 @@ If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q\n might be useful to you as the presenter walks you through the contribution\n process by example.\n \n+Or, you can follow the [\"My First Contribution\"](https://git-scm.com/docs/MyFirstContribution)\n+tutorial for another example of the contribution process.\n+\n Your friendly Git community!\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 4515cab519..d8c6b4d71b 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -3,8 +3,9 @@ Submitting Patches\n \n == Guidelines\n \n-Here are some guidelines for people who want to contribute their code\n-to this software.\n+Here are some guidelines for people who want to contribute their code to this\n+software. There is also an link:MyFirstContribution.html[interactive tutorial]\n+available which covers many of these same guidelines.\n \n [[base-branch]]\n === Decide what to base your work on.\n-- \n2.27.0.rc0.183.gde8f92d652-goog\n\n"},{"id":"398824","messageId":"20200529010608.GF114915@google.com","threadId":"53577","inReplyTo":"20200528234939.145396-1-emilyshaffer@google.com","subject":"Re: [PATCH] docs: mention MyFirstContribution in more places","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2020-05-29T01:06:08Z","receivedAt":"2020-05-29T01:06:16Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Emily Shaffer wrote:\n\n> While the MyFirstContribution guide exists and has received some use and\n> positive reviews, it is still not as discoverable as it could be. Add a\n> reference to it from the GitHub pull request template, where many\n> brand-new contributors may look. Also add a reference to it in\n> SubmittingPatches, which is the central source of guidance for patch\n> contribution.\n>\n> Signed-off-by: Emily Shaffer \n> ---\n> .github/CONTRIBUTING.md | 3 +++\n> Documentation/SubmittingPatches | 5 +++--\n> 2 files changed, 6 insertions(+), 2 deletions(-)\n\nYay!\n\n> --- a/.github/CONTRIBUTING.md\n> +++ b/.github/CONTRIBUTING.md\n> @@ -16,4 +16,7 @@ If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q\n> might be useful to you as the presenter walks you through the contribution\n> process by example.\n> \n> +Or, you can follow the [\"My First Contribution\"](https://git-scm.com/docs/MyFirstContribution)\n> +tutorial for another example of the contribution process.\n> +\n> Your friendly Git community!\n\nLooks good.\n\n> --- a/Documentation/SubmittingPatches\n> +++ b/Documentation/SubmittingPatches\n> @@ -3,8 +3,9 @@ Submitting Patches\n> \n> == Guidelines\n> \n> -Here are some guidelines for people who want to contribute their code\n> -to this software.\n> +Here are some guidelines for people who want to contribute their code to this\n> +software. There is also an link:MyFirstContribution.html[interactive tutorial]\n> +available which covers many of these same guidelines.\n\nnit: when I see \"an interactive tutorial\" I imagine a \"git tutor\"\ncommand that interacts with me to guide me through my first\ncontribution (like \"vimtutor\"). I think this means to just say\n\"a tutorial\".\n\nWith that tweak,\nReviewed-by: Jonathan Nieder \n\nThanks.\n"},{"id":"398826","messageId":"7746C7A0-F328-482C-9B19-51BA5CB17C0A@gmail.com","threadId":"53577","inReplyTo":"20200529010608.GF114915@google.com","subject":"Re: [PATCH] docs: mention MyFirstContribution in more places","fromName":"Philippe Blain","fromEmail":"levraiphilippeblain@gmail.com","sentAt":"2020-05-29T01:36:58Z","receivedAt":"2020-05-29T01:37:07Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"Hi Emily, \n\n> Le 28 mai 2020 à 21:06, Jonathan Nieder a écrit :\n> \n> Emily Shaffer wrote:\n> \n>> While the MyFirstContribution guide exists and has received some use and\n>> positive reviews, it is still not as discoverable as it could be. Add a\n>> reference to it from the GitHub pull request template, where many\n>> brand-new contributors may look. Also add a reference to it in\n>> SubmittingPatches, which is the central source of guidance for patch\n>> contribution.\n>> \n>> Signed-off-by: Emily Shaffer \n>> ---\n>> .github/CONTRIBUTING.md | 3 +++\n>> Documentation/SubmittingPatches | 5 +++--\n>> 2 files changed, 6 insertions(+), 2 deletions(-)\n> \n> Yay!\n> \n>> --- a/.github/CONTRIBUTING.md\n>> +++ b/.github/CONTRIBUTING.md\n>> @@ -16,4 +16,7 @@ If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q\n>> might be useful to you as the presenter walks you through the contribution\n>> process by example.\n>> \n>> +Or, you can follow the [\"My First Contribution\"](https://git-scm.com/docs/MyFirstContribution)\n>> +tutorial for another example of the contribution process.\n>> +\n>> Your friendly Git community!\n> \n> Looks good.\n> \n>> --- a/Documentation/SubmittingPatches\n>> +++ b/Documentation/SubmittingPatches\n>> @@ -3,8 +3,9 @@ Submitting Patches\n>> \n>> == Guidelines\n>> \n>> -Here are some guidelines for people who want to contribute their code\n>> -to this software.\n>> +Here are some guidelines for people who want to contribute their code to this\n>> +software. There is also an link:MyFirstContribution.html[interactive tutorial]\n>> +available which covers many of these same guidelines.\n> \n> nit: when I see \"an interactive tutorial\" I imagine a \"git tutor\"\n> command that interacts with me to guide me through my first\n> contribution (like \"vimtutor\"). I think this means to just say\n> \"a tutorial\".\n\nI agree. Maybe \"a step-by-step tutorial\" ?\n\nThanks for taking the time to do this. That's exactly what I had in mind.\n\nPhilippe."},{"id":"399315","messageId":"20200608204700.GB148632@google.com","threadId":"53577","inReplyTo":"7746C7A0-F328-482C-9B19-51BA5CB17C0A@gmail.com","subject":"Re: [PATCH] docs: mention MyFirstContribution in more places","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2020-06-08T20:47:00Z","receivedAt":"2020-06-08T20:47:07Z","isPatch":true,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Thu, May 28, 2020 at 09:36:58PM -0400, Philippe Blain wrote:\n> \n> Hi Emily, \n> \n> > Le 28 mai 2020 à 21:06, Jonathan Nieder a écrit :\n> > \n> > Emily Shaffer wrote:\n> > \n> >> While the MyFirstContribution guide exists and has received some use and\n> >> positive reviews, it is still not as discoverable as it could be. Add a\n> >> reference to it from the GitHub pull request template, where many\n> >> brand-new contributors may look. Also add a reference to it in\n> >> SubmittingPatches, which is the central source of guidance for patch\n> >> contribution.\n> >> \n> >> Signed-off-by: Emily Shaffer \n> >> ---\n> >> .github/CONTRIBUTING.md | 3 +++\n> >> Documentation/SubmittingPatches | 5 +++--\n> >> 2 files changed, 6 insertions(+), 2 deletions(-)\n> > \n> > Yay!\n> > \n> >> --- a/.github/CONTRIBUTING.md\n> >> +++ b/.github/CONTRIBUTING.md\n> >> @@ -16,4 +16,7 @@ If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q\n> >> might be useful to you as the presenter walks you through the contribution\n> >> process by example.\n> >> \n> >> +Or, you can follow the [\"My First Contribution\"](https://git-scm.com/docs/MyFirstContribution)\n> >> +tutorial for another example of the contribution process.\n> >> +\n> >> Your friendly Git community!\n> > \n> > Looks good.\n> > \n> >> --- a/Documentation/SubmittingPatches\n> >> +++ b/Documentation/SubmittingPatches\n> >> @@ -3,8 +3,9 @@ Submitting Patches\n> >> \n> >> == Guidelines\n> >> \n> >> -Here are some guidelines for people who want to contribute their code\n> >> -to this software.\n> >> +Here are some guidelines for people who want to contribute their code to this\n> >> +software. There is also an link:MyFirstContribution.html[interactive tutorial]\n> >> +available which covers many of these same guidelines.\n> > \n> > nit: when I see \"an interactive tutorial\" I imagine a \"git tutor\"\n> > command that interacts with me to guide me through my first\n> > contribution (like \"vimtutor\"). I think this means to just say\n> > \"a tutorial\".\n> \n> I agree. Maybe \"a step-by-step tutorial\" ?\n\nThanks for the suggestion - I like that. I'll send an update shortly.\n\n - Emily\n"},{"id":"399316","messageId":"20200608211132.194267-1-emilyshaffer@google.com","threadId":"53577","inReplyTo":"20200528234939.145396-1-emilyshaffer@google.com","subject":"[PATCH v2] docs: mention MyFirstContribution in more places","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2020-06-08T21:11:32Z","receivedAt":"2020-06-08T21:11:39Z","isPatch":true,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"While the MyFirstContribution guide exists and has received some use and\npositive reviews, it is still not as discoverable as it could be. Add a\nreference to it from the GitHub pull request template, where many\nbrand-new contributors may look. Also add a reference to it in\nSubmittingPatches, which is the central source of guidance for patch\ncontribution.\n\nSigned-off-by: Emily Shaffer \n---\n\nSince v1, only the tiny nit - took Philippe's advice to refer to a\n\"step-by-step\" tutorial, instead of an \"interactive\" tutorial.\n\nThanks.\n - Emily\n\n .github/CONTRIBUTING.md | 3 +++\n Documentation/SubmittingPatches | 5 +++--\n 2 files changed, 6 insertions(+), 2 deletions(-)\n\ndiff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md\nindex e7b4e2f3c2..c8755e38de 100644\n--- a/.github/CONTRIBUTING.md\n+++ b/.github/CONTRIBUTING.md\n@@ -16,4 +16,7 @@ If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q\n might be useful to you as the presenter walks you through the contribution\n process by example.\n \n+Or, you can follow the [\"My First Contribution\"](https://git-scm.com/docs/MyFirstContribution)\n+tutorial for another example of the contribution process.\n+\n Your friendly Git community!\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 4515cab519..ecf9438cf0 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -3,8 +3,9 @@ Submitting Patches\n \n == Guidelines\n \n-Here are some guidelines for people who want to contribute their code\n-to this software.\n+Here are some guidelines for people who want to contribute their code to this\n+software. There is also a link:MyFirstContribution.html[step-by-step tutorial]\n+available which covers many of these same guidelines.\n \n [[base-branch]]\n === Decide what to base your work on.\n-- \n2.27.0.278.ge193c7cf3a9-goog\n\n"},{"id":"399318","messageId":"6BD1731B-8D1D-4A07-BE23-70AEB740C455@gmail.com","threadId":"53577","inReplyTo":"20200608211132.194267-1-emilyshaffer@google.com","subject":"Re: [PATCH v2] docs: mention MyFirstContribution in more places","fromName":"Philippe Blain","fromEmail":"levraiphilippeblain@gmail.com","sentAt":"2020-06-08T21:25:05Z","receivedAt":"2020-06-08T21:25:11Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"Hi Emily,\n\n> Le 8 juin 2020 à 17:11, Emily Shaffer a écrit :\n> \n> While the MyFirstContribution guide exists and has received some use and\n> positive reviews, it is still not as discoverable as it could be. Add a\n> reference to it from the GitHub pull request template, where many\n> brand-new contributors may look. Also add a reference to it in\n> SubmittingPatches, which is the central source of guidance for patch\n> contribution.\n> \n> Signed-off-by: Emily Shaffer \n> ---\n> \n> Since v1, only the tiny nit - took Philippe's advice to refer to a\n> \"step-by-step\" tutorial, instead of an \"interactive\" tutorial.\n> \n> Thanks.\n> - Emily\n\nThanks. Looks good. \n\nReviewed-by: Philippe Blain "},{"id":"399327","messageId":"xmqq5zc1jjfl.fsf@gitster.c.googlers.com","threadId":"53577","inReplyTo":"6BD1731B-8D1D-4A07-BE23-70AEB740C455@gmail.com","subject":"Re: [PATCH v2] docs: mention MyFirstContribution in more places","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-06-08T22:12:46Z","receivedAt":"2020-06-08T22:12:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Philippe Blain writes:\n\n> Hi Emily,\n>\n>> Le 8 juin 2020 à 17:11, Emily Shaffer a écrit :\n>> \n>> While the MyFirstContribution guide exists and has received some use and\n>> positive reviews, it is still not as discoverable as it could be. Add a\n>> reference to it from the GitHub pull request template, where many\n>> brand-new contributors may look. Also add a reference to it in\n>> SubmittingPatches, which is the central source of guidance for patch\n>> contribution.\n>> \n>> Signed-off-by: Emily Shaffer \n>> ---\n>> \n>> Since v1, only the tiny nit - took Philippe's advice to refer to a\n>> \"step-by-step\" tutorial, instead of an \"interactive\" tutorial.\n>> \n>> Thanks.\n>> - Emily\n>\n> Thanks. Looks good. \n>\n> Reviewed-by: Philippe Blain \n\nThanks, both.\n"}]}