{"thread":{"id":"53553","subject":"[PATCH v2 0/1] Documentation fix related to hash algorithm","startedAt":"2020-05-26T18:37:49Z","lastAt":"2020-05-27T17:05:10Z","messageCount":3,"participants":["Toon Claes","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":1},"messages":[{"id":"398591","messageId":"20200526183720.120314-1-toon@iotcl.com","threadId":"53553","inReplyTo":null,"subject":"[PATCH v2 0/1] Documentation fix related to hash algorithm","fromName":"Toon Claes","fromEmail":"toon@iotcl.com","sentAt":"2020-05-26T18:37:19Z","receivedAt":"2020-05-26T18:37:49Z","isPatch":true,"sender":{"key":"toon@iotcl.com","avatar":"https://avatars.githubusercontent.com/u/121621?v=4"},"body":"I was doing some research on the SHA256 implementation, and I discovered\na mismatch between the docs and the code. I have a patch attached that\nfixes the docs.\n\nThis is version 2, which has a slightly nicer commit message as\nsuggested by Martin Ågren.\n\nMartin Ågren also mentioned[0] this discrepancy is added on 2020-02-22\nin 3c9331a129, which added both the documentation and the\nimplementation. As developers-only as this variable is, that commit was\nnot in v2.26.0, so this might be worth fixing before cutting v2.27.0.\n\n[0] https://lore.kernel.org/git/20200525144138.1624272-1-toon@iotcl.com/T/#m637dc0692962e882928e035888435267b784ee17\n\nToon Claes (1):\n  Documentation: correct hash environment variable\n\n Documentation/git.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.27.0.rc1.73.g31835d1b01\n"},{"id":"398592","messageId":"20200526183720.120314-2-toon@iotcl.com","threadId":"53553","inReplyTo":"20200526183720.120314-1-toon@iotcl.com","subject":"[PATCH v2 1/1] Documentation: correct hash environment variable","fromName":"Toon Claes","fromEmail":"toon@iotcl.com","sentAt":"2020-05-26T18:37:20Z","receivedAt":"2020-05-26T18:38:00Z","isPatch":true,"sender":{"key":"toon@iotcl.com","avatar":"https://avatars.githubusercontent.com/u/121621?v=4"},"body":"To set the default hash algorithm you can set the `GIT_DEFAULT_HASH`\nenvironment variable. In the documentation this variable is named\n`GIT_DEFAULT_HASH_ALGORITHM`, which is incorrect.\n\nSigned-off-by: Toon Claes <toon@iotcl.com>\n---\n Documentation/git.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git.txt b/Documentation/git.txt\nindex 9d6769e95a..12890841c4 100644\n--- a/Documentation/git.txt\n+++ b/Documentation/git.txt\n@@ -493,7 +493,7 @@ double-quotes and respecting backslash escapes. E.g., the value\n \tdetails. This variable has lower precedence than other path\n \tvariables such as GIT_INDEX_FILE, GIT_OBJECT_DIRECTORY...\n \n-`GIT_DEFAULT_HASH_ALGORITHM`::\n+`GIT_DEFAULT_HASH`::\n \tIf this variable is set, the default hash algorithm for new\n \trepositories will be set to this value. This value is currently\n \tignored when cloning; the setting of the remote repository\n-- \n2.27.0.rc1.73.g31835d1b01\n\n"},{"id":"398661","messageId":"xmqq1rn5mhq8.fsf@gitster.c.googlers.com","threadId":"53553","inReplyTo":"20200526183720.120314-2-toon@iotcl.com","subject":"Re: [PATCH v2 1/1] Documentation: correct hash environment variable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-05-27T17:05:03Z","receivedAt":"2020-05-27T17:05:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Toon Claes <toon@iotcl.com> writes:\n\n> To set the default hash algorithm you can set the `GIT_DEFAULT_HASH`\n> environment variable. In the documentation this variable is named\n> `GIT_DEFAULT_HASH_ALGORITHM`, which is incorrect.\n\nMy reading stuttered while reading words around \"to set ... you can\nset\"; I would have written\n\n\tThe GIT_DEFAULT_HASH environment variable, which is the way\n\tto specify the default hash algorithm, was misspelled in the\n\tdocumentation.  Fix it.\n\nbut it's OK.\n\nAs you said, bc/sha-256-part-1-of-4 is new in this release, so let's\nmerge this fix down before the final.\n\nThanks.\n\n> Signed-off-by: Toon Claes <toon@iotcl.com>\n> ---\n>  Documentation/git.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git.txt b/Documentation/git.txt\n> index 9d6769e95a..12890841c4 100644\n> --- a/Documentation/git.txt\n> +++ b/Documentation/git.txt\n> @@ -493,7 +493,7 @@ double-quotes and respecting backslash escapes. E.g., the value\n>  \tdetails. This variable has lower precedence than other path\n>  \tvariables such as GIT_INDEX_FILE, GIT_OBJECT_DIRECTORY...\n>  \n> -`GIT_DEFAULT_HASH_ALGORITHM`::\n> +`GIT_DEFAULT_HASH`::\n>  \tIf this variable is set, the default hash algorithm for new\n>  \trepositories will be set to this value. This value is currently\n>  \tignored when cloning; the setting of the remote repository\n"}]}