{"thread":{"id":"53542","subject":"[PATCH 0/1] Documentation fix related to hash algorithm","startedAt":"2020-05-25T14:49:29Z","lastAt":"2020-05-25T17:58:35Z","messageCount":4,"participants":["Toon Claes","Martin Ågren","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"398490","messageId":"20200525144138.1624272-1-toon@iotcl.com","threadId":"53542","inReplyTo":null,"subject":"[PATCH 0/1] Documentation fix related to hash algorithm","fromName":"Toon Claes","fromEmail":"toon@iotcl.com","sentAt":"2020-05-25T14:41:37Z","receivedAt":"2020-05-25T14:49:29Z","isPatch":true,"sender":{"key":"toon@iotcl.com","avatar":"https://avatars.githubusercontent.com/u/121621?v=4"},"body":"I was doing some research on the SHA256 implementation, and I discovered a\nmismatch between the docs and the code. I have a patch attached that fixes the\ndocs.\n\nToon Claes (1):\n  Documentation: correct hash environment variable\n\n Documentation/git.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.27.0.rc1.72.g3440a8306a\n"},{"id":"398491","messageId":"20200525144138.1624272-2-toon@iotcl.com","threadId":"53542","inReplyTo":"20200525144138.1624272-1-toon@iotcl.com","subject":"[PATCH 1/1] Documentation: correct hash environment variable","fromName":"Toon Claes","fromEmail":"toon@iotcl.com","sentAt":"2020-05-25T14:41:38Z","receivedAt":"2020-05-25T14:49:32Z","isPatch":true,"sender":{"key":"toon@iotcl.com","avatar":"https://avatars.githubusercontent.com/u/121621?v=4"},"body":"To set the default hash algorithm you can set the `GIT_DEFAULT_HASH` environment\nvariable. In the documentation this variable was named\n`GIT_DEFAULT_HASH_ALGORITHM`, which was incorrect.\n\nSigned-off-by: Toon Claes <toon@iotcl.com>\n---\n Documentation/git.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git.txt b/Documentation/git.txt\nindex 9d6769e95a..12890841c4 100644\n--- a/Documentation/git.txt\n+++ b/Documentation/git.txt\n@@ -493,7 +493,7 @@ double-quotes and respecting backslash escapes. E.g., the value\n \tdetails. This variable has lower precedence than other path\n \tvariables such as GIT_INDEX_FILE, GIT_OBJECT_DIRECTORY...\n \n-`GIT_DEFAULT_HASH_ALGORITHM`::\n+`GIT_DEFAULT_HASH`::\n \tIf this variable is set, the default hash algorithm for new\n \trepositories will be set to this value. This value is currently\n \tignored when cloning; the setting of the remote repository\n-- \n2.27.0.rc1.72.g3440a8306a\n\n"},{"id":"398494","messageId":"CAN0heSoyxvTTaJaRmnQADTaMrWa4QBbGnXi8MUZp7ksibejc8g@mail.gmail.com","threadId":"53542","inReplyTo":"20200525144138.1624272-2-toon@iotcl.com","subject":"Re: [PATCH 1/1] Documentation: correct hash environment variable","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2020-05-25T16:42:57Z","receivedAt":"2020-05-25T16:43:11Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"On Mon, 25 May 2020 at 16:52, Toon Claes <toon@iotcl.com> wrote:\n>\n> To set the default hash algorithm you can set the `GIT_DEFAULT_HASH` environment\n> variable. In the documentation this variable was named\n> `GIT_DEFAULT_HASH_ALGORITHM`, which was incorrect.\n>\n> Signed-off-by: Toon Claes <toon@iotcl.com>\n\nI would replace both instances of \"was\" with \"is\", since you're\ndescribing the state immediately before applying your patch, not after.\n\nChanging that and wrapping at 72 characters yields something like\n\n  To set the default hash algorithm you can set the `GIT_DEFAULT_HASH`\n  environment variable. In the documentation this variable is named\n  `GIT_DEFAULT_HASH_ALGORITHM`, which is incorrect.\n\nNits aside...\n\n> -`GIT_DEFAULT_HASH_ALGORITHM`::\n> +`GIT_DEFAULT_HASH`::\n>         If this variable is set, the default hash algorithm for new\n>         repositories will be set to this value. This value is currently\n>         ignored when cloning; the setting of the remote repository\n\nIndeed. This discrepancy is visible in the commit which added both the\ndocumentation and the implementation, 3c9331a129 (\"builtin/init-db: add\nenvironment variable for new repo hash\", 2020-02-22). As\ndevelopers-only as this variable is, that commit was not in v2.26.0, so\nthis might be worth fixing before cutting v2.27.0.\n\nMartin\n"},{"id":"398500","messageId":"20200525175758.GE1915090@camp.crustytoothpaste.net","threadId":"53542","inReplyTo":"CAN0heSoyxvTTaJaRmnQADTaMrWa4QBbGnXi8MUZp7ksibejc8g@mail.gmail.com","subject":"Re: [PATCH 1/1] Documentation: correct hash environment variable","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2020-05-25T17:57:58Z","receivedAt":"2020-05-25T17:58:35Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2020-05-25 at 16:42:57, Martin Ågren wrote:\n> > -`GIT_DEFAULT_HASH_ALGORITHM`::\n> > +`GIT_DEFAULT_HASH`::\n> >         If this variable is set, the default hash algorithm for new\n> >         repositories will be set to this value. This value is currently\n> >         ignored when cloning; the setting of the remote repository\n> \n> Indeed. This discrepancy is visible in the commit which added both the\n> documentation and the implementation, 3c9331a129 (\"builtin/init-db: add\n> environment variable for new repo hash\", 2020-02-22). As\n> developers-only as this variable is, that commit was not in v2.26.0, so\n> this might be worth fixing before cutting v2.27.0.\n\nYeah, thanks for catching this.  I think this is worth fixing.  It\ndoesn't do anything right now except produce an error, but we might as\nwell not mislead people.\n-- \nbrian m. carlson: Houston, Texas, US\nOpenPGP: https://keybase.io/bk2204\n"}]}