{"thread":{"id":"53522","subject":"[PATCH] git-bisect: remove no longer needed variables","startedAt":"2020-05-21T16:35:04Z","lastAt":"2020-05-21T16:57:17Z","messageCount":2,"participants":["Carlo Marcelo Arenas Belón"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"398362","messageId":"20200521163449.36108-1-carenas@gmail.com","threadId":"53522","inReplyTo":null,"subject":"[PATCH] git-bisect: remove no longer needed variables","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2020-05-21T16:34:49Z","receivedAt":"2020-05-21T16:35:04Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"With the original functionality moved to bisect--helper there is no need\nfor them in git-bisect.sh anymore.\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n git-bisect.sh | 34 ----------------------------------\n 1 file changed, 34 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 2da0810b1a..d6debcbb87 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -1,41 +1,7 @@\n #!/bin/sh\n \n-USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|view|replay|log|run]'\n-LONG_USAGE='git bisect help\n-\tprint this long help message.\n-git bisect start [--term-{old,good}=<term> --term-{new,bad}=<term>]\n-\t\t [--no-checkout] [<bad> [<good>...]] [--] [<pathspec>...]\n-\treset bisect state and start bisection.\n-git bisect (bad|new) [<rev>]\n-\tmark <rev> a known-bad revision/\n-\t\ta revision after change in a given property.\n-git bisect (good|old) [<rev>...]\n-\tmark <rev>... known-good revisions/\n-\t\trevisions before change in a given property.\n-git bisect terms [--term-good | --term-bad]\n-\tshow the terms used for old and new commits (default: bad, good)\n-git bisect skip [(<rev>|<range>)...]\n-\tmark <rev>... untestable revisions.\n-git bisect next\n-\tfind next bisection to test and check it out.\n-git bisect reset [<commit>]\n-\tfinish bisection search and go back to commit.\n-git bisect (visualize|view)\n-\tshow bisect status in gitk.\n-git bisect replay <logfile>\n-\treplay bisection log.\n-git bisect log\n-\tshow bisect log.\n-git bisect run <cmd>...\n-\tuse <cmd>... to automatically bisect.\n-\n-Please use \"git help bisect\" to get the full man page.'\n-\n-OPTIONS_SPEC=\n . git-sh-setup\n \n-_x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'\n-_x40=\"$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40\"\n TERM_BAD=bad\n TERM_GOOD=good\n \n\nbase-commit: 011eca7cfdb7f13ee285c00dfe9ea576ec1166a7\n-- \n2.27.0.rc1.181.g8d5cacc8d1\n\n"},{"id":"398366","messageId":"20200521165708.GG20332@Carlos-MBP","threadId":"53522","inReplyTo":"20200521163449.36108-1-carenas@gmail.com","subject":"Re: [PATCH] git-bisect: remove no longer needed variables","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2020-05-21T16:57:08Z","receivedAt":"2020-05-21T16:57:17Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Thu, May 21, 2020 at 09:34:49AM -0700, Carlo Marcelo Arenas Belón wrote:\n> With the original functionality moved to bisect--helper there is no need\n> for them in git-bisect.sh anymore.\n\nthem, really only being _x40, which was retired with 06f5608c14\n(bisect--helper: `bisect_start` shell function partially in C, 2019-01-02)\n\nwith the rest obviously still in use for `git bisect help` to anyone that\nwould bother trying to run the script before hitting `git send-email`; sorry\nfor the noise\n\nCarlo\n"}]}