{"thread":{"id":"5352","subject":"[PATCH] gitweb: all bold lists are \"list_bold\" style","startedAt":"2006-08-22T08:57:39Z","lastAt":"2006-08-22T10:38:59Z","messageCount":3,"participants":["Luben Tuikov","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"25735","messageId":"20060822085739.75519.qmail@web31810.mail.mud.yahoo.com","threadId":"5352","inReplyTo":null,"subject":"[PATCH] gitweb: all bold lists are \"list_bold\" style","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-22T08:57:39Z","receivedAt":"2006-08-22T08:57:39Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Signed-off-by: Luben Tuikov \n---\n gitweb/gitweb.perl | 10 +++++-----\n 1 files changed, 5 insertions(+), 5 deletions(-)\n\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 5237f25..4caf69e 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1583,7 +1583,7 @@ sub git_tags_body {\n \t\tprint \"$tag{'age'}\\n\" .\n \t\t \"\" .\n \t\t $cgi->a({-href => href(action=>$tag{'reftype'}, hash=>$tag{'refid'}),\n-\t\t -class => \"list\"}, \"\" . esc_html($tag{'name'}) . \"\") .\n+\t\t -class => \"list_bold\"}, esc_html($tag{'name'})) .\n \t\t \"\\n\" .\n \t\t \"\";\n \t\tif (defined $comment) {\n@@ -1637,7 +1637,7 @@ sub git_heads_body {\n \t\tprint \"$tag{'age'}\\n\" .\n \t\t ($tag{'id'} eq $head ? \"\" : \"\") .\n \t\t $cgi->a({-href => href(action=>\"shortlog\", hash=>$tag{'name'}),\n-\t\t -class => \"list\"}, \"\" . esc_html($tag{'name'}) . \"\") .\n+\t\t -class => \"list_bold\"}, esc_html($tag{'name'})) .\n \t\t \"\\n\" .\n \t\t \"\" .\n \t\t $cgi->a({-href => href(action=>\"shortlog\", hash=>$tag{'name'})}, \"shortlog\") . \" | \" .\n@@ -2686,7 +2686,7 @@ sub git_search {\n \t\t\tprint \"$co{'age_string_date'}\\n\" .\n \t\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5)) . \"\\n\" .\n \t\t\t \"\" .\n-\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}) -class => \"list\"}, \"\" . esc_html(chop_str($co{'title'}, 50)) . \"
\");\n+\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}) -class => \"list_bold\"}, esc_html(chop_str($co{'title'}, 50)) . \"
\");\n \t\t\tmy $comment = $co{'comment'};\n \t\t\tforeach my $line (@$comment) {\n \t\t\t\tif ($line =~ m/^(.*)($searchtext)(.*)$/i) {\n@@ -2739,8 +2739,8 @@ sub git_search {\n \t\t\t\t\tprint \"$co{'age_string_date'}\\n\" .\n \t\t\t\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5)) . \"\\n\" .\n \t\t\t\t\t \"\" .\n-\t\t\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}), -class => \"list\"}, \"\" .\n-\t\t\t\t\t esc_html(chop_str($co{'title'}, 50)) . \"
\");\n+\t\t\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}), -class => \"list_bold\"},\n+\t\t\t\t\t esc_html(chop_str($co{'title'}, 50)) . \"
\");\n \t\t\t\t\twhile (my $setref = shift @files) {\n \t\t\t\t\t\tmy %set = %$setref;\n \t\t\t\t\t\tprint $cgi->a({-href => href(action=>\"blob\", hash=>$set{'id'}, hash_base=>$co{'id'}, file_name=>$set{'file'}), class => \"list\"},\n-- \n1.4.2.g3851f\n"},{"id":"25738","messageId":"eceis6$rv2$2@sea.gmane.org","threadId":"5352","inReplyTo":"20060822085739.75519.qmail@web31810.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: all bold lists are \"list_bold\" style","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-22T09:30:46Z","receivedAt":"2006-08-22T09:30:46Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"This should be reply to\n\n [PATCH] gitweb: bugfix: list regression\n\n(or at least it should be mentioned that this patch is needed).\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"25741","messageId":"11562431392439-git-send-email-jnareb@git.vger.kernel.org","threadId":"5352","inReplyTo":"20060822085739.75519.qmail@web31810.mail.mud.yahoo.com","subject":"[PATCH] gitweb: Replace some presentational HTML by CSS","fromName":"Jakub Narebski","fromEmail":"jnareb@git.vger.kernel.org","sentAt":"2006-08-22T10:38:59Z","receivedAt":"2006-08-22T10:38:59Z","isPatch":true,"sender":{"key":"jnareb@git.vger.kernel.org","avatar":null},"body":"From: Jakub Narebski \n\nSigned-off-by: Jakub Narebski \n---\nFollows \"gitweb: bugfix: a.list formatting regression\" patch.\n\n gitweb/gitweb.css | 3 ++-\n gitweb/gitweb.perl | 19 ++++++++++---------\n 2 files changed, 12 insertions(+), 10 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 6c13d9e..4821022 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -42,6 +42,7 @@ div.page_nav a:visited {\n \n div.page_path {\n \tpadding: 8px;\n+\tfont-weight: bold;\n \tborder: solid #d9d8d1;\n \tborder-width: 0px 0px 1px;\n }\n@@ -120,7 +121,7 @@ a.list {\n \tcolor: #000000;\n }\n \n-a.subject {\n+a.subject, a.name {\n \tfont-weight: bold;\n }\n \ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 40c5177..607b8b7 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1267,17 +1267,17 @@ sub git_print_page_path {\n \tmy $hb = shift;\n \n \tif (!defined $name) {\n-\t\tprint \"
/
\\n\";\n+\t\tprint \"
/
\\n\";\n \t} elsif (defined $type && $type eq 'blob') {\n-\t\tprint \"
\";\n+\t\tprint \"
\";\n \t\tif (defined $hb) {\n \t\t\tprint $cgi->a({-href => href(action=>\"blob_plain\", hash_base=>$hb, file_name=>$file_name)}, esc_html($name));\n \t\t} else {\n \t\t\tprint $cgi->a({-href => href(action=>\"blob_plain\", file_name=>$file_name)}, esc_html($name));\n \t\t}\n-\t\tprint \"
\\n\";\n+\t\tprint \"
\\n\";\n \t} else {\n-\t\tprint \"
\" . esc_html($name) . \"
\\n\";\n+\t\tprint \"
\" . esc_html($name) . \"
\\n\";\n \t}\n }\n \n@@ -1630,7 +1630,7 @@ sub git_tags_body {\n \t\tprint \"$tag{'age'}\\n\" .\n \t\t \"\" .\n \t\t $cgi->a({-href => href(action=>$tag{'reftype'}, hash=>$tag{'refid'}),\n-\t\t -class => \"list\"}, \"\" . esc_html($tag{'name'}) . \"\") .\n+\t\t -class => \"list name\"}, esc_html($tag{'name'})) .\n \t\t \"\\n\" .\n \t\t \"\";\n \t\tif (defined $comment) {\n@@ -1684,7 +1684,7 @@ sub git_heads_body {\n \t\tprint \"$tag{'age'}\\n\" .\n \t\t ($tag{'id'} eq $head ? \"\" : \"\") .\n \t\t $cgi->a({-href => href(action=>\"shortlog\", hash=>$tag{'name'}),\n-\t\t -class => \"list\"}, \"\" . esc_html($tag{'name'}) . \"\") .\n+\t\t -class => \"list name\"},esc_html($tag{'name'})) .\n \t\t \"\\n\" .\n \t\t \"\" .\n \t\t $cgi->a({-href => href(action=>\"shortlog\", hash=>$tag{'name'})}, \"shortlog\") . \" | \" .\n@@ -2774,7 +2774,8 @@ sub git_search {\n \t\t\tprint \"$co{'age_string_date'}\\n\" .\n \t\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5)) . \"\\n\" .\n \t\t\t \"\" .\n-\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}) -class => \"list\"}, \"\" . esc_html(chop_str($co{'title'}, 50)) . \"
\");\n+\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}), -class => \"list subject\"},\n+\t\t\t esc_html(chop_str($co{'title'}, 50)) . \"
\");\n \t\t\tmy $comment = $co{'comment'};\n \t\t\tforeach my $line (@$comment) {\n \t\t\t\tif ($line =~ m/^(.*)($searchtext)(.*)$/i) {\n@@ -2827,8 +2828,8 @@ sub git_search {\n \t\t\t\t\tprint \"$co{'age_string_date'}\\n\" .\n \t\t\t\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5)) . \"\\n\" .\n \t\t\t\t\t \"\" .\n-\t\t\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}), -class => \"list\"}, \"\" .\n-\t\t\t\t\t esc_html(chop_str($co{'title'}, 50)) . \"
\");\n+\t\t\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}), -class => \"list subject\"},\n+\t\t\t\t\t esc_html(chop_str($co{'title'}, 50)) . \"
\");\n \t\t\t\t\twhile (my $setref = shift @files) {\n \t\t\t\t\t\tmy %set = %$setref;\n \t\t\t\t\t\tprint $cgi->a({-href => href(action=>\"blob\", hash=>$set{'id'}, hash_base=>$co{'id'}, file_name=>$set{'file'}), class => \"list\"},\n-- \n1.4.1.1\n"}]}