{"thread":{"id":"53519","subject":"[PATCH] doc: fix wrong 4-byte length of pkt-line message","startedAt":"2020-05-21T07:56:52Z","lastAt":"2020-05-21T11:33:34Z","messageCount":5,"participants":["Jiuyang Xie","Denton Liu"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"398332","messageId":"20200521075643.35286-1-jiuyang.xjy@alibaba-inc.com","threadId":"53519","inReplyTo":null,"subject":"[PATCH] doc: fix wrong 4-byte length of pkt-line message","fromName":"Jiuyang Xie","fromEmail":"jiuyangxie@gmail.com","sentAt":"2020-05-21T07:56:43Z","receivedAt":"2020-05-21T07:56:52Z","isPatch":true,"sender":{"key":"jiuyangxie@gmail.com","avatar":"https://avatars.githubusercontent.com/u/16410723?v=4"},"body":"The first four bytes of the line, the pkt-len, indicates the total\nlength of the pkt-line in hexadecimal.  Fixed wrong pkt-len headers of\nsome pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.\n\nSigned-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>\n---\n Documentation/technical/http-protocol.txt | 2 +-\n Documentation/technical/pack-protocol.txt | 6 +++---\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt\nindex 9c5b6f0fac..51a79e63de 100644\n--- a/Documentation/technical/http-protocol.txt\n+++ b/Documentation/technical/http-protocol.txt\n@@ -216,7 +216,7 @@ smart server reply:\n    S: 001e# service=git-upload-pack\\n\n    S: 0000\n    S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\\0multi_ack\\n\n-   S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\\n\n+   S: 003fd049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\\n\n    S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\\n\n    S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\\n\n    S: 0000\ndiff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt\nindex d5ce4eea8a..a4573d12ce 100644\n--- a/Documentation/technical/pack-protocol.txt\n+++ b/Documentation/technical/pack-protocol.txt\n@@ -96,7 +96,7 @@ Basically what the Git client is doing to connect to an 'upload-pack'\n process on the server side over the Git protocol is this:\n \n    $ echo -e -n \\\n-     \"0039git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\" |\n+     \"003agit-upload-pack /schacon/gitbook.git\\0host=example.com\\0\" |\n      nc -v example.com 9418\n \n \n@@ -171,9 +171,9 @@ with a version number (if \"version=1\" is sent as an Extra Parameter),\n and a listing of each reference it has (all branches and tags) along\n with the object name that each reference currently points to.\n \n-   $ echo -e -n \"0044git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\\0version=1\\0\" |\n+   $ echo -e -n \"0045git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\\0version=1\\0\" |\n       nc -v example.com 9418\n-   000aversion 1\n+   000eversion 1\n    00887217a7c7e582c46cec22a130adf4b9d7d950fba0 HEAD\\0multi_ack thin-pack\n \t\tside-band side-band-64k ofs-delta shallow no-progress include-tag\n    00441d3fcd5ced445d1abc402225c0b8a1299641f497 refs/heads/integration\n-- \n2.25.0\n\n"},{"id":"398333","messageId":"20200521094454.GA577071@generichostname","threadId":"53519","inReplyTo":"20200521075643.35286-1-jiuyang.xjy@alibaba-inc.com","subject":"Re: [PATCH] doc: fix wrong 4-byte length of pkt-line message","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2020-05-21T09:44:54Z","receivedAt":"2020-05-21T09:45:00Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"Hi Jiuyang,\n\nOn Thu, May 21, 2020 at 03:56:43PM +0800, Jiuyang Xie wrote:\n> The first four bytes of the line, the pkt-len, indicates the total\n> length of the pkt-line in hexadecimal.  Fixed wrong pkt-len headers of\n\ns/Fixed/Fix/ perhaps?\n\n> some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.\n> \n> Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>\n\nAside from the above, I manually checked all of the changes and they\nlook good to me.\n\n-Denton\n"},{"id":"398349","messageId":"20200521104146.36729-1-jiuyang.xjy@alibaba-inc.com","threadId":"53519","inReplyTo":"20200521094454.GA577071@generichostname","subject":"[PATCH v2] doc: fix wrong 4-byte length of pkt-line message","fromName":"Jiuyang Xie","fromEmail":"jiuyangxie@gmail.com","sentAt":"2020-05-21T10:41:46Z","receivedAt":"2020-05-21T10:42:24Z","isPatch":true,"sender":{"key":"jiuyangxie@gmail.com","avatar":"https://avatars.githubusercontent.com/u/16410723?v=4"},"body":"The first four bytes of the line, the pkt-len, indicates the total\nlength of the pkt-line in hexadecimal. Fix wrong pkt-len headers of\nsome pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.\n\nReviewd-by: Denton Liu <liu.denton@gmail.com>\nSigned-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>\n---\n Documentation/technical/http-protocol.txt | 2 +-\n Documentation/technical/pack-protocol.txt | 6 +++---\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt\nindex 9c5b6f0fac..51a79e63de 100644\n--- a/Documentation/technical/http-protocol.txt\n+++ b/Documentation/technical/http-protocol.txt\n@@ -216,7 +216,7 @@ smart server reply:\n    S: 001e# service=git-upload-pack\\n\n    S: 0000\n    S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\\0multi_ack\\n\n-   S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\\n\n+   S: 003fd049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\\n\n    S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\\n\n    S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\\n\n    S: 0000\ndiff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt\nindex d5ce4eea8a..a4573d12ce 100644\n--- a/Documentation/technical/pack-protocol.txt\n+++ b/Documentation/technical/pack-protocol.txt\n@@ -96,7 +96,7 @@ Basically what the Git client is doing to connect to an 'upload-pack'\n process on the server side over the Git protocol is this:\n \n    $ echo -e -n \\\n-     \"0039git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\" |\n+     \"003agit-upload-pack /schacon/gitbook.git\\0host=example.com\\0\" |\n      nc -v example.com 9418\n \n \n@@ -171,9 +171,9 @@ with a version number (if \"version=1\" is sent as an Extra Parameter),\n and a listing of each reference it has (all branches and tags) along\n with the object name that each reference currently points to.\n \n-   $ echo -e -n \"0044git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\\0version=1\\0\" |\n+   $ echo -e -n \"0045git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\\0version=1\\0\" |\n       nc -v example.com 9418\n-   000aversion 1\n+   000eversion 1\n    00887217a7c7e582c46cec22a130adf4b9d7d950fba0 HEAD\\0multi_ack thin-pack\n \t\tside-band side-band-64k ofs-delta shallow no-progress include-tag\n    00441d3fcd5ced445d1abc402225c0b8a1299641f497 refs/heads/integration\n-- \n2.25.0\n\n"},{"id":"398351","messageId":"20200521112125.GA581643@generichostname","threadId":"53519","inReplyTo":"20200521104146.36729-1-jiuyang.xjy@alibaba-inc.com","subject":"Re: [PATCH v2] doc: fix wrong 4-byte length of pkt-line message","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2020-05-21T11:21:25Z","receivedAt":"2020-05-21T11:21:32Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"Hi Jiuyang,\n\nSorry, one more small typo.\n\nOn Thu, May 21, 2020 at 06:41:46PM +0800, Jiuyang Xie wrote:\n> The first four bytes of the line, the pkt-len, indicates the total\n> length of the pkt-line in hexadecimal. Fix wrong pkt-len headers of\n> some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.\n> \n> Reviewd-by: Denton Liu <liu.denton@gmail.com>\n\ns/Reviewd/Reviewed/\n\nThanks,\n\nDenton\n\n> Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>\n"},{"id":"398353","messageId":"20200521113238.37160-1-jiuyang.xjy@alibaba-inc.com","threadId":"53519","inReplyTo":"20200521112125.GA581643@generichostname","subject":"[PATCH v3] doc: fix wrong 4-byte length of pkt-line message","fromName":"Jiuyang Xie","fromEmail":"jiuyangxie@gmail.com","sentAt":"2020-05-21T11:32:38Z","receivedAt":"2020-05-21T11:33:34Z","isPatch":true,"sender":{"key":"jiuyangxie@gmail.com","avatar":"https://avatars.githubusercontent.com/u/16410723?v=4"},"body":"The first four bytes of the line, the pkt-len, indicates the total\nlength of the pkt-line in hexadecimal. Fix wrong pkt-len headers of\nsome pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.\n\nReviewed-by: Denton Liu <liu.denton@gmail.com>\nSigned-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>\n---\n Documentation/technical/http-protocol.txt | 2 +-\n Documentation/technical/pack-protocol.txt | 6 +++---\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt\nindex 9c5b6f0fac..51a79e63de 100644\n--- a/Documentation/technical/http-protocol.txt\n+++ b/Documentation/technical/http-protocol.txt\n@@ -216,7 +216,7 @@ smart server reply:\n    S: 001e# service=git-upload-pack\\n\n    S: 0000\n    S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\\0multi_ack\\n\n-   S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\\n\n+   S: 003fd049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\\n\n    S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\\n\n    S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\\n\n    S: 0000\ndiff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt\nindex d5ce4eea8a..a4573d12ce 100644\n--- a/Documentation/technical/pack-protocol.txt\n+++ b/Documentation/technical/pack-protocol.txt\n@@ -96,7 +96,7 @@ Basically what the Git client is doing to connect to an 'upload-pack'\n process on the server side over the Git protocol is this:\n \n    $ echo -e -n \\\n-     \"0039git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\" |\n+     \"003agit-upload-pack /schacon/gitbook.git\\0host=example.com\\0\" |\n      nc -v example.com 9418\n \n \n@@ -171,9 +171,9 @@ with a version number (if \"version=1\" is sent as an Extra Parameter),\n and a listing of each reference it has (all branches and tags) along\n with the object name that each reference currently points to.\n \n-   $ echo -e -n \"0044git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\\0version=1\\0\" |\n+   $ echo -e -n \"0045git-upload-pack /schacon/gitbook.git\\0host=example.com\\0\\0version=1\\0\" |\n       nc -v example.com 9418\n-   000aversion 1\n+   000eversion 1\n    00887217a7c7e582c46cec22a130adf4b9d7d950fba0 HEAD\\0multi_ack thin-pack\n \t\tside-band side-band-64k ofs-delta shallow no-progress include-tag\n    00441d3fcd5ced445d1abc402225c0b8a1299641f497 refs/heads/integration\n-- \n2.25.0\n\n"}]}