{"thread":{"id":"5351","subject":"[PATCH] gitweb: bugfix: list regression","startedAt":"2006-08-22T08:55:40Z","lastAt":"2006-08-23T05:23:09Z","messageCount":10,"participants":["Luben Tuikov","Junio C Hamano","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"25733","messageId":"20060822085540.1104.qmail@web31812.mail.mud.yahoo.com","threadId":"5351","inReplyTo":null,"subject":"[PATCH] gitweb: bugfix: list regression","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-22T08:55:40Z","receivedAt":"2006-08-22T08:55:40Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Fix regression introduced by\ncommit 17d07443188909ef5f8b8c24043cb6d9fef51bca.\n\n1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines\n\"a.list\" twice in gitweb.css, once with bold and once with\nnormal font-weight.\n\n2. \"a.list\" being \"bold\", makes a myriad of things shown by\ngitweb in bold font-weight, which is a regression from\npre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.\n\nThe fix is to define separately \"a.list_bold\" and use\nthat style in format_subject_html().\n\nSigned-off-by: Luben Tuikov \n---\n gitweb/gitweb.css | 9 +++++++--\n gitweb/gitweb.perl | 4 ++--\n 2 files changed, 9 insertions(+), 4 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 9013895..db58629 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -115,13 +115,18 @@ div.list_head {\n \tfont-style: italic;\n }\n \n-a.list {\n+a.list_bold {\n \ttext-decoration: none;\n \tfont-weight: bold;\n \tcolor: #000000;\n }\n \n-table.tags a.list {\n+a.list {\n+\ttext-decoration: none;\n+\tcolor: #000000;\n+}\n+\n+table.tags {\n \tfont-weight: normal;\n }\n \ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 063735d..5237f25 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -504,11 +504,11 @@ sub format_subject_html {\n \t$extra = '' unless defined($extra);\n \n \tif (length($short) < length($long)) {\n-\t\treturn $cgi->a({-href => $href, -class => \"list\",\n+\t\treturn $cgi->a({-href => $href, -class => \"list_bold\",\n \t\t -title => $long},\n \t\t esc_html($short) . $extra);\n \t} else {\n-\t\treturn $cgi->a({-href => $href, -class => \"list\"},\n+\t\treturn $cgi->a({-href => $href, -class => \"list_bold\"},\n \t\t esc_html($long) . $extra);\n \t}\n }\n-- \n1.4.2.g3851f\n"},{"id":"25736","messageId":"7vbqqdnn4u.fsf@assigned-by-dhcp.cox.net","threadId":"5351","inReplyTo":"20060822085540.1104.qmail@web31812.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: bugfix: list regression","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-22T09:19:29Z","receivedAt":"2006-08-22T09:19:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov writes:\n\n> Fix regression introduced by\n> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.\n>\n> 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines\n> \"a.list\" twice in gitweb.css, once with bold and once with\n> normal font-weight.\n\nThe normal one is limited to a.list that is inside table.tags\nisn't it? I had an impression that this was done on purpose.\n\n> 2. \"a.list\" being \"bold\", makes a myriad of things shown by\n> gitweb in bold font-weight, which is a regression from\n> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.\n\nThe only difference I see offhand is that Jakub's version shows\nthe tag text in normal weight in summary pane (tags section),\nwhile yours show it in bold. Also clickable object names in\nmany views are shown in bold in Jakub's version while yours do\nnot distinguish them from unclickable ones.\n\nI tend to agree that bold looks too loud in tree view, but\nshowing tree and parent diffently from commit itself in commit\nview may be a good thing. I am not sure bold is a good choice,\nthough. Usually people underline clickable links not type in\nbold.\n\nI do not case either way myself that much. Could you battle\nthis out with the guilty party?\n"},{"id":"25737","messageId":"eceir6$rv2$1@sea.gmane.org","threadId":"5351","inReplyTo":"20060822085540.1104.qmail@web31812.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: bugfix: list regression","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-22T09:30:08Z","receivedAt":"2006-08-22T09:30:08Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Luben Tuikov wrote:\n\n> Fix regression introduced by\n> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.\n> \n> 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines\n> \"a.list\" twice in gitweb.css, once with bold and once with\n> normal font-weight.\n> \n> 2. \"a.list\" being \"bold\", makes a myriad of things shown by\n> gitweb in bold font-weight, which is a regression from\n> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.\n> \n> The fix is to define separately \"a.list_bold\" and use\n> that style in format_subject_html().\n\nThis fix is counter to what I wanted to do. I thought that\n\"list\" class is used only in \"subject\" links, so I defaulted\nit to bold (all such elements except one were inside ...),\nand encoded exceptions; notice\n\n+table.tags a.list {\n+ font-weight: normal;\n+}\n+\n\nWe could as well define \"bold\" class for \"a\", i.e.\n\n+a.bold {\n+ font-weight: bold;\n+}\n\nbut this is presentational CSS, no better than ... element.\n\n\nThe correct solution would be to add \"subject\" class perhaps,\nand do exceptions for it.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"25740","messageId":"11562409683011-git-send-email-jnareb@git.vger.kernel.org","threadId":"5351","inReplyTo":"20060822085540.1104.qmail@web31812.mail.mud.yahoo.com","subject":"[PATCH] gitweb: bugfix: a.list formatting regression","fromName":"Jakub Narebski","fromEmail":"jnareb@git.vger.kernel.org","sentAt":"2006-08-22T10:02:48Z","receivedAt":"2006-08-22T10:02:48Z","isPatch":true,"sender":{"key":"jnareb@git.vger.kernel.org","avatar":null},"body":"From: Jakub Narebski \n\nFix regression introduced by\ncommit 17d07443188909ef5f8b8c24043cb6d9fef51bca.\n\n\"a.list\" being \"bold\", makes a myriad of things shown by\ngitweb in bold font-weight, which is a regression from\npre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.\n\nThe fix is to add \"subject\" class and use this class\nto replace pre-format_subject_html formatting of subject\n(comment) via using (or not) ... element. This\nshould go back to the pre-17d0744318... style.\n\nRegression noticed by Luben Tuikov.\n\nSigned-off-by: Jakub Narebski \nSigned-off-by: Luben Tuikov \n---\nLuben Tuikov wrote:\n\n> 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines\n> \"a.list\" twice in gitweb.css, once with bold and once with\n> normal font-weight.\n\n\"table.tags a.list\" means \"a.list\" inside \"table.tags\",\nso it is not redefinition of \"a.list\", but override\n(more specific CSS rule wins). It is for subject of tags\nlist (\"summary\" and \"tags\" actions) to be in normal\nweight, as in such list the tag itself (ref) is in bold,\nnot the tag comment (first line of free form part of tag).\n\n gitweb/gitweb.css | 7 +++++--\n gitweb/gitweb.perl | 4 ++--\n 2 files changed, 7 insertions(+), 4 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 9013895..6c13d9e 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -117,11 +117,14 @@ div.list_head {\n \n a.list {\n \ttext-decoration: none;\n-\tfont-weight: bold;\n \tcolor: #000000;\n }\n \n-table.tags a.list {\n+a.subject {\n+\tfont-weight: bold;\n+}\n+\n+table.tags a.subject {\n \tfont-weight: normal;\n }\n \ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 90157d5..40c5177 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -504,11 +504,11 @@ sub format_subject_html {\n \t$extra = '' unless defined($extra);\n \n \tif (length($short) < length($long)) {\n-\t\treturn $cgi->a({-href => $href, -class => \"list\",\n+\t\treturn $cgi->a({-href => $href, -class => \"list subject\",\n \t\t -title => $long},\n \t\t esc_html($short) . $extra);\n \t} else {\n-\t\treturn $cgi->a({-href => $href, -class => \"list\"},\n+\t\treturn $cgi->a({-href => $href, -class => \"list subject\"},\n \t\t esc_html($long) . $extra);\n \t}\n }\n-- \n1.4.1.1\n"},{"id":"25769","messageId":"7vr6z8mmb7.fsf@assigned-by-dhcp.cox.net","threadId":"5351","inReplyTo":"11562409683011-git-send-email-jnareb@git.vger.kernel.org","subject":"Re: [PATCH] gitweb: bugfix: a.list formatting regression","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-22T22:34:52Z","receivedAt":"2006-08-22T22:34:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> From: Jakub Narebski \n>\n> Fix regression introduced by\n> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.\n>\n> \"a.list\" being \"bold\", makes a myriad of things shown by\n> gitweb in bold font-weight, which is a regression from\n> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.\n>\n> The fix is to add \"subject\" class and use this class\n> to replace pre-format_subject_html formatting of subject\n> (comment) via using (or not) ... element. This\n> should go back to the pre-17d0744318... style.\n>\n> Regression noticed by Luben Tuikov.\n>\n> Signed-off-by: Jakub Narebski \n> Signed-off-by: Luben Tuikov \n> ---\n\nI haven't seen an Ack from Luben for the proposed renaming of\nthe class, although I very much like naming things for what they\nmean (i.e. \"subject\"), not what they do (i.e. \"bold\") myself.\n\nIt might be worthwhile to do a full sweep of the pages we\ngenerate and identify what classes we would want. I have a\nfeeling that we overuse a.list for example -- they are all in\nsome form of list alright but they might benefit from a bit\nfiner logical separatoin. One list is enumaration of refs and\nanother is a chronological sequence of commits.\n\nThen people who would want to tweak the presentation would have\nan easier time changing only gitweb.css.\n"},{"id":"25771","messageId":"ecg1fd$3uj$2@sea.gmane.org","threadId":"5351","inReplyTo":"7vr6z8mmb7.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: bugfix: a.list formatting regression","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-22T22:46:09Z","receivedAt":"2006-08-22T22:46:09Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Jakub Narebski writes:\n(the above is result of paste in wrong place in git-send-email invocation)\n[...]\n>> The fix is to add \"subject\" class and use this class\n>> to replace pre-format_subject_html formatting of subject\n>> (comment) via using (or not) ... element. This\n>> should go back to the pre-17d0744318... style.\n[...]\n> \n> I haven't seen an Ack from Luben for the proposed renaming of\n> the class, although I very much like naming things for what they\n> mean (i.e. \"subject\"), not what they do (i.e. \"bold\") myself.\n> \n> It might be worthwhile to do a full sweep of the pages we\n> generate and identify what classes we would want. I have a\n> feeling that we overuse a.list for example -- they are all in\n> some form of list alright but they might benefit from a bit\n> finer logical separatoin. One list is enumaration of refs and\n> another is a chronological sequence of commits.\n> \n> Then people who would want to tweak the presentation would have\n> an easier time changing only gitweb.css.\n\nNext patch in this series of patches \n [PATCH] gitweb: Replace some presentational HTML by CSS\n Message-Id: <11562431392439-git-send-email-jnareb@git.vger.kernel.org>\nadds \"name\" subclass (a.list.name) for ref names. (I think\nsubclasses/multiple classes is the way to do it, as all a.list\nelements have something in common: use next class to divide).\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"25772","messageId":"7vy7tgl5vx.fsf@assigned-by-dhcp.cox.net","threadId":"5351","inReplyTo":"ecg1fd$3uj$2@sea.gmane.org","subject":"Re: [PATCH] gitweb: bugfix: a.list formatting regression","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-22T23:14:58Z","receivedAt":"2006-08-22T23:14:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> Junio C Hamano wrote:\n>\n>> It might be worthwhile to do a full sweep of the pages we\n>> generate and identify what classes we would want. I have a\n>> feeling that we overuse a.list for example -- they are all in\n>> some form of list alright but they might benefit from a bit\n>> finer logical separatoin. One list is enumaration of refs and\n>> another is a chronological sequence of commits.\n>> \n>> Then people who would want to tweak the presentation would have\n>> an easier time changing only gitweb.css.\n>\n> Next patch in this series of patches \n> [PATCH] gitweb: Replace some presentational HTML by CSS\n> Message-Id: <11562431392439-git-send-email-jnareb@git.vger.kernel.org>\n> adds \"name\" subclass (a.list.name) for ref names. (I think\n> subclasses/multiple classes is the way to do it, as all a.list\n> elements have something in common: use next class to divide).\n\nI agree about the implementation aspect, such as using\n\"list.name\" as class names; I was suggesting to start from\ndesign.\n"},{"id":"25783","messageId":"20060823044339.28307.qmail@web31806.mail.mud.yahoo.com","threadId":"5351","inReplyTo":"11562409683011-git-send-email-jnareb@git.vger.kernel.org","subject":"Re: [PATCH] gitweb: bugfix: a.list formatting regression","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-23T04:43:39Z","receivedAt":"2006-08-23T04:43:39Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Jakub Narebski wrote:\n\n> From: Jakub Narebski \n> \n> Fix regression introduced by\n> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.\n> \n> \"a.list\" being \"bold\", makes a myriad of things shown by\n> gitweb in bold font-weight, which is a regression from\n> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.\n> \n> The fix is to add \"subject\" class and use this class\n> to replace pre-format_subject_html formatting of subject\n> (comment) via using (or not) ... element. This\n> should go back to the pre-17d0744318... style.\n> \n> Regression noticed by Luben Tuikov.\n> \n> Signed-off-by: Jakub Narebski \n> Signed-off-by: Luben Tuikov \n> ---\n\nACK. Looks good.\n\n Luben\n\n\n> Luben Tuikov wrote:\n> \n> > 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines\n> > \"a.list\" twice in gitweb.css, once with bold and once with\n> > normal font-weight.\n> \n> \"table.tags a.list\" means \"a.list\" inside \"table.tags\",\n> so it is not redefinition of \"a.list\", but override\n> (more specific CSS rule wins). It is for subject of tags\n> list (\"summary\" and \"tags\" actions) to be in normal\n> weight, as in such list the tag itself (ref) is in bold,\n> not the tag comment (first line of free form part of tag).\n> \n> gitweb/gitweb.css | 7 +++++--\n> gitweb/gitweb.perl | 4 ++--\n> 2 files changed, 7 insertions(+), 4 deletions(-)\n> \n> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\n> index 9013895..6c13d9e 100644\n> --- a/gitweb/gitweb.css\n> +++ b/gitweb/gitweb.css\n> @@ -117,11 +117,14 @@ div.list_head {\n> \n> a.list {\n> \ttext-decoration: none;\n> -\tfont-weight: bold;\n> \tcolor: #000000;\n> }\n> \n> -table.tags a.list {\n> +a.subject {\n> +\tfont-weight: bold;\n> +}\n> +\n> +table.tags a.subject {\n> \tfont-weight: normal;\n> }\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 90157d5..40c5177 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -504,11 +504,11 @@ sub format_subject_html {\n> \t$extra = '' unless defined($extra);\n> \n> \tif (length($short) < length($long)) {\n> -\t\treturn $cgi->a({-href => $href, -class => \"list\",\n> +\t\treturn $cgi->a({-href => $href, -class => \"list subject\",\n> \t\t -title => $long},\n> \t\t esc_html($short) . $extra);\n> \t} else {\n> -\t\treturn $cgi->a({-href => $href, -class => \"list\"},\n> +\t\treturn $cgi->a({-href => $href, -class => \"list subject\"},\n> \t\t esc_html($long) . $extra);\n> \t}\n> }\n> -- \n> 1.4.1.1\n> \n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> \n"},{"id":"25784","messageId":"20060823044545.25836.qmail@web31802.mail.mud.yahoo.com","threadId":"5351","inReplyTo":"11562409683011-git-send-email-jnareb@git.vger.kernel.org","subject":"Re: [PATCH] gitweb: bugfix: a.list formatting regression","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-23T04:45:45Z","receivedAt":"2006-08-23T04:45:45Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Jakub Narebski wrote:\n\n> From: Jakub Narebski \n> \n> Fix regression introduced by\n> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.\n> \n> \"a.list\" being \"bold\", makes a myriad of things shown by\n> gitweb in bold font-weight, which is a regression from\n> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.\n> \n> The fix is to add \"subject\" class and use this class\n> to replace pre-format_subject_html formatting of subject\n> (comment) via using (or not) ... element. This\n> should go back to the pre-17d0744318... style.\n> \n> Regression noticed by Luben Tuikov.\n> \n> Signed-off-by: Jakub Narebski \n> Signed-off-by: Luben Tuikov \n> ---\n\nACK. Looks good.\n\n Luben\n\n\n> Luben Tuikov wrote:\n> \n> > 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines\n> > \"a.list\" twice in gitweb.css, once with bold and once with\n> > normal font-weight.\n> \n> \"table.tags a.list\" means \"a.list\" inside \"table.tags\",\n> so it is not redefinition of \"a.list\", but override\n> (more specific CSS rule wins). It is for subject of tags\n> list (\"summary\" and \"tags\" actions) to be in normal\n> weight, as in such list the tag itself (ref) is in bold,\n> not the tag comment (first line of free form part of tag).\n> \n> gitweb/gitweb.css | 7 +++++--\n> gitweb/gitweb.perl | 4 ++--\n> 2 files changed, 7 insertions(+), 4 deletions(-)\n> \n> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\n> index 9013895..6c13d9e 100644\n> --- a/gitweb/gitweb.css\n> +++ b/gitweb/gitweb.css\n> @@ -117,11 +117,14 @@ div.list_head {\n> \n> a.list {\n> \ttext-decoration: none;\n> -\tfont-weight: bold;\n> \tcolor: #000000;\n> }\n> \n> -table.tags a.list {\n> +a.subject {\n> +\tfont-weight: bold;\n> +}\n> +\n> +table.tags a.subject {\n> \tfont-weight: normal;\n> }\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 90157d5..40c5177 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -504,11 +504,11 @@ sub format_subject_html {\n> \t$extra = '' unless defined($extra);\n> \n> \tif (length($short) < length($long)) {\n> -\t\treturn $cgi->a({-href => $href, -class => \"list\",\n> +\t\treturn $cgi->a({-href => $href, -class => \"list subject\",\n> \t\t -title => $long},\n> \t\t esc_html($short) . $extra);\n> \t} else {\n> -\t\treturn $cgi->a({-href => $href, -class => \"list\"},\n> +\t\treturn $cgi->a({-href => $href, -class => \"list subject\"},\n> \t\t esc_html($long) . $extra);\n> \t}\n> }\n> -- \n> 1.4.1.1\n> \n> \n"},{"id":"25786","messageId":"7vy7tghvpe.fsf@assigned-by-dhcp.cox.net","threadId":"5351","inReplyTo":"20060823044545.25836.qmail@web31802.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: bugfix: a.list formatting regression","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-23T05:23:09Z","receivedAt":"2006-08-23T05:23:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov writes:\n\n>> The fix is to add \"subject\" class and use this class\n>> to replace pre-format_subject_html formatting of subject\n>> (comment) via using (or not) ... element. This\n>> should go back to the pre-17d0744318... style.\n>> \n>> Regression noticed by Luben Tuikov.\n>> \n>> Signed-off-by: Jakub Narebski \n>> Signed-off-by: Luben Tuikov \n>> ---\n>\n> ACK. Looks good.\n>\n> Luben\n\nThanks, both.\n"}]}